47917 2010-10-19 12:11:12 -0700 [Chromium] Populate caps lock state in WebInputEventFactory 2010-10-27 14:38:56 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 stuartmorgan stuartmorgan commit-queue levin oldest_to_newest 296320 0 stuartmorgan 2010-10-19 12:11:12 -0700 WebInputEvent recently acquired a CapsLockOn modifier flag, but it wasn't added to the NSEvent->WebInputEvent conversion path. 299903 1 71968 stuartmorgan 2010-10-26 17:12:37 -0700 Created attachment 71968 fix 299992 2 levin 2010-10-26 22:11:35 -0700 (In reply to comment #0) > WebInputEvent recently acquired a CapsLockOn modifier flag, but it wasn't added to the NSEvent->WebInputEvent conversion path. It looks like this was added in http://trac.webkit.org/changeset/68047 That change also added NumLockOn but that doesn't seem to be part of this change. Why? 300295 3 stuartmorgan 2010-10-27 09:52:25 -0700 Because there's no concept of a num lock flag in NSEvent. 300591 4 71968 commit-queue 2010-10-27 14:38:51 -0700 Comment on attachment 71968 fix Clearing flags on attachment: 71968 Committed r70713: <http://trac.webkit.org/changeset/70713> 300592 5 commit-queue 2010-10-27 14:38:56 -0700 All reviewed patches have been landed. Closing bug. 71968 2010-10-26 17:12:37 -0700 2010-10-27 14:38:51 -0700 fix 47917.patch text/plain 1300 stuartmorgan SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNzAwNzIpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMTAtMTkgIFN0dWFy dCBNb3JnYW4gIDxzdHVhcnRtb3JnYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluY2x1ZGUgY2FwcyBsb2NrIHN0YXRlIHdo ZW4gY29udmVydGluZyBOU0V2ZW50IG1vZGlmaWVycyB0bworICAgICAgICBXZWJJbnB1dEV2ZW50 CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3OTE3 CisKKyAgICAgICAgKiBzcmMvbWFjL1dlYklucHV0RXZlbnRGYWN0b3J5Lm1tOgorICAgICAgICAo V2ViS2l0Ojptb2RpZmllcnNGcm9tRXZlbnQpOgorCiAyMDEwLTEwLTE5ICBUb255IENoYW5nICA8 dG9ueUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gIFJvbGxpbmcgY2hyb21p dW0gREVQUyB0byA2MzA1NyB0byBwaWNrIHVwIG1hYyBwbHVnaW4KSW5kZXg6IFdlYktpdC9jaHJv bWl1bS9zcmMvbWFjL1dlYklucHV0RXZlbnRGYWN0b3J5Lm1tCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktp dC9jaHJvbWl1bS9zcmMvbWFjL1dlYklucHV0RXZlbnRGYWN0b3J5Lm1tCShyZXZpc2lvbiA3MDA3 MikKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMvbWFjL1dlYklucHV0RXZlbnRGYWN0b3J5Lm1tCSh3 b3JraW5nIGNvcHkpCkBAIC04NTYsNiArODU2LDggQEAgc3RhdGljIGlubGluZSBpbnQgbW9kaWZp ZXJzRnJvbUV2ZW50KE5TRQogICAgICAgICBtb2RpZmllcnMgfD0gV2ViSW5wdXRFdmVudDo6QWx0 S2V5OwogICAgIGlmIChbZXZlbnQgbW9kaWZpZXJGbGFnc10gJiBOU0NvbW1hbmRLZXlNYXNrKQog ICAgICAgICBtb2RpZmllcnMgfD0gV2ViSW5wdXRFdmVudDo6TWV0YUtleTsKKyAgICBpZiAoW2V2 ZW50IG1vZGlmaWVyRmxhZ3NdICYgTlNBbHBoYVNoaWZ0S2V5TWFzaykKKyAgICAgICAgbW9kaWZp ZXJzIHw9IFdlYklucHV0RXZlbnQ6OkNhcHNMb2NrT247CiAgICAgLy8gVE9ETyhwb3J0KTogU2V0 IG1vdXNlIGJ1dHRvbiBzdGF0ZXMKIAogICAgIHJldHVybiBtb2RpZmllcnM7Cg==