47913 2010-10-19 11:00:16 -0700 [chromium] Disable mipmapping of ImageLayer's to conserve CPU and VRAM 2010-10-19 12:39:14 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 vangelis vangelis kbr wjmaclean oldest_to_newest 296283 0 vangelis 2010-10-19 11:00:16 -0700 Mipmapping for ImageLayers was enabled with: https://bugs.webkit.org/show_bug.cgi?id=46493 However, it turns out that a lot of regular HTML content makes no use of mipmap levels since images are drawn untransformed and in their source resolution. In addition, mipmaping seems to have tickled an ANGLE bug: http://code.google.com/p/chromium/issues/detail?id=59426 A possible alternative solution once the ANGLE bug is resolved would be to turn on mipmapping only for layers that are displayed at a smaller size that would make effective use of the gpu. 296290 1 71187 vangelis 2010-10-19 11:11:12 -0700 Created attachment 71187 proposed patch 296296 2 71187 kbr 2010-10-19 11:14:29 -0700 Comment on attachment 71187 proposed patch Verified that this patch is a reversion of the earlier one. 296336 3 vangelis 2010-10-19 12:39:14 -0700 Committed r70075: <http://trac.webkit.org/changeset/70075> 71187 2010-10-19 11:11:12 -0700 2010-10-19 11:14:29 -0700 proposed patch revertMipmap.txt text/plain 6957 vangelis SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MDA2OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjIgQEAKKzIwMTAtMTAtMTkgIFZhbmdlbGlzIEtva2tldmlzICA8dmFuZ2VsaXNA Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFtjaHJvbWl1bV0gRGlzYWJsZSBtaXBtYXBwaW5nIGZvciBJbWFnZUxheWVyJ3MgdG8g cHJldmVudCBtZW1vcnkgdXNlIGFuZAorICAgICAgICBwZXJmb3JtYW5jZSByZWdyZXNzaW9uLgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDc5MTMKKyAg ICAgICAgCisgICAgICAgIFRoaXMgcGF0Y2ggaXMgYSBzdHJhaWdodCByZXZlcnQgb2YgdGhlIHBh dGNoIGNvbW1pdHRlZCB3aXRoOgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NDY0OTMKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVt L0NvbnRlbnRMYXllckNocm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNvbnRlbnRMYXll ckNocm9taXVtOjpTaGFyZWRWYWx1ZXM6OlNoYXJlZFZhbHVlcyk6CisgICAgICAgIChXZWJDb3Jl OjpDb250ZW50TGF5ZXJDaHJvbWl1bTo6dXBkYXRlVGV4dHVyZVJlY3QpOgorICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0NvbnRlbnRMYXllckNocm9taXVtLmg6CisgICAgICAg IChXZWJDb3JlOjpDb250ZW50TGF5ZXJDaHJvbWl1bTo6U2hhcmVkVmFsdWVzOjppbml0aWFsaXpl ZCk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vSW1hZ2VMYXllckNocm9t aXVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkltYWdlTGF5ZXJDaHJvbWl1bTo6dXBkYXRlQ29u dGVudHMpOgorCiAyMDEwLTEwLTE5ICBFcmljIENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUu Y29tPgogCiAgICAgICAgIE5vdCByZXZpZXdlZC4gQnVpbGQgZml4LgpJbmRleDogV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9Db250ZW50TGF5ZXJDaHJvbWl1bS5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9Db250ZW50TGF5ZXJD aHJvbWl1bS5jcHAJKHJldmlzaW9uIDcwMDEwKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9jaHJvbWl1bS9Db250ZW50TGF5ZXJDaHJvbWl1bS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU1 LDcgKzU1LDYgQEAgQ29udGVudExheWVyQ2hyb21pdW06OlNoYXJlZFZhbHVlczo6U2hhcgogICAg ICwgbV9zaGFkZXJNYXRyaXhMb2NhdGlvbigtMSkKICAgICAsIG1fc2hhZGVyQWxwaGFMb2NhdGlv bigtMSkKICAgICAsIG1faW5pdGlhbGl6ZWQoZmFsc2UpCi0gICAgLCBtX25wb3RTdXBwb3J0ZWQo ZmFsc2UpCiB7CiAgICAgLy8gU2hhZGVycyBmb3IgZHJhd2luZyB0aGUgbGF5ZXIgY29udGVudHMu CiAgICAgY2hhciB2ZXJ0ZXhTaGFkZXJTdHJpbmdbXSA9CkBAIC0xMDIsOCArMTAxLDYgQEAgQ29u dGVudExheWVyQ2hyb21pdW06OlNoYXJlZFZhbHVlczo6U2hhcgogICAgIEFTU0VSVChtX3NoYWRl ck1hdHJpeExvY2F0aW9uICE9IC0xKTsKICAgICBBU1NFUlQobV9zaGFkZXJBbHBoYUxvY2F0aW9u ICE9IC0xKTsKIAotICAgIG1fbnBvdFN1cHBvcnRlZCA9IEdMQyhjb250ZXh0LCBjb250ZXh0LT5n ZXRTdHJpbmcoR3JhcGhpY3NDb250ZXh0M0Q6OkVYVEVOU0lPTlMpLmNvbnRhaW5zKCJHTF9PRVNf dGV4dHVyZV9ucG90IikpOwotCiAgICAgbV9pbml0aWFsaXplZCA9IHRydWU7CiB9CiAKQEAgLTI5 NCwxNCArMjkxLDcgQEAgdm9pZCBDb250ZW50TGF5ZXJDaHJvbWl1bTo6dXBkYXRlQ29udGVudAog ICAgICAgICB1cGRhdGVUZXh0dXJlUmVjdChwaXhlbHMsIGJpdG1hcFNpemUsIHJlcXVpcmVkVGV4 dHVyZVNpemUsIHVwZGF0ZVJlY3QsIHRleHR1cmVJZCk7CiB9CiAKLXN0YXRpYyBpbmxpbmUgYm9v bCBpc1Bvd2VyT2ZUd28oaW50IHgpCi17Ci0gICAgQVNTRVJUKHggPj0gMCk7Ci0gICAgcmV0dXJu ICEoeCAmICh4LTEpKTsKLX0KLQotdm9pZCBDb250ZW50TGF5ZXJDaHJvbWl1bTo6dXBkYXRlVGV4 dHVyZVJlY3Qodm9pZCogcGl4ZWxzLCBjb25zdCBJbnRTaXplJiBiaXRtYXBTaXplLAotICAgIGNv bnN0IEludFNpemUmIHJlcXVpcmVkVGV4dHVyZVNpemUsIGNvbnN0IEludFJlY3QmIHVwZGF0ZVJl Y3QsIHVuc2lnbmVkIHRleHR1cmVJZCwgTWlwbWFwVXNlIHJlcXVlc3RNaXBtYXApCit2b2lkIENv bnRlbnRMYXllckNocm9taXVtOjp1cGRhdGVUZXh0dXJlUmVjdCh2b2lkKiBwaXhlbHMsIGNvbnN0 IEludFNpemUmIGJpdG1hcFNpemUsIGNvbnN0IEludFNpemUmIHJlcXVpcmVkVGV4dHVyZVNpemUs IGNvbnN0IEludFJlY3QmIHVwZGF0ZVJlY3QsIHVuc2lnbmVkIHRleHR1cmVJZCkKIHsKICAgICBp ZiAoIXBpeGVscykKICAgICAgICAgcmV0dXJuOwpAQCAtMzA5LDI2ICsyOTksMTEgQEAgdm9pZCBD b250ZW50TGF5ZXJDaHJvbWl1bTo6dXBkYXRlVGV4dHVyZQogICAgIEdyYXBoaWNzQ29udGV4dDNE KiBjb250ZXh0ID0gbGF5ZXJSZW5kZXJlckNvbnRleHQoKTsKICAgICBjb250ZXh0LT5iaW5kVGV4 dHVyZShHcmFwaGljc0NvbnRleHQzRDo6VEVYVFVSRV8yRCwgdGV4dHVyZUlkKTsKIAotICAgIGJv b2wgZ2VuZXJhdGVNaXBtYXAgPSAocmVxdWVzdE1pcG1hcCA9PSB1c2VNaXBtYXApCi0gICAgICAg ICAgICAgICAgICAgICAgICAgICYmIChsYXllclJlbmRlcmVyKCktPmNvbnRlbnRMYXllclNoYXJl ZFZhbHVlcygpLT5ucG90U3VwcG9ydGVkKCkKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHx8IChpc1Bvd2VyT2ZUd28odXBkYXRlUmVjdC53aWR0aCgpKSAmJiBpc1Bvd2VyT2ZUd28odXBk YXRlUmVjdC5oZWlnaHQoKSkpKTsKLQogICAgIC8vIElmIHRoZSB0ZXh0dXJlIGlkIG9yIHNpemUg Y2hhbmdlZCBzaW5jZSBsYXN0IHRpbWUgdGhlbiB3ZSBuZWVkIHRvIHRlbGwgR0wKICAgICAvLyB0 byByZS1hbGxvY2F0ZSBhIHRleHR1cmUuCiAgICAgaWYgKG1fY29udGVudHNUZXh0dXJlICE9IHRl eHR1cmVJZCB8fCByZXF1aXJlZFRleHR1cmVTaXplICE9IG1fYWxsb2NhdGVkVGV4dHVyZVNpemUp IHsKICAgICAgICAgQVNTRVJUKGJpdG1hcFNpemUgPT0gcmVxdWlyZWRUZXh0dXJlU2l6ZSk7CiAg ICAgICAgIEdMQyhjb250ZXh0LCBjb250ZXh0LT50ZXhJbWFnZTJEKEdyYXBoaWNzQ29udGV4dDNE OjpURVhUVVJFXzJELCAwLCBHcmFwaGljc0NvbnRleHQzRDo6UkdCQSwgcmVxdWlyZWRUZXh0dXJl U2l6ZS53aWR0aCgpLCByZXF1aXJlZFRleHR1cmVTaXplLmhlaWdodCgpLCAwLCBHcmFwaGljc0Nv bnRleHQzRDo6UkdCQSwgR3JhcGhpY3NDb250ZXh0M0Q6OlVOU0lHTkVEX0JZVEUsIHBpeGVscykp OwotICAgICAgICBpZiAoZ2VuZXJhdGVNaXBtYXApIHsKLSAgICAgICAgICAgIEdMQyhjb250ZXh0 LCBjb250ZXh0LT50ZXhQYXJhbWV0ZXJpKEdyYXBoaWNzQ29udGV4dDNEOjpURVhUVVJFXzJELCBH cmFwaGljc0NvbnRleHQzRDo6VEVYVFVSRV9NSU5fRklMVEVSLAotICAgICAgICAgICAgICAgIEdy YXBoaWNzQ29udGV4dDNEOjpMSU5FQVJfTUlQTUFQX0xJTkVBUikpOwotICAgICAgICAgICAgR0xD KGNvbnRleHQsIGNvbnRleHQtPnRleFBhcmFtZXRlcmkoR3JhcGhpY3NDb250ZXh0M0Q6OlRFWFRV UkVfMkQsIEdyYXBoaWNzQ29udGV4dDNEOjpURVhUVVJFX01BR19GSUxURVIsCi0gICAgICAgICAg ICAgICAgR3JhcGhpY3NDb250ZXh0M0Q6OkxJTkVBUikpOwotICAgICAgICB9IGVsc2UgewotICAg ICAgICAgICAgR0xDKGNvbnRleHQsIGNvbnRleHQtPnRleFBhcmFtZXRlcmkoR3JhcGhpY3NDb250 ZXh0M0Q6OlRFWFRVUkVfMkQsIEdyYXBoaWNzQ29udGV4dDNEOjpURVhUVVJFX01JTl9GSUxURVIs Ci0gICAgICAgICAgICAgICAgIEdyYXBoaWNzQ29udGV4dDNEOjpMSU5FQVIpKTsKLSAgICAgICAg ICAgIEdMQyhjb250ZXh0LCBjb250ZXh0LT50ZXhQYXJhbWV0ZXJpKEdyYXBoaWNzQ29udGV4dDNE OjpURVhUVVJFXzJELCBHcmFwaGljc0NvbnRleHQzRDo6VEVYVFVSRV9NQUdfRklMVEVSLAotICAg ICAgICAgICAgICAgIEdyYXBoaWNzQ29udGV4dDNEOjpMSU5FQVIpKTsKLSAgICAgICAgfQogCiAg ICAgICAgIG1fY29udGVudHNUZXh0dXJlID0gdGV4dHVyZUlkOwogICAgICAgICBtX2FsbG9jYXRl ZFRleHR1cmVTaXplID0gcmVxdWlyZWRUZXh0dXJlU2l6ZTsKQEAgLTMzOCw5ICszMTMsNiBAQCB2 b2lkIENvbnRlbnRMYXllckNocm9taXVtOjp1cGRhdGVUZXh0dXJlCiAgICAgICAgIEdMQyhjb250 ZXh0LCBjb250ZXh0LT50ZXhTdWJJbWFnZTJEKEdyYXBoaWNzQ29udGV4dDNEOjpURVhUVVJFXzJE LCAwLCB1cGRhdGVSZWN0LngoKSwgdXBkYXRlUmVjdC55KCksIHVwZGF0ZVJlY3Qud2lkdGgoKSwg dXBkYXRlUmVjdC5oZWlnaHQoKSwgR3JhcGhpY3NDb250ZXh0M0Q6OlJHQkEsIEdyYXBoaWNzQ29u dGV4dDNEOjpVTlNJR05FRF9CWVRFLCBwaXhlbHMpKTsKICAgICB9CiAKLSAgICBpZiAoZ2VuZXJh dGVNaXBtYXApCi0gICAgICAgIEdMQyhjb250ZXh0LCBjb250ZXh0LT5nZW5lcmF0ZU1pcG1hcChH cmFwaGljc0NvbnRleHQzRDo6VEVYVFVSRV8yRCkpOwotCiAgICAgbV9kaXJ0eVJlY3Quc2V0U2l6 ZShGbG9hdFNpemUoKSk7CiAgICAgLy8gTGFyZ2UgbGF5ZXJzIGFsd2F5cyBzdGF5IGRpcnR5LCBi ZWNhdXNlIHRoZXkgbmVlZCB0byB1cGRhdGUgd2hlbiB0aGUgY29udGVudCByZWN0IGNoYW5nZXMu CiAgICAgbV9jb250ZW50c0RpcnR5ID0gcmVxdWlyZXNDbGlwcGVkVXBkYXRlUmVjdCgpOwpJbmRl eDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9Db250ZW50TGF5ZXJDaHJvbWl1 bS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vQ29u dGVudExheWVyQ2hyb21pdW0uaAkocmV2aXNpb24gNzAwMDkpCisrKyBXZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2Nocm9taXVtL0NvbnRlbnRMYXllckNocm9taXVtLmgJKHdvcmtpbmcgY29weSkK QEAgLTYzLDcgKzYzLDYgQEAgcHVibGljOgogICAgICAgICBpbnQgc2hhZGVyTWF0cml4TG9jYXRp b24oKSBjb25zdCB7IHJldHVybiBtX3NoYWRlck1hdHJpeExvY2F0aW9uOyB9CiAgICAgICAgIGlu dCBzaGFkZXJBbHBoYUxvY2F0aW9uKCkgY29uc3QgeyByZXR1cm4gbV9zaGFkZXJBbHBoYUxvY2F0 aW9uOyB9CiAgICAgICAgIGludCBpbml0aWFsaXplZCgpIGNvbnN0IHsgcmV0dXJuIG1faW5pdGlh bGl6ZWQ7IH0KLSAgICAgICAgYm9vbCBucG90U3VwcG9ydGVkKCkgY29uc3QgeyByZXR1cm4gbV9u cG90U3VwcG9ydGVkOyB9CiAKICAgICBwcml2YXRlOgogICAgICAgICBHcmFwaGljc0NvbnRleHQz RCogbV9jb250ZXh0OwpAQCAtNzIsMTYgKzcxLDEzIEBAIHB1YmxpYzoKICAgICAgICAgaW50IG1f c2hhZGVyTWF0cml4TG9jYXRpb247CiAgICAgICAgIGludCBtX3NoYWRlckFscGhhTG9jYXRpb247 CiAgICAgICAgIGludCBtX2luaXRpYWxpemVkOwotICAgICAgICBib29sIG1fbnBvdFN1cHBvcnRl ZDsKICAgICB9OwogCiBwcm90ZWN0ZWQ6CiAgICAgQ29udGVudExheWVyQ2hyb21pdW0oR3JhcGhp Y3NMYXllckNocm9taXVtKiBvd25lcik7CiAKLSAgICBlbnVtIE1pcG1hcFVzZSB7bm9NaXBtYXAs IHVzZU1pcG1hcH07Ci0KICAgICB2b2lkIHVwZGF0ZVRleHR1cmVSZWN0KHZvaWQqIHBpeGVscywg Y29uc3QgSW50U2l6ZSYgYml0bWFwU2l6ZSwgY29uc3QgSW50U2l6ZSYgcmVxdWlyZWRUZXh0dXJl U2l6ZSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IEludFJlY3QmIHVwZGF0ZVJl Y3QsIHVuc2lnbmVkIHRleHR1cmVJZCwgTWlwbWFwVXNlIGdlbmVyYXRlTWlwbWFwID0gbm9NaXBt YXApOworICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgSW50UmVjdCYgdXBkYXRlUmVj dCwgdW5zaWduZWQgdGV4dHVyZUlkKTsKIAogICAgIHZpcnR1YWwgdm9pZCBjbGVhbnVwUmVzb3Vy Y2VzKCk7CiAgICAgYm9vbCByZXF1aXJlc0NsaXBwZWRVcGRhdGVSZWN0KCkgY29uc3Q7CkluZGV4 OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ltYWdlTGF5ZXJDaHJvbWl1bS5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9JbWFn ZUxheWVyQ2hyb21pdW0uY3BwCShyZXZpc2lvbiA3MDAwOSkKKysrIFdlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY2hyb21pdW0vSW1hZ2VMYXllckNocm9taXVtLmNwcAkod29ya2luZyBjb3B5KQpA QCAtMTU0LDcgKzE1NCw3IEBAIHZvaWQgSW1hZ2VMYXllckNocm9taXVtOjp1cGRhdGVDb250ZW50 cygKICAgICBkaXJ0eVJlY3QuaW50ZXJzZWN0KEludFJlY3QoSW50UG9pbnQoMCwgMCksIGJpdG1h cFNpemUpKTsKIAogICAgIGlmIChwaXhlbHMpCi0gICAgICAgIHVwZGF0ZVRleHR1cmVSZWN0KHBp eGVscywgYml0bWFwU2l6ZSwgcmVxdWlyZWRUZXh0dXJlU2l6ZSwgIGRpcnR5UmVjdCwgdGV4dHVy ZUlkLCB1c2VNaXBtYXApOworICAgICAgICB1cGRhdGVUZXh0dXJlUmVjdChwaXhlbHMsIGJpdG1h cFNpemUsIHJlcXVpcmVkVGV4dHVyZVNpemUsICBkaXJ0eVJlY3QsIHRleHR1cmVJZCk7CiB9CiAK IH0K