47911 2010-10-19 10:23:56 -0700 Add DirectX SDK to Installing Developer Tools web page 2010-10-19 19:54:15 -0700 1 1 1 Unclassified WebKit WebKit Website 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jennb jennb aroben bweinstein cmarrin commit-queue eric oldest_to_newest 296259 0 jennb 2010-10-19 10:23:56 -0700 From a thread on webkit-dev: date Tue, Nov 24, 2009 at 7:39 AM subject [webkit-dev] New requirement for building on Windows coming I've submitted a patch for accelerated compositing support on Windows. I hope to land it today. When I do it will require d3d9.lib to link. The feature will be turned off at first, but the build still needs to find the library. So the build-bots will need to be updated with DirectX 9.0 SDK Update (December 2004): http://www.microsoft.com/downloads/details.aspx?FamilyId=4E825A37-0C94-4421-9EC8-156E52525D11&displaylang=en You'll also need to add a path to this SDK in your MSDev Include and Library paths. The WebKit build-bots have already been updated, but external ones should make the changes in preparation. ======== DirectX SDK is apparently now required to build on Windows. webkit.org info needs to be updated to reflect this. 296263 1 71182 jennb 2010-10-19 10:34:35 -0700 Created attachment 71182 patch 296406 2 71182 eric 2010-10-19 14:23:53 -0700 Comment on attachment 71182 patch OK. 296408 3 eric 2010-10-19 14:24:08 -0700 CCing the windows folks. 296421 4 71182 commit-queue 2010-10-19 14:49:23 -0700 Comment on attachment 71182 patch Rejecting patch 71182 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'land-attachment', '--force-clean', '--ignore-builders', '--quiet', '--non-interactive', '--parent-command=commit-queue', 71182]" exit_code: 2 Last 500 characters of output: ?id=71182&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=47911&ctype=xml Processing 1 patch from 1 bug. Cleaning working directory Updating working directory Processing patch 71182 from bug 47911. Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html Full output: http://queues.webkit.org/results/4553004 296441 5 71206 jennb 2010-10-19 15:06:41 -0700 Created attachment 71206 updated patch with ChangeLog Forgot to include ChangeLog in the previous patch. 296565 6 71206 aroben 2010-10-19 17:56:40 -0700 Comment on attachment 71206 updated patch with ChangeLog View in context: https://bugs.webkit.org/attachment.cgi?id=71206&action=review > WebKitSite/building/tools.html:63 > +<p> Verify MSVC|Tools|Options|Projects and Solutions|VC++ Directories has Include: <code>$(DXSDK_DIR)include</code> and Lib: <code>$(DXSDK_DIR)lib</code> 1) $(DXSDK_DIR)lib isn't correct. It should be $(DXSDK_DIR)lib/x86. 2) This shouldn't be necessary. Our projects add these to the include/lib paths for you. 296568 7 aroben 2010-10-19 17:56:56 -0700 But thanks for updating the instructions! 296606 8 71182 eric 2010-10-19 19:49:30 -0700 Comment on attachment 71182 patch Cleared Eric Seidel's review+ from obsolete attachment 71182 so that this bug does not appear in http://webkit.org/pending-commit. 296607 9 71206 commit-queue 2010-10-19 19:54:09 -0700 Comment on attachment 71206 updated patch with ChangeLog Clearing flags on attachment: 71206 Committed r70121: <http://trac.webkit.org/changeset/70121> 296608 10 commit-queue 2010-10-19 19:54:15 -0700 All reviewed patches have been landed. Closing bug. 71182 2010-10-19 10:34:35 -0700 2010-10-19 19:49:30 -0700 patch patch.txt text/plain 1460 jennb ZGlmZiAtLWdpdCBhL1dlYktpdFNpdGUvYnVpbGRpbmcvdG9vbHMuaHRtbCBiL1dlYktpdFNpdGUv YnVpbGRpbmcvdG9vbHMuaHRtbAppbmRleCAwNDZhODY0Li5iNjYyMjlmIDEwMDY0NAotLS0gYS9X ZWJLaXRTaXRlL2J1aWxkaW5nL3Rvb2xzLmh0bWwKKysrIGIvV2ViS2l0U2l0ZS9idWlsZGluZy90 b29scy5odG1sCkBAIC01OCw2ICs1OCwxMSBAQCBLZWVwIGFsbCB0aGUgZGVmYXVsdCBvcHRpb25z IGFuZCBjbGljayA8Yj5OZXh0PC9iPiB1bnRpbCB0aGUgZmlsZSBpcyBleHRyYWN0ZWQgYQogPGxp PjxwPkluc3RhbGwgUXVpY2tUaW1lIFNESzwvcD4KIDxwPkRvd25sb2FkIFF1aWNrVGltZSBTREsg Zm9yIFdpbmRvd3MgZnJvbSA8YSBocmVmPSJodHRwOi8vZGV2ZWxvcGVyLmFwcGxlLmNvbS9xdWlj a3RpbWUvZG93bmxvYWQvIj5odHRwOi8vZGV2ZWxvcGVyLmFwcGxlLmNvbS9xdWlja3RpbWUvZG93 bmxvYWQvPC9hPiBhbmQgaW5zdGFsbCBpdCB0byB0aGUgZGVmYXVsdCBsb2NhdGlvbiAoXFByb2dy YW0gRmlsZXNcUXVpY2tUaW1lIFNESykuIFRoaXMgaXMgbmVlZGVkIGZvciBtZWRpYSBzdXBwb3J0 LgogCis8bGk+PHA+SW5zdGFsbCBEaXJlY3RYIFNESzwvcD4KKzxwPkRvd25sb2FkIHRoZSA8YSBo cmVmPSJodHRwOi8vbXNkbi5taWNyb3NvZnQuY29tL2VuLXVzL2RpcmVjdHgvZGVmYXVsdC5hc3B4 Ij5EaXJlY3RYIFNESzwvYT4uICBUaGlzIGlzIG5lZWRlZCBmb3IgYWNjZWxlcmF0ZWQgY29tcG9z aXRpbmcgb24gV2luZG93cy48L3A+Cis8cD4gVmVyaWZ5IE1TVkN8VG9vbHN8T3B0aW9uc3xQcm9q ZWN0cyBhbmQgU29sdXRpb25zfFZDKysgRGlyZWN0b3JpZXMgaGFzIEluY2x1ZGU6IDxjb2RlPiQo RFhTREtfRElSKWluY2x1ZGU8L2NvZGU+IGFuZCBMaWI6IDxjb2RlPiQoRFhTREtfRElSKWxpYjwv Y29kZT4gCis8L3A+CisKIDxsaT48cD5PcHRpb25hbDogSW5zdGFsbCB0aGUgMzItYml0IHZlcnNp b24gb2YgRGVidWdnaW5nIFRvb2xzIGZvciBXaW5kb3dzPC9wPgogPHA+RGVidWdnaW5nIFRvb2xz IGZvciBXaW5kb3dzIGluY2x1ZGVzIG1hbnkgdXNlZnVsIGRlYnVnZ2luZyB0b29scyBzdWNoIGFz IFdpbkRiZyBhbmQgTlRTRC4gU29tZSBvZiBXZWJLaXQmcnNxdW87cyB0ZXN0cyBhbmQgc2NyaXB0 cyB1c2UgdGhlc2UgdG9vbHMuIEZvbGxvdyB0aGUgPGEgdGFyZ2V0PSJpbnN0YWxsdG9vbHMiIGhy ZWY9Imh0dHA6Ly93d3cubWljcm9zb2Z0LmNvbS93aGRjL2RldnRvb2xzL2RlYnVnZ2luZy9pbnN0 YWxseDg2Lm1zcHgjYiI+aW5zdHJ1Y3Rpb25zIGZvciBpbnN0YWxsaW5nIHRoZSAzMi1iaXQgdmVy c2lvbiBvZiBEZWJ1Z2dpbmcgVG9vbHMgZm9yIFdpbmRvd3M8L2E+LjwvcD4KIDxsaT48cD5PcHRp b25hbDogSG90Zml4IGZvciA2NC1iaXQgV2luZG93cyB0byBkaXNhYmxlIHRoZSB1c2VyLW1vZGUg Y2FsbGJhY2sgZmlsdGVyIGZvciBleGNlcHRpb25zPC9wPgo= 71206 2010-10-19 15:06:41 -0700 2010-10-19 19:54:09 -0700 updated patch with ChangeLog patch.txt text/plain 1949 jennb ZGlmZiAtLWdpdCBhL1dlYktpdFNpdGUvQ2hhbmdlTG9nIGIvV2ViS2l0U2l0ZS9DaGFuZ2VMb2cK aW5kZXggY2VhN2UxZC4uMDUxMDU5ZCAxMDA2NDQKLS0tIGEvV2ViS2l0U2l0ZS9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0U2l0ZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMC0xMC0xOSAg SmVubiBCcmFpdGh3YWl0ZSAgPGplbm5iQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgRGlyZWN0WCBTREsgdG8gSW5zdGFs bGluZyBEZXZlbG9wZXIgVG9vbHMgd2ViIHBhZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3OTExCisKKyAgICAgICAgKiBidWlsZGluZy90b29scy5o dG1sOgorCiAyMDEwLTA5LTMwICBEYXZpZCBMZXZpbiAgPGxldmluQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL1dlYktpdFNpdGUv YnVpbGRpbmcvdG9vbHMuaHRtbCBiL1dlYktpdFNpdGUvYnVpbGRpbmcvdG9vbHMuaHRtbAppbmRl eCAwNDZhODY0Li5iNjYyMjlmIDEwMDY0NAotLS0gYS9XZWJLaXRTaXRlL2J1aWxkaW5nL3Rvb2xz Lmh0bWwKKysrIGIvV2ViS2l0U2l0ZS9idWlsZGluZy90b29scy5odG1sCkBAIC01OCw2ICs1OCwx MSBAQCBLZWVwIGFsbCB0aGUgZGVmYXVsdCBvcHRpb25zIGFuZCBjbGljayA8Yj5OZXh0PC9iPiB1 bnRpbCB0aGUgZmlsZSBpcyBleHRyYWN0ZWQgYQogPGxpPjxwPkluc3RhbGwgUXVpY2tUaW1lIFNE SzwvcD4KIDxwPkRvd25sb2FkIFF1aWNrVGltZSBTREsgZm9yIFdpbmRvd3MgZnJvbSA8YSBocmVm PSJodHRwOi8vZGV2ZWxvcGVyLmFwcGxlLmNvbS9xdWlja3RpbWUvZG93bmxvYWQvIj5odHRwOi8v ZGV2ZWxvcGVyLmFwcGxlLmNvbS9xdWlja3RpbWUvZG93bmxvYWQvPC9hPiBhbmQgaW5zdGFsbCBp dCB0byB0aGUgZGVmYXVsdCBsb2NhdGlvbiAoXFByb2dyYW0gRmlsZXNcUXVpY2tUaW1lIFNESyku IFRoaXMgaXMgbmVlZGVkIGZvciBtZWRpYSBzdXBwb3J0LgogCis8bGk+PHA+SW5zdGFsbCBEaXJl Y3RYIFNESzwvcD4KKzxwPkRvd25sb2FkIHRoZSA8YSBocmVmPSJodHRwOi8vbXNkbi5taWNyb3Nv ZnQuY29tL2VuLXVzL2RpcmVjdHgvZGVmYXVsdC5hc3B4Ij5EaXJlY3RYIFNESzwvYT4uICBUaGlz IGlzIG5lZWRlZCBmb3IgYWNjZWxlcmF0ZWQgY29tcG9zaXRpbmcgb24gV2luZG93cy48L3A+Cis8 cD4gVmVyaWZ5IE1TVkN8VG9vbHN8T3B0aW9uc3xQcm9qZWN0cyBhbmQgU29sdXRpb25zfFZDKysg RGlyZWN0b3JpZXMgaGFzIEluY2x1ZGU6IDxjb2RlPiQoRFhTREtfRElSKWluY2x1ZGU8L2NvZGU+ IGFuZCBMaWI6IDxjb2RlPiQoRFhTREtfRElSKWxpYjwvY29kZT4gCis8L3A+CisKIDxsaT48cD5P cHRpb25hbDogSW5zdGFsbCB0aGUgMzItYml0IHZlcnNpb24gb2YgRGVidWdnaW5nIFRvb2xzIGZv ciBXaW5kb3dzPC9wPgogPHA+RGVidWdnaW5nIFRvb2xzIGZvciBXaW5kb3dzIGluY2x1ZGVzIG1h bnkgdXNlZnVsIGRlYnVnZ2luZyB0b29scyBzdWNoIGFzIFdpbkRiZyBhbmQgTlRTRC4gU29tZSBv ZiBXZWJLaXQmcnNxdW87cyB0ZXN0cyBhbmQgc2NyaXB0cyB1c2UgdGhlc2UgdG9vbHMuIEZvbGxv dyB0aGUgPGEgdGFyZ2V0PSJpbnN0YWxsdG9vbHMiIGhyZWY9Imh0dHA6Ly93d3cubWljcm9zb2Z0 LmNvbS93aGRjL2RldnRvb2xzL2RlYnVnZ2luZy9pbnN0YWxseDg2Lm1zcHgjYiI+aW5zdHJ1Y3Rp b25zIGZvciBpbnN0YWxsaW5nIHRoZSAzMi1iaXQgdmVyc2lvbiBvZiBEZWJ1Z2dpbmcgVG9vbHMg Zm9yIFdpbmRvd3M8L2E+LjwvcD4KIDxsaT48cD5PcHRpb25hbDogSG90Zml4IGZvciA2NC1iaXQg V2luZG93cyB0byBkaXNhYmxlIHRoZSB1c2VyLW1vZGUgY2FsbGJhY2sgZmlsdGVyIGZvciBleGNl cHRpb25zPC9wPgo=