47904 2010-10-19 07:10:48 -0700 Use UChar instead of wchar_t in UnicodeWinCE 2010-10-19 12:24:12 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 1 paroga paroga commit-queue ddkilzer japhet mihaip oldest_to_newest 296171 0 paroga 2010-10-19 07:10:48 -0700 see patch 296176 1 71167 paroga 2010-10-19 07:18:20 -0700 Created attachment 71167 Patch 296313 2 71167 ddkilzer 2010-10-19 11:42:47 -0700 Comment on attachment 71167 Patch r=me 296327 3 commit-queue 2010-10-19 12:22:03 -0700 The commit-queue encountered the following flaky tests while processing attachment 71167: http/tests/navigation/image-load-in-unload-handler.html Please file bugs against the tests. The author(s) of the test(s) have been CCed on this bug. The commit-queue is continuing to process your patch. 296329 4 71167 commit-queue 2010-10-19 12:24:07 -0700 Comment on attachment 71167 Patch Clearing flags on attachment: 71167 Committed r70074: <http://trac.webkit.org/changeset/70074> 296330 5 commit-queue 2010-10-19 12:24:12 -0700 All reviewed patches have been landed. Closing bug. 71167 2010-10-19 07:18:20 -0700 2010-10-19 12:24:07 -0700 Patch bug-47904.patch text/plain 7340 paroga ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCAwYWE5NjgwLi5lNjA2YzdjIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzQg QEAKKzIwMTAtMTAtMjAgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIFVDaGFy IGluc3RlYWQgb2Ygd2NoYXJfdCBpbiBVbmljb2RlV2luQ0UKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3OTA0CisKKyAgICAgICAgTWFrZSBVbmljb2Rl V2luQ0UgbW9yZSBwb3J0YWJsZSwgc28gd2UgY2FuIHVzZSBpdCBmb3Igb3RoZXIgcG9ydHMgdG9v LgorCisgICAgICAgICogd3RmL3VuaWNvZGUvd2luY2UvVW5pY29kZVdpbkNFLmNwcDoKKyAgICAg ICAgKFdURjo6VW5pY29kZTo6dG9Mb3dlcik6CisgICAgICAgIChXVEY6OlVuaWNvZGU6OnRvVXBw ZXIpOgorICAgICAgICAoV1RGOjpVbmljb2RlOjpmb2xkQ2FzZSk6CisgICAgICAgIChXVEY6OlVu aWNvZGU6OmlzUHJpbnRhYmxlQ2hhcik6CisgICAgICAgIChXVEY6OlVuaWNvZGU6OmlzU3BhY2Up OgorICAgICAgICAoV1RGOjpVbmljb2RlOjppc0xldHRlcik6CisgICAgICAgIChXVEY6OlVuaWNv ZGU6OmlzVXBwZXIpOgorICAgICAgICAoV1RGOjpVbmljb2RlOjppc0xvd2VyKToKKyAgICAgICAg KFdURjo6VW5pY29kZTo6aXNEaWdpdCk6CisgICAgICAgIChXVEY6OlVuaWNvZGU6OmlzUHVuY3Qp OgorICAgICAgICAoV1RGOjpVbmljb2RlOjppc0FscGhhbnVtZXJpYyk6CisgICAgICAgIChXVEY6 OlVuaWNvZGU6OnRvVGl0bGVDYXNlKToKKyAgICAgICAgKFdURjo6VW5pY29kZTo6bWlycm9yZWRD aGFyKToKKyAgICAgICAgKFdURjo6VW5pY29kZTo6ZGlnaXRWYWx1ZSk6CisgICAgICAgICogd3Rm L3VuaWNvZGUvd2luY2UvVW5pY29kZVdpbkNFLmg6CisgICAgICAgIChXVEY6OlVuaWNvZGU6Omlz U2VwYXJhdG9yU3BhY2UpOgorICAgICAgICAoV1RGOjpVbmljb2RlOjppc0hpZ2hTdXJyb2dhdGUp OgorICAgICAgICAoV1RGOjpVbmljb2RlOjppc0xvd1N1cnJvZ2F0ZSk6CisgICAgICAgIChXVEY6 OlVuaWNvZGU6OnVtZW1jYXNlY21wKToKKyAgICAgICAgKFdURjo6VW5pY29kZTo6c3Vycm9nYXRl VG9VY3M0KToKKwogMjAxMC0xMC0xOSAgUGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0 Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbmRyZWFzIEtsaW5nLgpkaWZmIC0tZ2l0IGEv SmF2YVNjcmlwdENvcmUvd3RmL3VuaWNvZGUvd2luY2UvVW5pY29kZVdpbkNFLmNwcCBiL0phdmFT Y3JpcHRDb3JlL3d0Zi91bmljb2RlL3dpbmNlL1VuaWNvZGVXaW5DRS5jcHAKaW5kZXggZGRjOWU0 ZS4uOTZkYWM3ZCAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvd3RmL3VuaWNvZGUvd2luY2Uv VW5pY29kZVdpbkNFLmNwcAorKysgYi9KYXZhU2NyaXB0Q29yZS93dGYvdW5pY29kZS93aW5jZS9V bmljb2RlV2luQ0UuY3BwCkBAIC0yNyw2MiArMjcsNjIgQEAKIG5hbWVzcGFjZSBXVEYgewogbmFt ZXNwYWNlIFVuaWNvZGUgewogCi13Y2hhcl90IHRvTG93ZXIod2NoYXJfdCBjKQorVUNoYXIgdG9M b3dlcihVQ2hhciBjKQogewogICAgIHJldHVybiB0b3dsb3dlcihjKTsKIH0KIAotd2NoYXJfdCB0 b1VwcGVyKHdjaGFyX3QgYykKK1VDaGFyIHRvVXBwZXIoVUNoYXIgYykKIHsKICAgICByZXR1cm4g dG93dXBwZXIoYyk7CiB9CiAKLXdjaGFyX3QgZm9sZENhc2Uod2NoYXJfdCBjKQorVUNoYXIgZm9s ZENhc2UoVUNoYXIgYykKIHsKICAgICByZXR1cm4gdG93bG93ZXIoYyk7CiB9CiAKLWJvb2wgaXNQ cmludGFibGVDaGFyKHdjaGFyX3QgYykKK2Jvb2wgaXNQcmludGFibGVDaGFyKFVDaGFyIGMpCiB7 CiAgICAgcmV0dXJuICEhaXN3cHJpbnQoYyk7CiB9CiAKLWJvb2wgaXNTcGFjZSh3Y2hhcl90IGMp Citib29sIGlzU3BhY2UoVUNoYXIgYykKIHsKICAgICByZXR1cm4gISFpc3dzcGFjZShjKTsKIH0K IAotYm9vbCBpc0xldHRlcih3Y2hhcl90IGMpCitib29sIGlzTGV0dGVyKFVDaGFyIGMpCiB7CiAg ICAgcmV0dXJuICEhaXN3YWxwaGEoYyk7CiB9CiAKLWJvb2wgaXNVcHBlcih3Y2hhcl90IGMpCiti b29sIGlzVXBwZXIoVUNoYXIgYykKIHsKICAgICByZXR1cm4gISFpc3d1cHBlcihjKTsKIH0KIAot Ym9vbCBpc0xvd2VyKHdjaGFyX3QgYykKK2Jvb2wgaXNMb3dlcihVQ2hhciBjKQogewogICAgIHJl dHVybiAhIWlzd2xvd2VyKGMpOwogfQogCi1ib29sIGlzRGlnaXQod2NoYXJfdCBjKQorYm9vbCBp c0RpZ2l0KFVDaGFyIGMpCiB7CiAgICAgcmV0dXJuICEhaXN3ZGlnaXQoYyk7CiB9CiAKLWJvb2wg aXNQdW5jdCh3Y2hhcl90IGMpCitib29sIGlzUHVuY3QoVUNoYXIgYykKIHsKICAgICByZXR1cm4g ISFpc3dwdW5jdChjKTsKIH0KIAotYm9vbCBpc0FscGhhbnVtZXJpYyh3Y2hhcl90IGMpCitib29s IGlzQWxwaGFudW1lcmljKFVDaGFyIGMpCiB7CiAgICAgcmV0dXJuICEhaXN3YWxudW0oYyk7CiB9 CiAKLWludCB0b0xvd2VyKHdjaGFyX3QqIHJlc3VsdCwgaW50IHJlc3VsdExlbmd0aCwgY29uc3Qg d2NoYXJfdCogc291cmNlLCBpbnQgc291cmNlTGVuZ3RoLCBib29sKiBpc0Vycm9yKQoraW50IHRv TG93ZXIoVUNoYXIqIHJlc3VsdCwgaW50IHJlc3VsdExlbmd0aCwgY29uc3QgVUNoYXIqIHNvdXJj ZSwgaW50IHNvdXJjZUxlbmd0aCwgYm9vbCogaXNFcnJvcikKIHsKICAgICBjb25zdCBVQ2hhciog c291cmNlSXRlcmF0b3IgPSBzb3VyY2U7CiAgICAgY29uc3QgVUNoYXIqIHNvdXJjZUVuZCA9IHNv dXJjZSArIHNvdXJjZUxlbmd0aDsKQEAgLTEwNiw3ICsxMDYsNyBAQCBpbnQgdG9Mb3dlcih3Y2hh cl90KiByZXN1bHQsIGludCByZXN1bHRMZW5ndGgsIGNvbnN0IHdjaGFyX3QqIHNvdXJjZSwgaW50 IHNvdXJjZQogICAgIHJldHVybiAocmVzdWx0SXRlcmF0b3IgLSByZXN1bHQpICsgcmVtYWluaW5n Q2hhcmFjdGVyczsKIH0KIAotaW50IHRvVXBwZXIod2NoYXJfdCogcmVzdWx0LCBpbnQgcmVzdWx0 TGVuZ3RoLCBjb25zdCB3Y2hhcl90KiBzb3VyY2UsIGludCBzb3VyY2VMZW5ndGgsIGJvb2wqIGlz RXJyb3IpCitpbnQgdG9VcHBlcihVQ2hhciogcmVzdWx0LCBpbnQgcmVzdWx0TGVuZ3RoLCBjb25z dCBVQ2hhciogc291cmNlLCBpbnQgc291cmNlTGVuZ3RoLCBib29sKiBpc0Vycm9yKQogewogICAg IGNvbnN0IFVDaGFyKiBzb3VyY2VJdGVyYXRvciA9IHNvdXJjZTsKICAgICBjb25zdCBVQ2hhciog c291cmNlRW5kID0gc291cmNlICsgc291cmNlTGVuZ3RoOwpAQCAtMTMwLDcgKzEzMCw3IEBAIGlu dCB0b1VwcGVyKHdjaGFyX3QqIHJlc3VsdCwgaW50IHJlc3VsdExlbmd0aCwgY29uc3Qgd2NoYXJf dCogc291cmNlLCBpbnQgc291cmNlCiAgICAgcmV0dXJuIChyZXN1bHRJdGVyYXRvciAtIHJlc3Vs dCkgKyByZW1haW5pbmdDaGFyYWN0ZXJzOwogfQogCi1pbnQgZm9sZENhc2Uod2NoYXJfdCogcmVz dWx0LCBpbnQgcmVzdWx0TGVuZ3RoLCBjb25zdCB3Y2hhcl90KiBzb3VyY2UsIGludCBzb3VyY2VM ZW5ndGgsIGJvb2wqIGlzRXJyb3IpCitpbnQgZm9sZENhc2UoVUNoYXIqIHJlc3VsdCwgaW50IHJl c3VsdExlbmd0aCwgY29uc3QgVUNoYXIqIHNvdXJjZSwgaW50IHNvdXJjZUxlbmd0aCwgYm9vbCog aXNFcnJvcikKIHsKICAgICAqaXNFcnJvciA9IGZhbHNlOwogICAgIGlmIChyZXN1bHRMZW5ndGgg PCBzb3VyY2VMZW5ndGgpIHsKQEAgLTE0Miw3ICsxNDIsNyBAQCBpbnQgZm9sZENhc2Uod2NoYXJf dCogcmVzdWx0LCBpbnQgcmVzdWx0TGVuZ3RoLCBjb25zdCB3Y2hhcl90KiBzb3VyY2UsIGludCBz b3VyYwogICAgIHJldHVybiBzb3VyY2VMZW5ndGg7CiB9CiAKLXdjaGFyX3QgdG9UaXRsZUNhc2Uo d2NoYXJfdCBjKQorVUNoYXIgdG9UaXRsZUNhc2UoVUNoYXIgYykKIHsKICAgICByZXR1cm4gdG93 dXBwZXIoYyk7CiB9CkBAIC0xNjcsMTIgKzE2NywxMiBAQCB1bnNpZ25lZCBjaGFyIGNvbWJpbmlu Z0NsYXNzKFVDaGFyMzIgYykKICAgICByZXR1cm4gVW5pY29kZUNFOjpjb21iaW5pbmdDbGFzcyhj KTsKIH0KIAotd2NoYXJfdCBtaXJyb3JlZENoYXIoVUNoYXIzMiBjKQorVUNoYXIgbWlycm9yZWRD aGFyKFVDaGFyMzIgYykKIHsKICAgICByZXR1cm4gVW5pY29kZUNFOjptaXJyb3JlZENoYXIoYyk7 CiB9CiAKLWludCBkaWdpdFZhbHVlKHdjaGFyX3QgYykKK2ludCBkaWdpdFZhbHVlKFVDaGFyIGMp CiB7CiAgICAgcmV0dXJuIFVuaWNvZGVDRTo6ZGlnaXRWYWx1ZShjKTsKIH0KZGlmZiAtLWdpdCBh L0phdmFTY3JpcHRDb3JlL3d0Zi91bmljb2RlL3dpbmNlL1VuaWNvZGVXaW5DRS5oIGIvSmF2YVNj cmlwdENvcmUvd3RmL3VuaWNvZGUvd2luY2UvVW5pY29kZVdpbkNFLmgKaW5kZXggODU3NzQ5NS4u MjY4OGFhOSAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvd3RmL3VuaWNvZGUvd2luY2UvVW5p Y29kZVdpbkNFLmgKKysrIGIvSmF2YVNjcmlwdENvcmUvd3RmL3VuaWNvZGUvd2luY2UvVW5pY29k ZVdpbkNFLmgKQEAgLTExOSwyOSArMTE5LDI5IEBAIGVudW0gQ2hhckNhdGVnb3J5IHsKIAogQ2hh ckNhdGVnb3J5IGNhdGVnb3J5KHVuc2lnbmVkIGludCk7CiAKLWJvb2wgaXNTcGFjZSh3Y2hhcl90 KTsKLWJvb2wgaXNMZXR0ZXIod2NoYXJfdCk7Ci1ib29sIGlzUHJpbnRhYmxlQ2hhcih3Y2hhcl90 KTsKLWJvb2wgaXNVcHBlcih3Y2hhcl90KTsKLWJvb2wgaXNMb3dlcih3Y2hhcl90KTsKLWJvb2wg aXNQdW5jdCh3Y2hhcl90KTsKLWJvb2wgaXNEaWdpdCh3Y2hhcl90KTsKLWJvb2wgaXNBbHBoYW51 bWVyaWMod2NoYXJfdCk7Ci1pbmxpbmUgYm9vbCBpc1NlcGFyYXRvclNwYWNlKHdjaGFyX3QgYykg eyByZXR1cm4gY2F0ZWdvcnkoYykgPT0gU2VwYXJhdG9yX1NwYWNlOyB9Ci1pbmxpbmUgYm9vbCBp c0hpZ2hTdXJyb2dhdGUod2NoYXJfdCBjKSB7IHJldHVybiAoYyAmIDB4ZmMwMCkgPT0gMHhkODAw OyB9Ci1pbmxpbmUgYm9vbCBpc0xvd1N1cnJvZ2F0ZSh3Y2hhcl90IGMpIHsgcmV0dXJuIChjICYg MHhmYzAwKSA9PSAweGRjMDA7IH0KLQotd2NoYXJfdCB0b0xvd2VyKHdjaGFyX3QpOwotd2NoYXJf dCB0b1VwcGVyKHdjaGFyX3QpOwotd2NoYXJfdCBmb2xkQ2FzZSh3Y2hhcl90KTsKLXdjaGFyX3Qg dG9UaXRsZUNhc2Uod2NoYXJfdCk7Ci1pbnQgdG9Mb3dlcih3Y2hhcl90KiByZXN1bHQsIGludCBy ZXN1bHRMZW5ndGgsIGNvbnN0IHdjaGFyX3QqIHNvdXJjZSwgaW50IHNvdXJjZUxlbmd0aCwgYm9v bCogaXNFcnJvcik7Ci1pbnQgdG9VcHBlcih3Y2hhcl90KiByZXN1bHQsIGludCByZXN1bHRMZW5n dGgsIGNvbnN0IHdjaGFyX3QqIHNvdXJjZSwgaW50IHNvdXJjZUxlbmd0aCwgYm9vbCogaXNFcnJv cik7Ci1pbnQgZm9sZENhc2UoVUNoYXIqIHJlc3VsdCwgaW50IHJlc3VsdExlbmd0aCwgY29uc3Qg d2NoYXJfdCogc291cmNlLCBpbnQgc291cmNlTGVuZ3RoLCBib29sKiBpc0Vycm9yKTsKLQotaW50 IGRpZ2l0VmFsdWUod2NoYXJfdCk7Ci0KLXdjaGFyX3QgbWlycm9yZWRDaGFyKFVDaGFyMzIpOwor Ym9vbCBpc1NwYWNlKFVDaGFyKTsKK2Jvb2wgaXNMZXR0ZXIoVUNoYXIpOworYm9vbCBpc1ByaW50 YWJsZUNoYXIoVUNoYXIpOworYm9vbCBpc1VwcGVyKFVDaGFyKTsKK2Jvb2wgaXNMb3dlcihVQ2hh cik7Citib29sIGlzUHVuY3QoVUNoYXIpOworYm9vbCBpc0RpZ2l0KFVDaGFyKTsKK2Jvb2wgaXNB bHBoYW51bWVyaWMoVUNoYXIpOworaW5saW5lIGJvb2wgaXNTZXBhcmF0b3JTcGFjZShVQ2hhciBj KSB7IHJldHVybiBjYXRlZ29yeShjKSA9PSBTZXBhcmF0b3JfU3BhY2U7IH0KK2lubGluZSBib29s IGlzSGlnaFN1cnJvZ2F0ZShVQ2hhciBjKSB7IHJldHVybiAoYyAmIDB4ZmMwMCkgPT0gMHhkODAw OyB9CitpbmxpbmUgYm9vbCBpc0xvd1N1cnJvZ2F0ZShVQ2hhciBjKSB7IHJldHVybiAoYyAmIDB4 ZmMwMCkgPT0gMHhkYzAwOyB9CisKK1VDaGFyIHRvTG93ZXIoVUNoYXIpOworVUNoYXIgdG9VcHBl cihVQ2hhcik7CitVQ2hhciBmb2xkQ2FzZShVQ2hhcik7CitVQ2hhciB0b1RpdGxlQ2FzZShVQ2hh cik7CitpbnQgdG9Mb3dlcihVQ2hhciogcmVzdWx0LCBpbnQgcmVzdWx0TGVuZ3RoLCBjb25zdCBV Q2hhciogc291cmNlLCBpbnQgc291cmNlTGVuZ3RoLCBib29sKiBpc0Vycm9yKTsKK2ludCB0b1Vw cGVyKFVDaGFyKiByZXN1bHQsIGludCByZXN1bHRMZW5ndGgsIGNvbnN0IFVDaGFyKiBzb3VyY2Us IGludCBzb3VyY2VMZW5ndGgsIGJvb2wqIGlzRXJyb3IpOworaW50IGZvbGRDYXNlKFVDaGFyKiBy ZXN1bHQsIGludCByZXN1bHRMZW5ndGgsIGNvbnN0IFVDaGFyKiBzb3VyY2UsIGludCBzb3VyY2VM ZW5ndGgsIGJvb2wqIGlzRXJyb3IpOworCitpbnQgZGlnaXRWYWx1ZShVQ2hhcik7CisKK1VDaGFy IG1pcnJvcmVkQ2hhcihVQ2hhcjMyKTsKIHVuc2lnbmVkIGNoYXIgY29tYmluaW5nQ2xhc3MoVUNo YXIzMik7CiBEZWNvbXBvc2l0aW9uVHlwZSBkZWNvbXBvc2l0aW9uVHlwZShVQ2hhcjMyKTsKIERp cmVjdGlvbiBkaXJlY3Rpb24oVUNoYXIzMik7CkBAIC0xNTUsMTggKzE1NSwxOCBAQCBpbmxpbmUg Ym9vbCBoYXNMaW5lQnJlYWtpbmdQcm9wZXJ0eUNvbXBsZXhDb250ZXh0KFVDaGFyMzIpCiAgICAg cmV0dXJuIGZhbHNlOyAvLyBGSVhNRTogaW1wbGVtZW50IQogfQogCi1pbmxpbmUgaW50IHVtZW1j YXNlY21wKGNvbnN0IHdjaGFyX3QqIGEsIGNvbnN0IHdjaGFyX3QqIGIsIGludCBsZW4pCitpbmxp bmUgaW50IHVtZW1jYXNlY21wKGNvbnN0IFVDaGFyKiBhLCBjb25zdCBVQ2hhciogYiwgaW50IGxl bikKIHsKICAgICBmb3IgKGludCBpID0gMDsgaSA8IGxlbjsgKytpKSB7Ci0gICAgICAgIHdjaGFy X3QgYzEgPSBmb2xkQ2FzZShhW2ldKTsKLSAgICAgICAgd2NoYXJfdCBjMiA9IGZvbGRDYXNlKGJb aV0pOworICAgICAgICBVQ2hhciBjMSA9IGZvbGRDYXNlKGFbaV0pOworICAgICAgICBVQ2hhciBj MiA9IGZvbGRDYXNlKGJbaV0pOwogICAgICAgICBpZiAoYzEgIT0gYzIpCiAgICAgICAgICAgICBy ZXR1cm4gYzEgLSBjMjsKICAgICB9CiAgICAgcmV0dXJuIDA7CiB9CiAKLWlubGluZSBVQ2hhcjMy IHN1cnJvZ2F0ZVRvVWNzNCh3Y2hhcl90IGhpZ2gsIHdjaGFyX3QgbG93KQoraW5saW5lIFVDaGFy MzIgc3Vycm9nYXRlVG9VY3M0KFVDaGFyIGhpZ2gsIFVDaGFyIGxvdykKIHsKICAgICByZXR1cm4g KFVDaGFyMzIoaGlnaCkgPDwgMTApICsgbG93IC0gMHgzNWZkYzAwOwogfQo=