47901 2010-10-19 06:40:27 -0700 fast/canvas/canvas-getImageData-negative-source.html fails on Mac 2011-04-19 13:51:05 -0700 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 kling mihaip agl commit-queue jamesr jschuh mdelaney7 mihaip senorblanco wjmaclean oldest_to_newest 296146 0 kling 2010-10-19 06:40:27 -0700 fast/canvas/canvas-getImageData-negative-source.html fails on Mac. It was added in <http://trac.webkit.org/changeset/70050> 296376 1 jamesr 2010-10-19 13:47:42 -0700 Fails on chromium mac as well (but passes on other chromium platforms). Looks like a CoreGraphics issue. 319180 2 75998 mihaip 2010-12-08 18:23:06 -0800 Created attachment 75998 Patch 319181 3 75998 darin 2010-12-08 18:25:49 -0800 Comment on attachment 75998 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=75998&action=review Looks fine. > WebCore/html/HTMLCanvasElement.cpp:349 > #if PLATFORM(SKIA) > - if (wf > MaxSkiaDim || hf > MaxSkiaDim) > + if (width > MaxSkiaDim || height > MaxSkiaDim) > return IntSize(); > #endif Really? Why does Skia need this at this level? Why doesn’t any other graphics system need this? 319751 4 mihaip 2010-12-09 15:46:31 -0800 (In reply to comment #3) > Really? Why does Skia need this at this level? Why doesn’t any other graphics system need this? This was done in http://trac.webkit.org/changeset/63219 because of a security bug (bug 41962) that I don't have permission to see, perhaps one of the people involved with that patch can say for sure. 319779 5 jamesr 2010-12-09 16:26:59 -0800 (In reply to comment #3) > (From update of attachment 75998 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=75998&action=review > > Looks fine. > > > WebCore/html/HTMLCanvasElement.cpp:349 > > #if PLATFORM(SKIA) > > - if (wf > MaxSkiaDim || hf > MaxSkiaDim) > > + if (width > MaxSkiaDim || height > MaxSkiaDim) > > return IntSize(); > > #endif > > Really? Why does Skia need this at this level? Why doesn’t any other graphics system need this? The short story here is that Skia's limitations are more strict than that of other graphics systems - every graphics system has a max area cap, but Skia also has a maximum value it can handle in any one dimension. I think the decision was made to enforce the Skia limits in the same places that the limitations of other graphics systems are enforced rather than reducing everyone's limits to that of skia. I agree it's kind of weird. At this point, I'm not sure if the limits for Skia are even necessary any more (we've switched to using floating point math instead of fixed point math in some of Skia's internals) - so it's possible that we can just drop all of the Skia guards and stick the cross-platform limits. Stephen or Adam would probably know if I'm just imagining things here. 319796 6 75998 senorblanco 2010-12-09 17:00:51 -0800 Comment on attachment 75998 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=75998&action=review >>> WebCore/html/HTMLCanvasElement.cpp:349 >>> #endif >> >> Really? Why does Skia need this at this level? Why doesn’t any other graphics system need this? > > The short story here is that Skia's limitations are more strict than that of other graphics systems - every graphics system has a max area cap, but Skia also has a maximum value it can handle in any one dimension. I think the decision was made to enforce the Skia limits in the same places that the limitations of other graphics systems are enforced rather than reducing everyone's limits to that of skia. I agree it's kind of weird. > > At this point, I'm not sure if the limits for Skia are even necessary any more (we've switched to using floating point math instead of fixed point math in some of Skia's internals) - so it's possible that we can just drop all of the Skia guards and stick the cross-platform limits. Stephen or Adam would probably know if I'm just imagining things here. No, unfortunately we still need this. See r63219 where this was added. One way to make it less ugly would be to have a function or enum on GraphicsContext.h to retrieve the (platform-specific) maximum dimension, rather than having an #if PLATFORM here. 319869 7 commit-queue 2010-12-09 19:08:18 -0800 The commit-queue encountered the following flaky tests while processing attachment 75998: http/tests/appcache/foreign-fallback.html fast/css/font-face-download-error.html Please file bugs against the tests. These tests were authored by ap@webkit.org and yuzo@google.com. The commit-queue is continuing to process your patch. 319870 8 75998 commit-queue 2010-12-09 19:09:31 -0800 Comment on attachment 75998 Patch Rejecting patch 75998 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'apply-attachment', '--force-clean', '--non-interactive', 75998]" exit_code: 2 Last 500 characters of output: s.txt Hunk #1 FAILED at 2412. Hunk #2 succeeded at 2919 (offset -15 lines). Hunk #3 FAILED at 2991. 2 out of 3 hunks FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/html/HTMLCanvasElement.cpp patching file WebCore/html/HTMLCanvasElement.h Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Darin Adler', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/6953031 320243 9 mihaip 2010-12-10 10:48:05 -0800 Committed r73744: <http://trac.webkit.org/changeset/73744> 388762 10 mdelaney7 2011-04-19 13:51:05 -0700 This test appears to be still on the platform/mac/Skipped list. If it's fixed for all/mac, it should be taken off all/mac skipped lists. 75998 2010-12-08 18:23:06 -0800 2010-12-09 19:09:31 -0800 Patch bug-47901-20101208182304.patch text/plain 9940 mihaip ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBmNzlhOTY2MmU4NmFhOWJkN2UzNGE2MWU2ZTBkODkwNDY1YjlkZGNhLi4yNTlmMzFh ZGZjZjJkNTEwNzNjZGE3Y2M5MzU5NmFjNDIwMzQzZTg5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAK KzIwMTAtMTItMDggIE1paGFpIFBhcnBhcml0YSAgPG1paGFpcEBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgZmFzdC9jYW52YXMv Y2FudmFzLWdldEltYWdlRGF0YS1uZWdhdGl2ZS1zb3VyY2UuaHRtbCBmYWlscyBvbiBNYWMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3OTAxCisgICAg ICAgIAorICAgICAgICBBZGQgdGVzdCBmb3Igcm91bmRpbmcgYmVoYXZpb3IuIFJlbW92ZSBub3ct cGFzc2luZyB0ZXN0cyBmcm9tCisgICAgICAgIHRlc3RfZXhwZWN0YXRpb25zLnR4dC4KKworICAg ICAgICAqIGZhc3QvY2FudmFzL2NhbnZhcy1nZXRJbWFnZURhdGEtcm91bmRpbmctZXhwZWN0ZWQu dHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2NhbnZhcy9jYW52YXMtZ2V0SW1hZ2VEYXRhLXJv dW5kaW5nLmh0bWw6IEFkZGVkLgorICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhw ZWN0YXRpb25zLnR4dDoKKwogMjAxMC0xMi0wOCAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0 Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkIENocm9taXVtIHRlc3QgZXhwZWN0YXRpb25zIHVw ZGF0ZS4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY2FudmFzL2NhbnZhcy1nZXRJbWFn ZURhdGEtcm91bmRpbmctZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvY2Fu dmFzLWdldEltYWdlRGF0YS1yb3VuZGluZy1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2 NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZTdlYTI4 YmI3NDdkNzNmZjVkMDVkMGQ2NDJjOGY3ZGFkOTIzNDYzYQotLS0gL2Rldi9udWxsCisrKyBiL0xh eW91dFRlc3RzL2Zhc3QvY2FudmFzL2NhbnZhcy1nZXRJbWFnZURhdGEtcm91bmRpbmctZXhwZWN0 ZWQudHh0CkBAIC0wLDAgKzEsMzYgQEAKK1Rlc3QgdGhlIGhhbmRsaW5nIG9mIG5vbi1pbnRlZ2Vy IHNvdXJjZSBjb29yZGluYXRlcyBpbiBnZXRJbWFnZURhdGEoKS4KKworT24gc3VjY2VzcywgeW91 IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1Qg Q09NUExFVEUiLgorCisKK2dldEltYWdlRGF0YSgwLCAwLCAyMCwgMTApCitQQVNTIGltYWdlRGF0 YS53aWR0aCBpcyAyMAorUEFTUyBpbWFnZURhdGEuaGVpZ2h0IGlzIDEwCitnZXRJbWFnZURhdGEo MC4xLCAwLjIsIDIwLCAxMCkKK1BBU1MgaW1hZ2VEYXRhLndpZHRoIGlzIDIxCitQQVNTIGltYWdl RGF0YS5oZWlnaHQgaXMgMTEKK2dldEltYWdlRGF0YSgwLjksIDAuOCwgMjAsIDEwKQorUEFTUyBp bWFnZURhdGEud2lkdGggaXMgMjEKK1BBU1MgaW1hZ2VEYXRhLmhlaWdodCBpcyAxMQorZ2V0SW1h Z2VEYXRhKDAsIDAsIDE5LjksIDkuOSkKK1BBU1MgaW1hZ2VEYXRhLndpZHRoIGlzIDIwCitQQVNT IGltYWdlRGF0YS5oZWlnaHQgaXMgMTAKK2dldEltYWdlRGF0YSgwLCAwLCAxOS4xLCA5LjEpCitQ QVNTIGltYWdlRGF0YS53aWR0aCBpcyAyMAorUEFTUyBpbWFnZURhdGEuaGVpZ2h0IGlzIDEwCitn ZXRJbWFnZURhdGEoMC45LCAwLCAwLjIsIDEwKQorUEFTUyBpbWFnZURhdGEud2lkdGggaXMgMgor UEFTUyBpbWFnZURhdGEuaGVpZ2h0IGlzIDEwCitnZXRJbWFnZURhdGEoLTEsIC0xLCAyMCwgMTAp CitQQVNTIGltYWdlRGF0YS53aWR0aCBpcyAyMAorUEFTUyBpbWFnZURhdGEuaGVpZ2h0IGlzIDEw CitnZXRJbWFnZURhdGEoLTEuMSwgMCwgMjAsIDEwKQorUEFTUyBpbWFnZURhdGEud2lkdGggaXMg MjEKK1BBU1MgaW1hZ2VEYXRhLmhlaWdodCBpcyAxMAorZ2V0SW1hZ2VEYXRhKC0xLjksIDAsIDIw LCAxMCkKK1BBU1MgaW1hZ2VEYXRhLndpZHRoIGlzIDIxCitQQVNTIGltYWdlRGF0YS5oZWlnaHQg aXMgMTAKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQor CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy9jYW52YXMtZ2V0SW1hZ2VEYXRh LXJvdW5kaW5nLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy9jYW52YXMtZ2V0SW1hZ2VE YXRhLXJvdW5kaW5nLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZmU0ZjA3ZjNhMDAxZDQ0NTVmYWZkMDkxZGFi NGE1OWNiMDNiYzI5MwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY2FudmFz L2NhbnZhcy1nZXRJbWFnZURhdGEtcm91bmRpbmcuaHRtbApAQCAtMCwwICsxLDQ4IEBACis8IURP Q1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9 Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXN0eWxlLmNzcyI+Cis8c2NyaXB0IHNyYz0iLi4vanMv cmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPHAg aWQ9ImRlc2NyaXB0aW9uIj48L3A+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxzY3JpcHQ+ CitkZXNjcmlwdGlvbigiVGVzdCB0aGUgaGFuZGxpbmcgb2Ygbm9uLWludGVnZXIgc291cmNlIGNv b3JkaW5hdGVzIGluIGdldEltYWdlRGF0YSgpLiIpOworCitjdHggPSBkb2N1bWVudC5jcmVhdGVF bGVtZW50KCdjYW52YXMnKS5nZXRDb250ZXh0KCcyZCcpOworCitmdW5jdGlvbiBkaW1lbnNpb25z U2hvdWxkQmUoc3gsIHN5LCBzdywgc2gsIHdpZHRoLCBoZWlnaHQpCit7CisgICAgaW1hZ2VEYXRh ID0gY3R4LmdldEltYWdlRGF0YShzeCwgc3ksIHN3LCBzaCk7CisgICAgZGVidWcoJ2dldEltYWdl RGF0YSgnICsgc3ggKyAnLCAnICsgc3kgKyAnLCAnICsgc3cgKyAnLCAnICsgc2ggKyAnKScpOwor ICAgIHNob3VsZEJlKCdpbWFnZURhdGEud2lkdGgnLCB3aWR0aCArICcnKTsKKyAgICBzaG91bGRC ZSgnaW1hZ2VEYXRhLmhlaWdodCcsIGhlaWdodCArICcnKTsKK30KKworLy8gQmFzaWMgaW50ZWdl ciB2YWx1ZXMKK2RpbWVuc2lvbnNTaG91bGRCZSggICAwLCAgMCwgICAyMCwgIDEwLCAgICAgMjAs IDEwKTsKKworLy8gU291cmNlIHBvaW50IGlzIG5vdCBhbiBpbnRlZ2VyCitkaW1lbnNpb25zU2hv dWxkQmUoICAuMSwgLjIsICAgMjAsICAxMCwgICAgIDIxLCAxMSk7CitkaW1lbnNpb25zU2hvdWxk QmUoICAuOSwgLjgsICAgMjAsICAxMCwgICAgIDIxLCAxMSk7CisKKy8vIFNpemUgaXMgbm90IGFu IGludGVnZXIKK2RpbWVuc2lvbnNTaG91bGRCZSggICAwLCAgMCwgMTkuOSwgOS45LCAgICAgMjAs IDEwKTsKK2RpbWVuc2lvbnNTaG91bGRCZSggICAwLCAgMCwgMTkuMSwgOS4xLCAgICAgMjAsIDEw KTsKKworLy8gV2lkdGggc3RyYWRkbGVzIGEgcGl4ZWwgYm91bmRhcnkKK2RpbWVuc2lvbnNTaG91 bGRCZSggIC45LCAgMCwgICAuMiwgIDEwLCAgICAgIDIsIDEwKTsKKworLy8gQmFzaWMgaW50ZWdl ciBuZWdhdGl2ZSB2YWx1ZXMKK2RpbWVuc2lvbnNTaG91bGRCZSggIC0xLCAtMSwgICAyMCwgIDEw LCAgICAgMjAsIDEwKTsKKworLy8gTm9uLWludGVnZXIgbmVnYXRpdmUgdmFsdWVzCitkaW1lbnNp b25zU2hvdWxkQmUoLTEuMSwgIDAsICAgMjAsICAxMCwgICAgIDIxLCAxMCk7CitkaW1lbnNpb25z U2hvdWxkQmUoLTEuOSwgIDAsICAgMjAsICAxMCwgICAgIDIxLCAxMCk7CisKK3N1Y2Nlc3NmdWxs eVBhcnNlZCA9IHRydWU7Cis8L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi9qcy9yZXNvdXJjZXMv anMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dCBiL0xh eW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAppbmRleCA4 YTIzNGMxMTliZDBkYzE2YzA0MjYwN2Y0M2RiMTU5M2Y1OTg0MDJhLi5mY2FlNWRmNjhjOTI4MzJm MDFjYTYwN2VjMmRiMzZiZWU2ZWZjMWEzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZv cm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CkBAIC0yNDEyLDggKzI0MTIsNiBAQCBC VUdXSzQ1OTkxIE1BQyA6IGNhbnZhcy9waGlsaXAvdGVzdHMvMmQuc3Ryb2tlUmVjdC56ZXJvLjQu aHRtbCA9IFRFWFQgUEFTUwogQlVHV0s0NTk5MSBNQUMgOiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJk LnRleHQuZHJhdy5iYXNlbGluZS5pZGVvZ3JhcGhpYy5odG1sID0gVEVYVCBQQVNTCiBCVUdXSzQ1 OTkxIE1BQyA6IGNhbnZhcy9waGlsaXAvdGVzdHMvdG9EYXRhVVJMLmpwZWcuYWxwaGEuaHRtbCA9 IFRFWFQgUEFTUwogCi1CVUdXSzQ1OTkxIE1BQyA6IGNhbnZhcy9waGlsaXAvdGVzdHMvMmQuaW1h Z2VEYXRhLmdldC5zb3VyY2Uub3V0c2lkZS5odG1sID0gVEVYVAotCiAvLyBUaGlzIHNlZW1zIHRv IGJlIGZhaWxpbmcgb24gd2luZG93cyBvbmx5LgogQlVHV0s0NTk5MSBXSU4gOiBjYW52YXMvcGhp bGlwL3Rlc3RzLzJkLmdyYWRpZW50LnJhZGlhbC50b3VjaDIuaHRtbCA9IFRFWFQKIApAQCAtMjkz Niw4ICsyOTM0LDYgQEAgQlVHNDc1NzggOiBwcmludGluZy9zaW11bHRhbmVvdXMtcG9zaXRpb24t ZmxvYXQtY2hhbmdlLmh0bWwgPSBJTUFHRStURVhUCiAKIEJVRzU5NjQ3IFdJTiA6IHN2Zy9kb20v bGVuZ3RoLWxpc3QtcGFyc2VyLmh0bWwgPSBQQVNTIENSQVNICiAKLUJVR1dLNDc5MDEgTUFDIDog ZmFzdC9jYW52YXMvY2FudmFzLWdldEltYWdlRGF0YS1uZWdhdGl2ZS1zb3VyY2UuaHRtbCA9IFRF WFQKLQogLy8gV2UgZG9uJ3Qgc3VwcG9ydCBsYXlvdXRUZXN0Q29udHJvbGxlci5ub2Rlc0Zyb21S ZWN0IHNvIHRoaXMgdGVzdCBqdXN0IHRpbWVzIG91dAogQlVHV0s0NjYwMCBTS0lQIDogZmFzdC9k b20vbm9kZXNGcm9tUmVjdC1saW5rcy1hbmQtdGV4dC5odG1sID0gVEVYVAogQlVHV0s0NjYwMCBT S0lQIDogZmFzdC9kb20vbm9kZXNGcm9tUmVjdC1pbm5lci1kb2N1bWVudHMuaHRtbCA9IFRFWFQK QEAgLTMwMTAsNyArMzAwNiw2IEBAIEJVR1dLNjEyNDYgOiBmYXN0L2pzL2ludGVycHJldGVyLW5v LWFjdGl2YXRpb24uaHRtbCA9IFRFWFQKIEJVR1dLNjEyNjAgOiBtZWRpYS9tZWRpYS1jYW4tcGxh eS13YXYtYXVkaW8uaHRtbCA9IFRFWFQKIAogLy8gRmFpbHVyZXMgYWZ0ZXIgV2ViS2l0IHJvbGwg NzA5NDk6NzEwMDAKLUJVR1dLNzEwMDAgTUFDIDogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5pbWFn ZURhdGEuZ2V0LnNvdXJjZS5uZWdhdGl2ZS5odG1sID0gVEVYVAogQlVHNjE0MDYgOiBzdmcvZHlu YW1pYy11cGRhdGVzL1NWR0ZFQ29sb3JNYXRyaXhFbGVtZW50LXN2Z2RvbS12YWx1ZXMtcHJvcC5o dG1sID0gSU1BR0UrVEVYVAogQlVHNjE0MDYgOiBzdmcvZHluYW1pYy11cGRhdGVzL1NWR0ZFQ29s b3JNYXRyaXhFbGVtZW50LXN2Z2RvbS10eXBlLXByb3AuaHRtbCA9IElNQUdFCiBCVUc2MTQwNiBX SU4gTElOVVggOiBzdmcvZHluYW1pYy11cGRhdGVzL1NWR0ZFVHVyYnVsZW5jZUVsZW1lbnQtc3Zn ZG9tLWJhc2VGcmVxdWVuY3ktcHJvcC5odG1sID0gSU1BR0UKZGlmZiAtLWdpdCBhL1dlYkNvcmUv Q2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmE4Y2Y0ZTljZTc2YjM0ZDU2YmM4 YjJjZTcxOTY0NzgzZDJjOGJkMS4uNGI2ZjUyYmNjNzBlMzlkZjEyYzMzYzg1YTcyNDNhMWZlODNm YTVkNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VM b2cKQEAgLTEsMyArMSwyNCBAQAorMjAxMC0xMi0wOCAgTWloYWkgUGFycGFyaXRhICA8bWloYWlw QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBmYXN0L2NhbnZhcy9jYW52YXMtZ2V0SW1hZ2VEYXRhLW5lZ2F0aXZlLXNvdXJjZS5o dG1sIGZhaWxzIG9uIE1hYworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NDc5MDEKKworICAgICAgICBUZXN0OiBmYXN0L2NhbnZhcy9jYW52YXMtZ2V0SW1h Z2VEYXRhLXJvdW5kaW5nLmh0bWwKKyAgICAgICAgCisgICAgICAgIHN0YXRpY19jYXN0PHVuc2ln bmVkPiBpcyBnZW5lcmFsbHkgbm90IHdoYXQgd2Ugd2FudCBpbgorICAgICAgICBjb252ZXJ0TG9n aWNhbFRvRGV2aWNlLiBJdCBwcm9kdWNlcyBpbmNvbnNpc3RlbnQgcmVzdWx0cyB3aGVuIGNvbXBp bGluZworICAgICAgICBmb3IgMzItYml0IHZzLiA2NC1iaXQsIGFuZCBpbiBhbnkgY2FzZSB3ZSB3 ZXJlbid0IGdldHRpbmcgY29ycmVjdAorICAgICAgICByb3VuZGluZyBiZWhhdmlvciBmb3Igc291 cmNlIHJlY3RhbmdsZXMgKGUuZy4gd2Ugc2hvdWxkIGdldCBhIHNvdXJjZSByZWN0CisgICAgICAg IG9mIHdpZHRoIDIgaWYgdGhlIHNvdXJjZSBYIGlzIDAuOSBhbmQgdGhlIHNvdXJjZSB3aWR0aCBp cyAwLjIsIGJ1dCB3ZQorICAgICAgICB3ZXJlIGdldHRpbmcgb25seSBvbmUgb2Ygd2lkdGggMSku CisKKyAgICAgICAgKiBodG1sL0hUTUxDYW52YXNFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkhUTUxDYW52YXNFbGVtZW50Ojpjb252ZXJ0TG9naWNhbFRvRGV2aWNlKToKKyAgICAgICAg KFdlYkNvcmU6OkhUTUxDYW52YXNFbGVtZW50Ojpjb252ZXJ0VG9WYWxpZERldmljZVNpemUpOgor ICAgICAgICAqIGh0bWwvSFRNTENhbnZhc0VsZW1lbnQuaDoKKwogMjAxMC0xMi0wOCAgQW5kZXJz IENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERh cmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9odG1sL0hUTUxDYW52YXNFbGVtZW50LmNw cCBiL1dlYkNvcmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5jcHAKaW5kZXggZmVhNzBkMTYzNWUw NTFmMTU1MjRhNThmYmE0YTYyOWFjYzYzOGI2OC4uNDEzMGUzODJmZGY0MjBmZGYwN2RjMzg3YmMx ZWExNjhmZjIxN2Q3NCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9odG1sL0hUTUxDYW52YXNFbGVtZW50 LmNwcAorKysgYi9XZWJDb3JlL2h0bWwvSFRNTENhbnZhc0VsZW1lbnQuY3BwCkBAIC0zMjIsMzEg KzMyMiwzMyBAQCBTdHJpbmcgSFRNTENhbnZhc0VsZW1lbnQ6OnRvRGF0YVVSTChjb25zdCBTdHJp bmcmIG1pbWVUeXBlLCBjb25zdCBkb3VibGUqIHF1YWxpdAogCiBJbnRSZWN0IEhUTUxDYW52YXNF bGVtZW50Ojpjb252ZXJ0TG9naWNhbFRvRGV2aWNlKGNvbnN0IEZsb2F0UmVjdCYgbG9naWNhbFJl Y3QpIGNvbnN0CiB7Ci0gICAgcmV0dXJuIEludFJlY3QoY29udmVydExvZ2ljYWxUb0RldmljZShs b2dpY2FsUmVjdC5sb2NhdGlvbigpKSwgY29udmVydExvZ2ljYWxUb0RldmljZShsb2dpY2FsUmVj dC5zaXplKCkpKTsKKyAgICBmbG9hdCBsZWZ0ID0gZmxvb3JmKGxvZ2ljYWxSZWN0LmxlZnQoKSAq IG1fcGFnZVNjYWxlRmFjdG9yKTsKKyAgICBmbG9hdCB0b3AgPSBmbG9vcmYobG9naWNhbFJlY3Qu dG9wKCkgKiBtX3BhZ2VTY2FsZUZhY3Rvcik7CisgICAgZmxvYXQgcmlnaHQgPSBjZWlsZihsb2dp Y2FsUmVjdC5yaWdodCgpICogbV9wYWdlU2NhbGVGYWN0b3IpOworICAgIGZsb2F0IGJvdHRvbSA9 IGNlaWxmKGxvZ2ljYWxSZWN0LmJvdHRvbSgpICogbV9wYWdlU2NhbGVGYWN0b3IpOworICAgIAor ICAgIHJldHVybiBJbnRSZWN0KEludFBvaW50KGxlZnQsIHRvcCksIGNvbnZlcnRUb1ZhbGlkRGV2 aWNlU2l6ZShyaWdodCAtIGxlZnQsIGJvdHRvbSAtIHRvcCkpOwogfQogCiBJbnRTaXplIEhUTUxD YW52YXNFbGVtZW50Ojpjb252ZXJ0TG9naWNhbFRvRGV2aWNlKGNvbnN0IEZsb2F0U2l6ZSYgbG9n aWNhbFNpemUpIGNvbnN0CiB7Ci0gICAgZmxvYXQgd2YgPSBjZWlsZihsb2dpY2FsU2l6ZS53aWR0 aCgpICogbV9wYWdlU2NhbGVGYWN0b3IpOwotICAgIGZsb2F0IGhmID0gY2VpbGYobG9naWNhbFNp emUuaGVpZ2h0KCkgKiBtX3BhZ2VTY2FsZUZhY3Rvcik7CisgICAgcmV0dXJuIGNvbnZlcnRUb1Zh bGlkRGV2aWNlU2l6ZShsb2dpY2FsU2l6ZS53aWR0aCgpICogbV9wYWdlU2NhbGVGYWN0b3IsIGxv Z2ljYWxTaXplLmhlaWdodCgpICogbV9wYWdlU2NhbGVGYWN0b3IpOworfQogCi0gICAgaWYgKCEo d2YgPj0gMSAmJiBoZiA+PSAxICYmIHdmICogaGYgPD0gTWF4Q2FudmFzQXJlYSkpCitJbnRTaXpl IEhUTUxDYW52YXNFbGVtZW50Ojpjb252ZXJ0VG9WYWxpZERldmljZVNpemUoZmxvYXQgd2lkdGgs IGZsb2F0IGhlaWdodCkgY29uc3QKK3sKKyAgICB3aWR0aCA9IGNlaWxmKHdpZHRoKTsKKyAgICBo ZWlnaHQgPSBjZWlsZihoZWlnaHQpOworICAgIAorICAgIGlmICh3aWR0aCA8IDEgfHwgaGVpZ2h0 IDwgMSB8fCB3aWR0aCAqIGhlaWdodCA+IE1heENhbnZhc0FyZWEpCiAgICAgICAgIHJldHVybiBJ bnRTaXplKCk7CiAKICNpZiBQTEFURk9STShTS0lBKQotICAgIGlmICh3ZiA+IE1heFNraWFEaW0g fHwgaGYgPiBNYXhTa2lhRGltKQorICAgIGlmICh3aWR0aCA+IE1heFNraWFEaW0gfHwgaGVpZ2h0 ID4gTWF4U2tpYURpbSkKICAgICAgICAgcmV0dXJuIEludFNpemUoKTsKICNlbmRpZgogCi0gICAg cmV0dXJuIEludFNpemUoc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KHdmKSwgc3RhdGljX2Nhc3Q8dW5z aWduZWQ+KGhmKSk7Ci19Ci0KLUludFBvaW50IEhUTUxDYW52YXNFbGVtZW50Ojpjb252ZXJ0TG9n aWNhbFRvRGV2aWNlKGNvbnN0IEZsb2F0UG9pbnQmIGxvZ2ljYWxQb3MpIGNvbnN0Ci17Ci0gICAg ZmxvYXQgeGYgPSBsb2dpY2FsUG9zLngoKSAqIG1fcGFnZVNjYWxlRmFjdG9yOwotICAgIGZsb2F0 IHlmID0gbG9naWNhbFBvcy55KCkgKiBtX3BhZ2VTY2FsZUZhY3RvcjsKLQotICAgIHJldHVybiBJ bnRQb2ludChzdGF0aWNfY2FzdDx1bnNpZ25lZD4oeGYpLCBzdGF0aWNfY2FzdDx1bnNpZ25lZD4o eWYpKTsKKyAgICByZXR1cm4gSW50U2l6ZSh3aWR0aCwgaGVpZ2h0KTsKIH0KIAogY29uc3QgU2Vj dXJpdHlPcmlnaW4mIEhUTUxDYW52YXNFbGVtZW50OjpzZWN1cml0eU9yaWdpbigpIGNvbnN0CmRp ZmYgLS1naXQgYS9XZWJDb3JlL2h0bWwvSFRNTENhbnZhc0VsZW1lbnQuaCBiL1dlYkNvcmUvaHRt bC9IVE1MQ2FudmFzRWxlbWVudC5oCmluZGV4IGQ5Yjc3MzY4MTI2MDFmNTlmYjBlMTdjMTI5MTZk ODdlZGVhZWEwYzkuLjEwODFjMzNhZmViZjFmYTNmNTU2ODRjNDA3NTI0YmJkMWFlYWYxMzEgMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5oCisrKyBiL1dlYkNvcmUv aHRtbC9IVE1MQ2FudmFzRWxlbWVudC5oCkBAIC0xMDcsNyArMTA3LDcgQEAgcHVibGljOgogCiAg ICAgSW50UmVjdCBjb252ZXJ0TG9naWNhbFRvRGV2aWNlKGNvbnN0IEZsb2F0UmVjdCYpIGNvbnN0 OwogICAgIEludFNpemUgY29udmVydExvZ2ljYWxUb0RldmljZShjb25zdCBGbG9hdFNpemUmKSBj b25zdDsKLSAgICBJbnRQb2ludCBjb252ZXJ0TG9naWNhbFRvRGV2aWNlKGNvbnN0IEZsb2F0UG9p bnQmKSBjb25zdDsKKyAgICBJbnRTaXplIGNvbnZlcnRUb1ZhbGlkRGV2aWNlU2l6ZShmbG9hdCB3 aWR0aCwgZmxvYXQgaGVpZ2h0KSBjb25zdDsKIAogICAgIGNvbnN0IFNlY3VyaXR5T3JpZ2luJiBz ZWN1cml0eU9yaWdpbigpIGNvbnN0OwogICAgIHZvaWQgc2V0T3JpZ2luVGFpbnRlZCgpIHsgbV9v cmlnaW5DbGVhbiA9IGZhbHNlOyB9Cg==