47898 2010-10-19 04:42:46 -0700 [Qt] getImageData returns wrong data for non-0,0 source offset 2010-10-19 06:31:34 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 kling webkit-qt-unassigned abarth eric webkit.review.bot oldest_to_newest 296108 0 kling 2010-10-19 04:42:46 -0700 Our getImageData() is busted for any sourceRect offset that isn't (0,0) 296109 1 71153 kling 2010-10-19 04:46:43 -0700 Created attachment 71153 Proposed patch 296129 2 71153 kling 2010-10-19 05:46:10 -0700 Comment on attachment 71153 Proposed patch Clearing flags on attachment: 71153 Committed r70050: <http://trac.webkit.org/changeset/70050> 296130 3 kling 2010-10-19 05:46:20 -0700 All reviewed patches have been landed. Closing bug. 296143 4 webkit.review.bot 2010-10-19 06:31:34 -0700 http://trac.webkit.org/changeset/70050 might have broken Leopard Intel Release (Tests) The following tests are not passing: fast/canvas/canvas-getImageData-negative-source.html 71153 2010-10-19 04:46:43 -0700 2010-10-19 05:46:10 -0700 Proposed patch bug-47898.diff text/plain 4648 kling ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBiOTQyZGUwLi5lOGE5YjFmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMTAt MTkgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gZ2V0SW1hZ2VEYXRhIHJldHVybnMg d3JvbmcgZGF0YSBmb3Igbm9uLTAsMCBzb3VyY2Ugb2Zmc2V0CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00Nzg5OAorCisgICAgICAgICogZmFzdC9jYW52 YXMvY2FudmFzLWdldEltYWdlRGF0YS1uZWdhdGl2ZS1zb3VyY2UtZXhwZWN0ZWQudHh0OiBBZGRl ZC4KKyAgICAgICAgKiBmYXN0L2NhbnZhcy9jYW52YXMtZ2V0SW1hZ2VEYXRhLW5lZ2F0aXZlLXNv dXJjZS5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2NhbnZhcy9zY3JpcHQtdGVzdHMvY2Fu dmFzLWdldEltYWdlRGF0YS1uZWdhdGl2ZS1zb3VyY2UuanM6IEFkZGVkLgorCiAyMDEwLTEwLTE5 ICBIYXlhdG8gSXRvICA8aGF5YXRvQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY2FudmFzL2NhbnZh cy1nZXRJbWFnZURhdGEtbmVnYXRpdmUtc291cmNlLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3Rz L2Zhc3QvY2FudmFzL2NhbnZhcy1nZXRJbWFnZURhdGEtbmVnYXRpdmUtc291cmNlLWV4cGVjdGVk LnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5mOGE2YjFlCi0tLSAvZGV2 L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvY2FudmFzLWdldEltYWdlRGF0YS1u ZWdhdGl2ZS1zb3VyY2UtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMjEgQEAKK1Rlc3QgdGhlIGhh bmRsaW5nIG9mIG5lZ2F0aXZlIHNvdXJjZVJlY3Qgb2Zmc2V0IGluIGdldEltYWdlRGF0YSgpLgor CitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBm b2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyBpbWdkYXRhWzBdIGlzIDAKK1BB U1MgaW1nZGF0YVsxXSBpcyAwCitQQVNTIGltZ2RhdGFbMl0gaXMgMAorUEFTUyBpbWdkYXRhWzNd IGlzIDAKK1BBU1MgaW1nZGF0YVs2MF0gaXMgMAorUEFTUyBpbWdkYXRhWzYxXSBpcyAxMjgKK1BB U1MgaW1nZGF0YVs2Ml0gaXMgMAorUEFTUyBpbWdkYXRhWzYzXSBpcyAyNTUKK1BBU1MgaW1nZGF0 YVs2NF0gaXMgMjU1CitQQVNTIGltZ2RhdGFbNjVdIGlzIDAKK1BBU1MgaW1nZGF0YVs2Nl0gaXMg MAorUEFTUyBpbWdkYXRhWzY3XSBpcyAyNTUKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRy dWUKKworVEVTVCBDT01QTEVURQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2NhbnZh cy9jYW52YXMtZ2V0SW1hZ2VEYXRhLW5lZ2F0aXZlLXNvdXJjZS5odG1sIGIvTGF5b3V0VGVzdHMv ZmFzdC9jYW52YXMvY2FudmFzLWdldEltYWdlRGF0YS1uZWdhdGl2ZS1zb3VyY2UuaHRtbApuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi4xN2I4NWRiCi0tLSAvZGV2L251bGwKKysr IGIvTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvY2FudmFzLWdldEltYWdlRGF0YS1uZWdhdGl2ZS1z b3VyY2UuaHRtbApAQCAtMCwwICsxLDEzIEBACis8IURPQ1RZUEUgSFRNTCBQVUJMSUMgIi0vL0lF VEYvL0RURCBIVE1MLy9FTiI+Cis8aHRtbD4KKzxoZWFkPgorPGxpbmsgcmVsPSJzdHlsZXNoZWV0 IiBocmVmPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1zdHlsZS5jc3MiPgorPHNjcmlwdCBzcmM9 Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9k eT4KKzxwIGlkPSJkZXNjcmlwdGlvbiI+PC9wPgorPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+Cis8 c2NyaXB0IHNyYz0ic2NyaXB0LXRlc3RzL2NhbnZhcy1nZXRJbWFnZURhdGEtbmVnYXRpdmUtc291 cmNlLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1w b3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL2Zhc3QvY2FudmFzL3NjcmlwdC10ZXN0cy9jYW52YXMtZ2V0SW1hZ2VEYXRhLW5lZ2F0aXZl LXNvdXJjZS5qcyBiL0xheW91dFRlc3RzL2Zhc3QvY2FudmFzL3NjcmlwdC10ZXN0cy9jYW52YXMt Z2V0SW1hZ2VEYXRhLW5lZ2F0aXZlLXNvdXJjZS5qcwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRl eCAwMDAwMDAwLi5jNjc1NzM3Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9j YW52YXMvc2NyaXB0LXRlc3RzL2NhbnZhcy1nZXRJbWFnZURhdGEtbmVnYXRpdmUtc291cmNlLmpz CkBAIC0wLDAgKzEsMzEgQEAKK2Rlc2NyaXB0aW9uKCJUZXN0IHRoZSBoYW5kbGluZyBvZiBuZWdh dGl2ZSBzb3VyY2VSZWN0IG9mZnNldCBpbiBnZXRJbWFnZURhdGEoKS4iKTsKKworY3R4ID0gZG9j dW1lbnQuY3JlYXRlRWxlbWVudCgnY2FudmFzJykuZ2V0Q29udGV4dCgnMmQnKTsKKworY3R4LmZp bGxTdHlsZSA9ICdyZWQnOworY3R4LmZpbGxSZWN0KDAsIDAsIDEwMCwgMTAwKTsKK2N0eC5maWxs U3R5bGUgPSAnZ3JlZW4nOworY3R4LmZpbGxSZWN0KDAsIDAsIDYsIDYpOworCit2YXIgaW1hZ2VE YXRhID0gY3R4LmdldEltYWdlRGF0YSgtMTAsIDAsIDEwMCwgMSk7Cit2YXIgaW1nZGF0YSA9IGlt YWdlRGF0YS5kYXRhOworCisvLyBGdWxseSB0cmFuc3BhcmVudCBibGFjaworc2hvdWxkQmUoImlt Z2RhdGFbMF0iLCAiMCIpOworc2hvdWxkQmUoImltZ2RhdGFbMV0iLCAiMCIpOworc2hvdWxkQmUo ImltZ2RhdGFbMl0iLCAiMCIpOworc2hvdWxkQmUoImltZ2RhdGFbM10iLCAiMCIpOworCisvLyBH cmVlbgorc2hvdWxkQmUoImltZ2RhdGFbNjBdIiwgIjAiKTsKK3Nob3VsZEJlKCJpbWdkYXRhWzYx XSIsICIxMjgiKTsKK3Nob3VsZEJlKCJpbWdkYXRhWzYyXSIsICIwIik7CitzaG91bGRCZSgiaW1n ZGF0YVs2M10iLCAiMjU1Iik7CisKKy8vIFJlZAorc2hvdWxkQmUoImltZ2RhdGFbNjRdIiwgIjI1 NSIpOworc2hvdWxkQmUoImltZ2RhdGFbNjVdIiwgIjAiKTsKK3Nob3VsZEJlKCJpbWdkYXRhWzY2 XSIsICIwIik7CitzaG91bGRCZSgiaW1nZGF0YVs2N10iLCAiMjU1Iik7CisKK3N1Y2Nlc3NmdWxs eVBhcnNlZCA9IHRydWU7CmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUv Q2hhbmdlTG9nCmluZGV4IDM3YmFjODEuLjNhYzY2OTQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hh bmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMTAt MTkgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gZ2V0SW1hZ2VEYXRhIHJldHVybnMg d3JvbmcgZGF0YSBmb3Igbm9uLTAsMCBzb3VyY2Ugb2Zmc2V0CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00Nzg5OAorCisgICAgICAgIFRlc3Q6IGZhc3Qv Y2FudmFzL2NhbnZhcy1nZXRJbWFnZURhdGEtbmVnYXRpdmUtc291cmNlLmh0bWwKKworICAgICAg ICAqIHBsYXRmb3JtL2dyYXBoaWNzL3F0L0ltYWdlQnVmZmVyUXQuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6Z2V0SW1hZ2VEYXRhKTogQWRkIG1pc3NpbmcgKjQncyB0byBnZXQgY29ycmVjdCBwaXhl bCBvZmZzZXQuCisKIDIwMTAtMTAtMTkgIEhheWF0byBJdG8gIDxoYXlhdG9AY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9JbWFnZUJ1ZmZlclF0LmNwcCBiL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvcXQvSW1hZ2VCdWZmZXJRdC5jcHAKaW5kZXggMzViMzViMC4uZGIxNjllYSAx MDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9JbWFnZUJ1ZmZlclF0LmNw cAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0ltYWdlQnVmZmVyUXQuY3BwCkBA IC0yMTcsNyArMjE3LDcgQEAgUGFzc1JlZlB0cjxJbWFnZURhdGE+IGdldEltYWdlRGF0YShjb25z dCBJbnRSZWN0JiByZWN0LCBjb25zdCBJbWFnZUJ1ZmZlckRhdGEmIGkKICAgICBjb25zdCB1Y2hh ciogYml0cyA9IGltYWdlLmJpdHMoKTsKICNlbmRpZgogCi0gICAgcXVpbnQzMiogZGVzdFJvd3Mg PSByZWludGVycHJldF9jYXN0X3B0cjxxdWludDMyKj4oJmRhdGFbZGVzdHkgKiByZWN0LndpZHRo KCkgKyBkZXN0eF0pOworICAgIHF1aW50MzIqIGRlc3RSb3dzID0gcmVpbnRlcnByZXRfY2FzdF9w dHI8cXVpbnQzMio+KCZkYXRhW2Rlc3R5ICogcmVjdC53aWR0aCgpICogNCArIGRlc3R4ICogNF0p OwogCiAgICAgaWYgKG11bHRpcGxpZWQgPT0gVW5tdWx0aXBsaWVkKSB7CiAgICAgICAgIGZvciAo aW50IHkgPSAwOyB5IDwgbnVtUm93czsgKyt5KSB7Cg==