47895 2010-10-19 03:40:19 -0700 Building of WK2 APIs using Python fails on Scratchbox 2010-11-02 10:35:32 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 0 christian.webkit webkit-unassigned commit-queue dbates kenneth webkit.review.bot oldest_to_newest 296098 0 christian.webkit 2010-10-19 03:40:19 -0700 In Scratchbox the default Python version is 2.3 and it doesn't support most of the features in generate-messages-header.py and generate-message-receiver.py 296186 1 71170 christian.webkit 2010-10-19 07:46:57 -0700 Created attachment 71170 Patch to force use of Python 2.6 in Scratchbox 296187 2 71170 kenneth 2010-10-19 07:50:25 -0700 Comment on attachment 71170 Patch to force use of Python 2.6 in Scratchbox View in context: https://bugs.webkit.org/attachment.cgi?id=71170&action=review > WebKit2/DerivedSources.pro:32 > +linux*:contains(QMAKE_HOST.arch, arm): { > + PYTHON = python2.6 > +} else { Are you sure this doesn't break anything? Like if someone builds for ARM without using scratchbox? 296199 3 commit-queue 2010-10-19 08:10:10 -0700 The commit-queue encountered the following flaky tests while processing attachment 71170: http/tests/security/xssAuditor/script-tag-with-source-entities.html java/lc3/JSObject/ToObject-001.html Please file bugs against the tests. The author(s) of the test(s) have been CCed on this bug. The commit-queue is continuing to process your patch. 296209 4 commit-queue 2010-10-19 08:31:15 -0700 The commit-queue encountered the following flaky tests while processing attachment 71170: http/tests/appcache/404-manifest.html Please file bugs against the tests. The author(s) of the test(s) have been CCed on this bug. The commit-queue is continuing to process your patch. 296210 5 71170 commit-queue 2010-10-19 08:32:02 -0700 Comment on attachment 71170 Patch to force use of Python 2.6 in Scratchbox Clearing flags on attachment: 71170 Committed r70061: <http://trac.webkit.org/changeset/70061> 296211 6 commit-queue 2010-10-19 08:32:08 -0700 All reviewed patches have been landed. Closing bug. 296377 7 christian.webkit 2010-10-19 13:50:40 -0700 (In reply to comment #2) > (From update of attachment 71170 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=71170&action=review > > > WebKit2/DerivedSources.pro:32 > > +linux*:contains(QMAKE_HOST.arch, arm): { > > + PYTHON = python2.6 > > +} else { > > Are you sure this doesn't break anything? Like if someone builds for ARM without using scratchbox? It certainly can break if there is no python2.6, so if there is a way to detect if it is Scratchbox, I can change it to use that. 302678 8 72505 christian.webkit 2010-11-01 07:51:54 -0700 Created attachment 72505 Proper fix for detecting scratchbox The previous patch (71170) will break when building in Scratchbox for a non-ARM target. 302679 9 kenneth 2010-11-01 07:53:41 -0700 reopening 302680 10 webkit.review.bot 2010-11-01 07:54:46 -0700 Attachment 72505 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] WebKit2/ChangeLog:7: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 302702 11 72507 christian.webkit 2010-11-01 08:25:55 -0700 Created attachment 72507 Same as sb-python-2.patch but without tabs Removed tabs from Changelog 302707 12 72507 kling 2010-11-01 08:36:10 -0700 Comment on attachment 72507 Same as sb-python-2.patch but without tabs LGTM. 303459 13 72507 commit-queue 2010-11-02 10:35:26 -0700 Comment on attachment 72507 Same as sb-python-2.patch but without tabs Clearing flags on attachment: 72507 Committed r71128: <http://trac.webkit.org/changeset/71128> 303460 14 commit-queue 2010-11-02 10:35:32 -0700 All reviewed patches have been landed. Closing bug. 71170 2010-10-19 07:46:57 -0700 2010-11-01 07:51:54 -0700 Patch to force use of Python 2.6 in Scratchbox sb-python.patch text/plain 1045 christian.webkit SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MDA1NikKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMTAtMTkgIENocmlzdGlhbiBTZWplcnNlbiAgPGNocmlzdGlh bi53ZWJraXRAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFNjcmF0Y2hib3ggaGFzIGFuIG9sZCB2ZXJzaW9uIG9mIHB5dGhvbiBhcyB0 aGUgZGVmYXVsdCBvbmUsIHNvCisgICAgICAgIGZvcmNlIGl0IHRvIHVzZSB2ZXJzaW9uIDIuNi4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3ODk1CisK KyAgICAgICAgKiBEZXJpdmVkU291cmNlcy5wcm86CisKIDIwMTAtMTAtMTggIEFuZGVycyBDYXJs c3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2Vp bmlnLgpJbmRleDogV2ViS2l0Mi9EZXJpdmVkU291cmNlcy5wcm8KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi S2l0Mi9EZXJpdmVkU291cmNlcy5wcm8JKHJldmlzaW9uIDcwMDUyKQorKysgV2ViS2l0Mi9EZXJp dmVkU291cmNlcy5wcm8JKHdvcmtpbmcgY29weSkKQEAgLTI3LDYgKzI3LDEzIEBAIHdpbjMyLW1z dmMqfHN5bWJpYW4gewogICAgIERPVUJMRV9FU0NBUEVEX1FVT1RFID0gIlxcXCciCiB9CiAKK2xp bnV4Kjpjb250YWlucyhRTUFLRV9IT1NULmFyY2gsIGFybSk6IHsKKyAgICBQWVRIT04gPSBweXRo b24yLjYKK30gZWxzZSB7CisgICAgUFlUSE9OID0gcHl0aG9uCit9CisKKwogRElSUyA9IFwKICAg ICAkJE9VVFBVVF9ESVIvaW5jbHVkZS9KYXZhU2NyaXB0Q29yZSBcCiAgICAgJCRPVVRQVVRfRElS L2luY2x1ZGUvV2ViQ29yZSBcCg== 72505 2010-11-01 07:51:54 -0700 2010-11-01 08:25:55 -0700 Proper fix for detecting scratchbox sb-python-2.patch text/plain 1010 christian.webkit SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MTAyNCkKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMTEtMDEgIENocmlzdGlhbiBTZWplcnNlbiAgPGNocmlzdGlh bi53ZWJraXRAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRoZSBwcmV2aW91cyBwYXRjaCBvbmx5IHRvb2sgaW50byBhY2NvdW50IGFy bSB0YXJnZXRzLiBUaGlzIG9uZQorCW5vdyBjaGVja3Mgd2hldGhlciB0aGUgYnVpbGQgaXMgZG9u ZSBpbnNpZGUgU2NyYXRjaGJveC4KKwlodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NDc4OTUKKworICAgICAgICAqIERlcml2ZWRTb3VyY2VzLnBybzoKKwogMjAxMC0xMC0z MSAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg RGFuIEJlcm5zdGVpbi4KSW5kZXg6IFdlYktpdDIvRGVyaXZlZFNvdXJjZXMucHJvCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYktpdDIvRGVyaXZlZFNvdXJjZXMucHJvCShyZXZpc2lvbiA3MTAxOSkKKysrIFdl YktpdDIvRGVyaXZlZFNvdXJjZXMucHJvCSh3b3JraW5nIGNvcHkpCkBAIC0yNyw3ICsyNyw4IEBA IHdpbjMyLW1zdmMqfHN5bWJpYW4gewogICAgIERPVUJMRV9FU0NBUEVEX1FVT1RFID0gIlxcXCci CiB9CiAKLWxpbnV4Kjpjb250YWlucyhRTUFLRV9IT1NULmFyY2gsIGFybSk6IHsKK1NCT1hfQ0hF Q0sgPSAkJChfU0JPWF9ESVIpCishaXNFbXB0eShTQk9YX0NIRUNLKSB7CiAgICAgUFlUSE9OID0g cHl0aG9uMi42CiB9IGVsc2UgewogICAgIFBZVEhPTiA9IHB5dGhvbgo= 72507 2010-11-01 08:25:55 -0700 2010-11-02 10:35:26 -0700 Same as sb-python-2.patch but without tabs sb-python-3.patch text/plain 1024 christian.webkit SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MTAyNCkKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMTEtMDEgIENocmlzdGlhbiBTZWplcnNlbiAgPGNocmlzdGlh bi53ZWJraXRAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRoZSBwcmV2aW91cyBwYXRjaCBvbmx5IHRvb2sgaW50byBhY2NvdW50IGFy bSB0YXJnZXRzLiBUaGlzIG9uZQorICAgICAgICBub3cgY2hlY2tzIHdoZXRoZXIgdGhlIGJ1aWxk IGlzIGRvbmUgaW5zaWRlIFNjcmF0Y2hib3guCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD00Nzg5NQorCisgICAgICAgICogRGVyaXZlZFNvdXJjZXMucHJv OgorCiAyMDEwLTEwLTMxICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBEYW4gQmVybnN0ZWluLgpJbmRleDogV2ViS2l0Mi9EZXJpdmVkU291cmNl cy5wcm8KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0Mi9EZXJpdmVkU291cmNlcy5wcm8JKHJldmlzaW9u IDcxMDE5KQorKysgV2ViS2l0Mi9EZXJpdmVkU291cmNlcy5wcm8JKHdvcmtpbmcgY29weSkKQEAg LTI3LDcgKzI3LDggQEAgd2luMzItbXN2Yyp8c3ltYmlhbiB7CiAgICAgRE9VQkxFX0VTQ0FQRURf UVVPVEUgPSAiXFxcJyIKIH0KIAotbGludXgqOmNvbnRhaW5zKFFNQUtFX0hPU1QuYXJjaCwgYXJt KTogeworU0JPWF9DSEVDSyA9ICQkKF9TQk9YX0RJUikKKyFpc0VtcHR5KFNCT1hfQ0hFQ0spIHsK ICAgICBQWVRIT04gPSBweXRob24yLjYKIH0gZWxzZSB7CiAgICAgUFlUSE9OID0gcHl0aG9uCg==