47891 2010-10-19 02:07:13 -0700 Web Inspector: Uncaught TypeError when connection to WebSocket server is refused 2010-10-19 03:22:11 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 yutak yutak apavlov bweinstein commit-queue joepeck keishi loislo pfeldman pmuellr rik timothy ukai yurys oldest_to_newest 296065 0 yutak 2010-10-19 02:07:13 -0700 The following error occurs in Resources panel when a connection to an WebSocket server is refused. Chromium's stderr looks like: "Uncaught TypeError: Cannot call method 'split' of undefined," source: chrome://devtools/DevTools.js (8852) "Uncaught TypeError: Cannot call method 'escapeHTML' of undefined," source: chrome://devtools/DevTools.js (30523) How to reproduce: 1. Start HTTP server for layout tests (run-webkit-httpd) but do NOT start the WebSocket server. 2. Start the browser, open Web Inspector, enable resource tracking, and go to <http://localhost:8000/websocket/tests/send.html>. 3. Observe the error. This error occurs because resource.url is not set when an WebSocket is initialized. 296071 1 71144 yutak 2010-10-19 02:23:40 -0700 Created attachment 71144 Patch 296074 2 71144 ukai 2010-10-19 02:29:33 -0700 Comment on attachment 71144 Patch LGTM 296089 3 71144 commit-queue 2010-10-19 03:22:05 -0700 Comment on attachment 71144 Patch Clearing flags on attachment: 71144 Committed r70043: <http://trac.webkit.org/changeset/70043> 296090 4 commit-queue 2010-10-19 03:22:11 -0700 All reviewed patches have been landed. Closing bug. 71144 2010-10-19 02:23:40 -0700 2010-10-19 03:22:05 -0700 Patch bug-47891-20101019182338.patch text/plain 1352 yutak ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MzdiYWM4MTI2NTllOGExMDhiNTBhYWM2YWZjMTI4ZGQ1NDkzMmJjMi4uYTVhZjE2NGE1MTQyYjQ4 NTljM2YzNWYyOTM4MjE0YjZkNDIzMGZkMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0xMC0xOSAgWXV0 YSBLaXRhbXVyYSAgPHl1dGFrQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIHN1cmUgV2ViU29ja2V0IHJlc291cmNlIGhh cyB0aGUgdXJsIGZpZWxkIHdoZW4gaXQgaXMgY3JlYXRlZC4KKworICAgICAgICBXZWIgSW5zcGVj dG9yOiBVbmNhdWdodCBUeXBlRXJyb3Igd2hlbiBjb25uZWN0aW9uIHRvIFdlYlNvY2tldCBzZXJ2 ZXIgaXMgcmVmdXNlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NDc4OTEKKworICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JSZXNvdXJjZS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JSZXNvdXJjZTo6Y3JlYXRlV2ViU29ja2V0KToK KwogMjAxMC0xMC0xOSAgSGF5YXRvIEl0byAgPGhheWF0b0BjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rv ci9JbnNwZWN0b3JSZXNvdXJjZS5jcHAgYi9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JSZXNv dXJjZS5jcHAKaW5kZXggZjFiMjcwYWZhMjkyYWJhZjJlZjUyMTcyMWQ5NWYyNGJiYmQyODY4Zi4u MDViMWJmZjhiZjAwNDkyYjk0Y2MxYzVlMTBlN2E2OGNjOGU0NDVjZSAxMDA2NDQKLS0tIGEvV2Vi Q29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yUmVzb3VyY2UuY3BwCisrKyBiL1dlYkNvcmUvaW5zcGVj dG9yL0luc3BlY3RvclJlc291cmNlLmNwcApAQCAtMTQ3LDYgKzE0Nyw3IEBAIFBhc3NSZWZQdHI8 SW5zcGVjdG9yUmVzb3VyY2U+IEluc3BlY3RvclJlc291cmNlOjpjcmVhdGVXZWJTb2NrZXQodW5z aWduZWQgbG9uZyBpCiAgICAgUmVmUHRyPEluc3BlY3RvclJlc291cmNlPiByZXNvdXJjZSA9IGFk b3B0UmVmKG5ldyBJbnNwZWN0b3JSZXNvdXJjZShpZGVudGlmaWVyLCAwLCByZXF1ZXN0VVJMKSk7 CiAgICAgcmVzb3VyY2UtPm1hcmtXZWJTb2NrZXQoKTsKICAgICByZXNvdXJjZS0+bV9kb2N1bWVu dFVSTCA9IGRvY3VtZW50VVJMOworICAgIHJlc291cmNlLT5tX2NoYW5nZXMuc2V0QWxsKCk7CiAg ICAgcmV0dXJuIHJlc291cmNlLnJlbGVhc2UoKTsKIH0KICNlbmRpZgo=