47887 2010-10-19 00:52:02 -0700 Remove private: access level directive from WTF_MAKE_FAST_ALLOCATED macro 2010-11-22 01:29:59 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) PC All RESOLVED INVALID P2 Normal --- 42998 1 zoltan zoltan andersca darin oldest_to_newest 296037 0 zoltan 2010-10-19 00:52:02 -0700 We should remove private directive from the end of the WTF_MAKE_FAST_ALLOCATED macro, because it can causes problems with structs. This solution isn't nice: struct a { WTF_MAKE_FAST_ALLOCATED public: int x; } Other way is to put the macro to the end of the struct: struct a { int x; WTF_MAKE_FAST_ALLOCATED } Or we can simply remove "private:" from the end of the macro. Almost every class contains access level directives explicitly, so removing shouldn't cause much problems. 296038 1 71139 zoltan 2010-10-19 00:53:22 -0700 Created attachment 71139 proposed patch 312244 2 71139 zoltan 2010-11-22 01:29:48 -0800 Comment on attachment 71139 proposed patch I've chosen the first solution since it is unambiguous. Closing as invalid. 71139 2010-10-19 00:53:22 -0700 2010-11-22 01:29:47 -0800 proposed patch macro.patch text/plain 1106 zoltan ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCA4NjA2MWVjLi4zOTcyYTU0IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTAtMTAtMTkgIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtpdC5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIHByaXZh dGU6IGFjY2VzcyBsZXZlbCBkaXJlY3RpdmUgZnJvbSBXVEZfTUFLRV9GQVNUX0FMTE9DQVRFRCBt YWNybworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDc4 ODcKKworICAgICAgICBSZW1vdmUgcHJpdmF0ZSBhY2Nlc3MgbGV2ZWwgZGlyZWN0aXZlIGZyb20g V1RGX01BS0VfRkFTVF9BTExPQ0FURUQgbWFjcm8sIHNpbmNlCisgICAgICAgIGl0IGNhbiBjYXVz ZSBhY2Nlc3MgcHJvYmxlbXMgaW4gc3RydWN0cy4KKworICAgICAgICAqIHd0Zi9GYXN0QWxsb2NC YXNlLmg6CisKIDIwMTAtMTAtMTggIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9KYXZhU2Ny aXB0Q29yZS93dGYvRmFzdEFsbG9jQmFzZS5oIGIvSmF2YVNjcmlwdENvcmUvd3RmL0Zhc3RBbGxv Y0Jhc2UuaAppbmRleCBiYjE4MjVlLi5lODhhYzQyIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS93dGYvRmFzdEFsbG9jQmFzZS5oCisrKyBiL0phdmFTY3JpcHRDb3JlL3d0Zi9GYXN0QWxsb2NC YXNlLmgKQEAgLTExNCw4ICsxMTQsNyBAQCBwdWJsaWM6IFwKICAgICB7IFwKICAgICAgICAgIDo6 V1RGOjpmYXN0TWFsbG9jTWF0Y2hWYWxpZGF0ZUZyZWUocCwgOjpXVEY6OkludGVybmFsOjpBbGxv Y1R5cGVDbGFzc05ld0FycmF5KTsgXAogICAgICAgICAgOjpXVEY6OmZhc3RGcmVlKHApOyBcCi0g ICAgfSBcCi1wcml2YXRlOgorICAgIH0KIAogY2xhc3MgRmFzdEFsbG9jQmFzZSB7CiAgICAgV1RG X01BS0VfRkFTVF9BTExPQ0FURUQgIAo=