47875 2010-10-18 20:07:42 -0700 Regression in run_webkit_tests_unittest from r70017 2010-10-18 21:49:17 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 kbr kbr abarth dpranke eric jamesr webkit.review.bot oldest_to_newest 295941 0 kbr 2010-10-18 20:07:42 -0700 The change to WebKitTools/Scripts/webkitpy/layout_tests/port/base.py in r70017 introduced a regression in webkitpy/layout_tests/run_webkit_tests_unittest.py because the mocked file open routine is overspecialized for the file mode. 295944 1 71124 kbr 2010-10-18 20:13:33 -0700 Created attachment 71124 Patch Ran test-webkit-scripts (which I didn't know about before) to verify. 295948 2 71124 tony 2010-10-18 20:21:03 -0700 Comment on attachment 71124 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=71124&action=review > WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:267 > + if name.find("-expected.") != -1 and mode.find("w") != -1: Nit: "w" in mode 295949 3 kbr 2010-10-18 20:22:22 -0700 Committed r70021: <http://trac.webkit.org/changeset/70021> 295980 4 webkit.review.bot 2010-10-18 21:49:17 -0700 http://trac.webkit.org/changeset/70021 might have broken SnowLeopard Intel Release (Tests) 71124 2010-10-18 20:13:33 -0700 2010-10-18 20:21:02 -0700 Patch test-regression.patch text/plain 1309 kbr SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDcwMDIwKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMTAtMTggIEtlbm5ldGggUnVzc2VsbCAg PGtickBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFJlZ3Jlc3Npb24gaW4gcnVuX3dlYmtpdF90ZXN0c191bml0dGVzdCBmcm9tIHI3 MDAxNworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDc4 NzUKKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRf dGVzdHNfdW5pdHRlc3QucHk6CisKIDIwMTAtMTAtMTggIEFkYW0gQmFydGggIDxhYmFydGhAd2Vi a2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KSW5kZXg6IFdlYktp dFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHNfdW5p dHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0c191bml0dGVzdC5weQkocmV2aXNpb24gNzAwMTYpCisr KyBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rl c3RzX3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0yNjQsNyArMjY0LDcgQEAgY2xhc3Mg TWFpblRlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogCiBkZWYgX21vY2tlZF9vcGVuKG9yaWdpbmFs X29wZW4sIGZpbGVfbGlzdCk6CiAgICAgZGVmIF93cmFwcGVyKG5hbWUsIG1vZGUsIGVuY29kaW5n KToKLSAgICAgICAgaWYgbmFtZS5maW5kKCItZXhwZWN0ZWQuIikgIT0gLTEgYW5kIG1vZGUgPT0g InciOgorICAgICAgICBpZiBuYW1lLmZpbmQoIi1leHBlY3RlZC4iKSAhPSAtMSBhbmQgbW9kZS5m aW5kKCJ3IikgIT0gLTE6CiAgICAgICAgICAgICAjIHdlIGRvbid0IHdhbnQgdG8gYWN0dWFsbHkg d3JpdGUgbmV3IGJhc2VsaW5lcywgc28gc3R1YiB0aGVzZSBvdXQKICAgICAgICAgICAgIG5hbWUu cmVwbGFjZSgnXFwnLCAnLycpCiAgICAgICAgICAgICBmaWxlX2xpc3QuYXBwZW5kKG5hbWUpCg==