47867 2010-10-18 18:49:00 -0700 new-run-webkit-tests produces corrupt PNG baselines on Windows 2010-10-18 20:00:19 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 kbr kbr abarth dglazkov dpranke eric jamesr webkit.review.bot oldest_to_newest 295895 0 kbr 2010-10-18 18:49:00 -0700 new-run-webkit-tests produces corrupt PNG baselines on Windows, at least with the Python from http://www.python.org/, because the output file is opened with mode "w" rather than mode "wb" in WebKitTools/Scripts/webkitpy/layout_tests/port/base.py, update_baseline. Like _expected_file_contents in the same file, the encoding should be tested and "b" used if the encoding is None. 295896 1 71111 kbr 2010-10-18 18:52:45 -0700 Created attachment 71111 Patch 295898 2 71111 eric 2010-10-18 18:54:44 -0700 Comment on attachment 71111 Patch I would have written "if not encoding:", but this is fine. 295921 3 kbr 2010-10-18 19:32:47 -0700 Committed r70017: <http://trac.webkit.org/changeset/70017> 295927 4 eric 2010-10-18 19:38:10 -0700 Committed r70019: <http://trac.webkit.org/changeset/70019> 295939 5 webkit.review.bot 2010-10-18 20:00:19 -0700 http://trac.webkit.org/changeset/70017 might have broken SnowLeopard Intel Release (Tests) 71111 2010-10-18 18:52:45 -0700 2010-10-18 18:54:43 -0700 Patch png-baseline.patch text/plain 1288 kbr SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDcwMDE0KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMTAtMTggIEtlbm5ldGggUnVzc2VsbCAg PGtickBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIG5ldy1ydW4td2Via2l0LXRlc3RzIHByb2R1Y2VzIGNvcnJ1cHQgUE5HIGJhc2Vs aW5lcyBvbiBXaW5kb3dzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD00Nzg2NworCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMv cG9ydC9iYXNlLnB5OgorCiAyMDEwLTEwLTE4ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCkluZGV4OiBXZWJLaXRUb29s cy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Jhc2UucHkKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9iYXNlLnB5 CShyZXZpc2lvbiA3MDAxMSkKKysrIFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL3BvcnQvYmFzZS5weQkod29ya2luZyBjb3B5KQpAQCAtMzgyLDcgKzM4MiwxMCBAQCBj bGFzcyBQb3J0KG9iamVjdCk6CiAgICAgICAgICAgICBkYXRhOiBjb250ZW50cyBvZiB0aGUgYmFz ZWxpbmUuCiAgICAgICAgICAgICBlbmNvZGluZzogZmlsZSBlbmNvZGluZyB0byB1c2UgZm9yIHRo ZSBiYXNlbGluZS4KICAgICAgICAgIiIiCi0gICAgICAgIHdpdGggY29kZWNzLm9wZW4ocGF0aCwg InciLCBlbmNvZGluZz1lbmNvZGluZykgYXMgZmlsZToKKyAgICAgICAgd3JpdGVfbW9kZSA9ICJ3 IgorICAgICAgICBpZiBlbmNvZGluZyBpcyBOb25lOgorICAgICAgICAgICAgd3JpdGVfbW9kZSA9 ICJ3YiIKKyAgICAgICAgd2l0aCBjb2RlY3Mub3BlbihwYXRoLCB3cml0ZV9tb2RlLCBlbmNvZGlu Zz1lbmNvZGluZykgYXMgZmlsZToKICAgICAgICAgICAgIGZpbGUud3JpdGUoZGF0YSkKIAogICAg IGRlZiB1cmlfdG9fdGVzdF9uYW1lKHNlbGYsIHVyaSk6Cg==