47846 2010-10-18 14:08:15 -0700 elementCannotHaveEndTag should be a member function of MarkupAccumulator 2010-10-18 14:42:53 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) All All RESOLVED FIXED P2 Enhancement --- 1 rniwa rniwa abarth eric ojan tony oldest_to_newest 295735 0 rniwa 2010-10-18 14:08:15 -0700 Since serializeNodes have been moved into MarkupAccumulator, we should also move elementCannotHaveEndTag into MarkupAccumulator. 295738 1 71080 rniwa 2010-10-18 14:11:24 -0700 Created attachment 71080 cleanup 295743 2 71080 abarth 2010-10-18 14:15:47 -0700 Comment on attachment 71080 cleanup like 295764 3 rniwa 2010-10-18 14:42:53 -0700 Committed r69994: <http://trac.webkit.org/changeset/69994> 71080 2010-10-18 14:11:24 -0700 2010-10-18 14:15:47 -0700 cleanup bug-47846-20101018141123.patch text/plain 3926 rniwa SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2OTk4OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTAtMTAtMTggIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgZWxl bWVudENhbm5vdEhhdmVFbmRUYWcgc2hvdWxkIGJlIGEgbWVtYmVyIGZ1bmN0aW9uIG9mIE1hcmt1 cEFjY3VtdWxhdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD00Nzg0NgorCisgICAgICAgIE1vdmVkIGVsZW1lbnRDYW5ub3RIYXZlRW5kVGFnIGludG8g TWFya3VwQWNjdW11bGF0b3IuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGFyZSBhZGRlZCBzaW5j ZSB0aGlzIGlzIGEgY2xlYW51cC4KKworICAgICAgICAqIGVkaXRpbmcvTWFya3VwQWNjdW11bGF0 b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWFya3VwQWNjdW11bGF0b3I6OmVsZW1lbnRDYW5u b3RIYXZlRW5kVGFnKTogQWRkZWQuCisgICAgICAgICogZWRpdGluZy9NYXJrdXBBY2N1bXVsYXRv ci5oOiBBZGRlZCBNYXJrdXBBY2N1bXVsYXRvcjo6ZWxlbWVudENhbm5vdEhhdmVFbmRUYWcuCisg ICAgICAgICogZWRpdGluZy9tYXJrdXAuY3BwOiBSZW1vdmVkIGVsZW1lbnRDYW5ub3RIYXZlRW5k VGFnLgorICAgICAgICAqIGVkaXRpbmcvbWFya3VwLmg6IFJlbW92ZWQgZWxlbWVudENhbm5vdEhh dmVFbmRUYWcuCisKIDIwMTAtMTAtMTggIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgog CiAgICAgICAgICogZG9tL05vZGUuaDogRml4IGFuY2llbnQgdHlwbyBpbiBqdXN0LW1vZGlmaWVk IGNvbW1lbnQuCkluZGV4OiBXZWJDb3JlL2VkaXRpbmcvTWFya3VwQWNjdW11bGF0b3IuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYkNvcmUvZWRpdGluZy9NYXJrdXBBY2N1bXVsYXRvci5jcHAJKHJldmlz aW9uIDY5OTA5KQorKysgV2ViQ29yZS9lZGl0aW5nL01hcmt1cEFjY3VtdWxhdG9yLmNwcAkod29y a2luZyBjb3B5KQpAQCAtNDM5LDYgKzQzOSwxOCBAQCBib29sIE1hcmt1cEFjY3VtdWxhdG9yOjpz aG91bGRTZWxmQ2xvc2UoCiAgICAgcmV0dXJuIHRydWU7CiB9CiAKK2Jvb2wgTWFya3VwQWNjdW11 bGF0b3I6OmVsZW1lbnRDYW5ub3RIYXZlRW5kVGFnKGNvbnN0IE5vZGUqIG5vZGUpCit7CisgICAg aWYgKCFub2RlLT5pc0hUTUxFbGVtZW50KCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAK KyAgICAvLyBGSVhNRTogaWVGb3JiaWRzSW5zZXJ0SFRNTCBtYXkgbm90IGJlIHRoZSByaWdodCBm dW5jdGlvbiB0byBjYWxsIGhlcmUKKyAgICAvLyBpZUZvcmJpZHNJbnNlcnRIVE1MIGlzIHVzZWQg dG8gZGlzYWxsb3cgc2V0dGluZyBpbm5lckhUTUwvb3V0ZXJIVE1MCisgICAgLy8gb3IgY3JlYXRl Q29udGV4dHVhbEZyYWdtZW50LiAgSXQgZG9lcyBub3QgbmVjZXNzYXJpbHkgYWxpZ24gd2l0aAor ICAgIC8vIHdoaWNoIGVsZW1lbnRzIHNob3VsZCBiZSBzZXJpYWxpemVkIHcvbyBlbmQgdGFncy4K KyAgICByZXR1cm4gc3RhdGljX2Nhc3Q8Y29uc3QgSFRNTEVsZW1lbnQqPihub2RlKS0+aWVGb3Ji aWRzSW5zZXJ0SFRNTCgpOworfQorCiB2b2lkIE1hcmt1cEFjY3VtdWxhdG9yOjphcHBlbmRFbmRN YXJrdXAoVmVjdG9yPFVDaGFyPiYgcmVzdWx0LCBjb25zdCBOb2RlKiBub2RlKQogewogICAgIGlm ICghbm9kZS0+aXNFbGVtZW50Tm9kZSgpIHx8IHNob3VsZFNlbGZDbG9zZShub2RlKSB8fCAoIW5v ZGUtPmhhc0NoaWxkTm9kZXMoKSAmJiBlbGVtZW50Q2Fubm90SGF2ZUVuZFRhZyhub2RlKSkpCklu ZGV4OiBXZWJDb3JlL2VkaXRpbmcvTWFya3VwQWNjdW11bGF0b3IuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJDb3JlL2VkaXRpbmcvTWFya3VwQWNjdW11bGF0b3IuaAkocmV2aXNpb24gNjk5MDkpCisrKyBX ZWJDb3JlL2VkaXRpbmcvTWFya3VwQWNjdW11bGF0b3IuaAkod29ya2luZyBjb3B5KQpAQCAtOTYs NiArOTYsNyBAQCBwcm90ZWN0ZWQ6CiAgICAgdm9pZCBhcHBlbmRDREFUQVNlY3Rpb24oVmVjdG9y PFVDaGFyPiYgb3V0LCBjb25zdCBTdHJpbmcmIHNlY3Rpb24pOwogICAgIHZvaWQgYXBwZW5kU3Rh cnRNYXJrdXAoVmVjdG9yPFVDaGFyPiYgcmVzdWx0LCBjb25zdCBOb2RlKiwgTmFtZXNwYWNlcyop OwogICAgIGJvb2wgc2hvdWxkU2VsZkNsb3NlKGNvbnN0IE5vZGUqKTsKKyAgICBib29sIGVsZW1l bnRDYW5ub3RIYXZlRW5kVGFnKGNvbnN0IE5vZGUqIG5vZGUpOwogICAgIHZvaWQgYXBwZW5kRW5k TWFya3VwKFZlY3RvcjxVQ2hhcj4mIHJlc3VsdCwgY29uc3QgTm9kZSopOwogCiAgICAgYm9vbCBz aG91bGRSZXNvbHZlVVJMcygpIHsgcmV0dXJuIG1fc2hvdWxkUmVzb2x2ZVVSTHMgPT0gQWJzb2x1 dGVVUkxzOyB9CkluZGV4OiBXZWJDb3JlL2VkaXRpbmcvbWFya3VwLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJDb3JlL2VkaXRpbmcvbWFya3VwLmNwcAkocmV2aXNpb24gNjk5MDkpCisrKyBXZWJDb3Jl L2VkaXRpbmcvbWFya3VwLmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTMsMTggKzkzLDYgQEAgcHJp dmF0ZToKICAgICBTdHJpbmcgbV92YWx1ZTsKIH07CiAKLWJvb2wgZWxlbWVudENhbm5vdEhhdmVF bmRUYWcoY29uc3QgTm9kZSogbm9kZSkKLXsKLSAgICBpZiAoIW5vZGUtPmlzSFRNTEVsZW1lbnQo KSkKLSAgICAgICAgcmV0dXJuIGZhbHNlOwotCi0gICAgLy8gRklYTUU6IGllRm9yYmlkc0luc2Vy dEhUTUwgbWF5IG5vdCBiZSB0aGUgcmlnaHQgZnVuY3Rpb24gdG8gY2FsbCBoZXJlCi0gICAgLy8g aWVGb3JiaWRzSW5zZXJ0SFRNTCBpcyB1c2VkIHRvIGRpc2FsbG93IHNldHRpbmcgaW5uZXJIVE1M L291dGVySFRNTAotICAgIC8vIG9yIGNyZWF0ZUNvbnRleHR1YWxGcmFnbWVudC4gIEl0IGRvZXMg bm90IG5lY2Vzc2FyaWx5IGFsaWduIHdpdGgKLSAgICAvLyB3aGljaCBlbGVtZW50cyBzaG91bGQg YmUgc2VyaWFsaXplZCB3L28gZW5kIHRhZ3MuCi0gICAgcmV0dXJuIHN0YXRpY19jYXN0PGNvbnN0 IEhUTUxFbGVtZW50Kj4obm9kZSktPmllRm9yYmlkc0luc2VydEhUTUwoKTsKLX0KLQogc3RhdGlj IHZvaWQgY29tcGxldGVVUkxzKE5vZGUqIG5vZGUsIGNvbnN0IFN0cmluZyYgYmFzZVVSTCkKIHsK ICAgICBWZWN0b3I8QXR0cmlidXRlQ2hhbmdlPiBjaGFuZ2VzOwpJbmRleDogV2ViQ29yZS9lZGl0 aW5nL21hcmt1cC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvZWRpdGluZy9tYXJrdXAuaAkocmV2 aXNpb24gNjk5MDkpCisrKyBXZWJDb3JlL2VkaXRpbmcvbWFya3VwLmgJKHdvcmtpbmcgY29weSkK QEAgLTU2LDkgKzU2LDYgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgIFN0cmluZyBjcmVhdGVG dWxsTWFya3VwKGNvbnN0IFJhbmdlKik7CiAKICAgICBTdHJpbmcgdXJsVG9NYXJrdXAoY29uc3Qg S1VSTCYsIGNvbnN0IFN0cmluZyYgdGl0bGUpOwotCi0gICAgLy8gRklYTUU6IFNob3VsZCB0aGlz IGJlIGJldHRlciBlbmNhcHVsYXRlZCBzb21ld2hlcmU/Ci0gICAgYm9vbCBlbGVtZW50Q2Fubm90 SGF2ZUVuZFRhZyhjb25zdCBOb2RlKik7CiB9CiAKICNlbmRpZiAvLyBtYXJrdXBfaAo=