47844 2010-10-18 13:45:30 -0700 RVCT fails to compile DateMath.cpp due to overloaded function pow 2010-10-19 12:43:59 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 1 skyul webkit-unassigned commit-queue ddkilzer oldest_to_newest 295720 0 skyul 2010-10-18 13:45:30 -0700 RVCT fails to compile DateMath.cpp with the following compile error: "..\JavaScriptCore\wtf\DateMath.cpp", line 642: Error: #308: more than one instance of overloaded function "pow" matches the argument list: function "std::pow(double, double)" function "std::pow(float, float)" function "std::pow(float, int)" function "std::pow(double, int)" function "std::pow(long double, long double)" function "std::pow(long double, int)" argument types are: (int, long) seconds += fracSeconds * pow(10, -numFracDigits); We need to add an explicit cast to the arguments of pow. 295721 1 71076 skyul 2010-10-18 13:49:12 -0700 Created attachment 71076 Patch 296315 2 71076 ddkilzer 2010-10-19 11:49:53 -0700 Comment on attachment 71076 Patch r=me 296344 3 71076 commit-queue 2010-10-19 12:43:54 -0700 Comment on attachment 71076 Patch Clearing flags on attachment: 71076 Committed r70076: <http://trac.webkit.org/changeset/70076> 296345 4 commit-queue 2010-10-19 12:43:59 -0700 All reviewed patches have been landed. Closing bug. 71076 2010-10-18 13:49:12 -0700 2010-10-19 12:43:53 -0700 Patch pow.patch text/plain 1286 skyul SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDY5OTg4KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMTAtMTggIEt3YW5nIFl1 bCBTZW8gIDxza3l1bEBjb21wYW55MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBSVkNUIGZhaWxzIHRvIGNvbXBpbGUgRGF0ZU1hdGguY3Bw IGR1ZSB0byBvdmVybG9hZGVkIGZ1bmN0aW9uIHBvdworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDc4NDQKKworICAgICAgICBDaG9vc2Ugc3RkOjpwb3co ZG91YmxlLCBkb3VibGUpIGFtb25nIG11bHRpcGxlIG92ZXJsb2FkZWQgcG93IGZ1bmN0aW9ucwor ICAgICAgICB0byBmaXggYnVpbGQgZm9yIFJWQ1QuCisKKyAgICAgICAgKiB3dGYvRGF0ZU1hdGgu Y3BwOgorICAgICAgICAoV1RGOjpwYXJzZUVTNURhdGVGcm9tTnVsbFRlcm1pbmF0ZWRDaGFyYWN0 ZXJzKToKKwogMjAxMC0xMC0xOCAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogSmF2YVNjcmlwdENvcmUvd3Rm L0RhdGVNYXRoLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS93dGYvRGF0ZU1hdGgu Y3BwCShyZXZpc2lvbiA2OTk2NCkKKysrIEphdmFTY3JpcHRDb3JlL3d0Zi9EYXRlTWF0aC5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTYzOSw3ICs2MzksNyBAQCBkb3VibGUgcGFyc2VFUzVEYXRlRnJv bU51bGxUZXJtaW5hdGVkQ2hhCiAgICAgICAgICAgICByZXR1cm4gTmFOOwogICAgICAgICAKICAg ICAgICAgbG9uZyBudW1GcmFjRGlnaXRzID0gcG9zdFBhcnNlUG9zaXRpb24gLSBjdXJyZW50UG9z aXRpb247Ci0gICAgICAgIHNlY29uZHMgKz0gZnJhY1NlY29uZHMgKiBwb3coMTAsIC1udW1GcmFj RGlnaXRzKTsKKyAgICAgICAgc2Vjb25kcyArPSBmcmFjU2Vjb25kcyAqIHBvdygxMC4wLCBzdGF0 aWNfY2FzdDxkb3VibGU+KC1udW1GcmFjRGlnaXRzKSk7CiAgICAgfQogICAgIGN1cnJlbnRQb3Np dGlvbiA9IHBvc3RQYXJzZVBvc2l0aW9uOwogICAgIAo=