47829 2010-10-18 09:38:24 -0700 DOMStringList should return null if the index is out of range 2010-10-18 12:16:00 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jorlow jorlow andreip ap commit-queue steveblock oldest_to_newest 295555 0 jorlow 2010-10-18 09:38:24 -0700 DOMStringList should return null if the index is out of range 295556 1 71047 jorlow 2010-10-18 09:41:23 -0700 Created attachment 71047 Patch 295559 2 71047 darin 2010-10-18 09:43:10 -0700 Comment on attachment 71047 Patch Is DOMStringList testable only in the IDB context, or are there other DOMStringList clients? 295562 3 andreip 2010-10-18 09:45:32 -0700 LGTM 295564 4 jorlow 2010-10-18 09:46:06 -0700 I'm pretty sure only via IndexedDB at the moment. 295679 5 71047 commit-queue 2010-10-18 12:15:55 -0700 Comment on attachment 71047 Patch Clearing flags on attachment: 71047 Committed r69983: <http://trac.webkit.org/changeset/69983> 295680 6 commit-queue 2010-10-18 12:16:00 -0700 All reviewed patches have been landed. Closing bug. 71047 2010-10-18 09:41:23 -0700 2010-10-18 12:15:55 -0700 Patch bug-47829-20101018174120.patch text/plain 6606 jorlow ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5Y2FlNWJlZDUxM2IxNWU3NGEwYWE0NGRhN2Q0ZDlkMmJlMzM2ODdiLi5kNjljYjRj ZTdlZWIwMTM2ZDkxNjVjMjBmMDZkZGYyZjE1NTU4ZjQ5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAK KzIwMTAtMTAtMTggIEplcmVteSBPcmxvdyAgPGpvcmxvd0BjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRE9NU3RyaW5nTGlzdCBz aG91bGQgcmV0dXJuIG51bGwgaWYgdGhlIGluZGV4IGlzIG91dCBvZiByYW5nZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDc4MjkKKworICAgICAgICBB ZGQgdGVzdHMgZm9yIG91dCBvZiByYW5nZSBiZWhhdmlvciBoZXJlIHNpbmNlIEluZGV4ZWREQiBp cyB0aGUgb25seSB1c2VyCisgICAgICAgIG9mIERPTVN0cmluZ0xpc3QuCisKKyAgICAgICAgKiBz dG9yYWdlL2luZGV4ZWRkYi9kYXRhYmFzZS1iYXNpY3MtZXhwZWN0ZWQudHh0OgorICAgICAgICAq IHN0b3JhZ2UvaW5kZXhlZGRiL2RhdGFiYXNlLWJhc2ljcy5odG1sOgorICAgICAgICAqIHN0b3Jh Z2UvaW5kZXhlZGRiL29iamVjdHN0b3JlLWJhc2ljcy1leHBlY3RlZC50eHQ6CisgICAgICAgICog c3RvcmFnZS9pbmRleGVkZGIvb2JqZWN0c3RvcmUtYmFzaWNzLmh0bWw6CisKIDIwMTAtMTAtMTcg IE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJlYmFz ZWxpbmUgTWF0aE1MIHRlc3RzIGFmdGVyIHI2OTkyNi4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L3N0b3JhZ2UvaW5kZXhlZGRiL2RhdGFiYXNlLWJhc2ljcy1leHBlY3RlZC50eHQgYi9MYXlvdXRU ZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9kYXRhYmFzZS1iYXNpY3MtZXhwZWN0ZWQudHh0CmluZGV4 IGIwNjc0YWQ5ZTMwZTNhMDY1MzJiZmFkNzg2ZTU5ODZiYTJlN2U0ZmYuLjJhNWZhMmZhZmRiNTQ5 ZGNlZGU2OTMzYzIxODk5ZTkwNDg0YjgyYWYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3N0b3Jh Z2UvaW5kZXhlZGRiL2RhdGFiYXNlLWJhc2ljcy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVz dHMvc3RvcmFnZS9pbmRleGVkZGIvZGF0YWJhc2UtYmFzaWNzLWV4cGVjdGVkLnR4dApAQCAtODIs NiArODIsOCBAQCBQQVNTIGRiLm5hbWUgaXMgIm5hbWUiCiBQQVNTIGRiLm9iamVjdFN0b3JlcyBp cyBbXQogUEFTUyBkYi5vYmplY3RTdG9yZXMubGVuZ3RoIGlzIDAKIFBBU1MgZGIub2JqZWN0U3Rv cmVzLmNvbnRhaW5zKCcnKSBpcyBmYWxzZQorUEFTUyBkYi5vYmplY3RTdG9yZXNbMF0gaXMgbnVs bAorUEFTUyBkYi5vYmplY3RTdG9yZXMuaXRlbSgwKSBpcyBudWxsCiBkYi5jcmVhdGVPYmplY3RT dG9yZSgidGVzdDEyMyIpCiBQQVNTIGRiLm9iamVjdFN0b3JlcyBpcyBbJ3Rlc3QxMjMnXQogUEFT UyBkYi5vYmplY3RTdG9yZXMubGVuZ3RoIGlzIDEKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N0 b3JhZ2UvaW5kZXhlZGRiL2RhdGFiYXNlLWJhc2ljcy5odG1sIGIvTGF5b3V0VGVzdHMvc3RvcmFn ZS9pbmRleGVkZGIvZGF0YWJhc2UtYmFzaWNzLmh0bWwKaW5kZXggMjczOGM1OTE3NzQ1ODRkNDgz YjdhZTVkNWU5OGYyZTBlMzY3MDhjMS4uZGIyZDI4OTM5MmE4ZTZjYmYwYWEwN2VkZDcxM2ZhYjIz NGZmN2EyOCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvZGF0YWJh c2UtYmFzaWNzLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvZGF0YWJh c2UtYmFzaWNzLmh0bWwKQEAgLTcxLDYgKzcxLDggQEAgZnVuY3Rpb24gY3JlYXRlT2JqZWN0U3Rv cmUoKQogICAgIHNob3VsZEJlKCJkYi5vYmplY3RTdG9yZXMiLCAiW10iKTsKICAgICBzaG91bGRC ZSgiZGIub2JqZWN0U3RvcmVzLmxlbmd0aCIsICIwIik7CiAgICAgc2hvdWxkQmUoImRiLm9iamVj dFN0b3Jlcy5jb250YWlucygnJykiLCAiZmFsc2UiKTsKKyAgICBzaG91bGRCZU51bGwoImRiLm9i amVjdFN0b3Jlc1swXSIpOworICAgIHNob3VsZEJlTnVsbCgiZGIub2JqZWN0U3RvcmVzLml0ZW0o MCkiKTsKIAogICAgIG9iamVjdFN0b3JlID0gZXZhbEFuZExvZygnZGIuY3JlYXRlT2JqZWN0U3Rv cmUoInRlc3QxMjMiKScpOw0KICAgICBjaGVja09iamVjdFN0b3JlKCk7DQpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvb2JqZWN0c3RvcmUtYmFzaWNzLWV4cGVjdGVk LnR4dCBiL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL29iamVjdHN0b3JlLWJhc2ljcy1l eHBlY3RlZC50eHQKaW5kZXggZTUzNGUyZWM5NmVmYjFkN2FjM2FmMDI2ODg5ZGEyMmZhZTYxNGU1 Yy4uZDIyZTZmMDRiZDg2MzM5NDFkM2Y3NTMyNmI2OGZiMmM5YzcwYjg2NCAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvb2JqZWN0c3RvcmUtYmFzaWNzLWV4cGVjdGVk LnR4dAorKysgYi9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9vYmplY3RzdG9yZS1iYXNp Y3MtZXhwZWN0ZWQudHh0CkBAIC05MCw2ICs5MCwxMSBAQCBQQVNTIHN0b3JlLmluZGV4TmFtZXMu bGVuZ3RoIGlzIDEKIFBBU1Mgc3RvcmUuaW5kZXhOYW1lcy5jb250YWlucygnJykgaXMgZmFsc2UK IFBBU1Mgc3RvcmUuaW5kZXhOYW1lcy5jb250YWlucygnaW5kZXhGYWlsJykgaXMgZmFsc2UKIFBB U1Mgc3RvcmUuaW5kZXhOYW1lcy5jb250YWlucygnaW5kZXhOYW1lJykgaXMgdHJ1ZQorUEFTUyBz dG9yZS5pbmRleE5hbWVzWzBdIGlzICJpbmRleE5hbWUiCitQQVNTIHN0b3JlLmluZGV4TmFtZXNb MV0gaXMgbnVsbAorUEFTUyBzdG9yZS5pbmRleE5hbWVzWzEwMF0gaXMgbnVsbAorUEFTUyBzdG9y ZS5pbmRleE5hbWVzLml0ZW0oMSkgaXMgbnVsbAorUEFTUyBzdG9yZS5pbmRleE5hbWVzLml0ZW0o MTAwKSBpcyBudWxsCiB0cmFuc2FjdGlvbiA9IGRiLnRyYW5zYWN0aW9uKCkKIHN0b3JlID0gdHJh bnNhY3Rpb24ub2JqZWN0U3RvcmUoJ3N0b3JlTmFtZScpCiBzdG9yZS5hZGQoe3g6ICd2YWx1ZSd9 LCAna2V5JykKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL29iamVj dHN0b3JlLWJhc2ljcy5odG1sIGIvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvb2JqZWN0 c3RvcmUtYmFzaWNzLmh0bWwKaW5kZXggNzdlMzNiMGIwMGFlM2Q2YjkwM2JmMzNjODNjZTU2OTU5 Nzc2NzVmOS4uOTU3ZGZhYTQwNjMzNTI2NmY1ZDM4NzJiYjY0YmQ5YmY4NjE2NTU5MyAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvb2JqZWN0c3RvcmUtYmFzaWNzLmh0 bWwKKysrIGIvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvb2JqZWN0c3RvcmUtYmFzaWNz Lmh0bWwKQEAgLTEyOCw2ICsxMjgsMTEgQEAgZnVuY3Rpb24gY2hlY2tNZXRhZGF0YSgpCiAgICAg c2hvdWxkQmUoInN0b3JlLmluZGV4TmFtZXMuY29udGFpbnMoJycpIiwgImZhbHNlIik7DQogICAg IHNob3VsZEJlKCJzdG9yZS5pbmRleE5hbWVzLmNvbnRhaW5zKCdpbmRleEZhaWwnKSIsICJmYWxz ZSIpOw0KICAgICBzaG91bGRCZSgic3RvcmUuaW5kZXhOYW1lcy5jb250YWlucygnaW5kZXhOYW1l JykiLCAidHJ1ZSIpOw0KKyAgICBzaG91bGRCZUVxdWFsVG9TdHJpbmcoInN0b3JlLmluZGV4TmFt ZXNbMF0iLCAiaW5kZXhOYW1lIik7CisgICAgc2hvdWxkQmVOdWxsKCJzdG9yZS5pbmRleE5hbWVz WzFdIik7CisgICAgc2hvdWxkQmVOdWxsKCJzdG9yZS5pbmRleE5hbWVzWzEwMF0iKTsKKyAgICBz aG91bGRCZU51bGwoInN0b3JlLmluZGV4TmFtZXMuaXRlbSgxKSIpOworICAgIHNob3VsZEJlTnVs bCgic3RvcmUuaW5kZXhOYW1lcy5pdGVtKDEwMCkiKTsKICAgICBhZGREYXRhKCk7DQogfQ0KIApk aWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA3 MWM5OTc2MjRiZDNmNDUxYzQyODJiN2UxZDM1NTY4Mjk0NjRkM2QwLi42MjY3MzU1YjNlMGEwMjE4 ODJhZDM1OThlYTM0NGJiNDg4Y2Y1ZGU5IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZwor KysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEwLTEwLTE4ICBKZXJl bXkgT3Jsb3cgIDxqb3Jsb3dAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIERPTVN0cmluZ0xpc3Qgc2hvdWxkIHJldHVybiBudWxs IGlmIHRoZSBpbmRleCBpcyBvdXQgb2YgcmFuZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3ODI5CisKKyAgICAgICAgV2hlbiBpdGVtKCkgcmV0dXJu cyBhIG51bGwgc3RyaW5nLCBpdCBuZWVkcyB0byBiZSBwYXNzZWQgdG8gSlMgYXMKKyAgICAgICAg bnVsbC4gVGhlIGluZGV4ZWQgZ2V0dGVyIHdpbGwgdGhlbiBtYWdpY2FsbHkgZG8gdGhlIHJpZ2h0 IHRoaW5nLgorICAgICAgICBTbyBhbGwgdGhhdCdzIGxlZnQgaXMgaGF2aW5nIERPTVN0cmluZ0xp c3Q6Oml0ZW0oKSByZXR1cm4gbnVsbCB3aGVuCisgICAgICAgIHRoZSBpbmRleCBpcyBvdXQgb2Yg Ym91bmRzLgorCisgICAgICAgICogZG9tL0RPTVN0cmluZ0xpc3QuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6RE9NU3RyaW5nTGlzdDo6aXRlbSk6CisgICAgICAgICogZG9tL0RPTVN0cmluZ0xpc3Qu aDoKKyAgICAgICAgKiBkb20vRE9NU3RyaW5nTGlzdC5pZGw6CisKIDIwMTAtMTAtMTcgIFNpbW9u IEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg Tmlrb2xhcyBaaW1tZXJtYW5uLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9kb20vRE9NU3RyaW5nTGlz dC5jcHAgYi9XZWJDb3JlL2RvbS9ET01TdHJpbmdMaXN0LmNwcAppbmRleCA2NjBiZTkyMTEwN2Mw OTkzNDdhODRjOTc4NGVjN2I4Mzg2ZDA4MWEzLi40MzAyNjVhZGIzNTkxZDcxYWQ1Nzk3ZDg1YzQ1 OTlkNGQ0YjBkMGVhIDEwMDY0NAotLS0gYS9XZWJDb3JlL2RvbS9ET01TdHJpbmdMaXN0LmNwcAor KysgYi9XZWJDb3JlL2RvbS9ET01TdHJpbmdMaXN0LmNwcApAQCAtMjgsNiArMjgsMTMgQEAKIAog bmFtZXNwYWNlIFdlYkNvcmUgewogCitTdHJpbmcgRE9NU3RyaW5nTGlzdDo6aXRlbSh1bnNpZ25l ZCBpbmRleCkgY29uc3QKK3sKKyAgICBpZiAoaW5kZXggPj0gbV9zdHJpbmdzLnNpemUoKSkKKyAg ICAgICAgcmV0dXJuIFN0cmluZygpOworICAgIHJldHVybiBtX3N0cmluZ3NbaW5kZXhdOworfQor CiBib29sIERPTVN0cmluZ0xpc3Q6OmNvbnRhaW5zKGNvbnN0IFN0cmluZyYgc3RyaW5nKSBjb25z dAogewogICAgIC8vIEZJWE1FOiBDdXJyZW50bHksIGFsbCBjb25zdW1lcnMgb2YgRE9NU3RyaW5n TGlzdCBzdG9yZSBmYWlybHkgc21hbGwgbGlzdHMgYW5kIHRodXMgYW4gTyhuKQpkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9kb20vRE9NU3RyaW5nTGlzdC5oIGIvV2ViQ29yZS9kb20vRE9NU3RyaW5nTGlz dC5oCmluZGV4IGEzZjliNDBiMzg0NTcxYTg1YTQwNTU0YWEyMDIyZTZmYjY0NmE0YTEuLjY3MTlm MTc5YWJlMzZiZmFhMDM5YWRlNmI5OGEyNGQ5NmVjN2RkZGMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUv ZG9tL0RPTVN0cmluZ0xpc3QuaAorKysgYi9XZWJDb3JlL2RvbS9ET01TdHJpbmdMaXN0LmgKQEAg LTQ4LDcgKzQ4LDcgQEAgcHVibGljOgogCiAgICAgLy8gSW1wbGVtZW50cyB0aGUgSURMLgogICAg IHNpemVfdCBsZW5ndGgoKSBjb25zdCB7IHJldHVybiBtX3N0cmluZ3Muc2l6ZSgpOyB9Ci0gICAg U3RyaW5nIGl0ZW0odW5zaWduZWQgaW5kZXgpIGNvbnN0IHsgcmV0dXJuIG1fc3RyaW5nc1tpbmRl eF07IH0KKyAgICBTdHJpbmcgaXRlbSh1bnNpZ25lZCBpbmRleCkgY29uc3Q7CiAgICAgYm9vbCBj b250YWlucyhjb25zdCBTdHJpbmcmIHN0cikgY29uc3Q7CiAKIHByaXZhdGU6CmRpZmYgLS1naXQg YS9XZWJDb3JlL2RvbS9ET01TdHJpbmdMaXN0LmlkbCBiL1dlYkNvcmUvZG9tL0RPTVN0cmluZ0xp c3QuaWRsCmluZGV4IDI3MWM5ZGVhNmM5OTI5MjBkNGU0NTQ1Y2JlNTA5NGY3OGZhNWI1YWUuLmM5 ZTVjMjk1NjIwYzczNWNmMDZlMGUzZjdkZTdlZTZiOWJlYmMwM2UgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvZG9tL0RPTVN0cmluZ0xpc3QuaWRsCisrKyBiL1dlYkNvcmUvZG9tL0RPTVN0cmluZ0xpc3Qu aWRsCkBAIC0zMCw3ICszMCw3IEBAIG1vZHVsZSBjb3JlIHsKICAgICAgICAgSGFzSW5kZXhHZXR0 ZXIKICAgICBdIERPTVN0cmluZ0xpc3QgewogICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgdW5z aWduZWQgbG9uZyBsZW5ndGg7Ci0gICAgICAgIERPTVN0cmluZyBpdGVtKGluIFtJc0luZGV4XSB1 bnNpZ25lZCBsb25nIGluZGV4KTsKKyAgICAgICAgW0NvbnZlcnROdWxsU3RyaW5nVG89TnVsbF0g RE9NU3RyaW5nIGl0ZW0oaW4gW0lzSW5kZXhdIHVuc2lnbmVkIGxvbmcgaW5kZXgpOwogICAgICAg ICBib29sZWFuIGNvbnRhaW5zKGluIERPTVN0cmluZyBzdHJpbmcpOwogICAgIH07CiAK