47827 2010-10-18 09:25:54 -0700 Web Inspector: disable private browsing for inspector 2010-10-18 11:06:22 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 podivilov podivilov abarth apavlov bweinstein eric joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 295543 0 podivilov 2010-10-18 09:25:54 -0700 Currently private browsing is enabled for inspector which makes localStorage inaccessible. Comment says it's done to keep inspector out of history, but even with private browsing disabled, inspector don't appear in history. Debugging safari showed that inspector's WebView doesn't have history delegate, but I'm not sure because history delegate is assigned in private safari code. Joseph, could you please check if inspector doesn't have history delegate and thus private browsing isn't needed for inspector? 295548 1 71046 podivilov 2010-10-18 09:28:44 -0700 Created attachment 71046 Patch. 295557 2 joepeck 2010-10-18 09:41:52 -0700 Timothy would be more likely to know. I'll see what I can find. 295563 3 joepeck 2010-10-18 09:45:33 -0700 By the way, your patch should remove the comment if it is no longer true. =) 295570 4 71046 timothy 2010-10-18 09:50:06 -0700 Comment on attachment 71046 Patch. I do think this is correct now, since we have the history delegate concept and there isn't one hooked up to the Inspector. Assuming you tested and didn't see it show up in Safari's History menu. 295574 5 71046 podivilov 2010-10-18 09:58:03 -0700 Comment on attachment 71046 Patch. cq- to address Joseph's comment. 295592 6 podivilov 2010-10-18 10:22:23 -0700 Committed r69969: <http://trac.webkit.org/changeset/69969> 295622 7 webkit.review.bot 2010-10-18 11:06:22 -0700 http://trac.webkit.org/changeset/69969 might have broken Qt Windows 32-bit Release 71046 2010-10-18 09:28:44 -0700 2010-10-18 09:58:03 -0700 Patch. patch text/plain 2431 podivilov ZGlmZiAtLWdpdCBhL1dlYktpdC9tYWMvQ2hhbmdlTG9nIGIvV2ViS2l0L21hYy9DaGFuZ2VMb2cK aW5kZXggZTliMmU3YS4uMTU0Y2E0ZiAxMDA2NDQKLS0tIGEvV2ViS2l0L21hYy9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L21hYy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0xMC0xOCAg UGF2ZWwgUG9kaXZpbG92ICA8cG9kaXZpbG92QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBkaXNhYmxl IHByaXZhdGUgYnJvd3NpbmcgZm9yIGluc3BlY3RvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDc4MjcKKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0 L1dlYkluc3BlY3RvckNsaWVudC5tbToKKyAgICAgICAgKC1bV2ViSW5zcGVjdG9yV2luZG93Q29u dHJvbGxlciBpbml0XSk6CisKIDIwMTAtMTAtMTQgIElseWEgVGlraG9ub3Zza3kgIDxsb2lzbG9A Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFBhdmVsIEZlbGRtYW4uCmRpZmYg LS1naXQgYS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYkluc3BlY3RvckNsaWVudC5tbSBi L1dlYktpdC9tYWMvV2ViQ29yZVN1cHBvcnQvV2ViSW5zcGVjdG9yQ2xpZW50Lm1tCmluZGV4IGQw YzZjNzguLjU0ZWRhZTQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9tYWMvV2ViQ29yZVN1cHBvcnQvV2Vi SW5zcGVjdG9yQ2xpZW50Lm1tCisrKyBiL1dlYktpdC9tYWMvV2ViQ29yZVN1cHBvcnQvV2ViSW5z cGVjdG9yQ2xpZW50Lm1tCkBAIC0yMjEsNyArMjIxLDYgQEAgdm9pZCBXZWJJbnNwZWN0b3JGcm9u dGVuZENsaWVudDo6dXBkYXRlV2luZG93VGl0bGUoKSBjb25zdAogCiAgICAgV2ViUHJlZmVyZW5j ZXMgKnByZWZlcmVuY2VzID0gW1tXZWJQcmVmZXJlbmNlcyBhbGxvY10gaW5pdF07CiAgICAgW3By ZWZlcmVuY2VzIHNldEF1dG9zYXZlczpOT107Ci0gICAgW3ByZWZlcmVuY2VzIHNldFByaXZhdGVC cm93c2luZ0VuYWJsZWQ6WUVTXTsKICAgICBbcHJlZmVyZW5jZXMgc2V0TG9hZHNJbWFnZXNBdXRv bWF0aWNhbGx5OllFU107CiAgICAgW3ByZWZlcmVuY2VzIHNldEF1dGhvckFuZFVzZXJTdHlsZXNF bmFibGVkOllFU107CiAgICAgW3ByZWZlcmVuY2VzIHNldEphdmFTY3JpcHRFbmFibGVkOllFU107 CmRpZmYgLS1naXQgYS9XZWJLaXQvd2luL0NoYW5nZUxvZyBiL1dlYktpdC93aW4vQ2hhbmdlTG9n CmluZGV4IDJiNGU1MDEuLjBiNjlmNWEgMTAwNjQ0Ci0tLSBhL1dlYktpdC93aW4vQ2hhbmdlTG9n CisrKyBiL1dlYktpdC93aW4vQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMTAtMTgg IFBhdmVsIFBvZGl2aWxvdiAgPHBvZGl2aWxvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogZGlzYWJs ZSBwcml2YXRlIGJyb3dzaW5nIGZvciBpbnNwZWN0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3ODI3CisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9y dC9XZWJJbnNwZWN0b3JDbGllbnQuY3BwOgorICAgICAgICAoV2ViSW5zcGVjdG9yQ2xpZW50Ojpv cGVuSW5zcGVjdG9yRnJvbnRlbmQpOgorCiAyMDEwLTEwLTE3ICBBZGFtIEJhcnRoICA8YWJhcnRo QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGltaXRyaSBHbGF6a292LgpkaWZm IC0tZ2l0IGEvV2ViS2l0L3dpbi9XZWJDb3JlU3VwcG9ydC9XZWJJbnNwZWN0b3JDbGllbnQuY3Bw IGIvV2ViS2l0L3dpbi9XZWJDb3JlU3VwcG9ydC9XZWJJbnNwZWN0b3JDbGllbnQuY3BwCmluZGV4 IGI5MmE4MTYuLmMzNjAzYjQgMTAwNjQ0Ci0tLSBhL1dlYktpdC93aW4vV2ViQ29yZVN1cHBvcnQv V2ViSW5zcGVjdG9yQ2xpZW50LmNwcAorKysgYi9XZWJLaXQvd2luL1dlYkNvcmVTdXBwb3J0L1dl Ykluc3BlY3RvckNsaWVudC5jcHAKQEAgLTEyNiw4ICsxMjYsNiBAQCB2b2lkIFdlYkluc3BlY3Rv ckNsaWVudDo6b3Blbkluc3BlY3RvckZyb250ZW5kKEluc3BlY3RvckNvbnRyb2xsZXIqIGluc3Bl Y3RvckNvbgogICAgICAgICByZXR1cm47CiAgICAgaWYgKEZBSUxFRChwcmVmZXJlbmNlcy0+c2V0 QXV0b3NhdmVzKEZBTFNFKSkpCiAgICAgICAgIHJldHVybjsKLSAgICBpZiAoRkFJTEVEKHByZWZl cmVuY2VzLT5zZXRQcml2YXRlQnJvd3NpbmdFbmFibGVkKFRSVUUpKSkKLSAgICAgICAgcmV0dXJu OwogICAgIGlmIChGQUlMRUQocHJlZmVyZW5jZXMtPnNldExvYWRzSW1hZ2VzQXV0b21hdGljYWxs eShUUlVFKSkpCiAgICAgICAgIHJldHVybjsKICAgICBpZiAoRkFJTEVEKHByZWZlcmVuY2VzLT5z ZXRBdXRob3JBbmRVc2VyU3R5bGVzRW5hYmxlZChUUlVFKSkpCg==