47816 2010-10-18 05:50:55 -0700 Remove some unnecessary lines of code from Parser.cpp 2010-10-18 06:20:47 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pvarga webkit-unassigned abecsi commit-queue ossy oldest_to_newest 295465 0 pvarga 2010-10-18 05:50:55 -0700 Looks like the parser/Parser.cpp includes two unused headers in JavaScriptCore: - wtf/HashSet.h - wtf/Vector.h The explicit decleration of jscyyparse(void*) function should be removed as well because we don't use a generated parser any more. 295466 1 71027 pvarga 2010-10-18 05:54:12 -0700 Created attachment 71027 proposed patch 295467 2 71027 abecsi 2010-10-18 05:56:56 -0700 Comment on attachment 71027 proposed patch LGTM. Thanks, Peter. 295470 3 71027 kling 2010-10-18 06:02:47 -0700 Comment on attachment 71027 proposed patch LGTM, too. 295476 4 71027 commit-queue 2010-10-18 06:20:42 -0700 Comment on attachment 71027 proposed patch Clearing flags on attachment: 71027 Committed r69957: <http://trac.webkit.org/changeset/69957> 295477 5 commit-queue 2010-10-18 06:20:47 -0700 All reviewed patches have been landed. Closing bug. 71027 2010-10-18 05:54:12 -0700 2010-10-18 06:20:42 -0700 proposed patch 0001-unuse-parser.patch text/plain 1259 pvarga RnJvbSAxNDEzNWM1NGVkMjFlM2U3N2U3NmNiZjk1ZTg3ZDgxNmRhNTUwZTlkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBWYXJnYSA8cHZhcmdhQGluZi51LXN6ZWdlZC5odT4K RGF0ZTogTW9uLCAxOCBPY3QgMjAxMCAwNTo1MzoyOSAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIHVu dXNlIHBhcnNlcgoKLS0tCiBKYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgICAgICAgICB8ICAgIDkg KysrKysrKysrCiBKYXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2VyLmNwcCB8ICAgIDYgLS0tLS0t CiAyIGZpbGVzIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKCmRpZmYg LS1naXQgYS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VM b2cKaW5kZXggOWQxMjY2YS4uNGRlMTZkNCAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvQ2hh bmdlTG9nCisrKyBiL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisy MDEwLTEwLTE4ICBQZXRlciBWYXJnYSAgPHB2YXJnYUBpbmYudS1zemVnZWQuaHU+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIHNvbWUgdW5u ZWNlc3NhcnkgbGluZXMgb2YgY29kZSBmcm9tIFBhcnNlci5jcHAKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3ODE2CisKKyAgICAgICAgKiBwYXJzZXIv UGFyc2VyLmNwcDoKKwogMjAxMC0xMC0xOCAgWGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQ3NhYmEgT3N6dHJvZ29uw6FjLgpkaWZmIC0tZ2l0IGEv SmF2YVNjcmlwdENvcmUvcGFyc2VyL1BhcnNlci5jcHAgYi9KYXZhU2NyaXB0Q29yZS9wYXJzZXIv UGFyc2VyLmNwcAppbmRleCBkYzJjYmU0Li5hZDg1YTdjIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0 Q29yZS9wYXJzZXIvUGFyc2VyLmNwcAorKysgYi9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2Vy LmNwcApAQCAtMjYsMTIgKzI2LDYgQEAKICNpbmNsdWRlICJEZWJ1Z2dlci5oIgogI2luY2x1ZGUg IkpTUGFyc2VyLmgiCiAjaW5jbHVkZSAiTGV4ZXIuaCIKLSNpbmNsdWRlIDx3dGYvSGFzaFNldC5o PgotI2luY2x1ZGUgPHd0Zi9WZWN0b3IuaD4KLQotI2lmbmRlZiB5eXBhcnNlCi1leHRlcm4gaW50 IGpzY3l5cGFyc2Uodm9pZCopOwotI2VuZGlmCiAKIG5hbWVzcGFjZSBKU0MgewogCi0tIAoxLjcu Mi4yCgo=