47811 2010-10-18 04:06:51 -0700 Should not save state of a detached form control 2010-10-18 22:34:15 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 tkent tkent dglazkov oldest_to_newest 295432 0 tkent 2010-10-18 04:06:51 -0700 Should not save state of a detached form control 295433 1 71019 tkent 2010-10-18 04:10:30 -0700 Created attachment 71019 Patch 295434 2 tkent 2010-10-18 04:12:59 -0700 I found this problem while I was investigating a crash issue of saveFormControlState(), http://code.google.com/p/chromium/issues/detail?id=57462 . 295480 3 71019 dglazkov 2010-10-18 06:48:43 -0700 Comment on attachment 71019 Patch Ok. 295999 4 71019 tkent 2010-10-18 22:34:07 -0700 Comment on attachment 71019 Patch Clearing flags on attachment: 71019 Committed r70027: <http://trac.webkit.org/changeset/70027> 296000 5 tkent 2010-10-18 22:34:15 -0700 All reviewed patches have been landed. Closing bug. 71019 2010-10-18 04:10:30 -0700 2010-10-18 22:34:07 -0700 Patch bug-47811-20101018201028.patch text/plain 4329 tkent ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAzMzA0N2Q1OGIwMjY1OWRjZDlkMDA4ZDVmMWMxM2FlNmE0ZGUzOTIyLi44ZDBhMzk0 NTMyODIyZDdiMzUxNTBjYjVhZmI5MTVjMjVmOGQyNmJlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTAtMTAtMTggIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNob3VsZCBub3Qgc2F2ZSBz dGF0ZSBvZiBhIGRldGFjaGVkIGZvcm0gY29udHJvbC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3ODExCisKKyAgICAgICAgKiBmYXN0L2Zvcm1zL3N0 YXRlLXNhdmUtb2YtZGV0YWNoZWQtY29udHJvbC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAg ICAqIGZhc3QvZm9ybXMvc3RhdGUtc2F2ZS1vZi1kZXRhY2hlZC1jb250cm9sLmh0bWw6IEFkZGVk LgorCiAyMDEwLTEwLTE4ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAg ICAgQWRkIG1vcmUgU2tpcHBlZCBsaXN0IGVudHJpZXMgYmVjYXVzZSBXZWJQIHJlcXVpcmVzIGFu IGV4dGVybmFsIGRlY29kZXIKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvc3Rh dGUtc2F2ZS1vZi1kZXRhY2hlZC1jb250cm9sLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zh c3QvZm9ybXMvc3RhdGUtc2F2ZS1vZi1kZXRhY2hlZC1jb250cm9sLWV4cGVjdGVkLnR4dApuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwLi5iMTA4MGY3ZmUxMjJiZDI5MDAxOTgxNWIwNzExYmQzODE5YzhhYmVlCi0tLSAvZGV2 L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9zdGF0ZS1zYXZlLW9mLWRldGFjaGVk LWNvbnRyb2wtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsNSBAQAorVGVzdCB0byBOT1Qgc2F2ZSBz dGF0ZSBvZiBhIGRldGFjaGVkIGZvcm0gY29udHJvbC4KKworUEFTUyBkb2N1bWVudC5nZXRFbGVt ZW50QnlJZCgiaW5wdXQyIikudmFsdWUgaXMgIiIKKworCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9mYXN0L2Zvcm1zL3N0YXRlLXNhdmUtb2YtZGV0YWNoZWQtY29udHJvbC5odG1sIGIvTGF5b3V0 VGVzdHMvZmFzdC9mb3Jtcy9zdGF0ZS1zYXZlLW9mLWRldGFjaGVkLWNvbnRyb2wuaHRtbApuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwLi5kMTRjNTMxOTg3YTFhMjAzNmQxNzMxOTM5MTc3OTRhZWY2NzdkOWQ1Ci0tLSAvZGV2 L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9zdGF0ZS1zYXZlLW9mLWRldGFjaGVk LWNvbnRyb2wuaHRtbApAQCAtMCwwICsxLDQ1IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgor PGhlYWQ+Cis8bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9Ii4uLy4uL2Zhc3QvanMvcmVzb3Vy Y2VzL2pzLXRlc3Qtc3R5bGUuY3NzIj4KKzxzY3JpcHQgc3JjPSIuLi8uLi9mYXN0L2pzL3Jlc291 cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keSBvbmxvYWQ9InJ1 blRlc3QoKSI+Cis8cD5UZXN0IHRvIE5PVCBzYXZlIHN0YXRlIG9mIGEgZGV0YWNoZWQgZm9ybSBj b250cm9sLjwvcD4KKzxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorCis8aW5wdXQgaWQ9ZW1wdHlP bkZpcnN0VmlzaXQ+Cis8Zm9ybSBhY3Rpb249ImRhdGE6dGV4dC9odG1sLDxzY3JpcHQ+aGlzdG9y eS5iYWNrKCkmbHQ7L3NjcmlwdD4iIGlkPWZvcm0xPgorPGlucHV0IG5hbWU9dXNlciBpZD1pbnB1 dDI+Cis8L2Zvcm0+CisKKzxzY3JpcHQ+Cit2YXIgaTE7CisKK2Z1bmN0aW9uIHJ1blRlc3QoKQor eworICAgIHZhciBmb3JtMSA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdmb3JtMScpOworICAg IHZhciBzdGF0ZSA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdlbXB0eU9uRmlyc3RWaXNpdCcp OworICAgIGlmICghc3RhdGUudmFsdWUpIHsKKyAgICAgICAgLy8gRmlyc3QgdmlzaXQuCisgICAg ICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgICAgICBsYXlvdXRU ZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7CisgICAgICAgIHN0YXRlLnZhbHVlID0gJ3Zp c2l0ZWQnOworCisgICAgICAgIGZvcm0xLmlubmVySFRNTCA9ICc8aW5wdXQgbmFtZT11c2VyIGlk PWlucHV0MT4nOworICAgICAgICBpMSA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdpbnB1dDEn KTsKKyAgICAgICAgaTEudmFsdWUgPSAndmFsdWUxJzsKKyAgICAgICAgZm9ybTEucmVtb3ZlQ2hp bGQoaTEpOworICAgICAgICAvLyBTdWJtaXQgZm9ybSBpbiBhIHRpbWVvdXQgdG8gbWFrZSBzdXJl IHRoYXQgd2UgY3JlYXRlIGEgbmV3IGJhY2svZm9yd2FyZCBsaXN0IGl0ZW0uCisgICAgICAgIHNl dFRpbWVvdXQoZnVuY3Rpb24oKSB7ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2Zvcm0xJykuc3Vi bWl0KCk7fSwgMCk7CisgICAgfSBlbHNlIHsKKyAgICAgICAgLy8gU2Vjb25kIHZpc2l0LgorICAg ICAgICBzaG91bGRCZSgnZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImlucHV0MiIpLnZhbHVlJywg JyIiJyk7IC8vIE5vdCAndmFsdWUxJy4KKworICAgICAgICBpZiAod2luZG93LmxheW91dFRlc3RD b250cm9sbGVyKQorICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgp OworICAgIH0KKyB9Cis8L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL1dl YkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDQ3ZmEwODEwZTE1ZTY5 M2Y1MWJjYzlmZWU4ZjYzZDY5MzM2YzRmMC4uNDcwZWVlMGUwZjJmYjUzYzlkMGUxYjdmMGQ4ODU3 MTdlODY4ZDNkNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0xMC0xOCAgS2VudCBUYW11cmEgIDx0a2Vu dEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgU2hvdWxkIG5vdCBzYXZlIHN0YXRlIG9mIGEgZGV0YWNoZWQgZm9ybSBjb250cm9s LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDc4MTEK KworICAgICAgICBUZXN0OiBmYXN0L2Zvcm1zL3N0YXRlLXNhdmUtb2YtZGV0YWNoZWQtY29udHJv bC5odG1sCisKKyAgICAgICAgKiBodG1sL0hUTUxGb3JtQ29udHJvbEVsZW1lbnQuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6SFRNTEZvcm1Db250cm9sRWxlbWVudFdpdGhTdGF0ZTo6c2hvdWxkU2F2 ZUFuZFJlc3RvcmVGb3JtQ29udHJvbFN0YXRlKToKKyAgICAgICAgICBJZiB0aGUgbm9kZSBpcyBk ZXRhY2hlZCwgZG9uJ3Qgc2F2ZSB0aGUgc3RhdGUuCisKIDIwMTAtMTAtMTcgIEFuZHJlYXMgS2xp bmcgIDxrbGluZ0B3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9o ZGUgQ2hyaXN0aWFuc2VuLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9odG1sL0hUTUxGb3JtQ29udHJv bEVsZW1lbnQuY3BwIGIvV2ViQ29yZS9odG1sL0hUTUxGb3JtQ29udHJvbEVsZW1lbnQuY3BwCmlu ZGV4IDEwMzRiZmMxZjQ2M2E2ODA2ZWYzZjBlMjNiODBkNDcxYTUyODI3NTEuLjUxYjllMjAyNDk2 MWU3ZTM2NDRjYmFmZTMxNjBjMzM3MTAwZDZiMGYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaHRtbC9I VE1MRm9ybUNvbnRyb2xFbGVtZW50LmNwcAorKysgYi9XZWJDb3JlL2h0bWwvSFRNTEZvcm1Db250 cm9sRWxlbWVudC5jcHAKQEAgLTQ0MCw3ICs0NDAsNyBAQCBib29sIEhUTUxGb3JtQ29udHJvbEVs ZW1lbnRXaXRoU3RhdGU6OmF1dG9Db21wbGV0ZSgpIGNvbnN0CiBib29sIEhUTUxGb3JtQ29udHJv bEVsZW1lbnRXaXRoU3RhdGU6OnNob3VsZFNhdmVBbmRSZXN0b3JlRm9ybUNvbnRyb2xTdGF0ZSgp IGNvbnN0CiB7CiAgICAgLy8gV2UgZG9uJ3Qgc2F2ZS9yZXN0b3JlIGNvbnRyb2wgc3RhdGUgaW4g YSBmb3JtIHdpdGggYXV0b2NvbXBsZXRlPW9mZi4KLSAgICByZXR1cm4gYXV0b0NvbXBsZXRlKCk7 CisgICAgcmV0dXJuIGF0dGFjaGVkKCkgJiYgYXV0b0NvbXBsZXRlKCk7CiB9CiAKIHZvaWQgSFRN TEZvcm1Db250cm9sRWxlbWVudFdpdGhTdGF0ZTo6ZmluaXNoUGFyc2luZ0NoaWxkcmVuKCkK