47805 2010-10-18 02:38:46 -0700 [GTK] Tests LayoutTests/fast/encoding/utf-32* fail when using glib unicode 2010-10-21 04:26:17 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 47990 0 cgarcia webkit-unassigned commit-queue mrobinson webkit.review.bot oldest_to_newest 295407 0 cgarcia 2010-10-18 02:38:46 -0700 When webkit is built with glib unicode instead of icu tests utf-32-big-endian-bom, utf-32-big-endian-nobom, utf-32-little-endian-bom and utf-32-little-endian-nobom under LayoutTests/fast/encoding fail because TextCodecGtk doesn't register UTF-32 encoding names. 295410 1 71011 cgarcia 2010-10-18 02:46:22 -0700 Created attachment 71011 Patch 295412 2 webkit.review.bot 2010-10-18 02:49:36 -0700 Attachment 71011 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/platform/text/gtk/TextCodecGtk.h:72: m_codecAliases_UTF_32 is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/platform/text/gtk/TextCodecGtk.h:73: m_codecAliases_UTF_32BE is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/platform/text/gtk/TextCodecGtk.h:74: m_codecAliases_UTF_32LE is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/platform/text/gtk/TextCodecGtk.cpp:59: TextCodecGtk::m_codecAliases_UTF_8 is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/platform/text/gtk/TextCodecGtk.cpp:60: TextCodecGtk::m_codecAliases_UTF_32 is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/platform/text/gtk/TextCodecGtk.cpp:61: TextCodecGtk::m_codecAliases_UTF_32BE is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/platform/text/gtk/TextCodecGtk.cpp:62: TextCodecGtk::m_codecAliases_UTF_32LE is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 7 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 295741 3 71011 mrobinson 2010-10-18 14:14:59 -0700 Comment on attachment 71011 Patch Looks good, but please fix all the variable names (e.g. m_codecAliases_UTF_8 --> m_codecAliasesUTF8). Thanks. 297298 4 71407 cgarcia 2010-10-21 01:59:55 -0700 Created attachment 71407 Updated patch for current git master 297299 5 71407 mrobinson 2010-10-21 02:01:29 -0700 Comment on attachment 71407 Updated patch for current git master Much nicer! 297367 6 71407 commit-queue 2010-10-21 04:26:11 -0700 Comment on attachment 71407 Updated patch for current git master Clearing flags on attachment: 71407 Committed r70227: <http://trac.webkit.org/changeset/70227> 297368 7 commit-queue 2010-10-21 04:26:17 -0700 All reviewed patches have been landed. Closing bug. 71011 2010-10-18 02:46:22 -0700 2010-10-21 01:59:55 -0700 Patch utf-32-tests.diff text/plain 2587 cgarcia ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NGZkOTUzMi4uZmYzYjNiMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0xMC0xOCAgQ2FybG9zIEdhcmNp YSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gVGVzdHMgTGF5b3V0VGVzdHMvZmFzdC9lbmNv ZGluZy91dGYtMzIqIGZhaWwgd2hlbiB1c2luZyBnbGliIHVuaWNvZGUKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3ODA1CisKKyAgICAgICAgUmVnaXN0 ZXIgVVRGLTMyIG5hbWUgZW5jb25kaW5ncyBpbiBUZXh0Q29kZWNHdGsuCisKKyAgICAgICAgKiBw bGF0Zm9ybS90ZXh0L2d0ay9UZXh0Q29kZWNHdGsuY3BwOgorICAgICAgICAqIHBsYXRmb3JtL3Rl eHQvZ3RrL1RleHRDb2RlY0d0ay5oOgorCiAyMDEwLTEwLTE1ICBTZXJnaW8gVmlsbGFyIFNlbmlu ICA8c3ZpbGxhckBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFhhbiBMb3Blei4K ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9ndGsvVGV4dENvZGVjR3RrLmNwcCBi L1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9ndGsvVGV4dENvZGVjR3RrLmNwcAppbmRleCA0MjI0YzBj Li5hMTU0MGJlIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvZ3RrL1RleHRDb2Rl Y0d0ay5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L2d0ay9UZXh0Q29kZWNHdGsuY3Bw CkBAIC01Niw3ICs1NiwxMCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAvLyBFYWNoIGFsaWFzIGxp c3QgbXVzdCBiZSB0ZXJtaW5hdGVkIGJ5IGEgMC4KIAogLy8gVW5pY29kZQotVGV4dENvZGVjR3Rr Ojpjb2RlY0FsaWFzTGlzdCBUZXh0Q29kZWNHdGs6Om1fY29kZWNBbGlhc2VzX1VURl84ICAgICAg ICAgICAgPSB7ICJVVEYtOCIsIDAgfTsgCitUZXh0Q29kZWNHdGs6OmNvZGVjQWxpYXNMaXN0IFRl eHRDb2RlY0d0azo6bV9jb2RlY0FsaWFzZXNfVVRGXzggICAgICAgICAgICA9IHsgIlVURi04Iiwg MCB9OworVGV4dENvZGVjR3RrOjpjb2RlY0FsaWFzTGlzdCBUZXh0Q29kZWNHdGs6Om1fY29kZWNB bGlhc2VzX1VURl8zMiAgICAgICAgICAgPSB7ICJVVEYtMzIiLCAwIH07CitUZXh0Q29kZWNHdGs6 OmNvZGVjQWxpYXNMaXN0IFRleHRDb2RlY0d0azo6bV9jb2RlY0FsaWFzZXNfVVRGXzMyQkUgICAg ICAgICA9IHsgIlVURi0zMkJFIiwgMCB9OworVGV4dENvZGVjR3RrOjpjb2RlY0FsaWFzTGlzdCBU ZXh0Q29kZWNHdGs6Om1fY29kZWNBbGlhc2VzX1VURl8zMkxFICAgICAgICAgPSB7ICJVVEYtMzJM RSIsIDAgfTsKIAogLy8gV2VzdGVybgogVGV4dENvZGVjR3RrOjpjb2RlY0FsaWFzTGlzdCBUZXh0 Q29kZWNHdGs6Om1fY29kZWNBbGlhc2VzX0lTT184ODU5XzEgICAgICAgPSB7ICJJU08tODg1OS0x IiwgIkNQODE5IiwgIklCTTgxOSIsICJJU08tSVItMTAwIiwgIklTTzg4NTktMSIsICJJU09fODg1 OS0xIiwgIklTT184ODU5LTE6MTk4NyIsICAiTDEiLCAiTEFUSU4xIiwgIkNTSVNPTEFUSU4xIiwg MCB9OwpAQCAtMTI4LDYgKzEzMSw5IEBAIFRleHRDb2RlY0d0azo6Y29kZWNBbGlhc0xpc3QgVGV4 dENvZGVjR3RrOjptX2NvZGVjQWxpYXNlc19JU09fODg1OV80ICAgICAgID0geyAiCiBnY29uc3Rw b2ludGVyIGNvbnN0IFRleHRDb2RlY0d0azo6bV9pY29udkJhc2VDb2RlY0xpc3RbXSA9IHsgCiAg ICAgLy8gVW5pY29kZQogICAgICZtX2NvZGVjQWxpYXNlc19VVEZfOCwKKyAgICAmbV9jb2RlY0Fs aWFzZXNfVVRGXzMyLAorICAgICZtX2NvZGVjQWxpYXNlc19VVEZfMzJCRSwKKyAgICAmbV9jb2Rl Y0FsaWFzZXNfVVRGXzMyTEUsCiAKICAgICAvLyBXZXN0ZXJuCiAgICAgJm1fY29kZWNBbGlhc2Vz X0lTT184ODU5XzEKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9ndGsvVGV4dENv ZGVjR3RrLmggYi9XZWJDb3JlL3BsYXRmb3JtL3RleHQvZ3RrL1RleHRDb2RlY0d0ay5oCmluZGV4 IGE4YWY3NTIuLjQ2MmJkY2UgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9ndGsv VGV4dENvZGVjR3RrLmgKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L2d0ay9UZXh0Q29kZWNH dGsuaApAQCAtNjksNiArNjksOSBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKICAgICAgICAgLy8g VW5pY29kZQogICAgICAgICBzdGF0aWMgY29kZWNBbGlhc0xpc3QgbV9jb2RlY0FsaWFzZXNfVVRG Xzg7CisgICAgICAgIHN0YXRpYyBjb2RlY0FsaWFzTGlzdCBtX2NvZGVjQWxpYXNlc19VVEZfMzI7 CisgICAgICAgIHN0YXRpYyBjb2RlY0FsaWFzTGlzdCBtX2NvZGVjQWxpYXNlc19VVEZfMzJCRTsK KyAgICAgICAgc3RhdGljIGNvZGVjQWxpYXNMaXN0IG1fY29kZWNBbGlhc2VzX1VURl8zMkxFOwog CiAgICAgICAgIC8vIFdlc3Rlcm4KICAgICAgICAgc3RhdGljIGNvZGVjQWxpYXNMaXN0IG1fY29k ZWNBbGlhc2VzX0lTT184ODU5XzE7Cg== 71407 2010-10-21 01:59:55 -0700 2010-10-21 04:26:11 -0700 Updated patch for current git master utf32.diff text/plain 1852 cgarcia ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MWM3YjM5Ny4uYjYwMjE1OSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxOCBAQAogMjAxMC0xMC0yMSAgQ2FybG9zIEdhcmNp YSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gVGVzdHMgTGF5b3V0VGVzdHMvZmFzdC9lbmNv ZGluZy91dGYtMzIqIGZhaWwgd2hlbiB1c2luZyBnbGliIHVuaWNvZGUKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3ODA1CisKKyAgICAgICAgUmVnaXN0 ZXIgVVRGLTMyIGVuY29kaW5ncyBpbiBUZXh0Q29kZWNHdGsuCisKKyAgICAgICAgKiBwbGF0Zm9y bS90ZXh0L2d0ay9UZXh0Q29kZWNHdGsuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VGV4dENvZGVj R3RrOjpyZWdpc3RlckJhc2VFbmNvZGluZ05hbWVzKToKKyAgICAgICAgKFdlYkNvcmU6OlRleHRD b2RlY0d0azo6cmVnaXN0ZXJCYXNlQ29kZWNzKToKKworMjAxMC0xMC0yMSAgQ2FybG9zIEdhcmNp YSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFy dGluIFJvYmluc29uLgogCiAgICAgICAgIFtHVEtdIFJlcGxhY2UgZW5jb2RpbmdzIG11bHRpLWRp bWVuc2lvbmFsIGFycmF5IHdpdGggY2FsbHMgdG8gcmVnaXN0cmFyIG1ldGhvZApkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L2d0ay9UZXh0Q29kZWNHdGsuY3BwIGIvV2ViQ29yZS9w bGF0Zm9ybS90ZXh0L2d0ay9UZXh0Q29kZWNHdGsuY3BwCmluZGV4IDRkYWRjZjIuLjVmYTM4ZTIg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9ndGsvVGV4dENvZGVjR3RrLmNwcAor KysgYi9XZWJDb3JlL3BsYXRmb3JtL3RleHQvZ3RrL1RleHRDb2RlY0d0ay5jcHAKQEAgLTEwNSw2 ICsxMDUsOSBAQCB2b2lkIFRleHRDb2RlY0d0azo6cmVnaXN0ZXJCYXNlRW5jb2RpbmdOYW1lcyhF bmNvZGluZ05hbWVSZWdpc3RyYXIgcmVnaXN0cmFyKQogewogICAgIC8vIFVuaWNvZGUKICAgICBy ZWdpc3RlckVuY29kaW5nTmFtZUlmQXZhaWxhYmxlKHJlZ2lzdHJhciwgIlVURi04Iik7CisgICAg cmVnaXN0ZXJFbmNvZGluZ05hbWVJZkF2YWlsYWJsZShyZWdpc3RyYXIsICJVVEYtMzIiKTsKKyAg ICByZWdpc3RlckVuY29kaW5nTmFtZUlmQXZhaWxhYmxlKHJlZ2lzdHJhciwgIlVURi0zMkJFIik7 CisgICAgcmVnaXN0ZXJFbmNvZGluZ05hbWVJZkF2YWlsYWJsZShyZWdpc3RyYXIsICJVVEYtMzJM RSIpOwogCiAgICAgLy8gV2VzdGVybgogICAgIGlmIChyZWdpc3RlckVuY29kaW5nTmFtZUlmQXZh aWxhYmxlKHJlZ2lzdHJhciwgIklTTy04ODU5LTEiKSkgewpAQCAtMTI0LDYgKzEyNyw5IEBAIHZv aWQgVGV4dENvZGVjR3RrOjpyZWdpc3RlckJhc2VDb2RlY3MoVGV4dENvZGVjUmVnaXN0cmFyIHJl Z2lzdHJhcikKIHsKICAgICAvLyBVbmljb2RlCiAgICAgcmVnaXN0ZXJDb2RlY0lmQXZhaWxhYmxl KHJlZ2lzdHJhciwgIlVURi04Iik7CisgICAgcmVnaXN0ZXJDb2RlY0lmQXZhaWxhYmxlKHJlZ2lz dHJhciwgIlVURi0zMiIpOworICAgIHJlZ2lzdGVyQ29kZWNJZkF2YWlsYWJsZShyZWdpc3RyYXIs ICJVVEYtMzJCRSIpOworICAgIHJlZ2lzdGVyQ29kZWNJZkF2YWlsYWJsZShyZWdpc3RyYXIsICJV VEYtMzJMRSIpOwogCiAgICAgLy8gV2VzdGVybgogICAgIHJlZ2lzdGVyQ29kZWNJZkF2YWlsYWJs ZShyZWdpc3RyYXIsICJJU08tODg1OS0xIik7Cg==