47801 2010-10-18 00:01:18 -0700 Build broken with JIT disabled 2010-10-18 00:43:46 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 47788 1 xan.lopez webkit-unassigned xan.lopez oldest_to_newest 295373 0 xan.lopez 2010-10-18 00:01:18 -0700 r69940 broke it I believe. Attached patch seems like the reasonable fix. 295375 1 71005 xan.lopez 2010-10-18 00:04:34 -0700 Created attachment 71005 Patch 295376 2 71005 xan.lopez 2010-10-18 00:05:22 -0700 Comment on attachment 71005 Patch Wrong patch... 295377 3 71006 xan.lopez 2010-10-18 00:05:45 -0700 Created attachment 71006 fixbuild.diff 295380 4 71006 xan.lopez 2010-10-18 00:40:13 -0700 Comment on attachment 71006 fixbuild.diff Ossy suggested on IRC to just drop the const and r+ that, so I pushed it as r69944. 71005 2010-10-18 00:04:34 -0700 2010-10-18 00:05:22 -0700 Patch bug-47801-20101018160432.patch text/plain 1359 xan.lopez ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCAxOTA4NDdlZWNhOWE1NDk4YzVlZmUwNzJlYzhlM2RhYWM2NjIyMGUzLi5l MzhjOTc3NTE3ODMzYTlhZDNmN2JlNjgxNDM0NzBjNmMzMWUwNDI3IDEwMDY0NAotLS0gYS9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTMgQEAKKzIwMTAtMTAtMTUgIFhhbiBMb3BleiAgPHhsb3BlekBpZ2FsaWEuY29tPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFTU0VSVCBp biB0d2l0dGVyLmNvbSB3aXRoIEpJVCBkaXNhYmxlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDc3MTgKKworICAgICAgICAqIGludGVycHJldGVyL0lu dGVycHJldGVyLmNwcDoKKyAgICAgICAgKEpTQzo6SW50ZXJwcmV0ZXI6OnByaXZhdGVFeGVjdXRl KTogZG8gbm90IHVzZSBhY3RpdmF0aW9uVmFsdWUgaWYgaXQncyBub3Qgc2V0LgorCiAyMDEwLTEw LTE3ICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgU2FtIFdlaW5pZy4KZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0lu dGVycHJldGVyLmNwcCBiL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0ludGVycHJldGVyLmNw cAppbmRleCAxNDIwNGNlNmI3Y2Y1MzVjZDlmYzBmM2VmN2Y5ZjFjYjE2NTdhMTQxLi5hZjg1NGM0 YmM4N2Q3ZTU0ZjQyMjNmOGQzMDQ3ZjBkNzgwOTg4M2Q5IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0 Q29yZS9pbnRlcnByZXRlci9JbnRlcnByZXRlci5jcHAKKysrIGIvSmF2YVNjcmlwdENvcmUvaW50 ZXJwcmV0ZXIvSW50ZXJwcmV0ZXIuY3BwCkBAIC00MDg1LDcgKzQwODUsNyBAQCBza2lwX2lkX2N1 c3RvbV9zZWxmOgogICAgICAgICAgICAgYXNBcmd1bWVudHMoYXJndW1lbnRzVmFsdWUpLT5jb3B5 UmVnaXN0ZXJzKCk7CiAKICAgICAgICAgaWYgKEpTVmFsdWUgYXJndW1lbnRzVmFsdWUgPSBjYWxs RnJhbWUtPnIodW5tb2RpZmllZEFyZ3VtZW50c1JlZ2lzdGVyKGFyZ3VtZW50cykpLmpzVmFsdWUo KSkgewotICAgICAgICAgICAgaWYgKCFjb2RlQmxvY2stPmlzU3RyaWN0TW9kZSgpKQorICAgICAg ICAgICAgaWYgKGFjdGl2YXRpb25WYWx1ZSAmJiAhY29kZUJsb2NrLT5pc1N0cmljdE1vZGUoKSkK ICAgICAgICAgICAgICAgICBhc0FyZ3VtZW50cyhhcmd1bWVudHNWYWx1ZSktPnNldEFjdGl2YXRp b24oYXNBY3RpdmF0aW9uKGFjdGl2YXRpb25WYWx1ZSkpOwogICAgICAgICB9CiAK 71006 2010-10-18 00:05:45 -0700 2010-10-18 00:40:13 -0700 fixbuild.diff fixbuild.diff text/plain 1931 xan.lopez RnJvbSBlZmY0ZDI1NTQ1MGYzMzQyZWE2ZmZkNzIyMTQ1NzRjMzJjMDliMTA2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhsb3BlekBpZ2FsaWEuY29tPgpEYXRlOiBN b24sIDE4IE9jdCAyMDEwIDE2OjAzOjAzICswOTAwClN1YmplY3Q6IFtQQVRDSF0gMjAxMC0xMC0x OCAgWGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CgogICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgoKICAgICAgICBCdWlsZCBicm9rZW4gd2l0aCBKSVQgZGlzYWJsZWQKICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDc4MDEKCiAgICAg ICAgKiBpbnRlcnByZXRlci9JbnRlcnByZXRlci5jcHA6CiAgICAgICAgKEpTQzo6SW50ZXJwcmV0 ZXI6OnJlc29sdmVCYXNlKToKLS0tCiBKYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgICAgICAgICAg ICAgICAgICAgfCAgIDEwICsrKysrKysrKysKIEphdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0lu dGVycHJldGVyLmNwcCB8ICAgIDIgKy0KIDIgZmlsZXMgY2hhbmdlZCwgMTEgaW5zZXJ0aW9ucygr KSwgMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cg Yi9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggZTM4Yzk3Ny4uZGFmZGNlNiAxMDA2NDQK LS0tIGEvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL0phdmFTY3JpcHRDb3JlL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEwLTEwLTE4ICBYYW4gTG9wZXogIDx4bG9wZXpAaWdh bGlhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBCdWlsZCBicm9rZW4gd2l0aCBKSVQgZGlzYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3ODAxCisKKyAgICAgICAgKiBpbnRlcnByZXRlci9J bnRlcnByZXRlci5jcHA6CisgICAgICAgIChKU0M6OkludGVycHJldGVyOjpyZXNvbHZlQmFzZSk6 CisKIDIwMTAtMTAtMTUgIFhhbiBMb3BleiAgPHhsb3BlekBpZ2FsaWEuY29tPgogCiAgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUv aW50ZXJwcmV0ZXIvSW50ZXJwcmV0ZXIuY3BwIGIvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIv SW50ZXJwcmV0ZXIuY3BwCmluZGV4IGFmODU0YzQuLjM2ZWQ1OGQgMTAwNjQ0Ci0tLSBhL0phdmFT Y3JpcHRDb3JlL2ludGVycHJldGVyL0ludGVycHJldGVyLmNwcAorKysgYi9KYXZhU2NyaXB0Q29y ZS9pbnRlcnByZXRlci9JbnRlcnByZXRlci5jcHAKQEAgLTI4Miw3ICsyODIsNyBAQCBORVZFUl9J TkxJTkUgdm9pZCBJbnRlcnByZXRlcjo6cmVzb2x2ZUJhc2UoQ2FsbEZyYW1lKiBjYWxsRnJhbWUs IEluc3RydWN0aW9uKiB2UAogICAgIGludCBwcm9wZXJ0eSA9IHZQQ1syXS51Lm9wZXJhbmQ7CiAg ICAgYm9vbCBpc1N0cmljdFB1dCA9IHZQQ1szXS51Lm9wZXJhbmQ7CiAgICAgY29uc3QgSWRlbnRp ZmllciBpZGVudCA9IGNhbGxGcmFtZS0+Y29kZUJsb2NrKCktPmlkZW50aWZpZXIocHJvcGVydHkp OwotICAgIEpTVmFsdWUgcmVzdWx0ID0gSlNDOjpyZXNvbHZlQmFzZShjYWxsRnJhbWUsIGlkZW50 LCBjYWxsRnJhbWUtPnNjb3BlQ2hhaW4oKSwgaXNTdHJpY3RQdXQpOworICAgIEpTVmFsdWUgcmVz dWx0ID0gSlNDOjpyZXNvbHZlQmFzZShjYWxsRnJhbWUsIGNvbnN0X2Nhc3Q8SWRlbnRpZmllciY+ KGlkZW50KSwgY2FsbEZyYW1lLT5zY29wZUNoYWluKCksIGlzU3RyaWN0UHV0KTsKICAgICBpZiAo IXJlc3VsdCkgewogICAgICAgICBjYWxsRnJhbWUtPnIoZHN0KSA9IHJlc3VsdDsKICAgICAgICAg QVNTRVJUKGNhbGxGcmFtZS0+cihkc3QpLmpzVmFsdWUoKSk7Ci0tIAoxLjcuMi4zCgo=