47795 2010-10-17 22:38:12 -0700 Add a test to nodesFromRect involving links and text nodes 2010-10-19 14:16:04 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 tonikitoo tonikitoo kenneth simon.fraser oldest_to_newest 295346 0 tonikitoo 2010-10-17 22:38:12 -0700 ... 295975 1 71129 tonikitoo 2010-10-18 21:40:35 -0700 Created attachment 71129 (committed r70058, r=kenneth) patch v1 - Improves the test coverage for nodesFromRect. Similarly to bug 47766 (Enrich /fast/dom/nodesFromRect-basic.html test, this patch continues to improve the test coverage for Document::nodesFromRect. This time tests involving links and text nodes are being added this time. Basically it performs various rect hit tests involving the positions of the elements. 296201 2 71129 tonikitoo 2010-10-19 08:13:11 -0700 Comment on attachment 71129 (committed r70058, r=kenneth) patch v1 - Improves the test coverage for nodesFromRect. Clearing flags on attachment: 71129 Committed r70058: <http://trac.webkit.org/changeset/70058> 296378 3 tonikitoo 2010-10-19 13:50:41 -0700 Complementary fixes landed in: http://trac.webkit.org/changeset/70078 (renamed xxx-expected.html to xxx-expected.txt) http://trac.webkit.org/changeset/70080 (skipped the test on gtk, qt and windows). 296400 4 tonikitoo 2010-10-19 14:16:04 -0700 ... and http://trac.webkit.org/changeset/70086 (skipped the proper files on Qt, Win and Gtk's DRT). (In reply to comment #3) > Complementary fixes landed in: > > http://trac.webkit.org/changeset/70078 (renamed xxx-expected.html to xxx-expected.txt) > http://trac.webkit.org/changeset/70080 (skipped the test on gtk, qt and windows). 71129 2010-10-18 21:40:35 -0700 2010-10-19 08:14:26 -0700 (committed r70058, r=kenneth) patch v1 - Improves the test coverage for nodesFromRect. 0001-2010-10-18-Antonio-Gomes-agomes-rim.com.patch text/plain 5505 tonikitoo RnJvbSAyMDg3ZmE4MDhhNmVlYWZiNjMyMTdiNmU2ODRlY2M2MTIxMTU0ZDExIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K RGF0ZTogVHVlLCAxOSBPY3QgMjAxMCAwMDozNDowNCAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIDIw MTAtMTAtMTggIEFudG9uaW8gR29tZXMgIDxhZ29tZXNAcmltLmNvbT4KCiAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIEFkZCBhIHRlc3QgdG8gbm9kZXNGcm9tUmVj dCBpbnZvbHZpbmcgbGlua3MgYW5kIHRleHQgbm9kZXMKICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDc3OTUKCiAgICAgICAgU2ltaWxhcmx5IHRvIGJ1ZyA0 Nzc2NiAoRW5yaWNoIC9mYXN0L2RvbS9ub2Rlc0Zyb21SZWN0LWJhc2ljLmh0bWwgdGVzdCwKICAg ICAgICB0aGlzIHBhdGNoIGNvbnRpbnVlcyB0byBpbXByb3ZlIHRoZSB0ZXN0IGNvdmVyYWdlIGZv ciBEb2N1bWVudDo6bm9kZXNGcm9tUmVjdC4KICAgICAgICBUaGlzIHRpbWUgdGVzdHMgaW52b2x2 aW5nIGxpbmtzIGFuZCB0ZXh0IG5vZGVzIGFyZSBiZWluZyBhZGRlZCB0aGlzIHRpbWUuIEJhc2lj YWxseQogICAgICAgIGl0IHBlcmZvcm1zIHZhcmlvdXMgcmVjdCBoaXQgdGVzdHMgaW52b2x2aW5n IHRoZSBwb3NpdGlvbnMgb2YgdGhlIGVsZW1lbnRzLgoKICAgICAgICAqIGZhc3QvZG9tL25vZGVz RnJvbVJlY3QtbGlua3MtYW5kLXRleHQtZXhwZWN0ZWQuaHRtbDogQWRkZWQuCiAgICAgICAgKiBm YXN0L2RvbS9ub2Rlc0Zyb21SZWN0LWxpbmtzLWFuZC10ZXh0Lmh0bWw6IEFkZGVkLgoqIGZhc3Qv ZG9tL25vZGVzRnJvbVJlY3QtbGlua3MtYW5kLXRleHQtZXhwZWN0ZWQuaHRtbDogQWRkZWQuCiog ZmFzdC9kb20vbm9kZXNGcm9tUmVjdC1saW5rcy1hbmQtdGV4dC5odG1sOiBBZGRlZC4KLS0tCiBM YXlvdXRUZXN0cy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTUg KysrKysrCiAuLi4vZG9tL25vZGVzRnJvbVJlY3QtbGlua3MtYW5kLXRleHQtZXhwZWN0ZWQuaHRt bCB8ICAgMTMgKysrKysKIC4uLi9mYXN0L2RvbS9ub2Rlc0Zyb21SZWN0LWxpbmtzLWFuZC10ZXh0 Lmh0bWwgICAgIHwgICA1NCArKysrKysrKysrKysrKysrKysrKwogMyBmaWxlcyBjaGFuZ2VkLCA4 MiBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQogY3JlYXRlIG1vZGUgMTAwNjQ0IExheW91 dFRlc3RzL2Zhc3QvZG9tL25vZGVzRnJvbVJlY3QtbGlua3MtYW5kLXRleHQtZXhwZWN0ZWQuaHRt bAogY3JlYXRlIG1vZGUgMTAwNjQ0IExheW91dFRlc3RzL2Zhc3QvZG9tL25vZGVzRnJvbVJlY3Qt bGlua3MtYW5kLXRleHQuaHRtbAoKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBi L0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAxMTY5ODBlLi5jYjQ3NzM1IDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTggQEAKKzIwMTAtMTAtMTggIEFudG9uaW8gR29tZXMgIDxhZ29tZXNAcmltLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSB0 ZXN0IHRvIG5vZGVzRnJvbVJlY3QgaW52b2x2aW5nIGxpbmtzIGFuZCB0ZXh0IG5vZGVzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00Nzc5NQorCisgICAg ICAgIFNpbWlsYXJseSB0byBidWcgNDc3NjYgKEVucmljaCAvZmFzdC9kb20vbm9kZXNGcm9tUmVj dC1iYXNpYy5odG1sIHRlc3QsCisgICAgICAgIHRoaXMgcGF0Y2ggY29udGludWVzIHRvIGltcHJv dmUgdGhlIHRlc3QgY292ZXJhZ2UgZm9yIERvY3VtZW50Ojpub2Rlc0Zyb21SZWN0LgorICAgICAg ICBUaGlzIHRpbWUgdGVzdHMgaW52b2x2aW5nIGxpbmtzIGFuZCB0ZXh0IG5vZGVzIGFyZSBiZWlu ZyBhZGRlZCB0aGlzIHRpbWUuIEJhc2ljYWxseQorICAgICAgICBpdCBwZXJmb3JtcyB2YXJpb3Vz IHJlY3QgaGl0IHRlc3RzIGludm9sdmluZyB0aGUgcG9zaXRpb25zIG9mIHRoZSBlbGVtZW50cy4K KworICAgICAgICAqIGZhc3QvZG9tL25vZGVzRnJvbVJlY3QtbGlua3MtYW5kLXRleHQtZXhwZWN0 ZWQuaHRtbDogQWRkZWQuCisgICAgICAgICogZmFzdC9kb20vbm9kZXNGcm9tUmVjdC1saW5rcy1h bmQtdGV4dC5odG1sOiBBZGRlZC4KKwogMjAxMC0xMC0xOCAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJA YXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9ub2Rlc0Zyb21SZWN0LWxpbmtzLWFuZC10ZXh0LWV4cGVj dGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9ub2Rlc0Zyb21SZWN0LWxpbmtzLWFuZC10 ZXh0LWV4cGVjdGVkLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uYzli ZDk2ZQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL25vZGVzRnJvbVJl Y3QtbGlua3MtYW5kLXRleHQtZXhwZWN0ZWQuaHRtbApAQCAtMCwwICsxLDEzIEBACitBIC8gQgor QworCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKK1BB U1MgQWxsIGNvcnJlY3Qgbm9kZXMgZm91bmQgZm9yIHJlY3QgWzM3LDMyXSwgWzAsMCwwLDBdCitQ QVNTIEFsbCBjb3JyZWN0IG5vZGVzIGZvdW5kIGZvciByZWN0IFszNywzMl0sIFsxMCwwLDAsMF0K K1BBU1MgQWxsIGNvcnJlY3Qgbm9kZXMgZm91bmQgZm9yIHJlY3QgWzM3LDMyXSwgWzAsMCwxOCww XQorUEFTUyBBbGwgY29ycmVjdCBub2RlcyBmb3VuZCBmb3IgcmVjdCBbMzcsMzJdLCBbMCwxMS41 LDAsMF0KK1BBU1MgQWxsIGNvcnJlY3Qgbm9kZXMgZm91bmQgZm9yIHJlY3QgWzM3LDMyXSwgWzAs MjMsMCwwXQorUEFTUyBBbGwgY29ycmVjdCBub2RlcyBmb3VuZCBmb3IgcmVjdCBbMzcsMzJdLCBb MCwyMywxOCwwXQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9ub2Rlc0Zyb21S ZWN0LWxpbmtzLWFuZC10ZXh0Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9ub2Rlc0Zyb21S ZWN0LWxpbmtzLWFuZC10ZXh0Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAw MC4uN2JmZDkwOQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL25vZGVz RnJvbVJlY3QtbGlua3MtYW5kLXRleHQuaHRtbApAQCAtMCwwICsxLDU0IEBACis8aHRtbD4KKzxo ZWFkPgorICA8dGl0bGU+RG9jdW1lbnQ6Om5vZGVzRnJvbVJlY3QgOiBiYXNpYyB0ZXh0IG5vZGVz IGFuZCBsaW5rcyB0ZXN0IC0gYnVnIDQ3Nzk1PC90aXRsZT4KKyAgPHN0eWxlIHR5cGU9InRleHQv Y3NzIj4gQGltcG9ydCAicmVzb3VyY2VzL25vZGVzRnJvbVJlY3QuY3NzIjsgPC9zdHlsZT4KKyAg PHNjcmlwdCBzcmM9Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cisg IDxzY3JpcHQgc3JjPSJyZXNvdXJjZXMvbm9kZXNGcm9tUmVjdC5qcyI+PC9zY3JpcHQ+CisgIDxz Y3JpcHQgdHlwZT0iYXBwbGljYXRpb24vamF2YXNjcmlwdCI+CisgICAgZnVuY3Rpb24gcnVuVGVz dCgpCisgICAgeworICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgeworICAg ICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisgICAgICAgIGxheW91dFRl c3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKKyAgICAgIH0KKworICAgICAgdmFyIGUgPSB7 fTsKKworICAgICAgLy8gU2V0IHVwIHNob3J0Y3V0IGFjY2VzcyB0byBlbGVtZW50cworICAgICAg ZVsnaHRtbCddID0gZG9jdW1lbnQuZ2V0RWxlbWVudHNCeVRhZ05hbWUoImh0bWwiKVswXTsKKyAg ICAgIFsncDEnLCAnYTEnLCAnYTInLCAnYTMnLCAnYm9keSddLmZvckVhY2goZnVuY3Rpb24oYSkg eworICAgICAgICBlW2FdID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoYSk7CisgICAgICB9KTsK KworICAgICAgd2luZG93LnNjcm9sbFRvKDAsIDApOworCisgICAgICAvLyBBcmVhIHdpdGggbGlu a3MgYW5kIHRleHQgbm9kZXM6CisgICAgICB2YXIgY2VudGVyQTEgPSBnZXRDZW50ZXJGb3IoZS5h MSk7CisgICAgICB2YXIgY2VudGVyQTIgPSBnZXRDZW50ZXJGb3IoZS5hMik7CisgICAgICB2YXIg Y2VudGVyQTMgPSBnZXRDZW50ZXJGb3IoZS5hMyk7CisgICAgICB2YXIgY2VudGVyVGV4dCA9IHsg eCA6IChjZW50ZXJBMi54ICsgY2VudGVyQTEueCkgLyAyLCB5IDogY2VudGVyQTEueSB9OyAvL3Rl eHQgbm9kZSBiZXR3ZWVuIGExIGFuZCBhMgorCisgICAgICBjaGVjayhjZW50ZXJBMS54LCBjZW50 ZXJBMS55LCAwLCAwLCAwLCAwLCBbZS5hMS5maXJzdENoaWxkXSk7CisgICAgICBjaGVjayhjZW50 ZXJBMS54LCBjZW50ZXJBMS55LCAxMCwgMCwgMCwgMCwgW2UuYTEuZmlyc3RDaGlsZCwgZS5hMSwg ZS5wMV0pOworICAgICAgCisgICAgICBjaGVjayhjZW50ZXJBMS54LCBjZW50ZXJBMS55LCAwLCAw LCBjZW50ZXJBMy55IC0gY2VudGVyQTEueSwgMCwgW2UuYTMuZmlyc3RDaGlsZCwgZS5hMywgZS5w MSwgZS5hMS5maXJzdENoaWxkLCBlLmExXSk7CisgICAgICBjaGVjayhjZW50ZXJBMS54LCBjZW50 ZXJBMS55LCAwLCBjZW50ZXJUZXh0LnggLSBjZW50ZXJBMS54LCAwLCAwLCBbZS5wMS5jaGlsZE5v ZGVzWzJdLCBlLmExLmZpcnN0Q2hpbGQsIGUuYTEsIGUucDFdKTsKKyAgICAgIGNoZWNrKGNlbnRl ckExLngsIGNlbnRlckExLnksIDAsIGNlbnRlckEyLnggLSBjZW50ZXJBMS54LCAwLCAwLCBbZS5h Mi5maXJzdENoaWxkLCBlLmEyLCBlLnAxLmNoaWxkTm9kZXNbMl0sIGUuYTEuZmlyc3RDaGlsZCwg ZS5hMSwgZS5wMV0pOworICAgICAgY2hlY2soY2VudGVyQTEueCwgY2VudGVyQTEueSwgMCwgY2Vu dGVyQTIueCAtIGNlbnRlckExLngsIGNlbnRlckEzLnkgLSBjZW50ZXJBMS55LCAwLCBbZS5hMy5m aXJzdENoaWxkLCBlLmEzLCBlLnAxLCBlLmEyLmZpcnN0Q2hpbGQsIGUuYTIsIGUucDEuY2hpbGRO b2Rlc1syXSwgZS5hMS5maXJzdENoaWxkLCBlLmExXSk7CisKKyAgICAgIGlmICh3aW5kb3cubGF5 b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURv bmUoKTsKKyAgICB9CisKKyAgICB3aW5kb3cub25sb2FkID0gcnVuVGVzdDsKKyAgPC9zY3JpcHQ+ Cis8L2hlYWQ+Cis8Ym9keSBpZD0iYm9keSI+CisgIDxwIGlkPSJwMSI+CisgICAgPGEgaHJlZj0i IyIgaWQ9ImExIj5BPC9hPiAvIDxhIGhyZWY9IiMiIGlkPSJhMiI+QjwvYT48YnIvPjxhIGhyZWY9 IiMiIGlkPSJhMyI+QzwvYT4KKyAgPC9wPiAKKworICA8c3BhbiBpZD0iY29uc29sZSI+PC9zcGFu PgorICA8c2NyaXB0IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3Jp cHQ+Cis8L2JvZHk+Cis8L2h0bWw+Ci0tIAoxLjcuMwoK