47793 2010-10-17 22:17:12 -0700 [Gtk] all spatial-navigation tests stderr something 2010-10-27 09:10:08 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 48199 1 tonikitoo tonikitoo cshu mrobinson ossy rniwa tony xan.lopez yael oldest_to_newest 295337 0 tonikitoo 2010-10-17 22:17:12 -0700 As we can see in http://build.webkit.org/results/GTK%20Linux%2032-bit%20Release/r69922%20(6689)/results.html all spatial-navigation tests stderr the following message: LayoutTestController::overridePreference tried to override unknown preference 'WebKitTabToLinksPreferenceKey'. 295350 1 tonikitoo 2010-10-17 22:45:10 -0700 Gtk's LayoutTestController::overridePreference implementation does not support "WebKitTabToLinksPreferenceKey", but in the end it does not affect to spatial-navigation tests because Gtk "tabs to links" unconditionally: 331 bool ChromeClient::tabsToLinks() const 332 { 333 return true; 334 } It is not the case for Mac and Qt for example: both honor this preference. 296819 2 tonikitoo 2010-10-20 09:04:26 -0700 Martin, Xan: do you guys have interest in supporting DRT's WebKitTabToLinksPreferenceKey preference? Also, is there a way to set WebCore's Settings without having the corresponding webkitwebsettings? In Qt we have for example WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp|h can sets WebCore stuff directly from DRT/LayoutTestController. 296828 3 mrobinson 2010-10-20 09:21:10 -0700 I have interest in getting tests that use this key working. I've considered adding something like your DumpRenderTreeSupport in the past. Perhaps this is an opportunity to do that. 296830 4 tonikitoo 2010-10-20 09:23:42 -0700 Good to hear, Martin. We could start simple, like having this setter :). I could get to it. Would you have any special request for its design? In Qt they are mostly a bunch of static methods. 296834 5 mrobinson 2010-10-20 09:28:36 -0700 (In reply to comment #4) > Good to hear, Martin. We could start simple, like having this setter :). I could get to it. Would you have any special request for its design? In Qt they are mostly a bunch of static methods. Awesome! That'd be very helpful, as I am swamped right now and it would be maybe end of this week before I could get to it. I think having the same design (could it even share code?) as the Qt version makes a lot of sense (static methods). 300005 6 tonikitoo 2010-10-26 22:33:34 -0700 Shold be fixed by http://trac.webkit.org/changeset/70609. Waiting for the bots to catch up before closing accordingly. 300203 7 tonikitoo 2010-10-27 07:20:19 -0700 (In reply to comment #6) > Shold be fixed by http://trac.webkit.org/changeset/70609. > > Waiting for the bots to catch up before closing accordingly. Yes, fixed by r70609. 300269 8 mrobinson 2010-10-27 09:10:08 -0700 Thanks again!