47789 2010-10-17 20:36:14 -0700 check-webkit-style needs to ignore underscores in opcode names and vm_throw 2010-10-18 04:58:02 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 oliver levin abarth commit-queue levin oldest_to_newest 295319 0 oliver 2010-10-17 20:36:14 -0700 check-webkit-style complains about vm_throw, op_..., and underscores in the various CPU opcode defs. This makes it very noisy for JSC and will break the cq 295345 1 71000 levin 2010-10-17 22:35:00 -0700 Created attachment 71000 Proposed fix. 295445 2 71000 commit-queue 2010-10-18 04:57:56 -0700 Comment on attachment 71000 Proposed fix. Clearing flags on attachment: 71000 Committed r69953: <http://trac.webkit.org/changeset/69953> 295446 3 commit-queue 2010-10-18 04:58:02 -0700 All reviewed patches have been landed. Closing bug. 71000 2010-10-17 22:35:00 -0700 2010-10-18 04:57:56 -0700 Proposed fix. fix47789.txt text/plain 4437 levin ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAwYzdkZTlkLi45Mjc0ZWU3IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMTAt MTcgIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGNoZWNrLXdlYmtpdC1zdHlsZSBuZWVkcyB0 byBpZ25vcmUgdW5kZXJzY29yZXMgaW4gb3Bjb2RlIG5hbWVzIGFuZCB2bV90aHJvdworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDc3ODkKKworICAgICAg ICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlci5weTogQWRkZWQgdGhlIGV4Y2VwdGlv biBmb3IgdGhlIGFzc2VtYmxlciBkaXJlY3RvcnkuCisgICAgICAgICogU2NyaXB0cy93ZWJraXRw eS9zdHlsZS9jaGVja2Vycy9jcHAucHk6IEFkZGVkIHNwZWNpYWwgY2FzZWQgbmFtZXMuCisgICAg ICAgICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHk6IEFk ZGVkIHVuaXQgdGVzdHMgZm9yIHRoZSBzcGVjaWFsIGNhc2VzLgorCiAyMDEwLTEwLTE0ICBBbnRv bmlvIEdvbWVzICA8YWdvbWVzQHJpbS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFydGlu IFJvYmluc29uIGFuZCBYYW4gTG9wZXouCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRz L3dlYmtpdHB5L3N0eWxlL2NoZWNrZXIucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5 L3N0eWxlL2NoZWNrZXIucHkKaW5kZXggZjhlZWZhNC4uNDY1MTg1OSAxMDA2NDQKLS0tIGEvV2Vi S2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyLnB5CisrKyBiL1dlYktpdFRv b2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlci5weQpAQCAtMTQyLDYgKzE0MiwxMCBA QCBfUEFUSF9SVUxFU19TUEVDSUZJRVIgPSBbCiAgICAgICAjIGV4Y2VwdGlvbmFsIGhlYWRlciBn dWFyZHMgKGUuZy4sIFdlYkNvcmVfRldEX0RlYnVnZ2VyX2gpLgogICAgICAgIi9Gb3J3YXJkaW5n SGVhZGVycy8iXSwKICAgICAgWyItYnVpbGQvaGVhZGVyX2d1YXJkIl0pLAorICAgIChbIyBhc3Nl bWJsZXIgaGFzIGxvdHMgb2Ygb3Bjb2RlcyB0aGF0IHVzZSB1bmRlcnNjb3Jlcywgc28KKyAgICAg ICMgd2Ugb24ndCBjaGVjayBmb3IgdW5kZXJzY29yZXMgaW4gdGhhdCBkaXJlY3RvcnkuCisgICAg ICAiL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci8iXSwKKyAgICAgWyItcmVhZGFiaWxpdHkvbmFt aW5nIl0pLAogCiAgICAgIyBGb3IgdGhpcmQtcGFydHkgUHl0aG9uIGNvZGUsIGtlZXAgb25seSB0 aGUgZm9sbG93aW5nIGNoZWNrcy0tCiAgICAgIwpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2Ny aXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkgYi9XZWJLaXRUb29scy9TY3JpcHRz L3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQppbmRleCBmOGViZWZmLi43YzFjYjNlIDEw MDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2Nw cC5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2Nw cC5weQpAQCAtMjUxMiw3ICsyNTEyLDcgQEAgZGVmIGNoZWNrX2lkZW50aWZpZXJfbmFtZV9pbl9k ZWNsYXJhdGlvbihmaWxlbmFtZSwgbGluZV9udW1iZXIsIGxpbmUsIGVycm9yKToKICAgICAgICAg bW9kaWZpZWRfaWRlbnRpZmllciA9IHN1YihyJyhefCg/PD06OikpW21zXV8nLCAnJywgaWRlbnRp ZmllcikKICAgICAgICAgaWYgbW9kaWZpZWRfaWRlbnRpZmllci5maW5kKCdfJykgPj0gMDoKICAg ICAgICAgICAgICMgVmFyaW91cyBleGNlcHRpb25zIHRvIHRoZSBydWxlOiBKYXZhU2NyaXB0IG9w IGNvZGVzIGZ1bmN0aW9ucywgY29uc3RfaXRlcmF0b3IuCi0gICAgICAgICAgICBpZiAobm90IChm aWxlbmFtZS5maW5kKCdKYXZhU2NyaXB0Q29yZScpID49IDAgYW5kIG1vZGlmaWVkX2lkZW50aWZp ZXIuZmluZCgnX29wXycpID49IDApCisgICAgICAgICAgICBpZiAobm90IChmaWxlbmFtZS5maW5k KCdKYXZhU2NyaXB0Q29yZScpID49IDAgYW5kIG1vZGlmaWVkX2lkZW50aWZpZXIuZmluZCgnb3Bf JykgPj0gMCkKICAgICAgICAgICAgICAgICBhbmQgbm90IG1vZGlmaWVkX2lkZW50aWZpZXIuc3Rh cnRzd2l0aCgndHN0XycpCiAgICAgICAgICAgICAgICAgYW5kIG5vdCBtb2RpZmllZF9pZGVudGlm aWVyLnN0YXJ0c3dpdGgoJ3dlYmtpdF9kb21fb2JqZWN0XycpCiAgICAgICAgICAgICAgICAgYW5k IG5vdCBtb2RpZmllZF9pZGVudGlmaWVyLnN0YXJ0c3dpdGgoJ05QTl8nKQpAQCAtMjUyMSw3ICsy NTIxLDggQEAgZGVmIGNoZWNrX2lkZW50aWZpZXJfbmFtZV9pbl9kZWNsYXJhdGlvbihmaWxlbmFt ZSwgbGluZV9udW1iZXIsIGxpbmUsIGVycm9yKToKICAgICAgICAgICAgICAgICBhbmQgbm90IG1v ZGlmaWVkX2lkZW50aWZpZXIuc3RhcnRzd2l0aCgncXRfJykKICAgICAgICAgICAgICAgICBhbmQg bm90IG1vZGlmaWVkX2lkZW50aWZpZXIuc3RhcnRzd2l0aCgnY2Fpcm9fJykKICAgICAgICAgICAg ICAgICBhbmQgbm90IG1vZGlmaWVkX2lkZW50aWZpZXIuZmluZCgnOjpxdF8nKSA+PSAwCi0gICAg ICAgICAgICAgICAgYW5kIG5vdCBtb2RpZmllZF9pZGVudGlmaWVyID09ICJjb25zdF9pdGVyYXRv ciIpOgorICAgICAgICAgICAgICAgIGFuZCBub3QgbW9kaWZpZWRfaWRlbnRpZmllciA9PSAiY29u c3RfaXRlcmF0b3IiCisgICAgICAgICAgICAgICAgYW5kIG5vdCBtb2RpZmllZF9pZGVudGlmaWVy ID09ICJ2bV90aHJvdyIpOgogICAgICAgICAgICAgICAgIGVycm9yKGxpbmVfbnVtYmVyLCAncmVh ZGFiaWxpdHkvbmFtaW5nJywgNCwgaWRlbnRpZmllciArICIgaXMgaW5jb3JyZWN0bHkgbmFtZWQu IERvbid0IHVzZSB1bmRlcnNjb3JlcyBpbiB5b3VyIGlkZW50aWZpZXIgbmFtZXMuIikKIAogICAg ICAgICAjIENoZWNrIGZvciB2YXJpYWJsZXMgbmFtZWQgJ2wnLCB0aGVzZSBhcmUgdG9vIGVhc3kg dG8gY29uZnVzZSB3aXRoICcxJyBpbiBzb21lIGZvbnRzCmRpZmYgLS1naXQgYS9XZWJLaXRUb29s cy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weSBiL1dlYktp dFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5Cmlu ZGV4IDJmNTQzMDUuLjA3MWNlNTAgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CisrKyBiL1dlYktpdFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CkBAIC0zNjkwLDYg KzM2OTAsNyBAQCBjbGFzcyBXZWJLaXRTdHlsZVRlc3QoQ3BwU3R5bGVUZXN0QmFzZSk6CiAKICAg ICAgICAgIyBUaGVyZSBpcyBhbiBleGNlcHRpb24gZm9yIG9wIGNvZGUgZnVuY3Rpb25zIGJ1dCBv bmx5IGluIHRoZSBKYXZhU2NyaXB0Q29yZSBkaXJlY3RvcnkuCiAgICAgICAgIHNlbGYuYXNzZXJ0 X2xpbnQoJ3ZvaWQgdGhpc19vcF9jb2RlKGludCB2YXIxLCBpbnQgdmFyMiknLCAnJywgJ0phdmFT Y3JpcHRDb3JlL2Zvby5jcHAnKQorICAgICAgICBzZWxmLmFzc2VydF9saW50KCd2b2lkIG9wX2Nv ZGUoaW50IHZhcjEsIGludCB2YXIyKScsICcnLCAnSmF2YVNjcmlwdENvcmUvZm9vLmNwcCcpCiAg ICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ3ZvaWQgdGhpc19vcF9jb2RlKGludCB2YXIxLCBpbnQg dmFyMiknLCAndGhpc19vcF9jb2RlJyArIG5hbWVfdW5kZXJzY29yZV9lcnJvcl9tZXNzYWdlKQog CiAgICAgICAgICMgR09iamVjdCByZXF1aXJlcyBjZXJ0YWluIG1hZ2ljYWwgbmFtZXMgaW4gY2xh c3MgZGVjbGFyYXRpb25zLgpAQCAtMzcxNiw2ICszNzE3LDkgQEAgY2xhc3MgV2ViS2l0U3R5bGVU ZXN0KENwcFN0eWxlVGVzdEJhc2UpOgogICAgICAgICAjIGNvbnN0X2l0ZXJhdG9yIGlzIGFsbG93 ZWQgYXMgd2VsbC4KICAgICAgICAgc2VsZi5hc3NlcnRfbGludCgndHlwZWRlZiBWZWN0b3JUeXBl Ojpjb25zdF9pdGVyYXRvciBjb25zdF9pdGVyYXRvcjsnLCAnJykKIAorICAgICAgICAjIHZtX3Ro cm93IGlzIGFsbG93ZWQgYXMgd2VsbC4KKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnaW50IHZt X3Rocm93OycsICcnKQorCiAgICAgICAgICMgQml0ZmllbGRzLgogICAgICAgICBzZWxmLmFzc2Vy dF9saW50KCd1bnNpZ25lZCBfZmlsbFJ1bGUgOiAxOycsCiAgICAgICAgICAgICAgICAgICAgICAg ICAgJ19maWxsUnVsZScgKyBuYW1lX3VuZGVyc2NvcmVfZXJyb3JfbWVzc2FnZSkK