47747 2010-10-15 15:51:26 -0700 Make the find indicator window fade out when requested 2010-10-15 16:33:25 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 294972 0 andersca 2010-10-15 15:51:26 -0700 Make the find indicator window fade out when requested 294999 1 70915 andersca 2010-10-15 16:27:29 -0700 Created attachment 70915 Patch 295002 2 70915 darin 2010-10-15 16:32:38 -0700 Comment on attachment 70915 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=70915&action=review > WebKit2/UIProcess/API/mac/FindIndicatorWindow.mm:181 > - m_findIndicatorWindow.clear(); > + m_findIndicatorWindow = 0; Please use clear(). It will be a compilation error to use 0 when we turn off the “loose” option. 295003 3 andersca 2010-10-15 16:33:25 -0700 Committed r69895: <http://trac.webkit.org/changeset/69895> 70915 2010-10-15 16:27:29 -0700 2010-10-15 16:32:38 -0700 Patch bug-47747-20101015162728.patch text/plain 7332 andersca ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg ZmY0ZTA5ZGNmY2I4OTgwYWIyZTE0MGM2M2YyOWViYmEyODU0MWZjNS4uNDUwN2I2NmM0MDE2MThl MmQyZTRlYTFhMDg2MjhmNmY3YmJiYmNiZiAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsNSArMSw0MiBAQAogMjAxMC0xMC0xNSAgQW5k ZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2UgdGhlIGZpbmQgaW5kaWNhdG9yIHdpbmRv dyBmYWRlIG91dCB3aGVuIHJlcXVlc3RlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NDc3NDcKKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvbWFjL0Zp bmRJbmRpY2F0b3JXaW5kb3cuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL21hYy9GaW5kSW5k aWNhdG9yV2luZG93Lm1tOgorICAgICAgICBBZGQgV2ViRmluZEluZGljYXRvcldpbmRvd0FuaW1h dGlvbiAtIGFuIE5TQW5pbWF0aW9uIHN1YmNsYXNzIHRoYXQgdGFrZXMgdHdvCisgICAgICAgIEMr KyBtZW1iZXIgZnVuY3Rpb24gcG9pbnRlcnMgYW5kIGludm9rZXMgdGhlbSB0aGUgYW5pbWF0aW9u IHByb2dyZXNzIGNoYW5nZXMgYW5kCisgICAgICAgIHdoZW4gdGhlIGFuaW1hdGlvbiBzdG9wcy4K KworICAgICAgICAoLVtXZWJGaW5kSW5kaWNhdG9yV2luZG93QW5pbWF0aW9uIHNldEN1cnJlbnRQ cm9ncmVzczpdKToKKyAgICAgICAgQ2FsbCB0aGUgX2FuaW1hdGlvblByb2dyZXNzQ2FsbGJhY2su CisKKyAgICAgICAgKC1bV2ViRmluZEluZGljYXRvcldpbmRvd0FuaW1hdGlvbiBhbmltYXRpb25E aWRFbmQ6XSk6CisgICAgICAgIENhbGwgdGhlIF9hbmltYXRpb25EaWRFbmRDYWxsYmFjay4KKwor ICAgICAgICAoV2ViS2l0OjpGaW5kSW5kaWNhdG9yV2luZG93OjpGaW5kSW5kaWNhdG9yV2luZG93 KToKKyAgICAgICAgSW5pdGlhbGl6ZSB0aGUgZmFkZSBvdXQgc3RhcnQgdGltZXIuCisKKyAgICAg ICAgKFdlYktpdDo6RmluZEluZGljYXRvcldpbmRvdzo6c2V0RmluZEluZGljYXRvcik6CisgICAg ICAgIFdoZW4gYXNrZWQgdG8gZmFkZSBvdXQsIHdlIHN0YXJ0IHRoZSBmYWRlIG91dCB0aW1lci4K KworICAgICAgICAoV2ViS2l0OjpGaW5kSW5kaWNhdG9yV2luZG93OjpjbG9zZVdpbmRvdyk6Cisg ICAgICAgIFN0b3AgdGhlIGZhZGUgb3V0IHRpbWVyIGFuZCB0aGUgZmFkZSBvdXQgYW5pbWF0aW9u LgorCisgICAgICAgIChXZWJLaXQ6OkZpbmRJbmRpY2F0b3JXaW5kb3c6OnN0YXJ0RmFkZU91dFRp bWVyRmlyZWQpOgorICAgICAgICBDcmVhdGUgYSBmYWRlIG91dCBhbmltYXRpb24uCisKKyAgICAg ICAgKFdlYktpdDo6RmluZEluZGljYXRvcldpbmRvdzo6ZmFkZU91dEFuaW1hdGlvbkNhbGxiYWNr KToKKyAgICAgICAgVXBkYXRlIHRoZSB3aW5kb3cgYWxwaGEuCisKKyAgICAgICAgKFdlYktpdDo6 RmluZEluZGljYXRvcldpbmRvdzo6ZmFkZU91dEFuaW1hdGlvbkRpZEVuZCk6CisgICAgICAgIENs b3NlIHRoZSB3aW5kb3cuCisKKzIwMTAtMTAtMTUgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2Nh QGFwcGxlLmNvbT4KKwogICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgogCiAgICAgICAg IE1vdmUgZmluZCBpbmRpY2F0b3Igd2luZG93IGxvZ2ljIHRvIFdLVmlldwpkaWZmIC0tZ2l0IGEv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9GaW5kSW5kaWNhdG9yV2luZG93LmggYi9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvbWFjL0ZpbmRJbmRpY2F0b3JXaW5kb3cuaAppbmRleCA0NWFjZGM3NmY5 MzM3MWZhM2M0NTliODY4MjMzZTgyMzQ4OWZkMDVmLi40ZmZjZjc5YTdjZTc0YTY3MGQ1NjE3OTZh OGU4MmExZTE2ZGJjMTAxIDEwMDY0NAotLS0gYS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL0Zp bmRJbmRpY2F0b3JXaW5kb3cuaAorKysgYi9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL0ZpbmRJ bmRpY2F0b3JXaW5kb3cuaApAQCAtMzAsOCArMzAsMTAgQEAKICNpbXBvcnQgPHd0Zi9QYXNzT3du UHRyLmg+CiAjaW1wb3J0IDx3dGYvUmVmUHRyLmg+CiAjaW1wb3J0IDx3dGYvUmV0YWluUHRyLmg+ CisjaW1wb3J0ICJSdW5Mb29wLmgiCiAKIEBjbGFzcyBXS1ZpZXc7CitAY2xhc3MgV2ViRmluZElu ZGljYXRvcldpbmRvd0FuaW1hdGlvbjsKIAogbmFtZXNwYWNlIFdlYktpdCB7CiAKQEAgLTUwLDkg KzUyLDE3IEBAIHByaXZhdGU6CiAgICAgZXhwbGljaXQgRmluZEluZGljYXRvcldpbmRvdyhXS1Zp ZXcgKik7CiAgICAgdm9pZCBjbG9zZVdpbmRvdygpOwogCisgICAgdm9pZCBzdGFydEZhZGVPdXRU aW1lckZpcmVkKCk7CisKKyAgICB2b2lkIGZhZGVPdXRBbmltYXRpb25DYWxsYmFjayhkb3VibGUp OworICAgIHZvaWQgZmFkZU91dEFuaW1hdGlvbkRpZEVuZCgpOworCiAgICAgV0tWaWV3KiBtX3dr VmlldzsKICAgICBSZWZQdHI8RmluZEluZGljYXRvcj4gbV9maW5kSW5kaWNhdG9yOwogICAgIFJl dGFpblB0cjxOU1dpbmRvdz4gbV9maW5kSW5kaWNhdG9yV2luZG93OworCisgICAgUnVuTG9vcDo6 VGltZXI8RmluZEluZGljYXRvcldpbmRvdz4gbV9zdGFydEZhZGVPdXRUaW1lcjsKKyAgICBSZXRh aW5QdHI8V2ViRmluZEluZGljYXRvcldpbmRvd0FuaW1hdGlvbj4gbV9mYWRlT3V0QW5pbWF0aW9u OwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CmRpZmYgLS1naXQgYS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvbWFjL0ZpbmRJbmRpY2F0b3JXaW5kb3cubW0gYi9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvbWFjL0ZpbmRJbmRpY2F0b3JXaW5kb3cubW0KaW5kZXggYjhiYWQ3ODVhNDhmZDI3OGVjZDMx NWExMzNkOWZiMGI1OWMzNDc3MS4uYjE4ZDdkY2VkZGMwZTI3ZmNlNzYxMmJlMDlkNmE0MTk2ZTI0 NWNmNyAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9GaW5kSW5kaWNhdG9y V2luZG93Lm1tCisrKyBiL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvRmluZEluZGljYXRvcldp bmRvdy5tbQpAQCAtMjgsNiArMjgsMTAgQEAKICNpbmNsdWRlICJGaW5kSW5kaWNhdG9yLmgiCiAj aW5jbHVkZSA8V2ViQ29yZS9HcmFwaGljc0NvbnRleHQuaD4KIAorc3RhdGljIGNvbnN0IGRvdWJs ZSBwdWxzZUFuaW1hdGlvbkR1cmF0aW9uID0gMC4xMjsKK3N0YXRpYyBjb25zdCBkb3VibGUgdGlt ZUJlZm9yZUZhZGVTdGFydHMgPSBwdWxzZUFuaW1hdGlvbkR1cmF0aW9uICsgMC4yOworc3RhdGlj IGNvbnN0IGRvdWJsZSBmYWRlT3V0QW5pbWF0aW9uRHVyYXRpb24gPSAwLjM7CisKIHVzaW5nIG5h bWVzcGFjZSBXZWJDb3JlOwogCiBAaW50ZXJmYWNlIFdlYkZpbmRJbmRpY2F0b3JWaWV3IDogTlNW aWV3IHsKQEAgLTYxLDYgKzY1LDQ3IEBAIC0gKEJPT0wpaXNGbGlwcGVkCiAKIEBlbmQKIAorQGlu dGVyZmFjZSBXZWJGaW5kSW5kaWNhdG9yV2luZG93QW5pbWF0aW9uIDogTlNBbmltYXRpb248TlNB bmltYXRpb25EZWxlZ2F0ZT4geworICAgIFdlYktpdDo6RmluZEluZGljYXRvcldpbmRvdyogX2Zp bmRJbmRpY2F0b3JXaW5kb3c7CisgICAgdm9pZCAoV2ViS2l0OjpGaW5kSW5kaWNhdG9yV2luZG93 OjoqX2FuaW1hdGlvblByb2dyZXNzQ2FsbGJhY2spKGRvdWJsZSBwcm9ncmVzcyk7CisgICAgdm9p ZCAoV2ViS2l0OjpGaW5kSW5kaWNhdG9yV2luZG93OjoqX2FuaW1hdGlvbkRpZEVuZENhbGxiYWNr KSgpOworfQorCistIChpZClfaW5pdFdpdGhGaW5kSW5kaWNhdG9yV2luZG93OihXZWJLaXQ6OkZp bmRJbmRpY2F0b3JXaW5kb3cgKilmaW5kSW5kaWNhdG9yV2luZG93IAorICAgICAgICAgICAgICAg ICBhbmltYXRpb25Qcm9ncmVzc0NhbGxiYWNrOih2b2lkIChXZWJLaXQ6OkZpbmRJbmRpY2F0b3JX aW5kb3c6OiopKGRvdWJsZSBwcm9ncmVzcykpYW5pbWF0aW9uUHJvZ3Jlc3NDYWxsYmFjaworICAg ICAgICAgICAgICAgICAgIGFuaW1hdGlvbkRpZEVuZENhbGxiYWNrOih2b2lkIChXZWJLaXQ6OkZp bmRJbmRpY2F0b3JXaW5kb3c6OiopKCkpYW5pbWF0aW9uRGlkRW5kQ2FsbGJhY2s7CitAZW5kCisK K0BpbXBsZW1lbnRhdGlvbiBXZWJGaW5kSW5kaWNhdG9yV2luZG93QW5pbWF0aW9uCisKKy0gKGlk KV9pbml0V2l0aEZpbmRJbmRpY2F0b3JXaW5kb3c6KFdlYktpdDo6RmluZEluZGljYXRvcldpbmRv dyAqKWZpbmRJbmRpY2F0b3JXaW5kb3cgCisgICAgICAgICBhbmltYXRpb25Qcm9ncmVzc0NhbGxi YWNrOih2b2lkIChXZWJLaXQ6OkZpbmRJbmRpY2F0b3JXaW5kb3c6OiopKGRvdWJsZSBwcm9ncmVz cykpYW5pbWF0aW9uUHJvZ3Jlc3NDYWxsYmFjaworICAgICAgICAgICBhbmltYXRpb25EaWRFbmRD YWxsYmFjazoodm9pZCAoV2ViS2l0OjpGaW5kSW5kaWNhdG9yV2luZG93OjoqKSgpKWFuaW1hdGlv bkRpZEVuZENhbGxiYWNrOworeworICAgIGlmICgoc2VsZiA9IFtzdXBlciBpbml0V2l0aER1cmF0 aW9uOmZhZGVPdXRBbmltYXRpb25EdXJhdGlvbiBhbmltYXRpb25DdXJ2ZTpOU0FuaW1hdGlvbkVh c2VJbk91dF0pKSB7CisgICAgICAgIF9maW5kSW5kaWNhdG9yV2luZG93ID0gZmluZEluZGljYXRv cldpbmRvdzsKKyAgICAgICAgX2FuaW1hdGlvbkNhbGxiYWNrID0gYW5pbWF0aW9uQ2FsbGJhY2s7 CisgICAgICAgIF9hbmltYXRpb25EaWRFbmRDYWxsYmFjayA9IGFuaW1hdGlvbkRpZEVuZENhbGxi YWNrOworICAgICAgICBbc2VsZiBzZXREZWxlZ2F0ZTpzZWxmXTsKKyAgICAgICAgW3NlbGYgc2V0 QW5pbWF0aW9uQmxvY2tpbmdNb2RlOk5TQW5pbWF0aW9uTm9uYmxvY2tpbmddOworICAgIH0KKyAg ICByZXR1cm4gc2VsZjsKK30KKworLSAodm9pZClzZXRDdXJyZW50UHJvZ3Jlc3M6KE5TQW5pbWF0 aW9uUHJvZ3Jlc3MpcHJvZ3Jlc3MKK3sKKyAgICAoX2ZpbmRJbmRpY2F0b3JXaW5kb3ctPipfYW5p bWF0aW9uQ2FsbGJhY2spKHByb2dyZXNzKTsKK30KKworLSAodm9pZClhbmltYXRpb25EaWRFbmQ6 KE5TQW5pbWF0aW9uICopYW5pbWF0aW9uCit7CisgICAgQVNTRVJUKGFuaW1hdGlvbiA9PSBzZWxm KTsKKworICAgIChfZmluZEluZGljYXRvcldpbmRvdy0+Kl9hbmltYXRpb25EaWRFbmRDYWxsYmFj aykoKTsKK30KKworQGVuZAorCiBuYW1lc3BhY2UgV2ViS2l0IHsKIAogUGFzc093blB0cjxGaW5k SW5kaWNhdG9yV2luZG93PiBGaW5kSW5kaWNhdG9yV2luZG93OjpjcmVhdGUoV0tWaWV3ICp3a1Zp ZXcpCkBAIC03MCw2ICsxMTUsNyBAQCBQYXNzT3duUHRyPEZpbmRJbmRpY2F0b3JXaW5kb3c+IEZp bmRJbmRpY2F0b3JXaW5kb3c6OmNyZWF0ZShXS1ZpZXcgKndrVmlldykKIAogRmluZEluZGljYXRv cldpbmRvdzo6RmluZEluZGljYXRvcldpbmRvdyhXS1ZpZXcgKndrVmlldykKICAgICA6IG1fd2tW aWV3KHdrVmlldykKKyAgICAsIG1fc3RhcnRGYWRlT3V0VGltZXIoUnVuTG9vcDo6bWFpbigpLCB0 aGlzLCAmRmluZEluZGljYXRvcldpbmRvdzo6c3RhcnRGYWRlT3V0VGltZXJGaXJlZCkKIHsKIH0K IApAQCAtMTEzLDYgKzE1OSw5IEBAIHZvaWQgRmluZEluZGljYXRvcldpbmRvdzo6c2V0RmluZElu ZGljYXRvcihQYXNzUmVmUHRyPEZpbmRJbmRpY2F0b3I+IGZpbmRJbmRpY2F0CiAKICAgICBbW21f d2tWaWV3IHdpbmRvd10gYWRkQ2hpbGRXaW5kb3c6bV9maW5kSW5kaWNhdG9yV2luZG93LmdldCgp IG9yZGVyZWQ6TlNXaW5kb3dBYm92ZV07CiAgICAgW21fZmluZEluZGljYXRvcldpbmRvdy5nZXQo KSBzZXRSZWxlYXNlZFdoZW5DbG9zZWQ6Tk9dOworCisgICAgaWYgKGZhZGVPdXQpCisgICAgICAg IG1fc3RhcnRGYWRlT3V0VGltZXIuc3RhcnRPbmVTaG90KHRpbWVCZWZvcmVGYWRlU3RhcnRzKTsK IH0KIAogdm9pZCBGaW5kSW5kaWNhdG9yV2luZG93OjpjbG9zZVdpbmRvdygpCkBAIC0xMjAsMTAg KzE2OSw0MSBAQCB2b2lkIEZpbmRJbmRpY2F0b3JXaW5kb3c6OmNsb3NlV2luZG93KCkKICAgICBp ZiAoIW1fZmluZEluZGljYXRvcldpbmRvdykKICAgICAgICAgcmV0dXJuOwogCisgICAgbV9zdGFy dEZhZGVPdXRUaW1lci5zdG9wKCk7CisKKyAgICBpZiAobV9mYWRlT3V0QW5pbWF0aW9uKSB7Cisg ICAgICAgIFttX2ZhZGVPdXRBbmltYXRpb24uZ2V0KCkgc3RvcEFuaW1hdGlvbl07CisgICAgICAg IG1fZmFkZU91dEFuaW1hdGlvbiA9IDA7CisgICAgfQorCiAgICAgW1ttX2ZpbmRJbmRpY2F0b3JX aW5kb3cuZ2V0KCkgcGFyZW50V2luZG93XSByZW1vdmVDaGlsZFdpbmRvdzptX2ZpbmRJbmRpY2F0 b3JXaW5kb3cuZ2V0KCldOwogICAgIFttX2ZpbmRJbmRpY2F0b3JXaW5kb3cuZ2V0KCkgY2xvc2Vd OwotICAgIG1fZmluZEluZGljYXRvcldpbmRvdy5jbGVhcigpOworICAgIG1fZmluZEluZGljYXRv cldpbmRvdyA9IDA7Cit9CisKK3ZvaWQgRmluZEluZGljYXRvcldpbmRvdzo6c3RhcnRGYWRlT3V0 VGltZXJGaXJlZCgpCit7CisgICAgQVNTRVJUKCFtX2ZhZGVPdXRBbmltYXRpb24pOwogICAgIAor ICAgIG1fZmFkZU91dEFuaW1hdGlvbi5hZG9wdE5TKFtbV2ViRmluZEluZGljYXRvcldpbmRvd0Fu aW1hdGlvbiBhbGxvY10gX2luaXRXaXRoRmluZEluZGljYXRvcldpbmRvdzp0aGlzIAorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgYW5pbWF0aW9uUHJvZ3Jlc3NDYWxsYmFjazomRmluZEluZGljYXRvcldpbmRv dzo6ZmFkZU91dEFuaW1hdGlvbkNhbGxiYWNrCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGFuaW1hdGlv bkRpZEVuZENhbGxiYWNrOiZGaW5kSW5kaWNhdG9yV2luZG93OjpmYWRlT3V0QW5pbWF0aW9uRGlk RW5kXSk7CisgICAgW21fZmFkZU91dEFuaW1hdGlvbi5nZXQoKSBzdGFydEFuaW1hdGlvbl07Cit9 CisgICAgICAgICAgICAgICAgICAgICAgICAKK3ZvaWQgRmluZEluZGljYXRvcldpbmRvdzo6ZmFk ZU91dEFuaW1hdGlvbkNhbGxiYWNrKGRvdWJsZSBwcm9ncmVzcykKK3sKKyAgICBBU1NFUlQobV9m YWRlT3V0QW5pbWF0aW9uKTsKKworICAgIFttX2ZpbmRJbmRpY2F0b3JXaW5kb3cuZ2V0KCkgc2V0 QWxwaGFWYWx1ZToxLjAgLSBwcm9ncmVzc107Cit9CisKK3ZvaWQgRmluZEluZGljYXRvcldpbmRv dzo6ZmFkZU91dEFuaW1hdGlvbkRpZEVuZCgpCit7CisgICAgQVNTRVJUKG1fZmFkZU91dEFuaW1h dGlvbik7CisgICAgQVNTRVJUKG1fZmluZEluZGljYXRvcldpbmRvdyk7CisKKyAgICBjbG9zZVdp bmRvdygpOwogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQK