47742 2010-10-15 15:03:20 -0700 [GTK] Full page size flash plugins do not show in all situations 2010-12-08 19:34:08 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 juanpablougarte webkit-unassigned abarth commit-queue gustavo mrobinson nicolas oldest_to_newest 294946 0 70902 juanpablougarte 2010-10-15 15:03:20 -0700 Created attachment 70902 sample app to reproduce bug I was not able to find the exact problem, but it seems that flash objects the size of the WebKitWebView or bigger do not show up properly. They start working after you resize the window. Its easy to reproduce using the test case app and this url. ./a.out http://www.homestarrunner.com/sbemail205.swf Any ideas? 295583 1 nicolas 2010-10-18 10:09:34 -0700 (In reply to comment #0) > I was not able to find the exact problem, but it seems that flash objects the size of the WebKitWebView or bigger do not show up properly. > They start working after you resize the window. I've run this with trunk revison 69781, and I don't see any issues. This was with Flash player 10.1.85.3. Would it be possible to describe more the issue you see and let us know which version of the Flash player you are running ? 311458 2 nicolas 2010-11-19 07:49:13 -0800 (In reply to comment #1) > (In reply to comment #0) > > I was not able to find the exact problem, but it seems that flash objects the size of the WebKitWebView or bigger do not show up properly. > > They start working after you resize the window. > > I've run this with trunk revison 69781, and I don't see any issues. This was with Flash player 10.1.85.3. Would it be possible to describe more the issue you see and let us know which version of the Flash player you are running ? Ok I finally manage to reproduce this bug by moving away from nspluginwrapper. It seems that the widget size allocation does not work very well with the way it is implement right now. 311459 3 74388 nicolas 2010-11-19 07:52:20 -0800 Created attachment 74388 Move widget allocation after NPP_SetWindow This patch moves the plugin widget size allocation after the NPP_SetWindow is called with the effect that the resize of Flash content no longer result in grey flash. This seems logical since the widget tree cannot be fully constructed before the plugin receives the new container window. 312930 4 74388 abarth 2010-11-23 10:57:22 -0800 Comment on attachment 74388 Move widget allocation after NPP_SetWindow No test? 313056 5 nicolas 2010-11-23 15:51:05 -0800 (In reply to comment #4) > (From update of attachment 74388 [details]) > No test? If you know a way to write a test for this I'd appreciate, but so far those kind of rendering glitches are really hard to automatically test. I think we may be able to do so by: 1. Creating a window with a fullscreen plugin 2. Scaling down the window 3. Checking that the plugin content is not GTK Theme default color (assuming we have a test plugin that mimics Flash correctly and shows a different color) The problem is mainly about implementing a plugin that mimic the Adobe's Flash player since we don't really know what it's doing. So far I'm pretty sure they use a GtkDrawingArea, but's that's all I know. So my conclusion is that it's probably possible to test this, but it's very time consuming, which as usual is an issue ;) Let me know what you think about all this (assuming you have already read the code a little to take in consideration the level of changes involved too). Note that another way to reproduce this is to Zoom-out pages like youtube.com (assuming you have full zoom enable, and not text zoom). 313283 6 mrobinson 2010-11-24 07:17:15 -0800 (In reply to comment #5) > (In reply to comment #4) > > (From update of attachment 74388 [details] [details]) > > No test? > > If you know a way to write a test for this I'd appreciate, but so far those kind of rendering glitches are really hard to automatically test. > > I think we may be able to do so by: > 1. Creating a window with a fullscreen plugin > 2. Scaling down the window > 3. Checking that the plugin content is not GTK Theme default color (assuming we have a test plugin that mimics Flash correctly and shows a different color) We have pixel dumping support if that will be useful. 313383 7 nicolas 2010-11-24 10:43:48 -0800 (In reply to comment #6) > We have pixel dumping support if that will be useful. I don't think that works with windowed plugin. 317519 8 gustavo 2010-12-06 03:19:44 -0800 Is this an issue just for windowed plugins? If so, perhaps it would be enough to have a manual test, given the difficulty of testing this in an automated fashion? Check WebCore/manual-tests/, there are plenty of plugin tests in there. 317697 9 nicolas 2010-12-06 10:23:26 -0800 (In reply to comment #8) > Is this an issue just for windowed plugins? If so, perhaps it would be enough to have a manual test, given the difficulty of testing this in an automated fashion? Check WebCore/manual-tests/, there are plenty of plugin tests in there. Yes it's only for windowed plugins. Thanks for the pointer, I'll have a look at those. 318915 10 75936 nicolas 2010-12-08 11:34:53 -0800 Created attachment 75936 Patch 318924 11 75936 mrobinson 2010-12-08 11:51:57 -0800 Comment on attachment 75936 Patch Okay. I guess this is worth a shot. Thanks for including the test. 319222 12 75936 commit-queue 2010-12-08 19:34:00 -0800 Comment on attachment 75936 Patch Clearing flags on attachment: 75936 Committed r73587: <http://trac.webkit.org/changeset/73587> 319223 13 commit-queue 2010-12-08 19:34:08 -0800 All reviewed patches have been landed. Closing bug. 70902 2010-10-15 15:03:20 -0700 2010-10-15 15:03:20 -0700 sample app to reproduce bug url.txt text/plain 47 juanpablougarte aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvYXR0YWNobWVudC5jZ2k/aWQ9NzA3ODM= 74388 2010-11-19 07:52:20 -0800 2010-12-08 11:34:50 -0800 Move widget allocation after NPP_SetWindow 0001-Full-page-size-flash-plugins-do-not-show.patch text/plain 3750 nicolas RnJvbSBjNzQ0MzI4YjhkN2UyMDI0MDBkYzdmMTIwNDlhOTAzZDk4YjA5ZWE3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOaWNvbGFzIER1ZnJlc25lIDxuaWNvbGFzLmR1ZnJlc25lQGNv bGxhYm9yYS5jby51az4KRGF0ZTogRnJpLCAxOSBOb3YgMjAxMCAwNzo0MjowNiAtMDgwMApTdWJq ZWN0OiBbUEFUQ0hdIDIwMTAtMTEtMTkgIE5pY29sYXMgRHVmcmVzbmUgIDxuaWNvbGFzLmR1ZnJl c25lQGNvbGxhYm9yYS5jby51az4KCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CgogICAgICAgIEZ1bGwgcGFnZSBzaXplIGZsYXNoIHBsdWdpbnMgZG8gbm90IHNob3cgaW4gYWxs IHNpdHVhdGlvbnMKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NDc3NDIKCiAgICAgICAgVGhpcyBwYXRjaCBtb3ZlcyB0aGUgcGx1Z2luIHdpZGdldCBzaXpl IGFsbG9jYXRpb24gYWZ0ZXIgdGhlCiAgICAgICAgTlBQX1NldFdpbmRvdyBpcyBjYWxsZWQgd2l0 aCB0aGUgZWZmZWN0IHRoYXQgdGhlIHJlc2l6ZSBvZiBGbGFzaAogICAgICAgIGNvbnRlbnQgbm8g bG9uZ2VyIHJlc3VsdCBpbiBncmV5IGZsYXNoLiBUaGlzIHNlZW1zIGxvZ2ljYWwgc2luY2UgdGhl CiAgICAgICAgd2lkZ2V0IHRyZWUgY2Fubm90IGJlIGZ1bGx5IGNvbnN0cnVjdGVkIGJlZm9yZSB0 aGUgcGx1Z2luIHJlY2VpdmVzCiAgICAgICAgdGhlIG5ldyBjb250YWluZXIgd2luZG93LgoKICAg ICAgICBObyBuZXcgdGVzdHMuCgogICAgICAgICogcGx1Z2lucy9ndGsvUGx1Z2luVmlld0d0ay5j cHA6CiAgICAgICAgKFdlYkNvcmU6OlBsdWdpblZpZXc6OnNldE5QV2luZG93SWZOZWVkZWQpOgot LS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgfCAgIDE4ICsrKysrKysr KysrKysrKysrKwogV2ViQ29yZS9wbHVnaW5zL2d0ay9QbHVnaW5WaWV3R3RrLmNwcCB8ICAgMjAg KysrKysrKysrKystLS0tLS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgMjkgaW5zZXJ0aW9ucygrKSwg OSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUv Q2hhbmdlTG9nCmluZGV4IDA5ZTY2YmMuLjgxMzU5MDggMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hh bmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTAtMTEt MTkgIE5pY29sYXMgRHVmcmVzbmUgIDxuaWNvbGFzLmR1ZnJlc25lQGNvbGxhYm9yYS5jby51az4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGdWxsIHBh Z2Ugc2l6ZSBmbGFzaCBwbHVnaW5zIGRvIG5vdCBzaG93IGluIGFsbCBzaXR1YXRpb25zCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00Nzc0MgorCisgICAg ICAgIFRoaXMgcGF0Y2ggbW92ZXMgdGhlIHBsdWdpbiB3aWRnZXQgc2l6ZSBhbGxvY2F0aW9uIGFm dGVyIHRoZQorICAgICAgICBOUFBfU2V0V2luZG93IGlzIGNhbGxlZCB3aXRoIHRoZSBlZmZlY3Qg dGhhdCB0aGUgcmVzaXplIG9mIEZsYXNoCisgICAgICAgIGNvbnRlbnQgbm8gbG9uZ2VyIHJlc3Vs dCBpbiBncmV5IGZsYXNoLiBUaGlzIHNlZW1zIGxvZ2ljYWwgc2luY2UgdGhlCisgICAgICAgIHdp ZGdldCB0cmVlIGNhbm5vdCBiZSBmdWxseSBjb25zdHJ1Y3RlZCBiZWZvcmUgdGhlIHBsdWdpbiBy ZWNlaXZlcworICAgICAgICB0aGUgbmV3IGNvbnRhaW5lciB3aW5kb3cuCisKKyAgICAgICAgTm8g bmV3IHRlc3RzLgorCisgICAgICAgICogcGx1Z2lucy9ndGsvUGx1Z2luVmlld0d0ay5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpQbHVnaW5WaWV3OjpzZXROUFdpbmRvd0lmTmVlZGVkKToKKwogMjAx MC0xMS0xNSAgQmV0aCBEYWtpbiAgPGJkYWtpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsdWdpbnMvZ3RrL1BsdWdp blZpZXdHdGsuY3BwIGIvV2ViQ29yZS9wbHVnaW5zL2d0ay9QbHVnaW5WaWV3R3RrLmNwcAppbmRl eCA2NjA4ZjZjLi5hNTgzYjZlIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsdWdpbnMvZ3RrL1BsdWdp blZpZXdHdGsuY3BwCisrKyBiL1dlYkNvcmUvcGx1Z2lucy9ndGsvUGx1Z2luVmlld0d0ay5jcHAK QEAgLTQ5MiwxNSArNDkyLDYgQEAgdm9pZCBQbHVnaW5WaWV3OjpzZXROUFdpbmRvd0lmTmVlZGVk KCkKICAgICAgICAgbV9ucFdpbmRvdy5jbGlwUmVjdC50b3AgPSBtYXgoMCwgbV9jbGlwUmVjdC55 KCkpOwogICAgICAgICBtX25wV2luZG93LmNsaXBSZWN0LnJpZ2h0ID0gbV9jbGlwUmVjdC54KCkg KyBtX2NsaXBSZWN0LndpZHRoKCk7CiAgICAgICAgIG1fbnBXaW5kb3cuY2xpcFJlY3QuYm90dG9t ID0gbV9jbGlwUmVjdC55KCkgKyBtX2NsaXBSZWN0LmhlaWdodCgpOwotCi0gICAgICAgIEd0a0Fs bG9jYXRpb24gYWxsb2NhdGlvbiA9IHsgbV93aW5kb3dSZWN0LngoKSwgbV93aW5kb3dSZWN0Lnko KSwgbV93aW5kb3dSZWN0LndpZHRoKCksIG1fd2luZG93UmVjdC5oZWlnaHQoKSB9OwotICAgICAg ICBndGtfd2lkZ2V0X3NpemVfYWxsb2NhdGUocGxhdGZvcm1QbHVnaW5XaWRnZXQoKSwgJmFsbG9j YXRpb24pOwotI2lmIGRlZmluZWQoWFBfVU5JWCkKLSAgICAgICAgaWYgKCFtX25lZWRzWEVtYmVk KSB7Ci0gICAgICAgICAgICBndGtfeHRiaW5fc2V0X3Bvc2l0aW9uKEdUS19YVEJJTihwbGF0Zm9y bVBsdWdpbldpZGdldCgpKSwgbV93aW5kb3dSZWN0LngoKSwgbV93aW5kb3dSZWN0LnkoKSk7Ci0g ICAgICAgICAgICBndGtfeHRiaW5fcmVzaXplKHBsYXRmb3JtUGx1Z2luV2lkZ2V0KCksIG1fd2lu ZG93UmVjdC53aWR0aCgpLCBtX3dpbmRvd1JlY3QuaGVpZ2h0KCkpOwotICAgICAgICB9Ci0jZW5k aWYKICAgICB9IGVsc2UgewogICAgICAgICBtX25wV2luZG93LnggPSAwOwogICAgICAgICBtX25w V2luZG93LnkgPSAwOwpAQCAtNTE5LDYgKzUxMCwxNyBAQCB2b2lkIFBsdWdpblZpZXc6OnNldE5Q V2luZG93SWZOZWVkZWQoKQogICAgIG1fcGx1Z2luLT5wbHVnaW5GdW5jcygpLT5zZXR3aW5kb3co bV9pbnN0YW5jZSwgJm1fbnBXaW5kb3cpOwogICAgIHNldENhbGxpbmdQbHVnaW4oZmFsc2UpOwog ICAgIFBsdWdpblZpZXc6OnNldEN1cnJlbnRQbHVnaW5WaWV3KDApOworCisgICAgaWYgKG1faXNX aW5kb3dlZCkgeworICAgICAgICBHdGtBbGxvY2F0aW9uIGFsbG9jYXRpb24gPSB7IG1fd2luZG93 UmVjdC54KCksIG1fd2luZG93UmVjdC55KCksIG1fd2luZG93UmVjdC53aWR0aCgpLCBtX3dpbmRv d1JlY3QuaGVpZ2h0KCkgfTsKKyAgICAgICAgZ3RrX3dpZGdldF9zaXplX2FsbG9jYXRlKHBsYXRm b3JtUGx1Z2luV2lkZ2V0KCksICZhbGxvY2F0aW9uKTsKKyNpZiBkZWZpbmVkKFhQX1VOSVgpCisg ICAgICAgIGlmICghbV9uZWVkc1hFbWJlZCkgeworICAgICAgICAgICAgZ3RrX3h0YmluX3NldF9w b3NpdGlvbihHVEtfWFRCSU4ocGxhdGZvcm1QbHVnaW5XaWRnZXQoKSksIG1fd2luZG93UmVjdC54 KCksIG1fd2luZG93UmVjdC55KCkpOworICAgICAgICAgICAgZ3RrX3h0YmluX3Jlc2l6ZShwbGF0 Zm9ybVBsdWdpbldpZGdldCgpLCBtX3dpbmRvd1JlY3Qud2lkdGgoKSwgbV93aW5kb3dSZWN0Lmhl aWdodCgpKTsKKyAgICAgICAgfQorI2VuZGlmCisgICAgfQogfQogCiB2b2lkIFBsdWdpblZpZXc6 OnNldFBhcmVudFZpc2libGUoYm9vbCB2aXNpYmxlKQotLSAKMS43LjMuMgoK 75936 2010-12-08 11:34:53 -0800 2010-12-08 19:34:00 -0800 Patch bug-47742-20101208113452.patch text/plain 3989 nicolas ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NmE4OWNjNWRkMWIwYjVlNTY4MGNkYmEwMDg0Y2JiZDhjY2RiZjAxMi4uN2RiNTAyYTM2NTIwMTdi Yjg5ZTBmZGFjMWM3MDE5YjY2ODg0N2NjNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMC0xMi0wOCAgTmlj b2xhcyBEdWZyZXNuZSAgPG5pY29sYXMuZHVmcmVzbmVAY29sbGFib3JhLmNvLnVrPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZ1bGwgcGFnZSBzaXpl IGZsYXNoIHBsdWdpbnMgZG8gbm90IHNob3cgaW4gYWxsIHNpdHVhdGlvbnMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3NzQyCisKKyAgICAgICAgVGhp cyBwYXRjaCBtb3ZlcyB0aGUgcGx1Z2luIHdpZGdldCBzaXplIGFsbG9jYXRpb24gYWZ0ZXIgdGhl CisgICAgICAgIE5QUF9TZXRXaW5kb3cgaXMgY2FsbGVkIHdpdGggdGhlIGVmZmVjdCB0aGF0IHRo ZSByZXNpemUgb2YgRmxhc2gKKyAgICAgICAgY29udGVudCBubyBsb25nZXIgcmVzdWx0IGluIGdy ZXkgZmxhc2guIFRoaXMgc2VlbXMgbG9naWNhbCBzaW5jZSB0aGUKKyAgICAgICAgd2lkZ2V0IHRy ZWUgY2Fubm90IGJlIGZ1bGx5IGNvbnN0cnVjdGVkIGJlZm9yZSB0aGUgcGx1Z2luIHJlY2VpdmVz CisgICAgICAgIHRoZSBuZXcgY29udGFpbmVyIHdpbmRvdy4KKworICAgICAgICBUZXN0OiBtYW51 YWwtdGVzdHMvcGx1Z2lucy9ndGstd2luZG93ZWQtZ3JleS1nbGl0Y2guaHRtbAorCisgICAgICAg ICogcGx1Z2lucy9ndGsvUGx1Z2luVmlld0d0ay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQbHVn aW5WaWV3OjpzZXROUFdpbmRvd0lmTmVlZGVkKToKKwogMjAxMC0xMi0wOCAgU2ltb24gRnJhc2Vy ICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYW4gQmVy bnN0ZWluLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9tYW51YWwtdGVzdHMvcGx1Z2lucy9ndGstd2lu ZG93ZWQtZ3JleS1nbGl0Y2guaHRtbCBiL1dlYkNvcmUvbWFudWFsLXRlc3RzL3BsdWdpbnMvZ3Rr LXdpbmRvd2VkLWdyZXktZ2xpdGNoLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNzM5NzVlYjMxY2Y5ZTM4MWFk ZGQ2NzkwMDAyZTU5MDMwM2ZmYTM2MgotLS0gL2Rldi9udWxsCisrKyBiL1dlYkNvcmUvbWFudWFs LXRlc3RzL3BsdWdpbnMvZ3RrLXdpbmRvd2VkLWdyZXktZ2xpdGNoLmh0bWwKQEAgLTAsMCArMSwy MCBAQAorPGh0bWw+Cis8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCI+CisgIGZ1bmN0aW9u IG9wZW5GdWxsU2NyZWVuRmxhc2goKSB7CisgICAgICB3aW5kb3cub3BlbigidGVzdC5zd2YiLCIi LCJ3aWR0aD0yMDAsaGVpZ2h0PTIwMCIpOworICB9Cis8L3NjcmlwdD4KKzxoZWFkPgorICA8dGl0 bGU+VGVzdCBncmV5IGdsaXRjaCB3aXRoIGZ1bGxzY3JlZW4gRmxhc2ggYW5pbWF0aW9uIChidXQg NDc3NDIpPC90aXRsZT4KKzwvaGVhZD4KKzxib2R5PgorICA8cD5UaGlzIG1hbnVhbCB0ZXN0IGlz IHVzZWQgdG8gdGVzdCA8YSBocmVmPSJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NDc3NDIiPmJ1ZyA0Nzc0MjwvYT4uPC9wPgorICA8dWw+CisgICAgPGxpPjEuIENsaWNr IG9uIHRoZSBidXR0b24gdG8gb3BlbiBwb3B1cCB3aXRoIGZ1bGwgc2NyZWVuIGZsYXNoIGFuaW1h dGlvbi48L2xpPgorICAgIDxsaT4yLiBNYWtlIHN1cmUgdGhlIHBvcHVwIGNvbnRlbnQgaXMgbm90 IGdyZXkuPC9saT4KKyAgICA8bGk+My4gUmVzaXplIHRoZSBwb3B1cC4gPC9saT4KKyAgICA8bGk+ NC4gTWFrZSBzdXJlIHRoZSByZXNpemUgZG9lcyBub3QgcHJvZHVjZSBncmV5IGZsYXNoIChlc3Bl Y2lhbGx5IHdoZW4gc2NhbGluZyBkb3duKS48L2xpPgorICA8L3VsPgorICA8aW5wdXQgdHlwZT0i YnV0dG9uIiB2YWx1ZT0iT3BlbiBmdWxsc2NyZWVuIEZsYXNoIiBvbmNsaWNrPSJvcGVuRnVsbFNj cmVlbkZsYXNoKCk7Ii8+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9XZWJDb3JlL3Bs dWdpbnMvZ3RrL1BsdWdpblZpZXdHdGsuY3BwIGIvV2ViQ29yZS9wbHVnaW5zL2d0ay9QbHVnaW5W aWV3R3RrLmNwcAppbmRleCAzNWY4ZWUyNThkNjE5ZjkyMDYwNDZiZjBhNmE0NzRmNDU4MzFlNmZi Li45MjVhYjc5ODc4ZTJmNjVmZjZmNDMxMTdhODBiMzMxNzc3NzY0MDlhIDEwMDY0NAotLS0gYS9X ZWJDb3JlL3BsdWdpbnMvZ3RrL1BsdWdpblZpZXdHdGsuY3BwCisrKyBiL1dlYkNvcmUvcGx1Z2lu cy9ndGsvUGx1Z2luVmlld0d0ay5jcHAKQEAgLTQ5MiwxNSArNDkyLDYgQEAgdm9pZCBQbHVnaW5W aWV3OjpzZXROUFdpbmRvd0lmTmVlZGVkKCkKICAgICAgICAgbV9ucFdpbmRvdy5jbGlwUmVjdC50 b3AgPSBtYXgoMCwgbV9jbGlwUmVjdC55KCkpOwogICAgICAgICBtX25wV2luZG93LmNsaXBSZWN0 LnJpZ2h0ID0gbV9jbGlwUmVjdC54KCkgKyBtX2NsaXBSZWN0LndpZHRoKCk7CiAgICAgICAgIG1f bnBXaW5kb3cuY2xpcFJlY3QuYm90dG9tID0gbV9jbGlwUmVjdC55KCkgKyBtX2NsaXBSZWN0Lmhl aWdodCgpOwotCi0gICAgICAgIEd0a0FsbG9jYXRpb24gYWxsb2NhdGlvbiA9IHsgbV93aW5kb3dS ZWN0LngoKSwgbV93aW5kb3dSZWN0LnkoKSwgbV93aW5kb3dSZWN0LndpZHRoKCksIG1fd2luZG93 UmVjdC5oZWlnaHQoKSB9OwotICAgICAgICBndGtfd2lkZ2V0X3NpemVfYWxsb2NhdGUocGxhdGZv cm1QbHVnaW5XaWRnZXQoKSwgJmFsbG9jYXRpb24pOwotI2lmIGRlZmluZWQoWFBfVU5JWCkKLSAg ICAgICAgaWYgKCFtX25lZWRzWEVtYmVkKSB7Ci0gICAgICAgICAgICBndGtfeHRiaW5fc2V0X3Bv c2l0aW9uKEdUS19YVEJJTihwbGF0Zm9ybVBsdWdpbldpZGdldCgpKSwgbV93aW5kb3dSZWN0Lngo KSwgbV93aW5kb3dSZWN0LnkoKSk7Ci0gICAgICAgICAgICBndGtfeHRiaW5fcmVzaXplKHBsYXRm b3JtUGx1Z2luV2lkZ2V0KCksIG1fd2luZG93UmVjdC53aWR0aCgpLCBtX3dpbmRvd1JlY3QuaGVp Z2h0KCkpOwotICAgICAgICB9Ci0jZW5kaWYKICAgICB9IGVsc2UgewogICAgICAgICBtX25wV2lu ZG93LnggPSAwOwogICAgICAgICBtX25wV2luZG93LnkgPSAwOwpAQCAtNTE5LDYgKzUxMCwxNyBA QCB2b2lkIFBsdWdpblZpZXc6OnNldE5QV2luZG93SWZOZWVkZWQoKQogICAgIG1fcGx1Z2luLT5w bHVnaW5GdW5jcygpLT5zZXR3aW5kb3cobV9pbnN0YW5jZSwgJm1fbnBXaW5kb3cpOwogICAgIHNl dENhbGxpbmdQbHVnaW4oZmFsc2UpOwogICAgIFBsdWdpblZpZXc6OnNldEN1cnJlbnRQbHVnaW5W aWV3KDApOworCisgICAgaWYgKG1faXNXaW5kb3dlZCkgeworICAgICAgICBHdGtBbGxvY2F0aW9u IGFsbG9jYXRpb24gPSB7IG1fd2luZG93UmVjdC54KCksIG1fd2luZG93UmVjdC55KCksIG1fd2lu ZG93UmVjdC53aWR0aCgpLCBtX3dpbmRvd1JlY3QuaGVpZ2h0KCkgfTsKKyAgICAgICAgZ3RrX3dp ZGdldF9zaXplX2FsbG9jYXRlKHBsYXRmb3JtUGx1Z2luV2lkZ2V0KCksICZhbGxvY2F0aW9uKTsK KyNpZiBkZWZpbmVkKFhQX1VOSVgpCisgICAgICAgIGlmICghbV9uZWVkc1hFbWJlZCkgeworICAg ICAgICAgICAgZ3RrX3h0YmluX3NldF9wb3NpdGlvbihHVEtfWFRCSU4ocGxhdGZvcm1QbHVnaW5X aWRnZXQoKSksIG1fd2luZG93UmVjdC54KCksIG1fd2luZG93UmVjdC55KCkpOworICAgICAgICAg ICAgZ3RrX3h0YmluX3Jlc2l6ZShwbGF0Zm9ybVBsdWdpbldpZGdldCgpLCBtX3dpbmRvd1JlY3Qu d2lkdGgoKSwgbV93aW5kb3dSZWN0LmhlaWdodCgpKTsKKyAgICAgICAgfQorI2VuZGlmCisgICAg fQogfQogCiB2b2lkIFBsdWdpblZpZXc6OnNldFBhcmVudFZpc2libGUoYm9vbCB2aXNpYmxlKQo=