47733 2010-10-15 12:54:19 -0700 [GTK] Soup cache code still has some warnings 2010-10-19 07:39:28 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P3 Normal --- 1 mrobinson webkit-unassigned pnormand svillar xan.lopez oldest_to_newest 294869 0 mrobinson 2010-10-15 12:54:19 -0700 I see this when building the Soup cache code: ../../WebCore/platform/network/soup/cache/webkit/soup-cache.c: In function ‘webkit_soup_cache_entry_set_freshness’: ../../WebCore/platform/network/soup/cache/webkit/soup-cache.c:300: warning: cast from pointer to integer of different size ../../WebCore/platform/network/soup/cache/webkit/soup-cache.c: In function ‘close_ready_cb’: ../../WebCore/platform/network/soup/cache/webkit/soup-cache.c:512: warning: comparison between signed and unsigned integer expressions 296081 1 71148 pnormand 2010-10-19 02:48:10 -0700 Created attachment 71148 proposed patch 296091 2 71148 xan.lopez 2010-10-19 03:28:31 -0700 Comment on attachment 71148 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=71148&action=review > WebCore/platform/network/soup/cache/webkit/soup-cache.c:302 > The original code would NOT revalidate if the 'must-revalidate' is not present. Your patch changes that so that it WILL revalidate if the key is not there. I don't think that's right? 296119 3 71155 pnormand 2010-10-19 05:05:07 -0700 Created attachment 71155 updated patch 296180 4 71155 xan.lopez 2010-10-19 07:30:17 -0700 Comment on attachment 71155 updated patch Awesome. 296185 5 pnormand 2010-10-19 07:39:28 -0700 Committed r70056: <http://trac.webkit.org/changeset/70056> 71148 2010-10-19 02:48:10 -0700 2010-10-19 05:05:07 -0700 proposed patch proposed-patch.patch text/plain 2324 pnormand RnJvbSA1MzMyNTk0ZmEyYjQyMGFmZDZlYWJjNGM5NDAzMzQyZDBlYmI0MGM5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUdWUsIDE5IE9jdCAyMDEwIDExOjQ4OjUwICswMjAwClN1YmplY3Q6IFtQQVRDSF0g cHJvcG9zZWQgcGF0Y2gKCi0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgfCAgIDE0ICsrKysrKysrKysrKysrCiAuLi4vbmV0d29yay9zb3VwL2Nh Y2hlL3dlYmtpdC9zb3VwLWNhY2hlLmMgICAgICAgICB8ICAgIDUgKysrLS0KIDIgZmlsZXMgY2hh bmdlZCwgMTcgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJD b3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDU5NTNlOTIuLjBkMDYwNDMg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMTAtMTkgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBp Z2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFtHVEtdIFNvdXAgY2FjaGUgY29kZSBzdGlsbCBoYXMgc29tZSB3YXJuaW5ncworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDc3MzMKKworICAgICAg ICBGaXhlZCBzb21lIGNvbXBpbGF0aW9uIHdhcm5pbmdzIGhhcHBlbmluZyB3aXRoIGdjYyA0LjQu NSBvbgorICAgICAgICA2NC1iaXRzIGFyY2hpdGVjdHVyZS4KKworICAgICAgICAqIHBsYXRmb3Jt L25ldHdvcmsvc291cC9jYWNoZS93ZWJraXQvc291cC1jYWNoZS5jOgorICAgICAgICAod2Via2l0 X3NvdXBfY2FjaGVfZW50cnlfc2V0X2ZyZXNobmVzcyk6CisgICAgICAgIChjbG9zZV9yZWFkeV9j Yik6CisKIDIwMTAtMTAtMTkgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwu Y29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI3MDAzNC4KZGlmZiAtLWdp dCBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL2NhY2hlL3dlYmtpdC9zb3VwLWNhY2hl LmMgYi9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9jYWNoZS93ZWJraXQvc291cC1jYWNo ZS5jCmluZGV4IDRhMTIzYmEuLmU4ZjVjOGEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0v bmV0d29yay9zb3VwL2NhY2hlL3dlYmtpdC9zb3VwLWNhY2hlLmMKKysrIGIvV2ViQ29yZS9wbGF0 Zm9ybS9uZXR3b3JrL3NvdXAvY2FjaGUvd2Via2l0L3NvdXAtY2FjaGUuYwpAQCAtMjk3LDcgKzI5 Nyw4IEBAIHdlYmtpdF9zb3VwX2NhY2hlX2VudHJ5X3NldF9mcmVzaG5lc3MgKFdlYktpdFNvdXBD YWNoZUVudHJ5ICplbnRyeSwgU291cE1lc3NhZ2UKIAkJaGFzaCA9IHNvdXBfaGVhZGVyX3BhcnNl X3BhcmFtX2xpc3QgKGNhY2hlX2NvbnRyb2wpOwogCiAJCS8qIFNob3VsZCB3ZSByZS12YWxpZGF0 ZSB0aGUgZW50cnkgd2hlbiBpdCBnb2VzIHN0YWxlICovCi0JCWVudHJ5LT5tdXN0X3JldmFsaWRh dGUgPSAoZ2Jvb2xlYW4pZ19oYXNoX3RhYmxlX2xvb2t1cCAoaGFzaCwgIm11c3QtcmV2YWxpZGF0 ZSIpOworCQlpZiAoIWdfaGFzaF90YWJsZV9sb29rdXBfZXh0ZW5kZWQgKGhhc2gsICJtdXN0LXJl dmFsaWRhdGUiLCBOVUxMLCAoZ3BvaW50ZXIpICZlbnRyeS0+bXVzdF9yZXZhbGlkYXRlKSkKKwkJ CWVudHJ5LT5tdXN0X3JldmFsaWRhdGUgPSBUUlVFOwogCiAJCS8qIFNlY3Rpb24gMi4zLjEgKi8K IAkJaWYgKHByaXYtPmNhY2hlX3R5cGUgPT0gV0VCS0lUX1NPVVBfQ0FDSEVfU0hBUkVEKSB7CkBA IC01MDksNyArNTEwLDcgQEAgY2xvc2VfcmVhZHlfY2IgKEdPYmplY3QgKnNvdXJjZSwgR0FzeW5j UmVzdWx0ICpyZXN1bHQsIFdlYktpdFNvdXBDYWNoZVdyaXRpbmdGaXgKIAkJd2Via2l0X3NvdXBf Y2FjaGVfZW50cnlfZnJlZSAoZW50cnksIFRSVUUpOwogCQllbnRyeSA9IE5VTEw7CiAJfSBlbHNl IGlmICgoc291cF9tZXNzYWdlX2hlYWRlcnNfZ2V0X2VuY29kaW5nIChlbnRyeS0+aGVhZGVycykg PT0gU09VUF9FTkNPRElOR19DSFVOS0VEKSB8fAotCQkgICBlbnRyeS0+bGVuZ3RoICE9IGNvbnRl bnRfbGVuZ3RoKSB7CisJCSAgIGVudHJ5LT5sZW5ndGggIT0gKGdzaXplKSBjb250ZW50X2xlbmd0 aCkgewogCQkvKiogVHdvIG9wdGlvbnMgaGVyZToKIAkJICoKIAkJICogMS4gImNodW5rZWQiIGRh dGEsIGVudHJ5IHdhcyB0ZW1wb3JhcmlseSBhZGRlZCB0bwotLSAKMS43LjE= 71155 2010-10-19 05:05:07 -0700 2010-10-19 07:30:17 -0700 updated patch updated-patch.patch text/plain 2260 pnormand RnJvbSAzOTJjOGQ1N2I4M2RjYjFhYzQ5NTA0NjQ0ODhiYWE3NWFhMDdhNmUyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUdWUsIDE5IE9jdCAyMDEwIDExOjQ4OjUwICswMjAwClN1YmplY3Q6IFtQQVRDSF0g dXBkYXRlZCBwYXRjaAoKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICB8ICAgMTQgKysrKysrKysrKysrKysKIC4uLi9uZXR3b3JrL3NvdXAvY2Fj aGUvd2Via2l0L3NvdXAtY2FjaGUuYyAgICAgICAgIHwgICAgNCArKy0tCiAyIGZpbGVzIGNoYW5n ZWQsIDE2IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViQ29y ZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBjMGM2ODZiLi4yYzBjNTU1IDEw MDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE3IEBACisyMDEwLTEwLTE5ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdh bGlhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbR1RLXSBTb3VwIGNhY2hlIGNvZGUgc3RpbGwgaGFzIHNvbWUgd2FybmluZ3MKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3NzMzCisKKyAgICAgICAg Rml4ZWQgc29tZSBjb21waWxhdGlvbiB3YXJuaW5ncyBoYXBwZW5pbmcgd2l0aCBnY2MgNC40LjUg b24KKyAgICAgICAgNjQtYml0cyBhcmNoaXRlY3R1cmUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9u ZXR3b3JrL3NvdXAvY2FjaGUvd2Via2l0L3NvdXAtY2FjaGUuYzoKKyAgICAgICAgKHdlYmtpdF9z b3VwX2NhY2hlX2VudHJ5X3NldF9mcmVzaG5lc3MpOgorICAgICAgICAoY2xvc2VfcmVhZHlfY2Ip OgorCiAyMDEwLTEwLTE5ICBCZW4gTXVyZG9jaCAgPGJlbm1AZ29vZ2xlLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBTdGV2ZSBCbG9jay4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0v bmV0d29yay9zb3VwL2NhY2hlL3dlYmtpdC9zb3VwLWNhY2hlLmMgYi9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvc291cC9jYWNoZS93ZWJraXQvc291cC1jYWNoZS5jCmluZGV4IDRhMTIzYmEuLjcz YjE1YmEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL2NhY2hlL3dl YmtpdC9zb3VwLWNhY2hlLmMKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvY2Fj aGUvd2Via2l0L3NvdXAtY2FjaGUuYwpAQCAtMjk3LDcgKzI5Nyw3IEBAIHdlYmtpdF9zb3VwX2Nh Y2hlX2VudHJ5X3NldF9mcmVzaG5lc3MgKFdlYktpdFNvdXBDYWNoZUVudHJ5ICplbnRyeSwgU291 cE1lc3NhZ2UKIAkJaGFzaCA9IHNvdXBfaGVhZGVyX3BhcnNlX3BhcmFtX2xpc3QgKGNhY2hlX2Nv bnRyb2wpOwogCiAJCS8qIFNob3VsZCB3ZSByZS12YWxpZGF0ZSB0aGUgZW50cnkgd2hlbiBpdCBn b2VzIHN0YWxlICovCi0JCWVudHJ5LT5tdXN0X3JldmFsaWRhdGUgPSAoZ2Jvb2xlYW4pZ19oYXNo X3RhYmxlX2xvb2t1cCAoaGFzaCwgIm11c3QtcmV2YWxpZGF0ZSIpOworCQllbnRyeS0+bXVzdF9y ZXZhbGlkYXRlID0gZ19oYXNoX3RhYmxlX2xvb2t1cF9leHRlbmRlZCAoaGFzaCwgIm11c3QtcmV2 YWxpZGF0ZSIsIE5VTEwsIE5VTEwpOwogCiAJCS8qIFNlY3Rpb24gMi4zLjEgKi8KIAkJaWYgKHBy aXYtPmNhY2hlX3R5cGUgPT0gV0VCS0lUX1NPVVBfQ0FDSEVfU0hBUkVEKSB7CkBAIC01MDksNyAr NTA5LDcgQEAgY2xvc2VfcmVhZHlfY2IgKEdPYmplY3QgKnNvdXJjZSwgR0FzeW5jUmVzdWx0ICpy ZXN1bHQsIFdlYktpdFNvdXBDYWNoZVdyaXRpbmdGaXgKIAkJd2Via2l0X3NvdXBfY2FjaGVfZW50 cnlfZnJlZSAoZW50cnksIFRSVUUpOwogCQllbnRyeSA9IE5VTEw7CiAJfSBlbHNlIGlmICgoc291 cF9tZXNzYWdlX2hlYWRlcnNfZ2V0X2VuY29kaW5nIChlbnRyeS0+aGVhZGVycykgPT0gU09VUF9F TkNPRElOR19DSFVOS0VEKSB8fAotCQkgICBlbnRyeS0+bGVuZ3RoICE9IGNvbnRlbnRfbGVuZ3Ro KSB7CisJCSAgIGVudHJ5LT5sZW5ndGggIT0gKGdzaXplKSBjb250ZW50X2xlbmd0aCkgewogCQkv KiogVHdvIG9wdGlvbnMgaGVyZToKIAkJICoKIAkJICogMS4gImNodW5rZWQiIGRhdGEsIGVudHJ5 IHdhcyB0ZW1wb3JhcmlseSBhZGRlZCB0bwotLSAKMS43LjIuMw==