47726 2010-10-15 10:09:12 -0700 build-webkit: Should die when make fails when build a CMake project 2010-10-15 10:37:26 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 leandro leandro commit-queue oldest_to_newest 294794 0 leandro 2010-10-15 10:09:12 -0700 build-webkit: Should die when make fails when build a CMake project 294795 1 70880 leandro 2010-10-15 10:10:43 -0700 Created attachment 70880 Patch 294799 2 leandro 2010-10-15 10:14:45 -0700 This small bloop was causing the EFL buildbot and EWS to report a green light even when make failed. 294802 3 70880 gustavo 2010-10-15 10:20:49 -0700 Comment on attachment 70880 Patch LGTM! 294807 4 70880 commit-queue 2010-10-15 10:37:21 -0700 Comment on attachment 70880 Patch Clearing flags on attachment: 70880 Committed r69863: <http://trac.webkit.org/changeset/69863> 294808 5 commit-queue 2010-10-15 10:37:26 -0700 All reviewed patches have been landed. Closing bug. 70880 2010-10-15 10:10:43 -0700 2010-10-15 10:37:21 -0700 Patch bug-47726-20101015141036.patch text/plain 1097 leandro SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDY5ODYwKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMTAtMTUgIExlYW5kcm8gUGVyZWlyYSAg PGxlYW5kcm9AcHJvZnVzaW9uLm1vYmk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgYnVpbGQtd2Via2l0OiBTaG91bGQgZGllIHdoZW4gbWFrZSBmYWls cyB3aGVuIGJ1aWxkIGEgQ01ha2UgcHJvamVjdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDc3MjYKKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGly cy5wbTogSWYgbWFrZSBmYWlscywgZGllIGltbWVkaWF0ZWx5LgorCiAyMDEwLTEwLTE1ICBTaGVy aWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmll d2VkLCByb2xsaW5nIG91dCByNjk4MDkuCkluZGV4OiBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtp dGRpcnMucG0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBt CShyZXZpc2lvbiA2OTc4NikKKysrIFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQko d29ya2luZyBjb3B5KQpAQCAtMTQ2MSw2ICsxNDYxLDkgQEAgc3ViIGJ1aWxkQ01ha2VQcm9qZWN0 KCRAKQogCiAgICAgICAgIHByaW50ICJDYWxsaW5nICckbWFrZSAkbWFrZUFyZ3MnIGluICIgLiAk ZGlyIC4gIlxuXG4iOwogICAgICAgICAkcmVzdWx0ID0gc3lzdGVtICIkbWFrZSAkbWFrZUFyZ3Mi OworICAgICAgICBpZiAoJHJlc3VsdCBuZSAwKSB7CisgICAgICAgICAgICBkaWUgIkZhaWxlZCB0 byBidWlsZCAkcG9ydCBwb3J0XG4iOworICAgICAgICB9CiAKICAgICAgICAgY2hkaXIgIi4uIiBv ciBkaWU7CiAgICAgfQo=