47706 2010-10-14 18:19:50 -0700 Add "in select" insertion mode to parser. 2010-10-19 17:57:36 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 46676 0 simonjam webkit-unassigned abarth commit-queue eric oldest_to_newest 294515 0 simonjam 2010-10-14 18:19:50 -0700 Add "in select" insertion mode to parser. 294517 1 70815 simonjam 2010-10-14 18:24:42 -0700 Created attachment 70815 Patch 294518 2 simonjam 2010-10-14 18:25:51 -0700 I couldn't figure out how to contrive a test case to exercise this. If you know how, please let me know. 294615 3 70815 abarth 2010-10-15 00:42:08 -0700 Comment on attachment 70815 Patch From the ASSERT, it looks like you'll need to parse a fragment. Maybe try setting the innerHTML of an <option> element to "</select>" ? <select> <option>xxx</option> </select> You might need to mix in some optgroup elements or something to see the difference between table scope and select scope. r- for no test. Tests for these sorts of changes are essential. 295763 4 simonjam 2010-10-18 14:40:29 -0700 I don't think it's possible to test. The innerHTML of <option> doesn't work because that's processed in "in body" mode. Only <select> starts "in select" mode. From "in select" mode, there doesn't seem to be any way to insert an element that would change the scope, but not the mode. 296351 5 70815 abarth 2010-10-19 13:07:29 -0700 Comment on attachment 70815 Patch We looked at this change in detail. We don't believe it's observable because it's not possible to have a select element in the stack of open elements when in fragment mode. 296380 6 70815 commit-queue 2010-10-19 13:53:47 -0700 Comment on attachment 70815 Patch Rejecting patch 70815 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'land-attachment', '--force-clean', '--ignore-builders', '--quiet', '--non-interactive', '--parent-command=commit-queue', 70815]" exit_code: 2 Last 500 characters of output: atform/win/Skipped M LayoutTests/ChangeLog r70080 = 6b74d470f67a7767229ffea11b1571769f0f5ce5 (refs/remotes/trunk) First, rewinding head to replay your work on top of it... error: Untracked working tree file 'LayoutTests/fast/dom/nodesFromRect-links-and-text-expected.txt' would be overwritten by merge. could not detach HEAD rebase refs/remotes/trunk: command returned error: 1 Died at WebKitTools/Scripts/update-webkit line 129. Failed to run "['WebKitTools/Scripts/update-webkit']" exit_code: 2 Full output: http://queues.webkit.org/results/4558003 296388 7 eric 2010-10-19 14:03:22 -0700 Eek. I'lll see if I can figure out which bot has the screwy checkout. 296407 8 abarth 2010-10-19 14:24:07 -0700 (In reply to comment #7) > Eek. I'lll see if I can figure out which bot has the screwy checkout. Is there a command line argument we can pass to run-webkit-tests to tell it not to generated results for new tests? 296412 9 eric 2010-10-19 14:28:36 -0700 --[no-]new-test-results Generate results for new tests 296420 10 70815 abarth 2010-10-19 14:49:14 -0700 Comment on attachment 70815 Patch Adam's machine's checkout was wedged (eseidel) 296451 11 70815 commit-queue 2010-10-19 15:16:29 -0700 Comment on attachment 70815 Patch Clearing flags on attachment: 70815 Committed r70094: <http://trac.webkit.org/changeset/70094> 296452 12 commit-queue 2010-10-19 15:16:36 -0700 All reviewed patches have been landed. Closing bug. 296569 13 abarth 2010-10-19 17:57:36 -0700 (In reply to comment #9) > --[no-]new-test-results Generate results for new tests We should definitely add that. 70815 2010-10-14 18:24:42 -0700 2010-10-19 15:16:29 -0700 Patch bug-47706-20101014182441.patch text/plain 4223 simonjam ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Njg5YWM3YjYxMzBhOTg2ZjNkNmIxOTI5ZTUyNGMwZThlNGUzOGJmYS4uNzAxZDQ5OTM1MDEzZGIw Mjk0YzkyMDNlMWEwZTZiOTI1OGZmMWVlMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNyBAQAorMjAxMC0xMC0xNCAgSmFt ZXMgU2ltb25zZW4gIDxzaW1vbmphbUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkICJpbiBzZWxlY3QiIGluc2VydGlvbiBt b2RlIHRvIHBhcnNlci4KKworICAgICAgICBUaGlzIHdhcyBhZGRlZCB0byB0aGUgc3BlYyBpbjoK KyAgICAgICAgaHR0cDovL2h0bWw1Lm9yZy90b29scy93ZWItYXBwcy10cmFja2VyP2Zyb209NTUy MCZ0bz01NTIyCisKKyAgICAgICAgQW5kIGFzIGEgcmVzdWx0IG9mOgorICAgICAgICBodHRwOi8v d3d3LnczLm9yZy9CdWdzL1B1YmxpYy9zaG93X2J1Zy5jZ2k/aWQ9MTAzMTQKKworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDc3MDYKKworICAgICAgICBO byBuZXcgdGVzdHMuIE9wZW4gdG8gaWRlYXMuCisKKyAgICAgICAgKiBodG1sL3BhcnNlci9IVE1M RWxlbWVudFN0YWNrLmNwcDogQWRkZWQgImluIHNlbGVjdCIgbW9kZS4KKyAgICAgICAgKFdlYkNv cmU6OkhUTUxOYW1lczo6aXNTZWxlY3RTY29wZU1hcmtlcik6IERpdHRvLgorICAgICAgICAoV2Vi Q29yZTo6SFRNTEVsZW1lbnRTdGFjazo6aW5TZWxlY3RTY29wZSk6IERpdHRvLgorICAgICAgICAq IGh0bWwvcGFyc2VyL0hUTUxFbGVtZW50U3RhY2suaDogRGl0dG8uCisgICAgICAgICogaHRtbC9w YXJzZXIvSFRNTFRyZWVCdWlsZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxUcmVlQnVp bGRlcjo6cHJvY2Vzc1N0YXJ0VGFnKTogVXNlICJpbiBzZWxlY3QiIGluc3RlYWQgb2YgImluIHRh YmxlLiIKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxUcmVlQnVpbGRlcjo6cHJvY2Vzc0VuZFRhZyk6 IERpdHRvLgorCiAyMDEwLTEwLTE0ICBKYW1lcyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gRnJhc2VyLgpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9odG1sL3BhcnNlci9IVE1MRWxlbWVudFN0YWNrLmNwcCBiL1dlYkNvcmUvaHRtbC9wYXJz ZXIvSFRNTEVsZW1lbnRTdGFjay5jcHAKaW5kZXggMTIzNzc4ZDBjOTkwZTgxYzQwYmEyYTdhYTgx NmU2MTgyNWU4YTcxMS4uNmI5NjI5MWRjMjk5YWEyNjU5YmYwNTBhNDBjZGU5MDk2NTkzMzBlYiAx MDA2NDQKLS0tIGEvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MRWxlbWVudFN0YWNrLmNwcAorKysg Yi9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxFbGVtZW50U3RhY2suY3BwCkBAIC0xMTMsNiArMTEz LDEyIEBAIGlubGluZSBib29sIGlzQnV0dG9uU2NvcGVNYXJrZXIoRWxlbWVudCogZWxlbWVudCkK ICAgICAgICAgfHwgZWxlbWVudC0+aGFzVGFnTmFtZShidXR0b25UYWcpOwogfQogCitpbmxpbmUg Ym9vbCBpc1NlbGVjdFNjb3BlTWFya2VyKEVsZW1lbnQqIGVsZW1lbnQpCit7CisgICAgcmV0dXJu ICFlbGVtZW50LT5oYXNUYWdOYW1lKG9wdGdyb3VwVGFnKQorICAgICAgICAmJiAhZWxlbWVudC0+ aGFzVGFnTmFtZShvcHRpb25UYWcpOworfQorCiB9CiAKIEhUTUxFbGVtZW50U3RhY2s6OkVsZW1l bnRSZWNvcmQ6OkVsZW1lbnRSZWNvcmQoUGFzc1JlZlB0cjxFbGVtZW50PiBlbGVtZW50LCBQYXNz T3duUHRyPEVsZW1lbnRSZWNvcmQ+IG5leHQpCkBAIC00ODYsNiArNDkyLDE3IEBAIGJvb2wgSFRN TEVsZW1lbnRTdGFjazo6aW5CdXR0b25TY29wZShjb25zdCBRdWFsaWZpZWROYW1lJiB0YWdOYW1l KSBjb25zdAogICAgIHJldHVybiBpbkJ1dHRvblNjb3BlKHRhZ05hbWUubG9jYWxOYW1lKCkpOwog fQogCitib29sIEhUTUxFbGVtZW50U3RhY2s6OmluU2VsZWN0U2NvcGUoY29uc3QgQXRvbWljU3Ry aW5nJiB0YXJnZXRUYWcpIGNvbnN0Cit7CisgICAgcmV0dXJuIGluU2NvcGVDb21tb248aXNTZWxl Y3RTY29wZU1hcmtlcj4obV90b3AuZ2V0KCksIHRhcmdldFRhZyk7Cit9CisKK2Jvb2wgSFRNTEVs ZW1lbnRTdGFjazo6aW5TZWxlY3RTY29wZShjb25zdCBRdWFsaWZpZWROYW1lJiB0YWdOYW1lKSBj b25zdAoreworICAgIC8vIEZJWE1FOiBJcyBsb2NhbE5hbWUoKSByaWdodCBmb3Igbm9uLWh0bWwg ZWxlbWVudHM/CisgICAgcmV0dXJuIGluU2VsZWN0U2NvcGUodGFnTmFtZS5sb2NhbE5hbWUoKSk7 Cit9CisKIEVsZW1lbnQqIEhUTUxFbGVtZW50U3RhY2s6Omh0bWxFbGVtZW50KCkgY29uc3QKIHsK ICAgICBBU1NFUlQobV9odG1sRWxlbWVudCk7CmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0bWwvcGFy c2VyL0hUTUxFbGVtZW50U3RhY2suaCBiL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTEVsZW1lbnRT dGFjay5oCmluZGV4IDQ3ZmE2MDMyYzJmMGFlNzg5YWI3OGQ3MTRhYTlhZWZlZDA4Mjk0NDUuLjhh OGUxNjAwMDBhNDgxOTE4NjczYjkzZmU1MDU0Y2YyN2Q4ZTI1MmQgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvaHRtbC9wYXJzZXIvSFRNTEVsZW1lbnRTdGFjay5oCisrKyBiL1dlYkNvcmUvaHRtbC9wYXJz ZXIvSFRNTEVsZW1lbnRTdGFjay5oCkBAIC0xMTcsNiArMTE3LDggQEAgcHVibGljOgogICAgIGJv b2wgaW5UYWJsZVNjb3BlKGNvbnN0IFF1YWxpZmllZE5hbWUmKSBjb25zdDsKICAgICBib29sIGlu QnV0dG9uU2NvcGUoY29uc3QgQXRvbWljU3RyaW5nJiB0YWdOYW1lKSBjb25zdDsKICAgICBib29s IGluQnV0dG9uU2NvcGUoY29uc3QgUXVhbGlmaWVkTmFtZSYpIGNvbnN0OworICAgIGJvb2wgaW5T ZWxlY3RTY29wZShjb25zdCBBdG9taWNTdHJpbmcmIHRhZ05hbWUpIGNvbnN0OworICAgIGJvb2wg aW5TZWxlY3RTY29wZShjb25zdCBRdWFsaWZpZWROYW1lJikgY29uc3Q7CiAKICAgICBib29sIGhh c09ubHlIVE1MRWxlbWVudHNJblNjb3BlKCkgY29uc3Q7CiAgICAgYm9vbCBoYXNOdW1iZXJlZEhl YWRlckVsZW1lbnRJblNjb3BlKCkgY29uc3Q7CmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0bWwvcGFy c2VyL0hUTUxUcmVlQnVpbGRlci5jcHAgYi9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxUcmVlQnVp bGRlci5jcHAKaW5kZXggYTIyMzZkNTQ0ZTIxM2JmY2Q2MDRmZjFjYzlhNTZjNWY0OGE0NWY2MS4u NWY5MDI4NWQ1YTdkMDc0MzRjODFiNDdiY2VmNzU3NGZjMDdmNmUwYSAxMDA2NDQKLS0tIGEvV2Vi Q29yZS9odG1sL3BhcnNlci9IVE1MVHJlZUJ1aWxkZXIuY3BwCisrKyBiL1dlYkNvcmUvaHRtbC9w YXJzZXIvSFRNTFRyZWVCdWlsZGVyLmNwcApAQCAtMTQyMiw3ICsxNDIyLDcgQEAgdm9pZCBIVE1M VHJlZUJ1aWxkZXI6OnByb2Nlc3NTdGFydFRhZyhBdG9taWNIVE1MVG9rZW4mIHRva2VuKQogICAg ICAgICAgICAgfHwgdG9rZW4ubmFtZSgpID09IGtleWdlblRhZwogICAgICAgICAgICAgfHwgdG9r ZW4ubmFtZSgpID09IHRleHRhcmVhVGFnKSB7CiAgICAgICAgICAgICBwYXJzZUVycm9yKHRva2Vu KTsKLSAgICAgICAgICAgIGlmICghbV90cmVlLm9wZW5FbGVtZW50cygpLT5pblRhYmxlU2NvcGUo c2VsZWN0VGFnKSkgeworICAgICAgICAgICAgaWYgKCFtX3RyZWUub3BlbkVsZW1lbnRzKCktPmlu U2VsZWN0U2NvcGUoc2VsZWN0VGFnKSkgewogICAgICAgICAgICAgICAgIEFTU0VSVChpc1BhcnNp bmdGcmFnbWVudCgpKTsKICAgICAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgICAgICB9CkBA IC0yMjc5LDcgKzIyNzksNyBAQCB2b2lkIEhUTUxUcmVlQnVpbGRlcjo6cHJvY2Vzc0VuZFRhZyhB dG9taWNIVE1MVG9rZW4mIHRva2VuKQogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CiAg ICAgICAgIGlmICh0b2tlbi5uYW1lKCkgPT0gc2VsZWN0VGFnKSB7Ci0gICAgICAgICAgICBpZiAo IW1fdHJlZS5vcGVuRWxlbWVudHMoKS0+aW5UYWJsZVNjb3BlKHRva2VuLm5hbWUoKSkpIHsKKyAg ICAgICAgICAgIGlmICghbV90cmVlLm9wZW5FbGVtZW50cygpLT5pblNlbGVjdFNjb3BlKHRva2Vu Lm5hbWUoKSkpIHsKICAgICAgICAgICAgICAgICBBU1NFUlQoaXNQYXJzaW5nRnJhZ21lbnQoKSk7 CiAgICAgICAgICAgICAgICAgcGFyc2VFcnJvcih0b2tlbik7CiAgICAgICAgICAgICAgICAgcmV0 dXJuOwo=