47698 2010-10-14 16:25:55 -0700 [EFL] REGRESSION(69798) UCHAR can't be converted to String. 2010-10-15 05:23:52 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 ryuan.choi webkit-unassigned antognolli+webkit commit-queue kenneth leandro lucas.de.marchi tonikitoo zimmermann oldest_to_newest 294450 0 ryuan.choi 2010-10-14 16:25:55 -0700 /workspace/webkit/WebCore/platform/efl/PlatformKeyboardEventEfl.cpp: In function ‘void WebCore::createWindowsKeyMap()’: /workspace/webkit/WebCore/platform/efl/PlatformKeyboardEventEfl.cpp:136:32: error: conversion from ‘UChar’ to ‘WTF::String’ is ambiguous /workspace/webkit/JavaScriptCore/wtf/text/WTFString.h:312:5: note: candidates are: WTF::String::String(WTF::HashTableDeletedValueType) <near match> /workspace/webkit/JavaScriptCore/wtf/text/WTFString.h:96:5: note: WTF::String::String(WTF::StringImpl*) <near match> /workspace/webkit/JavaScriptCore/wtf/text/WTFString.h:93:5: note: WTF::String::String(const char*) <near match> /workspace/webkit/JavaScriptCore/wtf/text/WTFString.h:87:5: note: WTF::String::String(const UChar*) <near match> 294473 1 70804 ryuan.choi 2010-10-14 17:04:29 -0700 Created attachment 70804 Patch 294639 2 70804 zimmermann 2010-10-15 01:42:55 -0700 Comment on attachment 70804 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=70804&action=review Sorry, I wasn't aware EFL builds is broken. I checked the efl EWS bubble and it was green. Don't you actually build patches? > JavaScriptCore/wtf/text/WTFString.h:139 > + static String character(char); This should be avoided. > WebCore/platform/efl/PlatformKeyboardEventEfl.cpp:134 > String alphabet = "abcdefghijklmnopqrstuvwxyz"; I suggest changing this to: char alphabet[] = "abc..."; > WebCore/platform/efl/PlatformKeyboardEventEfl.cpp:136 > + String key = String::character(static_cast<char>(alphabet[i])); Then use: String key(alphabet + i, 1); here. 294691 3 70852 ryuan.choi 2010-10-15 04:46:15 -0700 Created attachment 70852 Patch 294693 4 70852 zimmermann 2010-10-15 04:51:14 -0700 Comment on attachment 70852 Patch Thanks a lot, this is it :-) 294697 5 commit-queue 2010-10-15 05:11:55 -0700 The commit-queue encountered the following flaky tests while processing attachment 70852: [u'http/tests/websocket/tests/close-on-navigate-new-location.html', u'http/tests/appcache/credential-url.html'] Please file bugs against the tests. The commit-queue is continuing to process your patch. 294703 6 70852 commit-queue 2010-10-15 05:23:45 -0700 Comment on attachment 70852 Patch Clearing flags on attachment: 70852 Committed r69849: <http://trac.webkit.org/changeset/69849> 294704 7 commit-queue 2010-10-15 05:23:52 -0700 All reviewed patches have been landed. Closing bug. 70804 2010-10-14 17:04:29 -0700 2010-10-15 04:46:08 -0700 Patch bug-47698-20101015090432.patch text/plain 2914 ryuan.choi SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDY5ODIyKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMTAtMTQgIFJ5dWFuIENo b2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtFRkxdIFJFR1JFU1NJT04oNjk3OTgpIFVDSEFSIGNhbid0 IGJlIGNvbnZlcnRlZCB0byBTdHJpbmcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD00NzY5OAorCisgICAgICAgIEltcGxlbWVudCBTdHJpbmc6OmNoYXJh Y3RlciBtZXRob2QgdG8gY29udmVydCBjaGFyIHRvIFN0cmluZy4KKworICAgICAgICAqIHd0Zi90 ZXh0L1dURlN0cmluZy5jcHA6IEFkZCBjaGFyYWN0ZXIoY2hhciBjKQorICAgICAgICAoV1RGOjpT dHJpbmc6OmNoYXJhY3Rlcik6CisgICAgICAgICogd3RmL3RleHQvV1RGU3RyaW5nLmg6CisKIDIw MTAtMTAtMTQgIE5pa29sYXMgWmltbWVybWFubiAgPG56aW1tZXJtYW5uQHJpbS5jb20+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgR2F2aW4gQmFycmFjbG91Z2guCkluZGV4OiBKYXZhU2NyaXB0Q29y ZS93dGYvdGV4dC9XVEZTdHJpbmcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL3d0 Zi90ZXh0L1dURlN0cmluZy5jcHAJKHJldmlzaW9uIDY5ODA3KQorKysgSmF2YVNjcmlwdENvcmUv d3RmL3RleHQvV1RGU3RyaW5nLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDA1LDYgKzQwNSwxMSBA QCBTdHJpbmcgU3RyaW5nOjpmb3JtYXQoY29uc3QgY2hhciAqZm9ybWF0CiAjZW5kaWYKIH0KIAor U3RyaW5nIFN0cmluZzo6Y2hhcmFjdGVyKGNoYXIgYykKK3sKKyAgICByZXR1cm4gU3RyaW5nOjpm b3JtYXQoIiVjIiwgYyk7Cit9CisKIFN0cmluZyBTdHJpbmc6Om51bWJlcihzaG9ydCBuKQogewog ICAgIHJldHVybiBTdHJpbmc6OmZvcm1hdCgiJWhkIiwgbik7CkluZGV4OiBKYXZhU2NyaXB0Q29y ZS93dGYvdGV4dC9XVEZTdHJpbmcuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS93dGYv dGV4dC9XVEZTdHJpbmcuaAkocmV2aXNpb24gNjk4MDcpCisrKyBKYXZhU2NyaXB0Q29yZS93dGYv dGV4dC9XVEZTdHJpbmcuaAkod29ya2luZyBjb3B5KQpAQCAtMTM2LDYgKzEzNiw4IEBAIHB1Ymxp YzoKICAgICAgICAgcmV0dXJuIG1faW1wbC0+Y2hhcmFjdGVycygpW2luZGV4XTsKICAgICB9CiAK KyAgICBzdGF0aWMgU3RyaW5nIGNoYXJhY3RlcihjaGFyKTsKKwogICAgIHN0YXRpYyBTdHJpbmcg bnVtYmVyKHNob3J0KTsKICAgICBzdGF0aWMgU3RyaW5nIG51bWJlcih1bnNpZ25lZCBzaG9ydCk7 CiAgICAgc3RhdGljIFN0cmluZyBudW1iZXIoaW50KTsKSW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9n Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiA2OTgyMikKKysrIFdl YkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMTAt MTQgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtFRkxdIFJFR1JFU1NJT04oNjk3OTgp IFVDSEFSIGNhbid0IGJlIGNvbnZlcnRlZCB0byBTdHJpbmcuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NzY5OAorCisgICAgICAgIENhbGwgU3RyaW5n OjpjaGFyYWN0ZXIoKSB0byBjb252ZXJ0IFVDSEFSIHRvIFN0cmluZy4KKworICAgICAgICBObyB0 ZXN0cy4gTm8gZnVuY3Rpb25hbGl0eSBjaGFuZ2VkLgorCisgICAgICAgICogcGxhdGZvcm0vZWZs L1BsYXRmb3JtS2V5Ym9hcmRFdmVudEVmbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjcmVhdGVX aW5kb3dzS2V5TWFwKToKKwogMjAxMC0xMC0xNCAgQmV0aCBEYWtpbiAgPGJkYWtpbkBhcHBsZS5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2ZSBIeWF0dC4KSW5kZXg6IFdlYkNvcmUvcGxh dGZvcm0vZWZsL1BsYXRmb3JtS2V5Ym9hcmRFdmVudEVmbC5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9wbGF0Zm9ybS9lZmwvUGxhdGZvcm1LZXlib2FyZEV2ZW50RWZsLmNwcAkocmV2aXNpb24g Njk4MDcpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2VmbC9QbGF0Zm9ybUtleWJvYXJkRXZlbnRFZmwu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMzMsNyArMTMzLDcgQEAgc3RhdGljIHZvaWQgY3JlYXRl V2luZG93c0tleU1hcCgpCiAgICAgLy8gQWxwaGFiZXQKICAgICBTdHJpbmcgYWxwaGFiZXQgPSAi YWJjZGVmZ2hpamtsbW5vcHFyc3R1dnd4eXoiOwogICAgIGZvciAodW5zaWduZWQgaW50IGkgPSAw OyBpIDwgMjY7IGkrKykgewotICAgICAgICBTdHJpbmcga2V5ID0gYWxwaGFiZXRbaV07CisgICAg ICAgIFN0cmluZyBrZXkgPSBTdHJpbmc6OmNoYXJhY3RlcihzdGF0aWNfY2FzdDxjaGFyPihhbHBo YWJldFtpXSkpOwogICAgICAgICBnV2luZG93c0tleU1hcC5zZXQoa2V5LCBWS19BICsgaSk7CiAg ICAgfQogCg== 70852 2010-10-15 04:46:15 -0700 2010-10-15 05:23:45 -0700 Patch bug-47698-20101015204612.patch text/plain 1390 ryuan.choi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2OTg0OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMTAtMTUgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1 bmcuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtFRkxdIFJFR1JFU1NJT04oNjk3OTgpIFVDSEFSIGNhbid0IGJlIGNvbnZlcnRlZCB0byBTdHJp bmcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NzY5 OAorCisgICAgICAgIENyZWF0ZSBTdHJpbmcgdmFsdWUgdXNpbmcgU3RyaW5nKGNvbnN0IGNoYXIq LCAxKSBpbnN0ZWFkIG9mIG9wZXJhdG9yW10uCisKKyAgICAgICAgTm8gdGVzdHMuIE5vIGZ1bmN0 aW9uYWxpdHkgY2hhbmdlZC4KKworICAgICAgICAqIHBsYXRmb3JtL2VmbC9QbGF0Zm9ybUtleWJv YXJkRXZlbnRFZmwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Y3JlYXRlV2luZG93c0tleU1hcCk6 CisKIDIwMTAtMTAtMTUgIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgWGFuIExvcGV6LgpJbmRleDogV2ViQ29yZS9wbGF0Zm9y bS9lZmwvUGxhdGZvcm1LZXlib2FyZEV2ZW50RWZsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3Jl L3BsYXRmb3JtL2VmbC9QbGF0Zm9ybUtleWJvYXJkRXZlbnRFZmwuY3BwCShyZXZpc2lvbiA2OTg0 OCkKKysrIFdlYkNvcmUvcGxhdGZvcm0vZWZsL1BsYXRmb3JtS2V5Ym9hcmRFdmVudEVmbC5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTEzMSw5ICsxMzEsOSBAQCBzdGF0aWMgdm9pZCBjcmVhdGVXaW5k b3dzS2V5TWFwKCkKICAgICBnV2luZG93c0tleU1hcC5zZXQoInF1b3RlZGJsIiwgICAgIFZLX09F TV83KTsKIAogICAgIC8vIEFscGhhYmV0Ci0gICAgU3RyaW5nIGFscGhhYmV0ID0gImFiY2RlZmdo aWprbG1ub3BxcnN0dXZ3eHl6IjsKKyAgICBjb25zdCBjaGFyKiBhbHBoYWJldCA9ICJhYmNkZWZn aGlqa2xtbm9wcXJzdHV2d3h5eiI7CiAgICAgZm9yICh1bnNpZ25lZCBpbnQgaSA9IDA7IGkgPCAy NjsgaSsrKSB7Ci0gICAgICAgIFN0cmluZyBrZXkgPSBhbHBoYWJldFtpXTsKKyAgICAgICAgU3Ry aW5nIGtleShhbHBoYWJldCArIGksIDEpOwogICAgICAgICBnV2luZG93c0tleU1hcC5zZXQoa2V5 LCBWS19BICsgaSk7CiAgICAgfQogCg==