47694 2010-10-14 15:02:38 -0700 [CMAKE] additional arguments was missed in GENERATE_DOM_NAMES 2010-10-19 19:18:33 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 ryuan.choi webkit-unassigned abarth antognolli+webkit commit-queue kenneth leandro lucas.de.marchi tonikitoo oldest_to_newest 294391 0 ryuan.choi 2010-10-14 15:02:38 -0700 crash while loading http://www.samsung.com/us. The reason looks that EFL port doesn't define STORE_FONT_CUSTOM_PLATFORM_DATA in CachedFont.cpp like other ports. 294505 1 ryuan.choi 2010-10-14 17:52:10 -0700 I found simple page which have same crash : https://bug-38758-attachments.webkit.org/attachment.cgi?id=55715 294525 2 70818 ryuan.choi 2010-10-14 18:42:32 -0700 Created attachment 70818 Patch 294526 3 70818 kenneth 2010-10-14 18:46:54 -0700 Comment on attachment 70818 Patch Ok, it avoid a crash, but the question is, does it make sense? Please state that in the ChangeLog. 294556 4 ryuan.choi 2010-10-14 20:10:14 -0700 (In reply to comment #3) > (From update of attachment 70818 [details]) > Ok, it avoid a crash, but the question is, does it make sense? Please state that in the ChangeLog. ah... you're right. It can't fix the real problem. It can make just passed above two cases. To find real solution, I need more time to investigate it. Thank you for your reviewing. 295499 5 71037 ryuan.choi 2010-10-18 07:59:28 -0700 Created attachment 71037 Patch 295501 6 ryuan.choi 2010-10-18 08:09:02 -0700 (In reply to comment #5) > Created an attachment (id=71037) [details] > Patch I found that WebKitMacros.cmake missed _additionArguments. So some code was not generated. (especially SVGFontFaceElement::create for crashes I reported). 296212 7 71037 leandro 2010-10-19 08:36:40 -0700 Comment on attachment 71037 Patch LGTM. 296221 8 commit-queue 2010-10-19 09:02:12 -0700 The commit-queue encountered the following flaky tests while processing attachment 71037: Please file bugs against the tests. The commit-queue is continuing to process your patch. 296223 9 71037 commit-queue 2010-10-19 09:02:40 -0700 Comment on attachment 71037 Patch Rejecting patch 71037 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'land-attachment', '--force-clean', '--ignore-builders', '--quiet', '--non-interactive', '--parent-command=commit-queue', 71037]" exit_code: 1 Last 500 characters of output: t.org/attachment.cgi?id=71037&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=47694&ctype=xml Processing 1 patch from 1 bug. Cleaning working directory Updating working directory Processing patch 71037 from bug 47694. NOBODY (OOPS!) found in /Projects/CommitQueue/ChangeLog does not appear to be a valid reviewer according to committers.py. ERROR: /Projects/CommitQueue/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/4496046 296595 10 71241 ryuan.choi 2010-10-19 18:42:37 -0700 Created attachment 71241 Patch 296598 11 ryuan.choi 2010-10-19 18:46:02 -0700 (In reply to comment #10) > Created an attachment (id=71241) [details] > Patch Although I am not sure if this don't need r+, I removed review flag. 296601 12 commit-queue 2010-10-19 19:16:32 -0700 The commit-queue encountered the following flaky tests while processing attachment 71241: http/tests/websocket/tests/handshake-challenge-randomness.html Please file bugs against the tests. The author(s) of the test(s) have been CCed on this bug. The commit-queue is continuing to process your patch. 296602 13 71241 commit-queue 2010-10-19 19:18:26 -0700 Comment on attachment 71241 Patch Clearing flags on attachment: 71241 Committed r70120: <http://trac.webkit.org/changeset/70120> 296603 14 commit-queue 2010-10-19 19:18:33 -0700 All reviewed patches have been landed. Closing bug. 70818 2010-10-14 18:42:32 -0700 2010-10-18 07:59:22 -0700 Patch bug-47694-20101015104235.patch text/plain 1372 ryuan.choi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2OTgzMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMTAtMTQgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1 bmcuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtFRkxdIENyYXNoIHdoaWxlIGxvYWRpbmcgaHR0cDovL3d3dy5zYW1zdW5nLmNvbS91cyBiZWNh dXNlIG9mIFNWRyBmb250CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD00NzY5NAorCisgICAgICAgIEVuYWJsZSBTVE9SRV9GT05UX0NVU1RPTV9QTEFURk9S TV9EQVRBIHRvIGF2b2lkIENyYXNoLgorCisgICAgICAgIFRlc3Q6IGh0dHBzOi8vYnVnLTM4NzU4 LWF0dGFjaG1lbnRzLndlYmtpdC5vcmcvYXR0YWNobWVudC5jZ2k/aWQ9NTU3MTUKKworICAgICAg ICAqIGxvYWRlci9DYWNoZWRGb250LmNwcDoKKwogMjAxMC0xMC0xNCAgSmFtZXMgUm9iaW5zb24g IDxqYW1lc3JAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEZyYXNl ci4KSW5kZXg6IFdlYkNvcmUvbG9hZGVyL0NhY2hlZEZvbnQuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YkNvcmUvbG9hZGVyL0NhY2hlZEZvbnQuY3BwCShyZXZpc2lvbiA2OTgwNykKKysrIFdlYkNvcmUv bG9hZGVyL0NhY2hlZEZvbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNyw3ICsyNyw3IEBACiAj aW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiQ2FjaGVkRm9udC5oIgogCi0jaWYgUExBVEZP Uk0oQ0cpIHx8IFBMQVRGT1JNKFFUKSB8fCBQTEFURk9STShHVEspIHx8IChQTEFURk9STShDSFJP TUlVTSkgJiYgKE9TKFdJTkRPV1MpIHx8IE9TKExJTlVYKSB8fCBPUyhGUkVFQlNEKSkpIHx8IFBM QVRGT1JNKEhBSUtVKSB8fCBPUyhXSU5DRSkgfHwgUExBVEZPUk0oQU5EUk9JRCkKKyNpZiBQTEFU Rk9STShDRykgfHwgUExBVEZPUk0oUVQpIHx8IFBMQVRGT1JNKEdUSykgfHwgKFBMQVRGT1JNKENI Uk9NSVVNKSAmJiAoT1MoV0lORE9XUykgfHwgT1MoTElOVVgpIHx8IE9TKEZSRUVCU0QpKSkgfHwg UExBVEZPUk0oSEFJS1UpIHx8IE9TKFdJTkNFKSB8fCBQTEFURk9STShBTkRST0lEKSB8fCBQTEFU Rk9STShFRkwpCiAjZGVmaW5lIFNUT1JFX0ZPTlRfQ1VTVE9NX1BMQVRGT1JNX0RBVEEKICNlbmRp ZgogCg== 71037 2010-10-18 07:59:28 -0700 2010-10-19 18:42:30 -0700 Patch bug-47694-20101018235926.patch text/plain 1311 ryuan.choi SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDY5OTU4 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMTAt MTggIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDTUFLRV0gQWRkaXRpb25hbCBhcmd1 bWVudHMgd2FzIG1pc3NlZCBpbiBHRU5FUkFURV9ET01fTkFNRVMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3Njk0CisKKyAgICAgICAgUGFzcyBhZGRp dGlvbmFsQXJndW1lbnRzIGZvciBtYWtlX25hbWVzLnBsIHRvIGNob29zZSBlbmFibGVkIGZlYXR1 cmVzLgorCisgICAgICAgICogY21ha2UvV2ViS2l0TWFjcm9zLmNtYWtlOgorCiAyMDEwLTEwLTE1 ICBTZXJnaW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IE1hcnRpbiBSb2JpbnNvbi4KSW5kZXg6IGNtYWtlL1dlYktpdE1hY3Jvcy5jbWFr ZQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBjbWFrZS9XZWJLaXRNYWNyb3MuY21ha2UJKHJldmlzaW9uIDY5OTU4 KQorKysgY21ha2UvV2ViS2l0TWFjcm9zLmNtYWtlCSh3b3JraW5nIGNvcHkpCkBAIC01MSw3ICs1 MSw3IEBAIE1BQ1JPIChHRU5FUkFURV9ET01fTkFNRVMgX25hbWVzcGFjZSBfYXQKICAgICBBRERf Q1VTVE9NX0NPTU1BTkQoCiAgICAgICAgIE9VVFBVVCAgJHtfb3V0cHV0ZmlsZXN9CiAgICAgICAg IERFUEVORFMgJHtOQU1FU19HRU5FUkFUT1J9ICR7U0NSSVBUU19CSU5ESU5HU30gJHtfYXR0cnN9 ICR7X3RhZ3N9Ci0gICAgICAgIENPTU1BTkQgJHtQRVJMX0VYRUNVVEFCTEV9IC1JJHtXRUJDT1JF X0RJUn0vYmluZGluZ3Mvc2NyaXB0cyAke05BTUVTX0dFTkVSQVRPUn0gLS1vdXRwdXREaXIgJHtE RVJJVkVEX1NPVVJDRVNfRElSfSAke19hcmd1bWVudHN9CisgICAgICAgIENPTU1BTkQgJHtQRVJM X0VYRUNVVEFCTEV9IC1JJHtXRUJDT1JFX0RJUn0vYmluZGluZ3Mvc2NyaXB0cyAke05BTUVTX0dF TkVSQVRPUn0gLS1vdXRwdXREaXIgJHtERVJJVkVEX1NPVVJDRVNfRElSfSAke19hcmd1bWVudHN9 ICR7X2FkZGl0aW9uQXJndW1lbnRzfQogICAgICAgICBWRVJCQVRJTSkKIEVORE1BQ1JPICgpCiAK 71241 2010-10-19 18:42:37 -0700 2010-10-19 19:18:26 -0700 Patch bug-47694-20101020104235.patch text/plain 1334 ryuan.choi SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDcwMTE3 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMTAt MTkgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIFVucmV2 aWV3ZWQsIGFkZGluZyBtaXNzZWQgYWRkaXRpb25hbEFyZ3VtZW50cy4KKworICAgICAgICBbQ01B S0VdIGFkZGl0aW9uYWwgYXJndW1lbnRzIHdhcyBtaXNzZWQgaW4gR0VORVJBVEVfRE9NX05BTUVT CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NzY5NAor CisgICAgICAgIFBhc3MgYWRkaXRpb25hbEFyZ3VtZW50cyBmb3IgbWFrZV9uYW1lcy5wbCB0byBj aG9vc2UgZW5hYmxlZCBmZWF0dXJlcy4KKworICAgICAgICAqIGNtYWtlL1dlYktpdE1hY3Jvcy5j bWFrZToKKwogMjAxMC0xMC0xOSAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFp bC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjcwMDM0LgpJbmRleDog Y21ha2UvV2ViS2l0TWFjcm9zLmNtYWtlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGNtYWtlL1dlYktpdE1hY3Jv cy5jbWFrZQkocmV2aXNpb24gNzAxMTMpCisrKyBjbWFrZS9XZWJLaXRNYWNyb3MuY21ha2UJKHdv cmtpbmcgY29weSkKQEAgLTUxLDcgKzUxLDcgQEAgTUFDUk8gKEdFTkVSQVRFX0RPTV9OQU1FUyBf bmFtZXNwYWNlIF9hdAogICAgIEFERF9DVVNUT01fQ09NTUFORCgKICAgICAgICAgT1VUUFVUICAk e19vdXRwdXRmaWxlc30KICAgICAgICAgREVQRU5EUyAke05BTUVTX0dFTkVSQVRPUn0gJHtTQ1JJ UFRTX0JJTkRJTkdTfSAke19hdHRyc30gJHtfdGFnc30KLSAgICAgICAgQ09NTUFORCAke1BFUkxf RVhFQ1VUQUJMRX0gLUkke1dFQkNPUkVfRElSfS9iaW5kaW5ncy9zY3JpcHRzICR7TkFNRVNfR0VO RVJBVE9SfSAtLW91dHB1dERpciAke0RFUklWRURfU09VUkNFU19ESVJ9ICR7X2FyZ3VtZW50c30K KyAgICAgICAgQ09NTUFORCAke1BFUkxfRVhFQ1VUQUJMRX0gLUkke1dFQkNPUkVfRElSfS9iaW5k aW5ncy9zY3JpcHRzICR7TkFNRVNfR0VORVJBVE9SfSAtLW91dHB1dERpciAke0RFUklWRURfU09V UkNFU19ESVJ9ICR7X2FyZ3VtZW50c30gJHtfYWRkaXRpb25Bcmd1bWVudHN9CiAgICAgICAgIFZF UkJBVElNKQogRU5ETUFDUk8gKCkKIAo=