47686 2010-10-14 13:35:12 -0700 [Chromium] Fix rebaseline_chromium_webkit_tests to use 0 tolerance image diff 2010-10-14 14:46:59 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 victorw victorw japhet oldest_to_newest 294320 0 victorw 2010-10-14 13:35:12 -0700 Rebaseline does not need tolerance for image diff. 294339 1 70773 victorw 2010-10-14 13:49:06 -0700 Created attachment 70773 Proposed patch 294343 2 70773 japhet 2010-10-14 13:51:51 -0700 Comment on attachment 70773 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=70773&action=review > WebKitTools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:598 > + Remove this extra newline before landing, unless there's a good reason for it that I'm missing :) 294348 3 70773 victorw 2010-10-14 13:56:47 -0700 Comment on attachment 70773 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=70773&action=review >> WebKitTools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:598 >> + > > Remove this extra newline before landing, unless there's a good reason for it that I'm missing :) we expect two blank lines here per pep8 style. check-webkit-style script will complain if removed. 294351 4 japhet 2010-10-14 13:58:11 -0700 (In reply to comment #3) > (From update of attachment 70773 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=70773&action=review > > >> WebKitTools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:598 > >> + > > > > Remove this extra newline before landing, unless there's a good reason for it that I'm missing :) > > we expect two blank lines here per pep8 style. check-webkit-style script will complain if removed. That would be a good reason, thanks! 294382 5 victorw 2010-10-14 14:46:59 -0700 Committed r69806: <http://trac.webkit.org/changeset/69806> 70773 2010-10-14 13:49:06 -0700 2010-10-14 13:56:47 -0700 Proposed patch image_diff.patch text/plain 1535 victorw SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDY5ODAwKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMTAtMTQgIFZpY3RvciBXYW5nICA8dmlj dG9yd0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgW0Nocm9taXVtXSBGaXggcmViYXNlbGluZV9jaHJvbWl1bV93ZWJraXRfdGVz dHMgdG8gdXNlIDAgdG9sZXJhbmNlIGltYWdlIGRpZmYuCisKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3Njg2CisKKyAgICAgICAgKiBTY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy9yZWJhc2VsaW5lX2Nocm9taXVtX3dlYmtpdF90ZXN0cy5weToK KwogMjAxMC0xMC0xNCAgQWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAKICAgICAgICAg VGVzdCB0aGF0IHByZXNzaW5nIHRoZSBBbHQga2V5IGdlbmVyYXRlcyBhIFdNX1NZU0NPTU1BTkQg bWVzc2FnZQpJbmRleDogV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMv cmViYXNlbGluZV9jaHJvbWl1bV93ZWJraXRfdGVzdHMucHkKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0 VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcmViYXNlbGluZV9jaHJvbWl1bV93 ZWJraXRfdGVzdHMucHkJKHJldmlzaW9uIDY5NzgxKQorKysgV2ViS2l0VG9vbHMvU2NyaXB0cy93 ZWJraXRweS9sYXlvdXRfdGVzdHMvcmViYXNlbGluZV9jaHJvbWl1bV93ZWJraXRfdGVzdHMucHkJ KHdvcmtpbmcgY29weSkKQEAgLTQ5Niw3ICs0OTYsNyBAQCBjbGFzcyBSZWJhc2VsaW5lcihvYmpl Y3QpOgogICAgICAgICAiIiIKIAogICAgICAgICBpZiBpc19pbWFnZToKLSAgICAgICAgICAgIHJl dHVybiBzZWxmLl9wb3J0LmRpZmZfaW1hZ2Uob3V0cHV0MSwgb3V0cHV0MikKKyAgICAgICAgICAg IHJldHVybiBzZWxmLl9wb3J0LmRpZmZfaW1hZ2Uob3V0cHV0MSwgb3V0cHV0MiwgTm9uZSwgMCkK ICAgICAgICAgZWxzZToKICAgICAgICAgICAgIHJldHVybiBzZWxmLl9wb3J0LmNvbXBhcmVfdGV4 dChvdXRwdXQxLCBvdXRwdXQyKQogCkBAIC01OTUsNiArNTk1LDcgQEAgY2xhc3MgUmViYXNlbGlu ZXIob2JqZWN0KToKICAgICAgICAgICAgICAgICBfbG9nLmluZm8oJyAgSHRtbDogY3JlYXRlZCBi YXNlbGluZSBkaWZmIGZpbGU6ICIlcyIuJywKICAgICAgICAgICAgICAgICAgICAgICAgICAgZGlm Zl9maWxlKQogCisKIGNsYXNzIEh0bWxHZW5lcmF0b3Iob2JqZWN0KToKICAgICAiIiJDbGFzcyB0 byBnZW5lcmF0ZSByZWJhc2VsaW5pbmcgcmVzdWx0IGNvbXBhcmlzb24gaHRtbC4iIiIKIAo=