47685 2010-10-14 13:26:38 -0700 Cache link status at linkProgram and use it in useProgram instead of querying GPU 2010-10-14 14:12:15 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 zmo zmo cmarrin enne gman kbr oldest_to_newest 294314 0 zmo 2010-10-14 13:26:38 -0700 This is a performance bottleneck. 294360 1 70776 zmo 2010-10-14 14:06:41 -0700 Created attachment 70776 patch 294363 2 70776 kbr 2010-10-14 14:10:46 -0700 Comment on attachment 70776 patch Looks good. Thanks for fixing this so quickly. 294364 3 zmo 2010-10-14 14:12:15 -0700 Committed r69804: <http://trac.webkit.org/changeset/69804> 70776 2010-10-14 14:06:41 -0700 2010-10-14 14:10:46 -0700 patch link.patch text/plain 4899 zmo SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2OTgwMikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTAtMTAtMTQgIFpoZW55YW8gTW8gIDx6bW9AZ29vZ2xlLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDYWNoZSBs aW5rIHN0YXR1cyBhdCBsaW5rUHJvZ3JhbSBhbmQgdXNlIGl0IGluIHVzZVByb2dyYW0gaW5zdGVh ZCBvZiBxdWVyeWluZyBHUFUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTQ3Njg1CisKKyAgICAgICAgKiBodG1sL2NhbnZhcy9XZWJHTFByb2dyYW0uY3Bw OiBBbHdheXMgY2FjaGUgbGluayBzdGF0dXMgYXQgbGlua1N0YXR1cyBhbmQgdXNlIGl0IHVwb24g cXVlcnkuCisgICAgICAgIChXZWJDb3JlOjpXZWJHTFByb2dyYW06OldlYkdMUHJvZ3JhbSk6Cisg ICAgICAgICogaHRtbC9jYW52YXMvV2ViR0xQcm9ncmFtLmg6IERpdHRvLgorICAgICAgICAoV2Vi Q29yZTo6V2ViR0xQcm9ncmFtOjpnZXRMaW5rU3RhdHVzKToKKyAgICAgICAgKFdlYkNvcmU6Oldl YkdMUHJvZ3JhbTo6c2V0TGlua1N0YXR1cyk6CisgICAgICAgICogaHRtbC9jYW52YXMvV2ViR0xS ZW5kZXJpbmdDb250ZXh0LmNwcDogRGl0dG8uCisgICAgICAgIChXZWJDb3JlOjpXZWJHTFJlbmRl cmluZ0NvbnRleHQ6OmdldFByb2dyYW1QYXJhbWV0ZXIpOgorICAgICAgICAoV2ViQ29yZTo6V2Vi R0xSZW5kZXJpbmdDb250ZXh0OjpsaW5rUHJvZ3JhbSk6CisgICAgICAgIChXZWJDb3JlOjpXZWJH TFJlbmRlcmluZ0NvbnRleHQ6OnVzZVByb2dyYW0pOgorCiAyMDEwLTEwLTE0ICBKdXN0aW4gU2No dWggIDxqc2NodWhAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEphbWVzIFJv Ymluc29uLgpJbmRleDogV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFByb2dyYW0uY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xQcm9ncmFtLmNwcAkocmV2aXNpb24g Njk4MDApCisrKyBXZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUHJvZ3JhbS5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTQwLDcgKzQwLDcgQEAgUGFzc1JlZlB0cjxXZWJHTFByb2dyYW0+IFdlYkdMUHJv Z3JhbTo6YwogCiBXZWJHTFByb2dyYW06OldlYkdMUHJvZ3JhbShXZWJHTFJlbmRlcmluZ0NvbnRl eHQqIGN0eCkKICAgICA6IFdlYkdMT2JqZWN0KGN0eCkKLSAgICAsIG1fbGlua0ZhaWx1cmUoZmFs c2UpCisgICAgLCBtX2xpbmtTdGF0dXMoZmFsc2UpCiB7CiAgICAgc2V0T2JqZWN0KGNvbnRleHQo KS0+Z3JhcGhpY3NDb250ZXh0M0QoKS0+Y3JlYXRlUHJvZ3JhbSgpKTsKIH0KSW5kZXg6IFdlYkNv cmUvaHRtbC9jYW52YXMvV2ViR0xQcm9ncmFtLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9odG1s L2NhbnZhcy9XZWJHTFByb2dyYW0uaAkocmV2aXNpb24gNjk4MDApCisrKyBXZWJDb3JlL2h0bWwv Y2FudmFzL1dlYkdMUHJvZ3JhbS5oCSh3b3JraW5nIGNvcHkpCkBAIC01MCwxMSArNTAsOCBAQCBw dWJsaWM6CiAKICAgICBib29sIGlzVXNpbmdWZXJ0ZXhBdHRyaWIwKCkgY29uc3Q7CiAKLSAgICAv LyBSZXR1cm4gdHJ1ZSBtZWFucyBnZXRQcm9ncmFtUGFyYW1ldGVyKExJTktfU1RBVFVTKSBzaG91 bGQgcmV0dXJuCi0gICAgLy8gZmFsc2U7IHJldHVybiBmYWxzZSBtZWFucyB3ZSBzaG91bGQgYWN0 dWFsbHkgY2FsbAotICAgIC8vIGdldFByb2dyYW1QYXJhbWV0ZXIoTElOS19TVEFUVVMpIHRvIGZp bmQgb3V0LgotICAgIGJvb2wgaXNMaW5rRmFpbHVyZUZsYWdTZXQoKSBjb25zdCB7IHJldHVybiBt X2xpbmtGYWlsdXJlOyB9Ci0gICAgdm9pZCBzZXRMaW5rRmFpbHVyZUZsYWcoYm9vbCBmYWlsZWQp IHsgbV9saW5rRmFpbHVyZSA9IGZhaWxlZDsgfQorICAgIGJvb2wgZ2V0TGlua1N0YXR1cygpIGNv bnN0IHsgcmV0dXJuIG1fbGlua1N0YXR1czsgfQorICAgIHZvaWQgc2V0TGlua1N0YXR1cyhib29s IHN0YXR1cykgeyBtX2xpbmtTdGF0dXMgPSBzdGF0dXM7IH0KIAogICAgIFdlYkdMU2hhZGVyKiBn ZXRBdHRhY2hlZFNoYWRlcihHcmFwaGljc0NvbnRleHQzRDo6V2ViR0xFbnVtVHlwZSk7CiAgICAg Ym9vbCBhdHRhY2hTaGFkZXIoV2ViR0xTaGFkZXIqKTsKQEAgLTcwLDcgKzY3LDcgQEAgcHJpdmF0 ZToKIAogICAgIFZlY3RvcjxpbnQ+IG1fYWN0aXZlQXR0cmliTG9jYXRpb25zOwogCi0gICAgYm9v bCBtX2xpbmtGYWlsdXJlOworICAgIGJvb2wgbV9saW5rU3RhdHVzOwogCiAgICAgUmVmUHRyPFdl YkdMU2hhZGVyPiBtX3ZlcnRleFNoYWRlcjsKICAgICBSZWZQdHI8V2ViR0xTaGFkZXI+IG1fZnJh Z21lbnRTaGFkZXI7CkluZGV4OiBXZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29u dGV4dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmlu Z0NvbnRleHQuY3BwCShyZXZpc2lvbiA2OTgwMCkKKysrIFdlYkNvcmUvaHRtbC9jYW52YXMvV2Vi R0xSZW5kZXJpbmdDb250ZXh0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTQ4NCwxMCArMTQ4NCw3 IEBAIFdlYkdMR2V0SW5mbyBXZWJHTFJlbmRlcmluZ0NvbnRleHQ6OmdldFAKICAgICAgICAgbV9j b250ZXh0LT5nZXRQcm9ncmFtaXYob2JqZWN0T3JaZXJvKHByb2dyYW0pLCBwbmFtZSwgJnZhbHVl KTsKICAgICAgICAgcmV0dXJuIFdlYkdMR2V0SW5mbyhzdGF0aWNfY2FzdDxib29sPih2YWx1ZSkp OwogICAgIGNhc2UgR3JhcGhpY3NDb250ZXh0M0Q6OkxJTktfU1RBVFVTOgotICAgICAgICBpZiAo cHJvZ3JhbS0+aXNMaW5rRmFpbHVyZUZsYWdTZXQoKSkKLSAgICAgICAgICAgIHJldHVybiBXZWJH TEdldEluZm8oZmFsc2UpOwotICAgICAgICBtX2NvbnRleHQtPmdldFByb2dyYW1pdihvYmplY3RP clplcm8ocHJvZ3JhbSksIHBuYW1lLCAmdmFsdWUpOwotICAgICAgICByZXR1cm4gV2ViR0xHZXRJ bmZvKHN0YXRpY19jYXN0PGJvb2w+KHZhbHVlKSk7CisgICAgICAgIHJldHVybiBXZWJHTEdldElu Zm8ocHJvZ3JhbS0+Z2V0TGlua1N0YXR1cygpKTsKICAgICBjYXNlIEdyYXBoaWNzQ29udGV4dDNE OjpJTkZPX0xPR19MRU5HVEg6CiAgICAgY2FzZSBHcmFwaGljc0NvbnRleHQzRDo6QVRUQUNIRURf U0hBREVSUzoKICAgICBjYXNlIEdyYXBoaWNzQ29udGV4dDNEOjpBQ1RJVkVfQVRUUklCVVRFUzoK QEAgLTE4OTcsMTQgKzE4OTQsMTcgQEAgdm9pZCBXZWJHTFJlbmRlcmluZ0NvbnRleHQ6OmxpbmtQ cm9ncmFtKAogICAgICAgICByZXR1cm47CiAgICAgaWYgKCFpc0dMRVMyQ29tcGxpYW50KCkpIHsK ICAgICAgICAgaWYgKCFwcm9ncmFtLT5nZXRBdHRhY2hlZFNoYWRlcihHcmFwaGljc0NvbnRleHQz RDo6VkVSVEVYX1NIQURFUikgfHwgIXByb2dyYW0tPmdldEF0dGFjaGVkU2hhZGVyKEdyYXBoaWNz Q29udGV4dDNEOjpGUkFHTUVOVF9TSEFERVIpKSB7Ci0gICAgICAgICAgICBwcm9ncmFtLT5zZXRM aW5rRmFpbHVyZUZsYWcodHJ1ZSk7CisgICAgICAgICAgICBwcm9ncmFtLT5zZXRMaW5rU3RhdHVz KGZhbHNlKTsKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgfQotICAgICAgICBwcm9ncmFt LT5zZXRMaW5rRmFpbHVyZUZsYWcoZmFsc2UpOwogICAgIH0KIAogICAgIG1fY29udGV4dC0+bGlu a1Byb2dyYW0ob2JqZWN0T3JaZXJvKHByb2dyYW0pKTsKICAgICBwcm9ncmFtLT5jYWNoZUFjdGl2 ZUF0dHJpYkxvY2F0aW9ucygpOworICAgIC8vIGNhY2hlIGxpbmsgc3RhdHVzCisgICAgaW50IHZh bHVlID0gMDsKKyAgICBtX2NvbnRleHQtPmdldFByb2dyYW1pdihvYmplY3RPclplcm8ocHJvZ3Jh bSksIEdyYXBoaWNzQ29udGV4dDNEOjpMSU5LX1NUQVRVUywgJnZhbHVlKTsKKyAgICBwcm9ncmFt LT5zZXRMaW5rU3RhdHVzKHN0YXRpY19jYXN0PGJvb2w+KHZhbHVlKSk7CiAgICAgY2xlYW51cEFm dGVyR3JhcGhpY3NDYWxsKGZhbHNlKTsKIH0KIApAQCAtMjcxNCwxMSArMjcxNCwxMiBAQCB2b2lk IFdlYkdMUmVuZGVyaW5nQ29udGV4dDo6dW5pZm9ybU1hdHJpCiAKIHZvaWQgV2ViR0xSZW5kZXJp bmdDb250ZXh0Ojp1c2VQcm9ncmFtKFdlYkdMUHJvZ3JhbSogcHJvZ3JhbSwgRXhjZXB0aW9uQ29k ZSYgZWMpCiB7CisgICAgVU5VU0VEX1BBUkFNKGVjKTsKICAgICBpZiAocHJvZ3JhbSAmJiBwcm9n cmFtLT5jb250ZXh0KCkgIT0gdGhpcykgewogICAgICAgICBtX2NvbnRleHQtPnN5bnRoZXNpemVH TEVycm9yKEdyYXBoaWNzQ29udGV4dDNEOjpJTlZBTElEX09QRVJBVElPTik7CiAgICAgICAgIHJl dHVybjsKICAgICB9Ci0gICAgaWYgKHByb2dyYW0gJiYgcHJvZ3JhbS0+b2JqZWN0KCkgJiYgIWdl dFByb2dyYW1QYXJhbWV0ZXIocHJvZ3JhbSwgR3JhcGhpY3NDb250ZXh0M0Q6OkxJTktfU1RBVFVT LCBlYykuZ2V0Qm9vbCgpKSB7CisgICAgaWYgKHByb2dyYW0gJiYgcHJvZ3JhbS0+b2JqZWN0KCkg JiYgIXByb2dyYW0tPmdldExpbmtTdGF0dXMoKSkgewogICAgICAgICBtX2NvbnRleHQtPnN5bnRo ZXNpemVHTEVycm9yKEdyYXBoaWNzQ29udGV4dDNEOjpJTlZBTElEX09QRVJBVElPTik7CiAgICAg ICAgIGNsZWFudXBBZnRlckdyYXBoaWNzQ2FsbChmYWxzZSk7CiAgICAgICAgIHJldHVybjsK