47674 2010-10-14 09:52:43 -0700 [GTK] fix compilation warnings in imported libsoup code 2010-10-14 16:25:08 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P3 Normal --- 0 svillar webkit-unassigned commit-queue oldest_to_newest 294158 0 svillar 2010-10-14 09:52:43 -0700 The new SoupURILoader loader stuff issues some warnings at compile time ../../WebCore/platform/network/soup/cache/soup-directory-input-stream.c:114: warning: comparison between signed and unsigned integer expressions ../../WebCore/platform/network/soup/cache/soup-directory-input-stream.c:127: warning: comparison between signed and unsigned integer expressions ../../WebCore/platform/network/soup/cache/soup-request-data.c:82: warning: comparison between signed and unsigned integer expressions ../../WebCore/platform/network/soup/cache/soup-request-data.c:82: warning: signed and unsigned type in conditional expression ../../WebCore/platform/network/soup/cache/webkit/soup-cache.c:271: warning: signed and unsigned type in conditional expression ../../WebCore/platform/network/soup/cache/webkit/soup-cache.c:1347: warning: comparison between signed and unsigned integer expressions ../../WebCore/platform/network/soup/cache/webkit/soup-cache.c:1366: warning: comparison between signed and unsigned integer expressions 294205 1 70751 svillar 2010-10-14 11:01:51 -0700 Created attachment 70751 Fixes for the warnings 294431 2 70751 mrobinson 2010-10-14 16:06:33 -0700 Comment on attachment 70751 Fixes for the warnings Great. Thanks. 294447 3 70751 commit-queue 2010-10-14 16:25:03 -0700 Comment on attachment 70751 Fixes for the warnings Clearing flags on attachment: 70751 Committed r69821: <http://trac.webkit.org/changeset/69821> 294448 4 commit-queue 2010-10-14 16:25:08 -0700 All reviewed patches have been landed. Closing bug. 70751 2010-10-14 11:01:51 -0700 2010-10-14 16:25:03 -0700 Fixes for the warnings 0001-Fix-for-47674.patch text/plain 5412 svillar RnJvbSBhNjc1ODA3NWUzZTBmYzZmYTIxMDVhMTkyMzU0MGU5ZDRkMGJlZmQzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTZXJnaW8gVmlsbGFyIFNlbmluIDxzdmlsbGFyQGlnYWxpYS5j b20+CkRhdGU6IFRodSwgMTQgT2N0IDIwMTAgMjA6MDE6MDIgKzAyMDAKU3ViamVjdDogW1BBVENI XSBGaXggZm9yIDQ3Njc0CgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHwgICAyMCArKysrKysrKysrKysrKysrKysrKwogLi4uL3NvdXAvY2Fj aGUvc291cC1kaXJlY3RvcnktaW5wdXQtc3RyZWFtLmMgICAgICAgfCAgICAyICstCiAuLi4vbmV0 d29yay9zb3VwL2NhY2hlL3NvdXAtcmVxdWVzdC1kYXRhLmMgICAgICAgICB8ICAgIDIgKy0KIC4u Li9uZXR3b3JrL3NvdXAvY2FjaGUvc291cC1yZXF1ZXN0LWZpbGUuYyAgICAgICAgIHwgICAgMyAr LS0KIC4uLi9uZXR3b3JrL3NvdXAvY2FjaGUvd2Via2l0L3NvdXAtY2FjaGUuYyAgICAgICAgIHwg ICAgOCArKysrLS0tLQogNSBmaWxlcyBjaGFuZ2VkLCAyNyBpbnNlcnRpb25zKCspLCA4IGRlbGV0 aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VM b2cKaW5kZXggMmNhMzBjNy4uNzQ5NDQ3NyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAxMC0xMC0xNCAgU2Vy Z2lvIFZpbGxhciBTZW5pbiAgPHN2aWxsYXJAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1RLXSBmaXggY29tcGlsYXRpb24gd2Fy bmluZ3MgaW4gaW1wb3J0ZWQgbGlic291cCBjb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NzY3NAorCisgICAgICAgIEZpeGVkIHNvbWUgd2Fybmlu Z3MgY2F1c2VkIGJ5IGNvbXBhcmlzb25zIGJldHdlZW4gc2lnbmVkIGFuZAorICAgICAgICB1bnNp Z25lZCBpbnRlZ2VyIGV4cHJlc3Npb25zCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3Nv dXAvY2FjaGUvc291cC1kaXJlY3RvcnktaW5wdXQtc3RyZWFtLmM6CisgICAgICAgICh3ZWJraXRf c291cF9kaXJlY3RvcnlfaW5wdXRfc3RyZWFtX3JlYWQpOgorICAgICAgICAqIHBsYXRmb3JtL25l dHdvcmsvc291cC9jYWNoZS9zb3VwLXJlcXVlc3QtZGF0YS5jOgorICAgICAgICAod2Via2l0X3Nv dXBfcmVxdWVzdF9kYXRhX3NlbmQpOgorICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvc291cC9j YWNoZS9zb3VwLXJlcXVlc3QtZmlsZS5jOgorICAgICAgICAod2Via2l0X3NvdXBfcmVxdWVzdF9m aWxlX2Vuc3VyZV9maWxlKToKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3NvdXAvY2FjaGUv d2Via2l0L3NvdXAtY2FjaGUuYzoKKyAgICAgICAgKHdlYmtpdF9zb3VwX2NhY2hlX2VudHJ5X2lz X2ZyZXNoX2Vub3VnaCk6CisgICAgICAgICh3ZWJraXRfc291cF9jYWNoZV9oYXNfcmVzcG9uc2Up OgorCiAyMDEwLTEwLTE0ICBIb2xnZXIgSGFucyBQZXRlciBGcmV5dGhlciAgPGhvbGdlckBtb2lq aS1tb2JpbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hcnRpbiBSb2JpbnNvbi4KZGlm ZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL2NhY2hlL3NvdXAtZGlyZWN0 b3J5LWlucHV0LXN0cmVhbS5jIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvY2FjaGUv c291cC1kaXJlY3RvcnktaW5wdXQtc3RyZWFtLmMKaW5kZXggYmYxNmRiYi4uYzE0ODYzYiAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvY2FjaGUvc291cC1kaXJlY3Rv cnktaW5wdXQtc3RyZWFtLmMKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvY2Fj aGUvc291cC1kaXJlY3RvcnktaW5wdXQtc3RyZWFtLmMKQEAgLTEwOSw3ICsxMDksNyBAQCB3ZWJr aXRfc291cF9kaXJlY3RvcnlfaW5wdXRfc3RyZWFtX3JlYWQgKEdJbnB1dFN0cmVhbSAgKmlucHV0 LAogCQkJCQkgR0Vycm9yICAgICAgICoqZXJyb3IpCiB7CiAJV2ViS2l0U291cERpcmVjdG9yeUlu cHV0U3RyZWFtICpzdHJlYW0gPSBXRUJLSVRfU09VUF9ESVJFQ1RPUllfSU5QVVRfU1RSRUFNIChp bnB1dCk7Ci0JZ3NzaXplIHRvdGFsLCBzaXplOworCWdzaXplIHRvdGFsLCBzaXplOwogCiAJZm9y ICh0b3RhbCA9IDA7IHRvdGFsIDwgY291bnQ7IHRvdGFsICs9IHNpemUpIHsKIAkJaWYgKHN0cmVh bS0+YnVmZmVyID09IE5VTEwpIHsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29y ay9zb3VwL2NhY2hlL3NvdXAtcmVxdWVzdC1kYXRhLmMgYi9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvc291cC9jYWNoZS9zb3VwLXJlcXVlc3QtZGF0YS5jCmluZGV4IDgwZTMwZjUuLjQ2M2ZjZWYg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL2NhY2hlL3NvdXAtcmVx dWVzdC1kYXRhLmMKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvY2FjaGUvc291 cC1yZXF1ZXN0LWRhdGEuYwpAQCAtNzksNyArNzksNyBAQCB3ZWJraXRfc291cF9yZXF1ZXN0X2Rh dGFfc2VuZCAoV2ViS2l0U291cFJlcXVlc3QgICAqcmVxdWVzdCwKIAkJc2VtaSA9IG1lbWNociAo dXJpc3RyLCAnOycsIGNvbW1hIC0gdXJpc3RyKTsKIAkJZW5kID0gc2VtaSA/IHNlbWkgOiBjb21t YTsKIAotCQlpZiAoc2VtaSAmJiAhZ19hc2NpaV9zdHJuY2FzZWNtcCAoc2VtaSwgIjtiYXNlNjQi LCBNQVggKGNvbW1hIC0gc2VtaSwgc3RybGVuICgiO2Jhc2U2NCIpKSkpCisJCWlmIChzZW1pICYm ICFnX2FzY2lpX3N0cm5jYXNlY21wIChzZW1pLCAiO2Jhc2U2NCIsIE1BWCAoKHNpemVfdCkgKGNv bW1hIC0gc2VtaSksIHN0cmxlbiAoIjtiYXNlNjQiKSkpKQogCQkJYmFzZTY0ID0gVFJVRTsKIAog CQlpZiAoZW5kICE9IHVyaXN0cikKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29y ay9zb3VwL2NhY2hlL3NvdXAtcmVxdWVzdC1maWxlLmMgYi9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvc291cC9jYWNoZS9zb3VwLXJlcXVlc3QtZmlsZS5jCmluZGV4IDEyMDNiOWUuLjI0Y2NiMTAg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL2NhY2hlL3NvdXAtcmVx dWVzdC1maWxlLmMKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvY2FjaGUvc291 cC1yZXF1ZXN0LWZpbGUuYwpAQCAtMTY4LDggKzE2OCw3IEBAIHdlYmtpdF9zb3VwX3JlcXVlc3Rf ZmlsZV9lbnN1cmVfZmlsZSAoV2ViS2l0U291cFJlcXVlc3RGaWxlICAqZmlsZSwKIAkJICogc291 cF91cmlfZGVjb2RlIHdoZW4gdGhlIHJlcXVpcmVkIGxpYnNvdXAgdmVyc2lvbgogCQkgKiBpcyBi dW1wZWQgb3V0IHRvIDIuMzIuMQogCQkgKi8KLQkJZ2NoYXIgKnVyaV9wYXRoID0gdXJpLT5wYXRo OwotCQlnY2hhciAqZGVjb2RlZF91cmkgPSB3ZWJraXRfc291cF9yZXF1ZXN0X3VyaV9kZWNvZGVk X2NvcHkgKHVyaV9wYXRoLCBzdHJsZW4gKHVyaV9wYXRoKSk7CisJCWdjaGFyICpkZWNvZGVkX3Vy aSA9IHdlYmtpdF9zb3VwX3JlcXVlc3RfdXJpX2RlY29kZWRfY29weSAodXJpLT5wYXRoLCBzdHJs ZW4gKHVyaS0+cGF0aCkpOwogCiAJCWlmIChkZWNvZGVkX3VyaSkgewogCQkJLyogRG8gbm90IHVz ZSBuZXdfZm9yX3VyaSgpIGFzIHRoZSBkZWNvZGVkIFVSSQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL3NvdXAvY2FjaGUvd2Via2l0L3NvdXAtY2FjaGUuYyBiL1dlYkNvcmUv cGxhdGZvcm0vbmV0d29yay9zb3VwL2NhY2hlL3dlYmtpdC9zb3VwLWNhY2hlLmMKaW5kZXggYTk0 NDZmZS4uYjI1YzRjYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAv Y2FjaGUvd2Via2l0L3NvdXAtY2FjaGUuYworKysgYi9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv c291cC9jYWNoZS93ZWJraXQvc291cC1jYWNoZS5jCkBAIC0yNjYsOSArMjY2LDkgQEAgd2Via2l0 X3NvdXBfY2FjaGVfZW50cnlfZ2V0X2N1cnJlbnRfYWdlIChXZWJLaXRTb3VwQ2FjaGVFbnRyeSAq ZW50cnkpCiB9CiAKIHN0YXRpYyBnYm9vbGVhbgotd2Via2l0X3NvdXBfY2FjaGVfZW50cnlfaXNf ZnJlc2hfZW5vdWdoIChXZWJLaXRTb3VwQ2FjaGVFbnRyeSAqZW50cnksIGludCBtaW5fZnJlc2gp Cit3ZWJraXRfc291cF9jYWNoZV9lbnRyeV9pc19mcmVzaF9lbm91Z2ggKFdlYktpdFNvdXBDYWNo ZUVudHJ5ICplbnRyeSwgZ2ludCBtaW5fZnJlc2gpCiB7Ci0JdW5zaWduZWQgbGltaXQgPSAobWlu X2ZyZXNoID09IC0xKSA/IHdlYmtpdF9zb3VwX2NhY2hlX2VudHJ5X2dldF9jdXJyZW50X2FnZSAo ZW50cnkpIDogbWluX2ZyZXNoOworCWd1aW50IGxpbWl0ID0gKG1pbl9mcmVzaCA9PSAtMSkgPyB3 ZWJraXRfc291cF9jYWNoZV9lbnRyeV9nZXRfY3VycmVudF9hZ2UgKGVudHJ5KSA6IChndWludCkg bWluX2ZyZXNoOwogCXJldHVybiBlbnRyeS0+ZnJlc2huZXNzX2xpZmV0aW1lID4gbGltaXQ7CiB9 CiAKQEAgLTEzNDQsNyArMTM0NCw3IEBAIHdlYmtpdF9zb3VwX2NhY2hlX2hhc19yZXNwb25zZSAo V2ViS2l0U291cENhY2hlICpjYWNoZSwgU291cE1lc3NhZ2UgKm1zZykKIAkJCS8qIElmIHdlIGFy ZSBvdmVyIG1heC1hZ2UgYW5kIG1heC1zdGFsZSBpcyBub3QKIAkJCSAgIHNldCwgZG8gbm90IHVz ZSB0aGUgdmFsdWUgZnJvbSB0aGUgY2FjaGUKIAkJCSAgIHdpdGhvdXQgdmFsaWRhdGlvbiAqLwot CQkJaWYgKG1heF9hZ2UgPD0gY3VycmVudF9hZ2UgJiYgbWF4X3N0YWxlID09IC0xKQorCQkJaWYg KChndWludCkgbWF4X2FnZSA8PSBjdXJyZW50X2FnZSAmJiBtYXhfc3RhbGUgPT0gLTEpCiAJCQkJ cmV0dXJuIFdFQktJVF9TT1VQX0NBQ0hFX1JFU1BPTlNFX05FRURTX1ZBTElEQVRJT047CiAJCX0K IAl9CkBAIC0xMzYzLDcgKzEzNjMsNyBAQCB3ZWJraXRfc291cF9jYWNoZV9oYXNfcmVzcG9uc2Ug KFdlYktpdFNvdXBDYWNoZSAqY2FjaGUsIFNvdXBNZXNzYWdlICptc2cpCiAJCQlpZiAobWF4X3N0 YWxlID09IEdfTUFYSU5UMzIpCiAJCQkJcmV0dXJuIFdFQktJVF9TT1VQX0NBQ0hFX1JFU1BPTlNF X0ZSRVNIOwogCi0JCQlpZiAoKHdlYmtpdF9zb3VwX2NhY2hlX2VudHJ5X2dldF9jdXJyZW50X2Fn ZSAoZW50cnkpIC0gZW50cnktPmZyZXNobmVzc19saWZldGltZSkgPD0gbWF4X3N0YWxlKQorCQkJ aWYgKCh3ZWJraXRfc291cF9jYWNoZV9lbnRyeV9nZXRfY3VycmVudF9hZ2UgKGVudHJ5KSAtIGVu dHJ5LT5mcmVzaG5lc3NfbGlmZXRpbWUpIDw9IChndWludCkgbWF4X3N0YWxlKQogCQkJCXJldHVy biBXRUJLSVRfU09VUF9DQUNIRV9SRVNQT05TRV9GUkVTSDsKIAkJfQogCi0tIAoxLjcuMQoK