47672 2010-10-14 08:37:40 -0700 ES5 strict mode bugs 2011-06-17 00:30:30 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC OS X 10.6 RESOLVED FIXED http://kangax.github.com/es5-compat-table/strict-mode/ P2 Normal --- 47788 47791 47833 1 kangax webkit-unassigned barraclough erights ggaren oliver oldest_to_newest 294123 0 kangax 2010-10-14 08:37:40 -0700 There are 3 oversights in the way strict mode works in webkit, which results in 4 failing tests with the above example page — http://kangax.github.com/es5-compat-table/strict-mode/ Also, for the ref, early error on "assignment to an unresolved reference" was discussed here — https://mail.mozilla.org/pipermail/es5-discuss/2010-October/003742.html 294927 1 ap 2010-10-15 14:36:54 -0700 The tests being: __i_dont_exist = 1; is a ReferenceError arguments++; is a SyntaxError (function(){ return this === undefined; })(); (function(){ return this === undefined; }).call(); 295296 2 oliver 2010-10-17 16:26:39 -0700 Fixing the reference error for global properties at the moment 295331 3 oliver 2010-10-17 21:18:28 -0700 __i_dont_exist = blah should now be fixed. 295349 4 oliver 2010-10-17 22:43:46 -0700 pre-/post-fix operations on arguments are now disallowed. 295591 5 oliver 2010-10-18 10:21:10 -0700 i've got the null vs. undefined |this| fix up for review now 295653 6 oliver 2010-10-18 11:33:47 -0700 And now the undefined vs null patch is landed. kangax are there any other problems you've found? 295714 7 kangax 2010-10-18 13:04:38 -0700 Hey Oliver. I don't have this fresh build yet, but the previous one seems to also fail to set strict mode for eval code (in certain cases). For example: (function(){ "use strict"; eval('with({ }) { }') })(); // no error To quote 10.1.1: "Eval code is strict eval code if it begins with a Directive Prologue that contains a Use Strict Directive or if the call to eval is a direct call (see 15.1.2.1.1) to the eval function that is contained in strict mode code." Note "direct call [...] contained in strict mode code". So based on my understanding (and actually, FF4 behavior) this should throw error, but currently doesn't. 295835 8 oliver 2010-10-18 16:42:00 -0700 (In reply to comment #7) > Hey Oliver. > > I don't have this fresh build yet, but the previous one seems to also fail to set strict mode for eval code (in certain cases). For example: > > (function(){ "use strict"; eval('with({ }) { }') })(); // no error Was this in the inspector? I'm seeing weird behaviour where code in the inspectors console fails to trigger strict mode 295839 9 kangax 2010-10-18 16:49:20 -0700 (In reply to comment #8) > (In reply to comment #7) > > Hey Oliver. > > > > I don't have this fresh build yet, but the previous one seems to also fail to set strict mode for eval code (in certain cases). For example: > > > > (function(){ "use strict"; eval('with({ }) { }') })(); // no error > > Was this in the inspector? I'm seeing weird behaviour where code in the inspectors console fails to trigger strict mode Ah. yes it was. Doesn't happen when run from within <script> element. Well, then I have nothing else as far as strict mode. Will file bugs if I find anything. 295842 10 oliver 2010-10-18 16:57:32 -0700 (In reply to comment #9) > (In reply to comment #8) > > (In reply to comment #7) > > > Hey Oliver. > > > > > > I don't have this fresh build yet, but the previous one seems to also fail to set strict mode for eval code (in certain cases). For example: > > > > > > (function(){ "use strict"; eval('with({ }) { }') })(); // no error > > > > Was this in the inspector? I'm seeing weird behaviour where code in the inspectors console fails to trigger strict mode > > Ah. yes it was. Doesn't happen when run from within <script> element. > > Well, then I have nothing else as far as strict mode. Will file bugs if I find anything. I just landed a fix for the Function constructor which should appear in the next nightly 297803 11 kangax 2010-10-21 20:08:15 -0700 I think I'm seeing browser crash under strict mode. Filed a separate bug for it — https://bugs.webkit.org/show_bug.cgi?id=48109 Oliver, can you please take a look? 422457 12 barraclough 2011-06-17 00:30:30 -0700 All the strict mode tests pass for me in ToT.