47669 2010-10-14 07:02:32 -0700 Title-Element has no popup on <svg>-Elements, but on <g> 2010-11-10 23:06:38 -0800 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 0 bugzillawebkit rwlbuis eric kling mdelaney7 rwlbuis zimmermann oldest_to_newest 294090 0 70736 bugzillawebkit 2010-10-14 07:02:32 -0700 Created attachment 70736 SVG Demo for a title in svg and g element The standard http://www.w3.org/TR/SVG/struct.html#DescriptionAndTitleElements defines: "Each container element [...] in an SVG drawing can supply [...] a ‘title’ description string" where http://www.w3.org/TR/SVG/intro.html#TermContainerElement defines an container element as "Specifically: ‘a’, ‘defs’, ‘glyph’, ‘g’, ‘marker’, ‘mask’, ‘missing-glyph’, ‘pattern’, ‘svg’, ‘switch’ and ‘symbol’." However a title element is only rendered as a popup at mouseover in <g>, but not in a <svg> Element as you can see in the attached demo. 294096 1 kling 2010-10-14 07:18:33 -0700 From SVGStyledElement::title() in WebCore/svg/SVGStyledElement.cpp: // According to spec, we should not return titles when hovering over <svg> elements (those // <title> elements are the title of the document, not a tooltip) so we instantly return. if (hasTagName(SVGNames::svgTag)) return String(); 294112 2 bugzillawebkit 2010-10-14 07:56:03 -0700 (In reply to comment #1) > From SVGStyledElement::title() in WebCore/svg/SVGStyledElement.cpp: > // According to spec, we should not return titles when hovering over <svg> elements (those > // <title> elements are the title of the document, not a tooltip) so we instantly return. > if (hasTagName(SVGNames::svgTag)) > return String(); I see. I have not found this spec, but the title could not be the title of the document, if they are nested. The SVG Spec only references to the "outermost svg element". 294602 3 70836 bugzillawebkit 2010-10-14 23:43:25 -0700 Created attachment 70836 SVG Demo for a title in root svg, svg and g element 294604 4 bugzillawebkit 2010-10-14 23:46:19 -0700 (In reply to comment #2) > (In reply to comment #1) > > From SVGStyledElement::title() in WebCore/svg/SVGStyledElement.cpp: > > // According to spec, we should not return titles when hovering over <svg> elements (those > > // <title> elements are the title of the document, not a tooltip) so we instantly return. > > if (hasTagName(SVGNames::svgTag)) > > return String(); > > I see. > > I have not found this spec, but the title could not be the title of the document, if they are nested. The SVG Spec only references to the "outermost svg element". Firefox 4 shows the tooltip on svg-elements, but not on the outmost svg https://bugzilla.mozilla.org/show_bug.cgi?id=547854 Uploaded a new testcase. 295141 5 70957 rwlbuis 2010-10-16 09:14:17 -0700 Created attachment 70957 Trivial patch 295142 6 rwlbuis 2010-10-16 09:15:59 -0700 I uploaded a trivial patch to provide behaviour such as FireFox 4. I waited with the testcase implementation(which should be easy by just checking the title attribute) because for instance Opera does not give a tooltip for svg elements either. Cheers, Rob. 295144 7 70957 kling 2010-10-16 09:20:36 -0700 Comment on attachment 70957 Trivial patch View in context: https://bugs.webkit.org/attachment.cgi?id=70957&action=review > WebCore/svg/SVGStyledElement.cpp:72 > + SVGSVGElement* svg = static_cast<SVGSVGElement*>(const_cast<SVGStyledElement*>(this)); Would read better like this IMO: const SVGSVGElement* svg = static_cast<const SVGSVGElement*>(this); 299330 8 bugzillawebkit 2010-10-26 01:01:33 -0700 (In reply to comment #6) > I uploaded a trivial patch to provide behaviour such as FireFox 4. I waited with the testcase implementation(which should be easy by just checking the title attribute) because for instance Thanks. It would be very nice, if this changes would land in the webkit source. > Opera does not give a tooltip for svg elements either. I filed a bug in the opera bug wizard (DSK-316141) as well as in Microsoft Connect https://connect.microsoft.com/IE/feedback/details/614675/title-element-has-no-tooltip-on-svg-elements Perhaps it is too late for IE9 since MS marked the beta as feature complete. Holger 299729 9 70957 zimmermann 2010-10-26 12:47:45 -0700 Comment on attachment 70957 Trivial patch Looks fine, r=me but Andreas suggestion is correct. 307543 10 eric 2010-11-10 14:13:33 -0800 Attachment 70957 was posted by a committer and has review+, assigning to Rob Buis for commit. 307736 11 rwlbuis 2010-11-10 23:06:38 -0800 Hi Eric, (In reply to comment #10) > Attachment 70957 [details] was posted by a committer and has review+, assigning to Rob Buis for commit. This was landed in r70617, I guess I forgot to close, doing that now :) Cheers, Rob. 70736 2010-10-14 07:02:32 -0700 2010-10-14 07:02:32 -0700 SVG Demo for a title in svg and g element webkit_svgtitle_bug.svg image/svg+xml 524 bugzillawebkit PD94bWwgdmVyc2lvbj0iMS4wIiBzdGFuZGFsb25lPSJubyI/Pg0KPHN2ZyB3aWR0aD0iNjAwIiBo ZWlnaHQ9IjIwMCIgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIj4NCgk8ZyB3aWR0 aD0iMTgwIj4NCgkJPHRpdGxlPg0KCQkJVGl0bGUgb2YgdGhlIFNWRyBnIGVsZW1lbnQuDQoJCTwv dGl0bGU+DQoJCTxyZWN0IHg9IjEwIiB5PSIxMCIgd2lkdGg9IjE1MCIgaGVpZ2h0PSI1MCIgc3R5 bGU9ImZpbGw6cmVkOyBzdHJva2U6Ymx1ZTsiLz4NCgkJPHRleHQgeD0iMjAiIHk9IjQwIj5HLUVs ZW1lbnQ8L3RleHQ+DQoJPC9nPg0KCTxzdmcgeD0iMjAwIiB3aWR0aD0iMTgwIj4NCgkJPHRpdGxl Pg0KCQkJVGl0bGUgb2YgdGhlIFNWRyBlbGVtZW50Lg0KCQk8L3RpdGxlPg0KCQk8cmVjdCB4PSIx MCIgeT0iMTAiIHdpZHRoPSIxNTAiIGhlaWdodD0iNTAiIHN0eWxlPSJmaWxsOnJlZDsgc3Ryb2tl OmJsdWU7Ii8+DQoJCTx0ZXh0IHg9IjIwIiB5PSI0MCI+U1ZHLUVsZW1lbnQ8L3RleHQ+DQoJPC9z dmc+DQo8L3N2Zz4= 70836 2010-10-14 23:43:25 -0700 2010-10-14 23:43:25 -0700 SVG Demo for a title in root svg, svg and g element webkit_svgtitle_bug.svg image/svg+xml 728 bugzillawebkit PD94bWwgdmVyc2lvbj0iMS4wIiBzdGFuZGFsb25lPSJubyI/Pg0KPHN2ZyB3aWR0aD0iNjAwIiBo ZWlnaHQ9IjIwMCIgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIj4NCgk8dGl0bGU+ DQoJCVRpdGxlIG9mIHRoZSByb290IFNWRyBlbGVtZW50Lg0KCTwvdGl0bGU+DQoJPHJlY3QgeD0i MTAiIHk9IjcwIiB3aWR0aD0iMzUwIiBoZWlnaHQ9IjUwIiBzdHlsZT0iZmlsbDpyZWQ7IHN0cm9r ZTpibHVlOyIvPg0KCTx0ZXh0IHg9IjIwIiB5PSIxMDAiPnJvb3QgU1ZHLUVsZW1lbnQgKHNob3Vs ZCBoYXZlIG5vIHBvcHVwKTwvdGV4dD4NCgk8ZyB3aWR0aD0iMTgwIj4NCgkJPHRpdGxlPg0KCQkJ VGl0bGUgb2YgdGhlIFNWRyBnIGVsZW1lbnQuDQoJCTwvdGl0bGU+DQoJCTxyZWN0IHg9IjEwIiB5 PSIxMCIgd2lkdGg9IjE1MCIgaGVpZ2h0PSI1MCIgc3R5bGU9ImZpbGw6cmVkOyBzdHJva2U6Ymx1 ZTsiLz4NCgkJPHRleHQgeD0iMjAiIHk9IjQwIj5HLUVsZW1lbnQ8L3RleHQ+DQoJPC9nPg0KCTxz dmcgeD0iMjAwIiB3aWR0aD0iMTgwIj4NCgkJPHRpdGxlPg0KCQkJVGl0bGUgb2YgdGhlIFNWRyBl bGVtZW50Lg0KCQk8L3RpdGxlPg0KCQk8cmVjdCB4PSIxMCIgeT0iMTAiIHdpZHRoPSIxNTAiIGhl aWdodD0iNTAiIHN0eWxlPSJmaWxsOnJlZDsgc3Ryb2tlOmJsdWU7Ii8+DQoJCTx0ZXh0IHg9IjIw IiB5PSI0MCI+U1ZHLUVsZW1lbnQ8L3RleHQ+DQoJPC9zdmc+DQo8L3N2Zz4= 70957 2010-10-16 09:14:17 -0700 2010-10-26 12:47:45 -0700 Trivial patch bug-47669-20101016181854.patch text/plain 1765 rwlbuis ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YjM1Yzg1NmI4ZDc4MTlhZjhhMjEzMzZjMWNhNjJmNTI1MDQyNGU5Zi4uNmI2YTQ5Mjc0NGJlNjcx NmZkOTBjOWZkZWYzNDgyZmU5Y2I1M2FmNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0xMC0xNiAgUm9i IEJ1aXMgIDxyd2xidWlzQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaXRsZS1FbGVtZW50IGhhcyBubyBwb3B1cCBvbiA8c3ZnPi1F bGVtZW50cywgYnV0IG9uIDxnPgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NDc2NjkKKworICAgICAgICBBbGxvdyB0b29sdGlwcyBvbiBub24tcm9vdCBz dmcgZWxlbWVudHMuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiAoT09QUyEpCisKKyAgICAgICAg KiBzdmcvU1ZHU3R5bGVkRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTVkdTdHlsZWRF bGVtZW50Ojp0aXRsZSk6CisKIDIwMTAtMTAtMTUgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtp dC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9X ZWJDb3JlL3N2Zy9TVkdTdHlsZWRFbGVtZW50LmNwcCBiL1dlYkNvcmUvc3ZnL1NWR1N0eWxlZEVs ZW1lbnQuY3BwCmluZGV4IGQ0ZmE4OWM2NWQ1YmRiZmNjNDEzZWQ4OTk4NGQ1MDJmZTYyNzExOTUu LjkyYzNjOWE0NzQ1ZjQyNjBmMDY4MjA0NGMzOTRiYzMwNDI5MzNmZDkgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvc3ZnL1NWR1N0eWxlZEVsZW1lbnQuY3BwCisrKyBiL1dlYkNvcmUvc3ZnL1NWR1N0eWxl ZEVsZW1lbnQuY3BwCkBAIC02NiwxMCArNjYsMTMgQEAgU1ZHU3R5bGVkRWxlbWVudDo6flNWR1N0 eWxlZEVsZW1lbnQoKQogCiBTdHJpbmcgU1ZHU3R5bGVkRWxlbWVudDo6dGl0bGUoKSBjb25zdAog ewotICAgIC8vIEFjY29yZGluZyB0byBzcGVjLCB3ZSBzaG91bGQgbm90IHJldHVybiB0aXRsZXMg d2hlbiBob3ZlcmluZyBvdmVyIDxzdmc+IGVsZW1lbnRzICh0aG9zZSAKKyAgICAvLyBBY2NvcmRp bmcgdG8gc3BlYywgd2Ugc2hvdWxkIG5vdCByZXR1cm4gdGl0bGVzIHdoZW4gaG92ZXJpbmcgb3Zl ciByb290IDxzdmc+IGVsZW1lbnRzICh0aG9zZSAKICAgICAvLyA8dGl0bGU+IGVsZW1lbnRzIGFy ZSB0aGUgdGl0bGUgb2YgdGhlIGRvY3VtZW50LCBub3QgYSB0b29sdGlwKSBzbyB3ZSBpbnN0YW50 bHkgcmV0dXJuLgotICAgIGlmIChoYXNUYWdOYW1lKFNWR05hbWVzOjpzdmdUYWcpKQotICAgICAg ICByZXR1cm4gU3RyaW5nKCk7CisgICAgaWYgKGhhc1RhZ05hbWUoU1ZHTmFtZXM6OnN2Z1RhZykp IHsKKyAgICAgICAgU1ZHU1ZHRWxlbWVudCogc3ZnID0gc3RhdGljX2Nhc3Q8U1ZHU1ZHRWxlbWVu dCo+KGNvbnN0X2Nhc3Q8U1ZHU3R5bGVkRWxlbWVudCo+KHRoaXMpKTsKKyAgICAgICAgaWYgKHN2 Zy0+aXNPdXRlcm1vc3RTVkcoKSkKKyAgICAgICAgICAgIHJldHVybiBTdHJpbmcoKTsKKyAgICB9 CiAgICAgCiAgICAgLy8gV2FsayB1cCB0aGUgdHJlZSwgdG8gZmluZCBvdXQgd2hldGhlciB3ZSdy ZSBpbnNpZGUgYSA8dXNlPiBzaGFkb3cgdHJlZSwgdG8gZmluZCB0aGUgcmlnaHQgdGl0bGUuCiAg ICAgTm9kZSogcGFyZW50ID0gY29uc3RfY2FzdDxTVkdTdHlsZWRFbGVtZW50Kj4odGhpcyk7Cg==