47666 2010-10-14 05:27:52 -0700 [GTK] Failing test LayoutTests/editing/undo/orphaned-selection-crash-bug32823-2.html 2010-10-15 00:22:29 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 svillar webkit-unassigned commit-queue mrobinson oldest_to_newest 294063 0 svillar 2010-10-14 05:27:52 -0700 The actual issue is most likely https://bugs.webkit.org/show_bug.cgi?id=47661. We have now a more strict decoding of base64 data with the recent land of the soupURILoader stuff. That's the reason why this test started to fail. 294066 1 70730 svillar 2010-10-14 05:32:14 -0700 Created attachment 70730 Fix for the failing test Reverted to old behaviour 294068 2 70730 xan.lopez 2010-10-14 05:35:59 -0700 Comment on attachment 70730 Fix for the failing test r=me 294171 3 70730 commit-queue 2010-10-14 10:14:08 -0700 Comment on attachment 70730 Fix for the failing test Clearing flags on attachment: 70730 Committed r69775: <http://trac.webkit.org/changeset/69775> 294172 4 commit-queue 2010-10-14 10:14:13 -0700 All reviewed patches have been landed. Closing bug. 294290 5 ap 2010-10-14 12:39:49 -0700 Note that Safari (or more precisely, CFNetwork) is strict in this respect - "data:image/png;base64,iVBORw0KGrkJggg==" fails to load, while "data:image/png;base64,iVBORw0KGrkJggg=" loads fine (but then fails to render, since the data itself is of course broken). This matches Firefox. 294379 6 mrobinson 2010-10-14 14:45:18 -0700 So perhaps instead of loading the URL, we just need to fail in a better way? 294611 7 svillar 2010-10-15 00:22:29 -0700 (In reply to comment #6) > So perhaps instead of loading the URL, we just need to fail in a better way? Yeah. We reverted the change in order to mimic the old behaviour but I think it'd be better to fail in a better way 70730 2010-10-14 05:32:14 -0700 2010-10-14 10:14:08 -0700 Fix for the failing test 0001-Fix-for-47666.patch text/plain 1961 svillar RnJvbSBiZWE2ZjlhN2M5YTdlNzkxNjg4NTA3NDMxYTE2OTBhZmMxMDU1ZmI0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTZXJnaW8gVmlsbGFyIFNlbmluIDxzdmlsbGFyQGlnYWxpYS5j b20+CkRhdGU6IFRodSwgMTQgT2N0IDIwMTAgMTQ6MzA6MDIgKzAyMDAKU3ViamVjdDogW1BBVENI XSBGaXggZm9yIDQ3NjY2CgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHwgICAxNCArKysrKysrKysrKysrKwogLi4uL25ldHdvcmsvc291cC9j YWNoZS9zb3VwLXJlcXVlc3QtZGF0YS5jICAgICAgICAgfCAgIDEyICsrKy0tLS0tLS0tLQogMiBm aWxlcyBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCspLCA5IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzEyM2VlMC4u OTE0YzZmNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0xMC0xNCAgU2VyZ2lvIFZpbGxhciBTZW5pbiAg PHN2aWxsYXJAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBbR1RLXSBGYWlsaW5nIHRlc3QgTGF5b3V0VGVzdHMvZWRpdGluZy91bmRv L29ycGhhbmVkLXNlbGVjdGlvbi1jcmFzaC1idWczMjgyMy0yLmh0bWwKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3NjY2CisKKyAgICAgICAgRG8gYSBs ZXNzIHN0cmljdCBkZWNvZGluZyBvZiBiYXNlNjQgZGF0YSB1cmwncyBhcyBpdCB3YXMgZG9uZQor ICAgICAgICBiZWZvcmUuIFRoZSBhY3R1YWwgcHJvYmxlbSBpcyBtb3N0IGxpa2VseQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDc2NjEgdG91Z2guCisK KyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3NvdXAvY2FjaGUvc291cC1yZXF1ZXN0LWRhdGEu YzoKKyAgICAgICAgKHdlYmtpdF9zb3VwX3JlcXVlc3RfZGF0YV9zZW5kKToKKwogMjAxMC0xMC0x MyAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAv Y2FjaGUvc291cC1yZXF1ZXN0LWRhdGEuYyBiL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3Vw L2NhY2hlL3NvdXAtcmVxdWVzdC1kYXRhLmMKaW5kZXggOTg0OTI2OS4uODBlMzBmNSAxMDA2NDQK LS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvY2FjaGUvc291cC1yZXF1ZXN0LWRh dGEuYworKysgYi9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9jYWNoZS9zb3VwLXJlcXVl c3QtZGF0YS5jCkBAIC05OCwxNSArOTgsOSBAQCB3ZWJraXRfc291cF9yZXF1ZXN0X2RhdGFfc2Vu ZCAoV2ViS2l0U291cFJlcXVlc3QgICAqcmVxdWVzdCwKIAkJZ3VjaGFyICpidWY7CiAKIAkJaWYg KGJhc2U2NCkgewotCQkJaW50IGlubGVuLCBzdGF0ZSA9IDA7Ci0JCQlndWludCBzYXZlID0gMDsK LQotCQkJaW5sZW4gPSBzdHJsZW4gKHN0YXJ0KTsKLQkJCWJ1ZiA9IGdfbWFsbG9jIChpbmxlbiAq IDMgLyA0KTsKLQkJCWRhdGEtPnByaXYtPmNvbnRlbnRfbGVuZ3RoID0KLQkJCQlnX2Jhc2U2NF9k ZWNvZGVfc3RlcCAoc3RhcnQsIGlubGVuLCBidWYsCi0JCQkJCQkgICAgICAmc3RhdGUsICZzYXZl KTsKLQkJCWlmIChzdGF0ZSAhPSAwKSB7CisJCQlidWYgPSBnX2Jhc2U2NF9kZWNvZGUgKHN0YXJ0 LCAmZGF0YS0+cHJpdi0+Y29udGVudF9sZW5ndGgpOworCisJCQlpZiAoIWJ1ZiB8fCBkYXRhLT5w cml2LT5jb250ZW50X2xlbmd0aCA8PSAwKSB7CiAJCQkJZ19mcmVlIChidWYpOwogCQkJCWdvdG8g ZmFpbDsKIAkJCX0KLS0gCjEuNy4xCgo=