47656 2010-10-13 23:48:01 -0700 [GTK] Needs fixing mistyped comments in the API documentation 2010-10-19 01:17:39 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 joone webkit-unassigned commit-queue gustavo mrobinson xan.lopez oldest_to_newest 293982 0 joone 2010-10-13 23:48:01 -0700 There are mistyped comments in webkitwebsettings.cpp and webkitwebwindowfeatures.cpp 294003 1 70717 joone 2010-10-14 00:35:09 -0700 Created attachment 70717 Proposed Patch1 294104 2 70717 gustavo 2010-10-14 07:21:47 -0700 Comment on attachment 70717 Proposed Patch1 View in context: https://bugs.webkit.org/attachment.cgi?id=70717&action=review > WebKit/gtk/webkit/webkitwebsettings.cpp:49 > - * the to be used text encoding, color, font sizes, printing mode, > + * the behaviour to be used text encoding, color, font sizes, printing mode, This change looks wrong. The grammar is a bit weird the way it is now, but not sure it's wrong - would be good to have input from a native English speaker =D 294113 3 xan.lopez 2010-10-14 08:01:40 -0700 (In reply to comment #2) > This change looks wrong. The grammar is a bit weird the way it is now, but not sure it's wrong - would be good to have input from a native English speaker =D Looks wrong indeed. I'd just do s/the to be used/its/ in the original text. But I agree with having Martin just put there something ;) 294120 4 joone 2010-10-14 08:26:31 -0700 (In reply to comment #2) > (From update of attachment 70717 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=70717&action=review > > > WebKit/gtk/webkit/webkitwebsettings.cpp:49 > > - * the to be used text encoding, color, font sizes, printing mode, > > + * the behaviour to be used text encoding, color, font sizes, printing mode, > > This change looks wrong. The grammar is a bit weird the way it is now, but not sure it's wrong - would be good to have input from a native English speaker =D How about this? #WebKitWebSettings can be applied to a #WebKitWebView to control the behaviour to be used, text encoding, color, font sizes, printing mode, script support, loading of images and various other things. 294129 5 mrobinson 2010-10-14 08:38:55 -0700 Here's my suggestion: (old) WebKitWebSettings can be applied to a WebKitWebView to control the to be used text encoding, color, font sizes, printing mode, script support, loading of images and various other things. (new) WebKitWebSettings can be applied to a WebKitWebView to control text encoding, color, font sizes, printing mode, script support, loading of images and various other things. After creation, a WebKitWebSettings object contains default settings. 294547 6 70822 joone 2010-10-14 19:48:19 -0700 Created attachment 70822 Proposed Patch2 Thanks, Martin. I applied your suggestion to the patch. 294585 7 mrobinson 2010-10-14 22:44:41 -0700 Thanks! 296044 8 70822 commit-queue 2010-10-19 01:17:33 -0700 Comment on attachment 70822 Proposed Patch2 Clearing flags on attachment: 70822 Committed r70036: <http://trac.webkit.org/changeset/70036> 296045 9 commit-queue 2010-10-19 01:17:39 -0700 All reviewed patches have been landed. Closing bug. 70717 2010-10-14 00:35:09 -0700 2010-10-14 19:48:19 -0700 Proposed Patch1 mistypings.diff text/plain 2112 joone ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggODFkM2I0MS4uNjBlMzM0NyAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0xMC0xMyAg Sm9vbmUgSHVyICA8am9vbmVAa2xkcC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgW0dUS10gTmVlZHMgZml4aW5nIG1pc3R5cGVkIGNvbW1lbnRz IGluIHRoZSBBUEkgZG9jdW1lbnRhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NDc2NTYKKworICAgICAgICBGaXhlZCBtaXN0eXBlZCBjb21tZW50 cyBpbiB0aGUgQVBJIGRvY3VtZW5lbnRhdGlvbi4KKworICAgICAgICAqIHdlYmtpdC93ZWJraXR3 ZWJzZXR0aW5ncy5jcHA6IEZpeGVkIGEgbWlzdHlwZWQgY29tbWVudCBpbiB0aGUgdGhlIHNlY3Rp b24gYmxvY2suCisgICAgICAgICogd2Via2l0L3dlYmtpdHdlYndpbmRvd2ZlYXR1cmVzLmNwcDog Rml4ZWQgYSBtaXN0eXBlZCBjb21tZW50IGluIHRoZSBzZWN0aW9uIGJsb2NrLgorCiAyMDEwLTEw LTEzICBYYW4gTG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBHdXN0YXZvIE5vcm9uaGEuCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3 ZWJzZXR0aW5ncy5jcHAgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJzZXR0aW5ncy5jcHAK aW5kZXggOGEyMDdkOS4uYTZiMDAzNSAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay93ZWJraXQvd2Vi a2l0d2Vic2V0dGluZ3MuY3BwCisrKyBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnNldHRp bmdzLmNwcApAQCAtNDYsNyArNDYsNyBAQAogICogQHNob3J0X2Rlc2NyaXB0aW9uOiBDb250cm9s IHRoZSBiZWhhdmlvdXIgb2YgYSAjV2ViS2l0V2ViVmlldwogICoKICAqICNXZWJLaXRXZWJTZXR0 aW5ncyBjYW4gYmUgYXBwbGllZCB0byBhICNXZWJLaXRXZWJWaWV3IHRvIGNvbnRyb2wKLSAqIHRo ZSB0byBiZSB1c2VkIHRleHQgZW5jb2RpbmcsIGNvbG9yLCBmb250IHNpemVzLCBwcmludGluZyBt b2RlLAorICogdGhlIGJlaGF2aW91ciB0byBiZSB1c2VkIHRleHQgZW5jb2RpbmcsIGNvbG9yLCBm b250IHNpemVzLCBwcmludGluZyBtb2RlLAogICogc2NyaXB0IHN1cHBvcnQsIGxvYWRpbmcgb2Yg aW1hZ2VzIGFuZCB2YXJpb3VzIG90aGVyIHRoaW5ncy4KICAqCiAgKiA8aW5mb3JtYWxleGFtcGxl Pjxwcm9ncmFtbGlzdGluZz4KZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdl YndpbmRvd2ZlYXR1cmVzLmNwcCBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYndpbmRvd2Zl YXR1cmVzLmNwcAppbmRleCBhNmZlMWRmLi5lNWQ2NWJkIDEwMDY0NAotLS0gYS9XZWJLaXQvZ3Rr L3dlYmtpdC93ZWJraXR3ZWJ3aW5kb3dmZWF0dXJlcy5jcHAKKysrIGIvV2ViS2l0L2d0ay93ZWJr aXQvd2Via2l0d2Vid2luZG93ZmVhdHVyZXMuY3BwCkBAIC0zOCw3ICszOCw3IEBACiAgKiBJbiB0 aGUgbm9ybWFsIGNhc2Ugb25lIHdpbGwgdXNlICN3ZWJraXRfd2ViX3ZpZXdfZ2V0X3dpbmRvd19m ZWF0dXJlcwogICogdG8gZ2V0IHRoZSAjV2ViS2l0V2ViV2luZG93RmVhdHVyZXMgYW5kIHRoZW4g bW9uaXRvciB0aGUgcHJvcGVydHkKICAqIGNoYW5nZXMuIEJlIGF3YXJlIHRoYXQgdGhlICNXZWJL aXRXZWJXaW5kb3dGZWF0dXJlcyBtaWdodCBjaGFuZ2UKLSAqIGNoYW5nZSBiZWZvcmUgI1dlYktp dFdlYlZpZXc6OndlYi12aWV3LXJlYWR5IHNpZ25hbCBpcyBlbWl0dGVkLgorICogYmVmb3JlICNX ZWJLaXRXZWJWaWV3Ojp3ZWItdmlldy1yZWFkeSBzaWduYWwgaXMgZW1pdHRlZC4KICAqIFRvIGJl IHNhZmUgbGlzdGVuIHRvIHRoZSBub3RpZnk6OndpbmRvdy1mZWF0dXJlcyBzaWduYWwgb2YgdGhl ICNXZWJLaXRXZWJWaWV3CiAgKiBhbmQgcmVjb25uZWN0IHRoZSBzaWduYWxzIHdoZW5ldmVyIHRo ZSAjV2ViS2l0V2ViV2luZG93RmVhdHVyZXMgb2YKICAqIGEgI1dlYktpdFdlYlZpZXcgY2hhbmdl cy4K 70822 2010-10-14 19:48:19 -0700 2010-10-19 01:17:33 -0700 Proposed Patch2 mistypings2.diff text/plain 2399 joone ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggODFkM2I0MS4uNjBlMzM0NyAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0xMC0xMyAg Sm9vbmUgSHVyICA8am9vbmVAa2xkcC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgW0dUS10gTmVlZHMgZml4aW5nIG1pc3R5cGVkIGNvbW1lbnRz IGluIHRoZSBBUEkgZG9jdW1lbnRhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NDc2NTYKKworICAgICAgICBGaXhlZCBtaXN0eXBlZCBjb21tZW50 cyBpbiB0aGUgQVBJIGRvY3VtZW5lbnRhdGlvbi4KKworICAgICAgICAqIHdlYmtpdC93ZWJraXR3 ZWJzZXR0aW5ncy5jcHA6IEZpeGVkIGEgbWlzdHlwZWQgY29tbWVudCBpbiB0aGUgdGhlIHNlY3Rp b24gYmxvY2suCisgICAgICAgICogd2Via2l0L3dlYmtpdHdlYndpbmRvd2ZlYXR1cmVzLmNwcDog Rml4ZWQgYSBtaXN0eXBlZCBjb21tZW50IGluIHRoZSBzZWN0aW9uIGJsb2NrLgorCiAyMDEwLTEw LTEzICBYYW4gTG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBHdXN0YXZvIE5vcm9uaGEuCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3 ZWJzZXR0aW5ncy5jcHAgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJzZXR0aW5ncy5jcHAK aW5kZXggOGEyMDdkOS4uZjU5MGMyYSAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay93ZWJraXQvd2Vi a2l0d2Vic2V0dGluZ3MuY3BwCisrKyBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnNldHRp bmdzLmNwcApAQCAtNDUsOSArNDUsOSBAQAogICogU0VDVElPTjp3ZWJraXR3ZWJzZXR0aW5ncwog ICogQHNob3J0X2Rlc2NyaXB0aW9uOiBDb250cm9sIHRoZSBiZWhhdmlvdXIgb2YgYSAjV2ViS2l0 V2ViVmlldwogICoKLSAqICNXZWJLaXRXZWJTZXR0aW5ncyBjYW4gYmUgYXBwbGllZCB0byBhICNX ZWJLaXRXZWJWaWV3IHRvIGNvbnRyb2wKLSAqIHRoZSB0byBiZSB1c2VkIHRleHQgZW5jb2Rpbmcs IGNvbG9yLCBmb250IHNpemVzLCBwcmludGluZyBtb2RlLAotICogc2NyaXB0IHN1cHBvcnQsIGxv YWRpbmcgb2YgaW1hZ2VzIGFuZCB2YXJpb3VzIG90aGVyIHRoaW5ncy4KKyAqICNXZWJLaXRXZWJT ZXR0aW5ncyBjYW4gYmUgYXBwbGllZCB0byBhICNXZWJLaXRXZWJWaWV3IHRvIGNvbnRyb2wgdGV4 dCBlbmNvZGluZywgCisgKiBjb2xvciwgZm9udCBzaXplcywgcHJpbnRpbmcgbW9kZSwgc2NyaXB0 IHN1cHBvcnQsIGxvYWRpbmcgb2YgaW1hZ2VzIGFuZCB2YXJpb3VzIG90aGVyIHRoaW5ncy4gCisg KiBBZnRlciBjcmVhdGlvbiwgYSAjV2ViS2l0V2ViU2V0dGluZ3Mgb2JqZWN0IGNvbnRhaW5zIGRl ZmF1bHQgc2V0dGluZ3MuIAogICoKICAqIDxpbmZvcm1hbGV4YW1wbGU+PHByb2dyYW1saXN0aW5n PgogICogLzwhLS0gLS0+KiBDcmVhdGUgYSBuZXcgd2Vic2V0dGluZ3MgYW5kIGRpc2FibGUgamF2 YSBzY3JpcHQgKjwhLS0gLS0+LwpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0 d2Vid2luZG93ZmVhdHVyZXMuY3BwIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vid2luZG93 ZmVhdHVyZXMuY3BwCmluZGV4IGE2ZmUxZGYuLmU1ZDY1YmQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9n dGsvd2Via2l0L3dlYmtpdHdlYndpbmRvd2ZlYXR1cmVzLmNwcAorKysgYi9XZWJLaXQvZ3RrL3dl YmtpdC93ZWJraXR3ZWJ3aW5kb3dmZWF0dXJlcy5jcHAKQEAgLTM4LDcgKzM4LDcgQEAKICAqIElu IHRoZSBub3JtYWwgY2FzZSBvbmUgd2lsbCB1c2UgI3dlYmtpdF93ZWJfdmlld19nZXRfd2luZG93 X2ZlYXR1cmVzCiAgKiB0byBnZXQgdGhlICNXZWJLaXRXZWJXaW5kb3dGZWF0dXJlcyBhbmQgdGhl biBtb25pdG9yIHRoZSBwcm9wZXJ0eQogICogY2hhbmdlcy4gQmUgYXdhcmUgdGhhdCB0aGUgI1dl YktpdFdlYldpbmRvd0ZlYXR1cmVzIG1pZ2h0IGNoYW5nZQotICogY2hhbmdlIGJlZm9yZSAjV2Vi S2l0V2ViVmlldzo6d2ViLXZpZXctcmVhZHkgc2lnbmFsIGlzIGVtaXR0ZWQuCisgKiBiZWZvcmUg I1dlYktpdFdlYlZpZXc6OndlYi12aWV3LXJlYWR5IHNpZ25hbCBpcyBlbWl0dGVkLgogICogVG8g YmUgc2FmZSBsaXN0ZW4gdG8gdGhlIG5vdGlmeTo6d2luZG93LWZlYXR1cmVzIHNpZ25hbCBvZiB0 aGUgI1dlYktpdFdlYlZpZXcKICAqIGFuZCByZWNvbm5lY3QgdGhlIHNpZ25hbHMgd2hlbmV2ZXIg dGhlICNXZWJLaXRXZWJXaW5kb3dGZWF0dXJlcyBvZgogICogYSAjV2ViS2l0V2ViVmlldyBjaGFu Z2VzLgo=