47654 2010-10-13 22:26:26 -0700 Chromium port can't run JavaScriptCore tests 2010-10-14 13:55:37 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth abarth eric oldest_to_newest 293959 0 abarth 2010-10-13 22:26:26 -0700 Chromium port can't run JavaScriptCore tests 293960 1 70711 abarth 2010-10-13 22:27:20 -0700 Created attachment 70711 Patch 293961 2 abarth 2010-10-13 22:29:09 -0700 Committed r69738: <http://trac.webkit.org/changeset/69738> 293962 3 70711 eric 2010-10-13 22:30:37 -0700 Comment on attachment 70711 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=70711&action=review Would be better to rename it to "JavaScript tests" and just return "echo 'nothing to do'" for Chromium. Eventually run-javascriptcore-tests could be made to work for v8 if we desired. > WebKitTools/Scripts/webkitpy/tool/steps/runtests.py:55 > + javascriptcore_tests_command = self.port().run_javascriptcore_tests_command() > + if javascriptcore_tests_command: > + log("Running JavaScriptCore tests") > + self._tool.executive.run_and_throw_if_fail(javascriptcore_tests_command, quiet=True) Very lame. So much extra code for this one stupid branch. 293963 4 eric 2010-10-13 22:31:10 -0700 That was kinda dickish. 293966 5 abarth 2010-10-13 22:32:50 -0700 :( 293969 6 abarth 2010-10-13 22:36:30 -0700 Each of these patches blocks progress on the bot. I'll try to patch these in manually instead of using the svn repo as the communication channel between my development machine and the bot. 294116 7 eric 2010-10-14 08:21:01 -0700 I think it's rude to ask for review and then ignore the comments (especially with an in-person cackle). This isn't really a patch to land unreviewed anyway. You made the code uglier/less-hackable. I've said my piece. This is not the end of the world. 294189 8 70711 ap 2010-10-14 10:41:06 -0700 Comment on attachment 70711 Patch Clearing r? flag in a resolved bug. Quoting Maciej, "please, ladies & gentlemen, let's try to remain courteous in these discussions". 294346 9 abarth 2010-10-14 13:55:37 -0700 I'll revert the patch and we can try again. 70711 2010-10-13 22:27:20 -0700 2010-10-14 10:41:06 -0700 Patch bug-47654-20101013222719.patch text/plain 2484 abarth ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBhMmVjOWFkNjcyY2U2M2ZhNTZmOWZlZDg2YWFkMGEzZWVjMDVmZjdjLi4yMzJmYWZi YTdjZTRhNWNiMGI4ZWMzMGU2NTRhODY4Mjk1NTE0NTkyIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcgQEAK IDIwMTAtMTAtMTMgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAorICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaHJvbWl1bSBwb3J0IGNhbid0 IHJ1biBKYXZhU2NyaXB0Q29yZSB0ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NDc2NTQKKworICAgICAgICBUaGlzIGxldHMgd2Via2l0LXBhdGNo IGJ1aWxkLWFuZC10ZXN0IHdvcmsgb24gQ2hyb21pdW0uCisKKyAgICAgICAgKiBTY3JpcHRzL3dl YmtpdHB5L2NvbW1vbi9jb25maWcvcG9ydHMucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRw eS90b29sL3N0ZXBzL3J1bnRlc3RzLnB5OgorCisyMDEwLTEwLTEzICBBZGFtIEJhcnRoICA8YWJh cnRoQHdlYmtpdC5vcmc+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCiAKICAg ICAgICAgTWFrZSAtLXBvcnQgYSBnbG9iYWwgb3B0aW9uIGFuZCBwYXNzIHRoZSBwb3J0IGluZm9y bWF0aW9uIHRvIHRoZSBjb21taXQtcXVldWUgc3VicHJvY2VzcwpkaWZmIC0tZ2l0IGEvV2ViS2l0 VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL3BvcnRzLnB5IGIvV2ViS2l0VG9v bHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL3BvcnRzLnB5CmluZGV4IGQ5YjljNDMy MGVkMGM2NzljZjlhMDdlYmZlZjgwZjlkYzAzYmJlYTkuLjVhODVmN2RiNjc3NGYxZjhhZDcwNGI4 OWM2NDlkMzA4MjA4ZjgyMmYgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0 cHkvY29tbW9uL2NvbmZpZy9wb3J0cy5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtp dHB5L2NvbW1vbi9jb25maWcvcG9ydHMucHkKQEAgLTIyOCw2ICsyMjgsMTAgQEAgY2xhc3MgQ2hy b21pdW1Qb3J0KFdlYktpdFBvcnQpOgogICAgICAgICAgICAgIi0tbm8tcGl4ZWwtdGVzdHMiLAog ICAgICAgICBdCiAKKyAgICBAY2xhc3NtZXRob2QKKyAgICBkZWYgcnVuX2phdmFzY3JpcHRjb3Jl X3Rlc3RzX2NvbW1hbmQoY2xzKToKKyAgICAgICAgcmV0dXJuIE5vbmUKKwogCiBjbGFzcyBDaHJv bWl1bVhWRkJQb3J0KENocm9taXVtUG9ydCk6CiAKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9ydW50ZXN0cy5weSBiL1dlYktpdFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvdG9vbC9zdGVwcy9ydW50ZXN0cy5weQppbmRleCA4OWVmNjk0OTczN2M1ZmEz NGFhMDFmOTZjMWM2ZmEwNzI2ODYyMWM5Li42ZmM5NGExYTc0YTA0N2UwZGFmOWRjNDYzM2I4N2Q2 ZTAwZjk1NWVlIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wv c3RlcHMvcnVudGVzdHMucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29s L3N0ZXBzL3J1bnRlc3RzLnB5CkBAIC00OCw4ICs0OCwxMSBAQCBjbGFzcyBSdW5UZXN0cyhBYnN0 cmFjdFN0ZXApOgogICAgICAgICBzZWxmLl90b29sLmV4ZWN1dGl2ZS5ydW5fYW5kX3Rocm93X2lm X2ZhaWwoc2VsZi5wb3J0KCkucnVuX3B5dGhvbl91bml0dGVzdHNfY29tbWFuZCgpKQogICAgICAg ICBsb2coIlJ1bm5pbmcgUGVybCB1bml0IHRlc3RzIikKICAgICAgICAgc2VsZi5fdG9vbC5leGVj dXRpdmUucnVuX2FuZF90aHJvd19pZl9mYWlsKHNlbGYucG9ydCgpLnJ1bl9wZXJsX3VuaXR0ZXN0 c19jb21tYW5kKCkpCi0gICAgICAgIGxvZygiUnVubmluZyBKYXZhU2NyaXB0Q29yZSB0ZXN0cyIp Ci0gICAgICAgIHNlbGYuX3Rvb2wuZXhlY3V0aXZlLnJ1bl9hbmRfdGhyb3dfaWZfZmFpbChzZWxm LnBvcnQoKS5ydW5famF2YXNjcmlwdGNvcmVfdGVzdHNfY29tbWFuZCgpLCBxdWlldD1UcnVlKQor CisgICAgICAgIGphdmFzY3JpcHRjb3JlX3Rlc3RzX2NvbW1hbmQgPSBzZWxmLnBvcnQoKS5ydW5f amF2YXNjcmlwdGNvcmVfdGVzdHNfY29tbWFuZCgpCisgICAgICAgIGlmIGphdmFzY3JpcHRjb3Jl X3Rlc3RzX2NvbW1hbmQ6CisgICAgICAgICAgICBsb2coIlJ1bm5pbmcgSmF2YVNjcmlwdENvcmUg dGVzdHMiKQorICAgICAgICAgICAgc2VsZi5fdG9vbC5leGVjdXRpdmUucnVuX2FuZF90aHJvd19p Zl9mYWlsKGphdmFzY3JpcHRjb3JlX3Rlc3RzX2NvbW1hbmQsIHF1aWV0PVRydWUpCiAKICAgICAg ICAgbG9nKCJSdW5uaW5nIHJ1bi13ZWJraXQtdGVzdHMiKQogICAgICAgICBhcmdzID0gc2VsZi5w b3J0KCkucnVuX3dlYmtpdF90ZXN0c19jb21tYW5kKCkK