47651 2010-10-13 20:54:21 -0700 PlatformMouseEvents need to contain modifier flags 2022-09-12 19:17:55 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 245108 1 sam webkit-unassigned oldest_to_newest 293934 0 sam 2010-10-13 20:54:21 -0700 The PlaformMouseEvent class contains modifier flags in two ways, as bits for the four main fields, and as an unsigned for m_modifierFlags. We don't set m_modifierFlags and thus don't get modifiers sent to us in mouseDidMoveOverElement. 293935 1 70707 sam 2010-10-13 20:57:29 -0700 Created attachment 70707 Patch 293948 2 sam 2010-10-13 21:28:05 -0700 Fixed in http://trac.webkit.org/changeset/69733. 70707 2010-10-13 20:57:29 -0700 2010-10-13 21:01:07 -0700 Patch mod.diff text/plain 1271 sam SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA2OTczMikKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMTAtMTMgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQbGF0Zm9y bU1vdXNlRXZlbnRzIG5lZWQgdG8gY29udGFpbiBtb2RpZmllciBmbGFncworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDc2NTEKKworICAgICAgICAqIFNo YXJlZC9XZWJFdmVudENvbnZlcnNpb24uY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJLaXQyUGxh dGZvcm1Nb3VzZUV2ZW50OjpXZWJLaXQyUGxhdGZvcm1Nb3VzZUV2ZW50KToKKyAgICAgICAgRmls bCBpbiBtX21vZGlmaWVyRmxhZ3MuCisKIDIwMTAtMTAtMTMgIEFuZGVycyBDYXJsc3NvbiAgPGFu ZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBKb2huIFN1bGxpdmFuLgpJ bmRleDogV2ViS2l0Mi9TaGFyZWQvV2ViRXZlbnRDb252ZXJzaW9uLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJLaXQyL1NoYXJlZC9XZWJFdmVudENvbnZlcnNpb24uY3BwCShyZXZpc2lvbiA2OTY2OCkK KysrIFdlYktpdDIvU2hhcmVkL1dlYkV2ZW50Q29udmVyc2lvbi5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTc1LDYgKzc1LDE0IEBAIHB1YmxpYzoKICAgICAgICAgbV9tZXRhS2V5ID0gd2ViRXZlbnQu bWV0YUtleSgpOwogCiAgICAgICAgIG1fbW9kaWZpZXJGbGFncyA9IDA7CisgICAgICAgIGlmICht X3NoaWZ0S2V5KQorICAgICAgICAgICAgbV9tb2RpZmllckZsYWdzIHw9IFdlYkV2ZW50OjpTaGlm dEtleTsKKyAgICAgICAgaWYgKG1fY3RybEtleSkKKyAgICAgICAgICAgIG1fbW9kaWZpZXJGbGFn cyB8PSBXZWJFdmVudDo6Q29udHJvbEtleTsKKyAgICAgICAgaWYgKG1fYWx0S2V5KQorICAgICAg ICAgICAgbV9tb2RpZmllckZsYWdzIHw9IFdlYkV2ZW50OjpBbHRLZXk7CisgICAgICAgIGlmICht X21ldGFLZXkpCisgICAgICAgICAgICBtX21vZGlmaWVyRmxhZ3MgfD0gV2ViRXZlbnQ6Ok1ldGFL ZXk7CiAgICAgfQogfTsKIAo=