47641 2010-10-13 17:45:49 -0700 Restore normal meaning of double-click on patch review page? 2010-11-08 14:18:31 -0800 1 1 1 Unclassified WebKit WebKit Website 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 darin abarth ap oldest_to_newest 293860 0 darin 2010-10-13 17:45:49 -0700 I think that clicking on line numbers is a fine way to select ranges to code to comment on. I find the double-click-to-comment behavior frustrating. I want to select words from the source code and paste them into my comments, but I end up creating new empty comments. Can we remove the double-clicking behavior? 305908 1 abarth 2010-11-07 16:27:38 -0800 Do you still feel this way, or have you gotten used to double-click-to-comment? 305976 2 ap 2010-11-07 20:51:30 -0800 I'm not the original reporter, but this is still an issue for me. 306186 3 darin 2010-11-08 10:17:51 -0800 (In reply to comment #1) > Do you still feel this way, or have you gotten used to double-click-to-comment? Yes. I feel it more strongly now since I have used the patch review page much more. I never use double click to comment. I click on the line numbers instead, which is quite convenient. I occasionally get an unexpected comment box, then when mentally reviewing what I had just done I realize that I double clicked. I am accustomed to using double click to select words anywhere I can select text, and it’s useful to select parts of the patch to paste into review comments or search. I run into this much more often now than back in October when I wrote the bug report. So much that I was about to write a bug report about it this week, not remembering I had already done so. 306203 4 abarth 2010-11-08 10:41:38 -0800 Okiedokes. I'll remove the behavior then. Thanks. 306356 5 73280 abarth 2010-11-08 14:10:12 -0800 Created attachment 73280 Patch 306360 6 73280 eric 2010-11-08 14:12:45 -0800 Comment on attachment 73280 Patch I likes it! 306364 7 abarth 2010-11-08 14:18:31 -0800 Committed r71570: <http://trac.webkit.org/changeset/71570> 73280 2010-11-08 14:10:12 -0800 2010-11-08 14:12:45 -0800 Patch bug-47641-20101108141011.patch text/plain 1640 abarth SW5kZXg6IEJ1Z3NTaXRlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBCdWdzU2l0ZS9DaGFuZ2VM b2cJKHJldmlzaW9uIDcxNTY4KQorKysgQnVnc1NpdGUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp CkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMTEtMDggIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0 Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBS ZXN0b3JlIG5vcm1hbCBtZWFuaW5nIG9mIGRvdWJsZS1jbGljayBvbiBwYXRjaCByZXZpZXcgcGFn ZT8KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3NjQx CisKKyAgICAgICAgQWZ0ZXIgdGhpcyBwYXRjaCwgeW91IG5lZWQgdG8gY2xpY2sgb24gdGhlIGxp bmUgbnVtYmVycyB0byBhZGQgYQorICAgICAgICBjb21tZW50LgorCisgICAgICAgICogUHJldHR5 UGF0Y2gvUHJldHR5UGF0Y2gucmI6CisgICAgICAgICogY29kZS1yZXZpZXcuanM6CisKIDIwMTAt MTAtMDkgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdl ZCBieSBBbGV4ZXkgUHJvc2t1cnlha292LgpJbmRleDogQnVnc1NpdGUvY29kZS1yZXZpZXcuanMK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gQnVnc1NpdGUvY29kZS1yZXZpZXcuanMJKHJldmlzaW9uIDcxNTY4KQor KysgQnVnc1NpdGUvY29kZS1yZXZpZXcuanMJKHdvcmtpbmcgY29weSkKQEAgLTI1Myw3ICsyNTMs NyBAQAogICB9CiAKICAgZnVuY3Rpb24gY3Jhd2xEaWZmKCkgewotICAgICQoJy5MaW5lJykuZWFj aChpZGlmeSkuZWFjaChob3ZlcmlmeSkuZGJsY2xpY2soYWRkQ29tbWVudEZpZWxkKTsKKyAgICAk KCcuTGluZScpLmVhY2goaWRpZnkpLmVhY2goaG92ZXJpZnkpOwogICAgICQoJy5GaWxlRGlmZicp LmVhY2goZnVuY3Rpb24oKSB7CiAgICAgICB2YXIgZmlsZV9uYW1lID0gJCh0aGlzKS5jaGlsZHJl bignaDEnKS50ZXh0KCk7CiAgICAgICBmaWxlc1tmaWxlX25hbWVdID0gdGhpczsKSW5kZXg6IEJ1 Z3NTaXRlL1ByZXR0eVBhdGNoL1ByZXR0eVBhdGNoLnJiCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEJ1Z3NTaXRl L1ByZXR0eVBhdGNoL1ByZXR0eVBhdGNoLnJiCShyZXZpc2lvbiA3MTU2OCkKKysrIEJ1Z3NTaXRl L1ByZXR0eVBhdGNoL1ByZXR0eVBhdGNoLnJiCSh3b3JraW5nIGNvcHkpCkBAIC0zMTIsNyArMzEy LDcgQEAgYm9keSB7CiB9CiA8L3N0eWxlPgogPHNjcmlwdCBzcmM9Imh0dHBzOi8vYWpheC5nb29n bGVhcGlzLmNvbS9hamF4L2xpYnMvanF1ZXJ5LzEuNC4yL2pxdWVyeS5taW4uanMiPjwvc2NyaXB0 PiAKLTxzY3JpcHQgc3JjPSJjb2RlLXJldmlldy5qcz92ZXJzaW9uPTEzIj48L3NjcmlwdD4gCis8 c2NyaXB0IHNyYz0iY29kZS1yZXZpZXcuanM/dmVyc2lvbj0xNCI+PC9zY3JpcHQ+IAogRU9GCiAK ICAgICBkZWYgc2VsZi5yZXZpc2lvbk9yRGVzY3JpcHRpb24oc3RyaW5nKQo=