47634 2010-10-13 16:18:41 -0700 WebFont text drawing mangles the clip rect 2010-12-14 01:53:06 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) All OS X 10.5 NEW P2 Normal --- 1 brettw brettw oldest_to_newest 293800 0 brettw 2010-10-13 16:18:41 -0700 WebFontImpl::drawText doesn't save and restore the GraphicsContext around setting the clip, so the GC will have the clip rect still applied after the call returns. 293810 1 70683 brettw 2010-10-13 16:32:50 -0700 Created attachment 70683 Patch 321826 2 70683 eric 2010-12-14 01:53:06 -0800 Comment on attachment 70683 Patch How do we test this? What tests does this affect? 70683 2010-10-13 16:32:50 -0700 2010-12-14 01:53:06 -0800 Patch save.diff text/plain 1170 brettw ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IGIwNzRmNGEuLjYwNjg2ODMgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE0IEBACisyMDEwLTEwLTEzICBCcmV0dCBXaWxzb24gIDxicmV0dHdAY2hyb21pdW0ub3JnPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNhdmUgYW5k IHJlc3RvcmUgdGhlIEdyYXBoaWNzQ29udGV4dCBhcm91bmQgc2V0dGluZyB0aGUgY2xpcCByZWN0 IGZvcgorICAgICAgICBkcmF3aW5nIHRleHQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD00NzYzNAorCisgICAgICAgICogc3JjL1dlYkZvbnRJbXBsLmNw cDoKKyAgICAgICAgKFdlYktpdDo6V2ViRm9udEltcGw6OmRyYXdUZXh0KToKKwogMjAxMC0xMC0x MyAgS2VubmV0aCBSdXNzZWxsICA8a2JyQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgSmFtZXMgUm9iaW5zb24uCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZv bnRJbXBsLmNwcCBiL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRm9udEltcGwuY3BwCmluZGV4IDZm YTU0OTQuLjM4ZDk1ZDQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRm9udElt cGwuY3BwCisrKyBiL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRm9udEltcGwuY3BwCkBAIC0xMDMs OSArMTAzLDExIEBAIHZvaWQgV2ViRm9udEltcGw6OmRyYXdUZXh0KFdlYkNhbnZhcyogY2FudmFz LCBjb25zdCBXZWJUZXh0UnVuJiBydW4sIGNvbnN0IFdlYkZsCiAgICAgbm90SW1wbGVtZW50ZWQo KTsKICNlbmRpZgogCisgICAgZ2Muc2F2ZSgpOwogICAgIGdjLnNldEZpbGxDb2xvcihjb2xvciwg RGV2aWNlQ29sb3JTcGFjZSk7CiAgICAgZ2MuY2xpcChXZWJDb3JlOjpGbG9hdFJlY3QoY2xpcCkp OwogICAgIG1fZm9udC5kcmF3VGV4dCgmZ2MsIHJ1biwgbGVmdEJhc2VsaW5lLCBmcm9tLCB0byk7 CisgICAgZ2MucmVzdG9yZSgpOwogfQogCiBpbnQgV2ViRm9udEltcGw6OmNhbGN1bGF0ZVdpZHRo KGNvbnN0IFdlYlRleHRSdW4mIHJ1bikgY29uc3QK