47631 2010-10-13 15:55:53 -0700 Draw the find overlay holes 2010-10-13 16:12:39 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 293783 0 andersca 2010-10-13 15:55:53 -0700 Draw the find overlay holes 293785 1 70677 andersca 2010-10-13 16:02:47 -0700 Created attachment 70677 Patch 293791 2 70677 sullivan 2010-10-13 16:07:38 -0700 Comment on attachment 70677 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=70677&action=review See my comment above about where to put the constant definitions. I don't have a horse in that race, though. > WebKit2/ChangeLog:10 > + Move the color component constants into overlayBackgroundColor. I'm not sure what the style guidelines say about this. I'm used to putting all the static consts at the top of the file. It seems odd to put the color ones inside overlayBackgroundColor, but not put the shadow ones inside drawRect. 293794 3 70677 mitz 2010-10-13 16:10:11 -0700 Comment on attachment 70677 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=70677&action=review > WebKit2/WebProcess/WebPage/FindPageOverlay.cpp:92 > +static const float shadowOffsetX = 0.0; > +static const float shadowOffsetY = 1.0; > +static const float shadowBlurRadius = 2.0; > +static const float whiteFrameThickness = 1.0; > + Please remove the “.0”s. > WebKit2/WebProcess/WebPage/FindPageOverlay.cpp:115 > graphicsContext.fillRect(paintRect, overlayBackgroundColor(), sRGBColorSpace); I wonder if this shouldn’t have been in device space. > WebKit2/WebProcess/WebPage/FindPageOverlay.cpp:125 > + whiteFrameRect.inflate(1); Did you mean to use whiteFrameThickness? 293799 4 andersca 2010-10-13 16:12:39 -0700 Committed r69711: <http://trac.webkit.org/changeset/69711> 70677 2010-10-13 16:02:47 -0700 2010-10-13 16:10:11 -0700 Patch bug-47631-20101013160246.patch text/plain 4537 andersca ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NGVkYmQ4NDU5MWU3MTU4NjQ0MTYwNGZlMTUzMDY1OWIwYzJhMDZiNi4uYWIwZGRhYTIwY2RmNzEx YWY3MWE4YTRlNzNiNjI2NzFkY2VlYjM4YiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNiBAQAogMjAxMC0xMC0xMyAgQW5k ZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERyYXcgdGhlIGZpbmQgb3ZlcmxheSBob2xlcwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDc2MzEKKwor ICAgICAgICBFeHBvcnQgc3ltYm9scyBuZWVkZWQgYnkgV2ViS2l0Mi4KKworICAgICAgICAqIFdl YkNvcmUuZXhwLmluOgorCisyMDEwLTEwLTEzICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBh cHBsZS5jb20+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgQmV0aCBEYWtpbi4KIAogICAgICAgICBE b24ndCBzZXQgdGhlIGZpbGwvc3Ryb2tlIGNvbG9yc3BhY2UgYmVmb3JlIGZpbGxpbmcvc3Ryb2tp bmcKZGlmZiAtLWdpdCBhL1dlYkNvcmUvV2ViQ29yZS5leHAuaW4gYi9XZWJDb3JlL1dlYkNvcmUu ZXhwLmluCmluZGV4IDI5ZjIyNGEwMmZhMjliODQzYjJmMGVlZWE5NjhjYWJhOGFmMWNjMjMuLmZj YjBlZmQ0YmRlNDJkNTkyMWFhYTgzZTY3Y2UwZWIxMTk5Mjk2ODUgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvV2ViQ29yZS5leHAuaW4KKysrIGIvV2ViQ29yZS9XZWJDb3JlLmV4cC5pbgpAQCAtMzUyLDcg KzM1Miw5IEBAIF9fWk43V2ViQ29yZTE1R3JhcGhpY3NDb250ZXh0MjJiZWdpblRyYW5zcGFyZW5j eUxheWVyRWYKIF9fWk43V2ViQ29yZTE1R3JhcGhpY3NDb250ZXh0NGNsaXBFUktOU185RmxvYXRS ZWN0RQogX19aTjdXZWJDb3JlMTVHcmFwaGljc0NvbnRleHQ0c2F2ZUV2CiBfX1pON1dlYkNvcmUx NUdyYXBoaWNzQ29udGV4dDdyZXN0b3JlRXYKK19fWk43V2ViQ29yZTE1R3JhcGhpY3NDb250ZXh0 OGZpbGxSZWN0RVJLTlNfOUZsb2F0UmVjdEUKIF9fWk43V2ViQ29yZTE1R3JhcGhpY3NDb250ZXh0 OGZpbGxSZWN0RVJLTlNfOUZsb2F0UmVjdEVSS05TXzVDb2xvckVOU18xMENvbG9yU3BhY2VFCitf X1pON1dlYkNvcmUxNUdyYXBoaWNzQ29udGV4dDlzZXRTaGFkb3dFUktOU185RmxvYXRTaXplRWZS S05TXzVDb2xvckVOU18xMENvbG9yU3BhY2VFCiBfX1pON1dlYkNvcmUxNUdyYXBoaWNzQ29udGV4 dDl0cmFuc2xhdGVFZmYKIF9fWk43V2ViQ29yZTE1R3JhcGhpY3NDb250ZXh0QzFFUDlDR0NvbnRl eHQKIF9fWk43V2ViQ29yZTE1R3JhcGhpY3NDb250ZXh0RDFFdgpkaWZmIC0tZ2l0IGEvV2ViS2l0 Mi9DaGFuZ2VMb2cgYi9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCAzMjY5ZmI2ZWQxM2M5MGNiZDE4 NDNjYjM2YmNlNmU5MjNjMjVjYWM5Li4xZGU4NDY4MTZhOTU5YWFmNGRkMTlmMTcyZGRmNzI4MWI4 YTUyMWViIDEwMDY0NAotLS0gYS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9XZWJLaXQyL0NoYW5n ZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDEwLTEwLTEzICBBbmRlcnMgQ2FybHNzb24gIDxhbmRl cnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgRHJhdyB0aGUgZmluZCBvdmVybGF5IGhvbGVzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NzYzMQorCisgICAgICAgICogV2ViUHJvY2Vz cy9XZWJQYWdlL0ZpbmRQYWdlT3ZlcmxheS5jcHA6CisgICAgICAgIChXZWJLaXQ6Om92ZXJsYXlC YWNrZ3JvdW5kQ29sb3IpOgorICAgICAgICBNb3ZlIHRoZSBjb2xvciBjb21wb25lbnQgY29uc3Rh bnRzIGludG8gb3ZlcmxheUJhY2tncm91bmRDb2xvci4KKworICAgICAgICAoV2ViS2l0OjpGaW5k UGFnZU92ZXJsYXk6OmRyYXdSZWN0KToKKyAgICAgICAgRHJhdyB0aGUgd2hpdGUgZnJhbWVzIGFu ZCB0aGUgaG9sZXMuCisKKzIwMTAtMTAtMTMgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFw cGxlLmNvbT4KKwogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KIAogICAgICAgICBV c2UgV0tTSSB0byBnZXQgd2hlZWwgZXZlbnQgZGVsdGFzCmRpZmYgLS1naXQgYS9XZWJLaXQyL1dl YlByb2Nlc3MvV2ViUGFnZS9GaW5kUGFnZU92ZXJsYXkuY3BwIGIvV2ViS2l0Mi9XZWJQcm9jZXNz L1dlYlBhZ2UvRmluZFBhZ2VPdmVybGF5LmNwcAppbmRleCBhNWM1NzA1ZTY3YTBkOWJkOTM1YWJk MmIyYjc0MjQxNTRjMGJjMTIyLi4zZmM4YjllN2Q3MWFmZGU0MDBmNGMxNGU5MmRmZDE2MzA1MTU2 NmYxIDEwMDY0NAotLS0gYS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9GaW5kUGFnZU92ZXJs YXkuY3BwCisrKyBiL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0ZpbmRQYWdlT3ZlcmxheS5j cHAKQEAgLTc1LDE2ICs3NSwyMSBAQCBWZWN0b3I8SW50UmVjdD4gRmluZFBhZ2VPdmVybGF5Ojpy ZWN0c0ZvclRleHRNYXRjaGVzKCkKICAgICByZXR1cm4gcmVjdHM7CiB9CiAKLXN0YXRpYyBjb25z dCBpbnQgb3ZlcmxheUJhY2tncm91bmRSZWQgPSAyNTsKLXN0YXRpYyBjb25zdCBpbnQgb3Zlcmxh eUJhY2tncm91bmRHcmVlbiA9IDI1Owotc3RhdGljIGNvbnN0IGludCBvdmVybGF5QmFja2dyb3Vu ZEJsdWUgPSAyNTsKLXN0YXRpYyBjb25zdCBpbnQgb3ZlcmxheUJhY2tncm91bmRBbHBoYSA9IDYz OwotICAgIAogc3RhdGljIENvbG9yIG92ZXJsYXlCYWNrZ3JvdW5kQ29sb3IoKQogeworICAgIHN0 YXRpYyBjb25zdCBpbnQgb3ZlcmxheUJhY2tncm91bmRSZWQgPSAyNTsKKyAgICBzdGF0aWMgY29u c3QgaW50IG92ZXJsYXlCYWNrZ3JvdW5kR3JlZW4gPSAyNTsKKyAgICBzdGF0aWMgY29uc3QgaW50 IG92ZXJsYXlCYWNrZ3JvdW5kQmx1ZSA9IDI1OworICAgIHN0YXRpYyBjb25zdCBpbnQgb3Zlcmxh eUJhY2tncm91bmRBbHBoYSA9IDYzOworICAgIAogICAgIHJldHVybiBDb2xvcihvdmVybGF5QmFj a2dyb3VuZFJlZCwgb3ZlcmxheUJhY2tncm91bmRHcmVlbiwgb3ZlcmxheUJhY2tncm91bmRCbHVl LCBvdmVybGF5QmFja2dyb3VuZEFscGhhKTsKIH0KLSAgICAKKworc3RhdGljIGNvbnN0IGZsb2F0 IHNoYWRvd09mZnNldFggPSAwLjA7CitzdGF0aWMgY29uc3QgZmxvYXQgc2hhZG93T2Zmc2V0WSA9 IDEuMDsKK3N0YXRpYyBjb25zdCBmbG9hdCBzaGFkb3dCbHVyUmFkaXVzID0gMi4wOworc3RhdGlj IGNvbnN0IGZsb2F0IHdoaXRlRnJhbWVUaGlja25lc3MgPSAxLjA7CisKIHZvaWQgRmluZFBhZ2VP dmVybGF5OjpkcmF3UmVjdChHcmFwaGljc0NvbnRleHQmIGdyYXBoaWNzQ29udGV4dCwgY29uc3Qg SW50UmVjdCYgZGlydHlSZWN0KQogewogICAgIFZlY3RvcjxJbnRSZWN0PiByZWN0cyA9IHJlY3Rz Rm9yVGV4dE1hdGNoZXMoKTsKQEAgLTEwOSw4ICsxMTQsMjkgQEAgdm9pZCBGaW5kUGFnZU92ZXJs YXk6OmRyYXdSZWN0KEdyYXBoaWNzQ29udGV4dCYgZ3JhcGhpY3NDb250ZXh0LCBjb25zdCBJbnRS ZWN0JgogICAgIC8vIERyYXcgdGhlIGJhY2tncm91bmQuCiAgICAgZ3JhcGhpY3NDb250ZXh0LmZp bGxSZWN0KHBhaW50UmVjdCwgb3ZlcmxheUJhY2tncm91bmRDb2xvcigpLCBzUkdCQ29sb3JTcGFj ZSk7CiAKLSAgICAvLyBGSVhNRTogRHJhdyB0aGUgaG9sZXMuCisgICAgZ3JhcGhpY3NDb250ZXh0 LnNhdmUoKTsKKyAgICBncmFwaGljc0NvbnRleHQuc2V0U2hhZG93KEZsb2F0U2l6ZShzaGFkb3dP ZmZzZXRYLCBzaGFkb3dPZmZzZXRZKSwgc2hhZG93Qmx1clJhZGl1cywgQ29sb3I6OmJsYWNrLCBz UkdCQ29sb3JTcGFjZSk7CisKKyAgICBncmFwaGljc0NvbnRleHQuc2V0RmlsbENvbG9yKENvbG9y Ojp3aGl0ZSwgc1JHQkNvbG9yU3BhY2UpOworCisgICAgLy8gRHJhdyB3aGl0ZSBmcmFtZXMgYXJv dW5kIHRoZSBob2xlcy4KKyAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IHJlY3RzLnNpemUoKTsg KytpKSB7CisgICAgICAgIEludFJlY3Qgd2hpdGVGcmFtZVJlY3QgPSByZWN0c1tpXTsKKyAgICAg ICAgd2hpdGVGcmFtZVJlY3QuaW5mbGF0ZSgxKTsKKworICAgICAgICBncmFwaGljc0NvbnRleHQu ZmlsbFJlY3Qod2hpdGVGcmFtZVJlY3QpOworICAgIH0KKworICAgIGdyYXBoaWNzQ29udGV4dC5y ZXN0b3JlKCk7CisKKyAgICBncmFwaGljc0NvbnRleHQuc2F2ZSgpOworICAgIGdyYXBoaWNzQ29u dGV4dC5zZXRGaWxsQ29sb3IoQ29sb3I6OnRyYW5zcGFyZW50LCBzUkdCQ29sb3JTcGFjZSk7CisK KyAgICAvLyBDbGVhciBvdXQgdGhlIGhvbGVzLgorICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwg cmVjdHMuc2l6ZSgpOyArK2kpCisgICAgICAgIGdyYXBoaWNzQ29udGV4dC5maWxsUmVjdChyZWN0 c1tpXSk7CiAKKyAgICBncmFwaGljc0NvbnRleHQucmVzdG9yZSgpOwogICAgIGdyYXBoaWNzQ29u dGV4dC5lbmRUcmFuc3BhcmVuY3lMYXllcigpOwogfQogCg==