47625 2010-10-13 15:30:49 -0700 Run layout tests when GL fails to initialize 2014-10-22 10:31:25 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 NEW P2 Normal --- 1 hclam webkit-unassigned abarth hclam jamesr vangelis vrk oldest_to_newest 293754 0 hclam 2010-10-13 15:30:49 -0700 test_shell and DRT uses Mesa which doesn't test that case when GL fails to initialize. The first step is to have the tools be able to fail the initialization when running the layout test. The second step is to allow layout test to control that in the script. 293757 1 70674 hclam 2010-10-13 15:37:44 -0700 Created attachment 70674 patch 293763 2 jamesr 2010-10-13 15:41:41 -0700 Do we want --use-gl or some flag to explicitly toggle whether context initialization fails? This flag doesn't seem to describe what it does very well. 293766 3 vrk 2010-10-13 15:43:16 -0700 (In reply to comment #2) > Do we want --use-gl or some flag to explicitly toggle whether context initialization fails? This flag doesn't seem to describe what it does very well. I agree, I think it would make more sense to have an explicit flag for testing the case where the GL initialization fails. 293769 4 hclam 2010-10-13 15:47:05 -0700 what about --no-gl-context? 293927 5 70674 levin 2010-10-13 20:47:13 -0700 Comment on attachment 70674 patch Based on comments already in the bug. 70674 2010-10-13 15:37:44 -0700 2010-10-13 20:47:12 -0700 patch webkit-fix-script.patch text/plain 2254 hclam ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBmMGI2MzM0Li5jNWIxZTFmIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMTAt MTMgIEFscGhhIExhbSAgPGhjbGFtQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NDc2MjUKKyAgICAgICAgU3BlY2lmeSBhIEdMIGltcGxlbWVudGF0aW9uIGZv ciBydW5uaW5nIHRlc3Rfc2hlbGwgYW5kIERSVC4KKworICAgICAgICBBZGRpbmcgLS11c2UtZ2wg YXMgYSB3YXkgdG8gbWFudWFsbHkgZmFpbCB0aGUgR0wgY29udGV4dCBpbml0aWFsaXphdGlvbi4K KyAgICAgICAgSXQgY2FuIGFsc28gYmUgdXNlZCB0byB0cnkgZGlmZmVyZW50IEdMIGltcGxlbWVu dGF0aW9ucyB3aXRoIGxheW91dCB0ZXN0cy4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW0ucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weToKKwogMjAxMC0xMC0xMyAgQWRhbSBC YXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IENzYWJhIE9z enRyb2dvbsOhYy4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW0ucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5 L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtLnB5CmluZGV4IDMwMWQ0YjEuLjg3MmJjMzcgMTAw NjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQv Y2hyb21pdW0ucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz dHMvcG9ydC9jaHJvbWl1bS5weQpAQCAtMzc1LDYgKzM3NSw5IEBAIGNsYXNzIENocm9taXVtRHJp dmVyKGJhc2UuRHJpdmVyKToKICAgICAgICAgaWYgc2VsZi5fb3B0aW9ucy5hY2NlbGVyYXRlZF9j b21wb3NpdGluZzoKICAgICAgICAgICAgIGRyaXZlcl9hcmdzLmFwcGVuZCgnLS1lbmFibGUtYWNj ZWxlcmF0ZWQtY29tcG9zaXRpbmcnKQogCisgICAgICAgIGlmIHNlbGYuX29wdGlvbnMudXNlX2ds OgorICAgICAgICAgICAgZHJpdmVyX2FyZ3MuYXBwZW5kKCctLXVzZS1nbD0nICsgc2VsZi5fb3B0 aW9ucy51c2VfZ2wpCisKICAgICAgICAgaWYgc2VsZi5fb3B0aW9ucy5hY2NlbGVyYXRlZF8yZF9j YW52YXM6CiAgICAgICAgICAgICBkcml2ZXJfYXJncy5hcHBlbmQoJy0tZW5hYmxlLWFjY2VsZXJh dGVkLTJkLWNhbnZhcycpCiAgICAgICAgIHJldHVybiBkcml2ZXJfYXJncwpkaWZmIC0tZ2l0IGEv V2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0 cy5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJr aXRfdGVzdHMucHkKaW5kZXggOWNjNzg5NS4uNmI4YjlkZCAxMDA3NTUKLS0tIGEvV2ViS2l0VG9v bHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weQorKysg Yi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rl c3RzLnB5CkBAIC0xNTI0LDYgKzE1MjQsOSBAQCBkZWYgcGFyc2VfYXJncyhhcmdzPU5vbmUpOgog ICAgICAgICBvcHRwYXJzZS5tYWtlX29wdGlvbigiLS1hY2NlbGVyYXRlZC1jb21wb3NpdGluZyIs CiAgICAgICAgICAgICBhY3Rpb249InN0b3JlX3RydWUiLAogICAgICAgICAgICAgaGVscD0iVXNl IGhhcmR3YXJlLWFjY2VsYXRlZCBjb21wb3NpdGluZyBmb3IgcmVuZGVyaW5nIiksCisgICAgICAg IG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCItLXVzZS1nbCIsCisgICAgICAgICAgICBkZXN0PSJ1c2Vf Z2wiLAorICAgICAgICAgICAgaGVscD0iVXNlIGEgc3BlY2lmaWMgR0wgaW1wbGVtZW50YXRpb24i KSwKICAgICAgICAgb3B0cGFyc2UubWFrZV9vcHRpb24oIi0tbm8tYWNjZWxlcmF0ZWQtY29tcG9z aXRpbmciLAogICAgICAgICAgICAgYWN0aW9uPSJzdG9yZV9mYWxzZSIsCiAgICAgICAgICAgICBk ZXN0PSJhY2NlbGVyYXRlZF9jb21wb3NpdGluZyIsCg==