47613 2010-10-13 12:44:44 -0700 [Qt] QtTestBrowser shows two Url input fields 2010-10-15 12:12:16 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) S60 Hardware S60 3rd edition RESOLVED FIXED P2 Normal --- 0 max.hong.shen webkit-unassigned ademar commit-queue tonikitoo oldest_to_newest 293634 0 max.hong.shen 2010-10-13 12:44:44 -0700 I saw two Url input fields show on the toolbar of QtTestBrowser. In MainWindow::buildUI(), it deletes the old toolbar instance which is supposed to delete the LocationEdit as well, however, it doesn't. To make a quick fix instead of waiting Qt UI code's change, we can explicitly delete the locationedit by ourself on Symbian. 293636 1 70648 max.hong.shen 2010-10-13 12:47:02 -0700 Created attachment 70648 first try 293641 2 tonikitoo 2010-10-13 12:51:54 -0700 Does it happens on trunk at all? 293647 3 max.hong.shen 2010-10-13 12:54:58 -0700 I think so, it can be reproduced on Symbian with Qt 4.7 293649 4 tonikitoo 2010-10-13 12:56:42 -0700 (In reply to comment #2) > Does it happens on trunk at all? because on trunk we have this: <<<<<>>> urlEdit = new LocationEdit(m_toolBar); <<<<<>>> so when we delete m_toolBar we should also be deleting the urlEdit. Could you please check if the 2.1 branch has this code? 293650 5 max.hong.shen 2010-10-13 13:01:59 -0700 Yes, 2.1 branch has that code. (Remember we have cheery-picked your patches) I think the root cause for this issue is from Qt Core/Gui, but we may want to address it quickly by deleting LocationEdit by ourself. 293657 6 tonikitoo 2010-10-13 13:11:54 -0700 I can not reproduce this problem with trunk with qtwebkit on mac :( what steps are you using? 293659 7 max.hong.shen 2010-10-13 13:12:52 -0700 It is only can be reproduced on Symbian :) 293660 8 tonikitoo 2010-10-13 13:14:03 -0700 (In reply to comment #7) > It is only can be reproduced on Symbian :) oh :) ok 293666 9 max.hong.shen 2010-10-13 13:17:27 -0700 Thanks, Antonio :) 293819 10 70648 commit-queue 2010-10-13 16:58:09 -0700 Comment on attachment 70648 first try Clearing flags on attachment: 70648 Committed r69714: <http://trac.webkit.org/changeset/69714> 293820 11 commit-queue 2010-10-13 16:58:14 -0700 All reviewed patches have been landed. Closing bug. 294850 12 ademar 2010-10-15 12:10:02 -0700 Revision r69714 cherry-picked into qtwebkit-2.1 with commit 995f39c <http://gitorious.org/webkit/qtwebkit/commit/995f39c> 294851 13 ademar 2010-10-15 12:12:16 -0700 duh, should've been "block" 39121, not "depends on". :-) Anyway, already integrated. 70648 2010-10-13 12:47:02 -0700 2010-10-13 16:58:08 -0700 first try 47613.patch text/plain 1266 max.hong.shen SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDY5Njc5KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMTAtMTMgIFlpIFNoZW4gIDx5aS40LnNo ZW5Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFtRdF0gUXRUZXN0QnJvd3NlciBzaG93cyB0d28gVXJsIGlucHV0IGZpZWxkcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDc2MTMKKworICAg ICAgICAqIFF0VGVzdEJyb3dzZXIvbWFpbndpbmRvdy5jcHA6CisgICAgICAgIChNYWluV2luZG93 OjpNYWluV2luZG93KToKKyAgICAgICAgKE1haW5XaW5kb3c6OmJ1aWxkVUkpOgorCiAyMDEwLTEw LTEzICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAg ICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByNjk2MzguCkluZGV4OiBXZWJLaXRUb29scy9RdFRl c3RCcm93c2VyL21haW53aW5kb3cuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1F0VGVz dEJyb3dzZXIvbWFpbndpbmRvdy5jcHAJKHJldmlzaW9uIDY5Njc1KQorKysgV2ViS2l0VG9vbHMv UXRUZXN0QnJvd3Nlci9tYWlud2luZG93LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzgsNiArMzgs NyBAQAogTWFpbldpbmRvdzo6TWFpbldpbmRvdygpCiAgICAgOiBtX3BhZ2UobmV3IFdlYlBhZ2Uo dGhpcykpCiAgICAgLCBtX3Rvb2xCYXIoMCkKKyAgICAsIHVybEVkaXQoMCkKIHsKICAgICBzZXRB dHRyaWJ1dGUoUXQ6OldBX0RlbGV0ZU9uQ2xvc2UpOwogICAgIGlmIChxZ2V0ZW52KCJRVFRFU1RC Uk9XU0VSX1VTRV9BUkdCX1ZJU1VBTFMiKS50b0ludCgpID09IDEpCkBAIC00OCw2ICs0OSw5IEBA IE1haW5XaW5kb3c6Ok1haW5XaW5kb3coKQogCiB2b2lkIE1haW5XaW5kb3c6OmJ1aWxkVUkoKQog eworI2lmIGRlZmluZWQoUV9PU19TWU1CSUFOKQorICAgIGRlbGV0ZSB1cmxFZGl0OworI2VuZGlm CiAgICAgZGVsZXRlIG1fdG9vbEJhcjsKIAogICAgIG1fdG9vbEJhciA9IGFkZFRvb2xCYXIoIk5h dmlnYXRpb24iKTsK