47610 2010-10-13 11:50:06 -0700 Revert changes to WebViewImpl in r69633 2010-10-13 13:30:15 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 kbr kbr jamesr levin oldest_to_newest 293572 0 kbr 2010-10-13 11:50:06 -0700 David Levin pointed out that the change to WebViewImpl in http://trac.webkit.org/changeset/69633 incorrectly used PassRefPtr for a local variable instead of RefPtr. I thought I had seen an assertion failure in this code change in http://trac.webkit.org/changeset/69624 but after reverting it it seems not. 293575 1 70643 kbr 2010-10-13 11:51:52 -0700 Created attachment 70643 Patch 293580 2 70643 jamesr 2010-10-13 12:01:18 -0700 Comment on attachment 70643 Patch Yup! 293671 3 kbr 2010-10-13 13:30:15 -0700 Committed r69693: <http://trac.webkit.org/changeset/69693> 70643 2010-10-13 11:51:52 -0700 2010-10-13 12:01:18 -0700 Patch web-view-impl.patch text/plain 1930 kbr SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjk2NzkpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTAtMTAtMTMgIEtlbm5l dGggUnVzc2VsbCAgPGtickBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFJldmVydCBjaGFuZ2VzIHRvIFdlYlZpZXdJbXBsIGluIHI2 OTYzMworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDc2 MTAKKworICAgICAgICBSZXZlcnQgY2hhbmdlIHRvIFdlYlZpZXdJbXBsLmNwcCBpbgorICAgICAg ICBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC82OTYzMyB3aGljaCBpbmNvcnJlY3Rs eSB1c2VkCisgICAgICAgIFBhc3NSZWZQdHIgZm9yIGEgbG9jYWwgdmFyaWFibGUgaW5zdGVhZCBv ZiBSZWZQdHIuIFRoaXMgd2FzIGEgZml4CisgICAgICAgIGZvciBjaGFuZ2VzIGluIGh0dHA6Ly90 cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzY5NjE5IGFuZAorICAgICAgICBodHRwOi8vdHJhYy53 ZWJraXQub3JnL2NoYW5nZXNldC82OTYyNCAuCisKKyAgICAgICAgKiBzcmMvV2ViVmlld0ltcGwu Y3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJWaWV3SW1wbDo6c2V0SXNBY2NlbGVyYXRlZENvbXBv c2l0aW5nQWN0aXZlKToKKwogMjAxMC0xMC0xMyAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQu b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFRvbnkgQ2hhbmcuCkluZGV4OiBXZWJLaXQvY2hy b21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0v c3JjL1dlYlZpZXdJbXBsLmNwcAkocmV2aXNpb24gNjk2MzMpCisrKyBXZWJLaXQvY2hyb21pdW0v c3JjL1dlYlZpZXdJbXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjM2OSwxMyArMjM2OSwxMyBA QCB2b2lkIFdlYlZpZXdJbXBsOjpzZXRJc0FjY2VsZXJhdGVkQ29tcG9zCiAgICAgICAgIHJldHVy bjsKICAgICB9CiAKLSAgICBQYXNzUmVmUHRyPEdyYXBoaWNzQ29udGV4dDNEPiBjb250ZXh0ID0g bV90ZW1wb3JhcnlPbnNjcmVlbkdyYXBoaWNzQ29udGV4dDNELnJlbGVhc2UoKTsKKyAgICBSZWZQ dHI8R3JhcGhpY3NDb250ZXh0M0Q+IGNvbnRleHQgPSBtX3RlbXBvcmFyeU9uc2NyZWVuR3JhcGhp Y3NDb250ZXh0M0QucmVsZWFzZSgpOwogICAgIGlmICghY29udGV4dCkgewogICAgICAgICBjb250 ZXh0ID0gR3JhcGhpY3NDb250ZXh0M0Q6OmNyZWF0ZShHcmFwaGljc0NvbnRleHQzRDo6QXR0cmli dXRlcygpLCBtX3BhZ2UtPmNocm9tZSgpLCBHcmFwaGljc0NvbnRleHQzRDo6UmVuZGVyRGlyZWN0 bHlUb0hvc3RXaW5kb3cpOwogICAgICAgICBpZiAoY29udGV4dCkKICAgICAgICAgICAgIGNvbnRl eHQtPnJlc2hhcGUoc3RkOjptYXgoMSwgbV9zaXplLndpZHRoKSwgc3RkOjptYXgoMSwgbV9zaXpl LmhlaWdodCkpOwogICAgIH0KLSAgICBtX2xheWVyUmVuZGVyZXIgPSBMYXllclJlbmRlcmVyQ2hy b21pdW06OmNyZWF0ZShjb250ZXh0KTsKKyAgICBtX2xheWVyUmVuZGVyZXIgPSBMYXllclJlbmRl cmVyQ2hyb21pdW06OmNyZWF0ZShjb250ZXh0LnJlbGVhc2UoKSk7CiAgICAgaWYgKG1fbGF5ZXJS ZW5kZXJlcikgewogICAgICAgICBtX2lzQWNjZWxlcmF0ZWRDb21wb3NpdGluZ0FjdGl2ZSA9IHRy dWU7CiAgICAgICAgIG1fY29tcG9zaXRvckNyZWF0aW9uRmFpbGVkID0gZmFsc2U7Cg==