47609 2010-10-13 11:48:38 -0700 [Qt] Fix http/tests/misc/redirect-to-external-url.html 2014-02-03 03:10:25 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC OS X 10.5 RESOLVED INVALID Qt, QtTriaged P2 Normal --- 47687 1 robert webkit-unassigned commit-queue jwieczorek tonikitoo oldest_to_newest 293571 0 robert 2010-10-13 11:48:38 -0700 Support the test in FrameLoaderClientQt 293574 1 70642 robert 2010-10-13 11:51:09 -0700 Created attachment 70642 Patch 294285 2 jwieczorek 2010-10-14 12:32:58 -0700 > [Qt] Fix http/tests/misc/redirect-to-external-url.html Nah, you're not fixing it, really. I recommend looking at what other ports are doing but special-casing a specific situation from a test case inside WebKit is not a solution at all. Not to mention that theoretically each scheme can be supported by the embedder via an extended QNAM. If this patch was OK, we could go ahead and reduce the failing test list to 0 with similar changes, but in real-world situations QtWebKit would still not work as expected and you'd not be aware of that due to the tests happily passing. 294287 3 70642 commit-queue 2010-10-14 12:38:34 -0700 Comment on attachment 70642 Patch Clearing flags on attachment: 70642 Committed r69795: <http://trac.webkit.org/changeset/69795> 294288 4 commit-queue 2010-10-14 12:38:39 -0700 All reviewed patches have been landed. Closing bug. 294294 5 tonikitoo 2010-10-14 12:42:47 -0700 (In reply to comment #2) > > [Qt] Fix http/tests/misc/redirect-to-external-url.html > > Nah, you're not fixing it, really. > I recommend looking at what other ports are doing but special-casing a specific situation from a test case inside WebKit is not a solution at all. Not to mention that theoretically each scheme can be supported by the embedder via an extended QNAM. > > If this patch was OK, we could go ahead and reduce the failing test list to 0 with similar changes, but in real-world situations QtWebKit would still not work as expected and you'd not be aware of that due to the tests happily passing. Oh. should we roll it out? it is one command on IRC :) 294300 6 robert 2010-10-14 12:58:37 -0700 (In reply to comment #2) > > [Qt] Fix http/tests/misc/redirect-to-external-url.html > > Nah, you're not fixing it, really. > I recommend looking at what other ports are doing but special-casing a specific situation from a test case inside WebKit is not a solution at all. Not to mention that theoretically each scheme can be supported by the embedder via an extended QNAM. Chromium special-cases it. My understanding is that the test is for WebCore functionality, PolicyChecker::continueAfterNavigationPolicy(PolicyAction policy and the canHandleRequest() is expected to fail. I agree that it would be better to remove the DRT special-casing we have in FrameLoaderClientQt, along with all the other DRT specific messages in there. But that's a different problem. 294307 7 jwieczorek 2010-10-14 13:18:55 -0700 (In reply to comment #6) > (In reply to comment #2) > > > [Qt] Fix http/tests/misc/redirect-to-external-url.html > > > > Nah, you're not fixing it, really. > > I recommend looking at what other ports are doing but special-casing a specific situation from a test case inside WebKit is not a solution at all. Not to mention that theoretically each scheme can be supported by the embedder via an extended QNAM. > > Chromium special-cases it. My understanding is that the test is for WebCore functionality, PolicyChecker::continueAfterNavigationPolicy(PolicyAction policy and the canHandleRequest() is expected to fail. OK. I don't think you should follow Chromium in this case though. Other ports don't seem to do this and yet, they pass this test, so apparently they can get the necessary information from the network stack. QtWebKit, due to its abstract network interface, cannot. Moreover, if a specific behavior of canHandleRequest() is an assumption in this test case and yet that behavior never occurs in QtWebKit, what's the point of testing this anyway? I think all this test deserves is a good comment in the skipped list. > I agree that it would be better to remove the DRT special-casing we have in FrameLoaderClientQt, along with all the other DRT specific messages in there. But that's a different problem. Yes. I'd suggest we don't make the situation even worse though. 294564 8 tonikitoo 2010-10-14 21:11:55 -0700 Rolled out by bug 47687. 974998 9 jturcotte 2014-02-03 03:10:25 -0800 === Bulk closing of Qt bugs === If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary. If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines. 70642 2010-10-13 11:51:09 -0700 2010-10-14 12:38:34 -0700 Patch bug-47609-20101013195106.patch text/plain 3653 robert ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBiZDU5ZDMwOTczY2YzNzkxNTliMDU4NDcyYzNkZjQ1NmJmYjA3NDZjLi43YTdkNzU0 MTJiODdiMmMzM2NkODIwOGE0YTU4MjUxNmZjOTE0MWVkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTAtMTAtMTMgIFJvYmVydCBIb2dhbiAgPHJvYmVydEB3ZWJraXQub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gRml4IGh0dHAvdGVz dHMvbWlzYy9yZWRpcmVjdC10by1leHRlcm5hbC11cmwuaHRtbAorCisgICAgICAgIFN1cHBvcnQg dGhlIHRlc3QgaW4gRnJhbWVMb2FkZXJDbGllbnRRdCBhbmQgdW5za2lwLgorCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NzYwOQorCisgICAgICAgICog cGxhdGZvcm0vcXQvU2tpcHBlZDoKKwogMjAxMC0xMC0xMiAgUm9iZXJ0IEhvZ2FuICA8cm9iZXJ0 QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxh dGZvcm0vcXQvU2tpcHBlZAppbmRleCA2MjNkNjNkYzQzNzgxMGE3NjBhOWQ5MzgwOWJlZmVmZjkw ZGU3MTk3Li4yMzFhNzZmM2UxZWI5NjY3OGNhNGM2NGYzMjgxZTYyZmU2MDBkMjQ4IDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3Bs YXRmb3JtL3F0L1NraXBwZWQKQEAgLTcyNiw3ICs3MjYsNiBAQCBodHRwL3Rlc3RzL3htbGh0dHBy ZXF1ZXN0L2RlZmF1bHQtY29udGVudC10eXBlLWRhc2hib2FyZC5odG1sCiBodHRwL3Rlc3RzL3ht bGh0dHByZXF1ZXN0L3N2Zy1jcmVhdGVkLWJ5LXhoci1kaXNhbGxvd2VkLWluLWRhc2hib2FyZC5o dG1sCiAKICMgdGltZW91dAotaHR0cC90ZXN0cy9taXNjL3JlZGlyZWN0LXRvLWV4dGVybmFsLXVy bC5odG1sCiBodHRwL3Rlc3RzL3NlY3VyaXR5L2ZlZWQtdXJscy1mcm9tLXJlbW90ZS5odG1sCiAK ICMgVGhpcyByZXF1aXJlcyBkaWRDbGVhcldpbmRvd09iamVjdEZvckZyYW1lSW5Jc29sYXRlZFdv cmxkIGZvbyBpbiBGcmFtZUxvYWRlckNsaWVudApkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0L0NoYW5n ZUxvZyBiL1dlYktpdC9xdC9DaGFuZ2VMb2cKaW5kZXggMTI0ZGFjMjhkYTExYTUwZTFiM2EyNzhl ODJlYjhjODdhZTk0MmZlMi4uMDY0YWQ0MTFiYmVlNDBlNzVkZjkzMGJmYjc1Y2U0NmM5ZjVlOGIy MyAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0L0NoYW5nZUxvZworKysgYi9XZWJLaXQvcXQvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMTAtMTMgIFJvYmVydCBIb2dhbiAgPHJvYmVydEB3 ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFtRdF0gRml4IGh0dHAvdGVzdHMvbWlzYy9yZWRpcmVjdC10by1leHRlcm5hbC11cmwuaHRt bAorCisgICAgICAgIFN1cHBvcnQgdGhlIHRlc3QgaW4gRnJhbWVMb2FkZXJDbGllbnRRdCBhbmQg dW5za2lwLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD00NzYwOQorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRRdC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlckNsaWVudFF0OjpjYW5IYW5kbGVSZXF1 ZXN0KToKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVyQ2xpZW50UXQ6OmRpc3BhdGNoVW5h YmxlVG9JbXBsZW1lbnRQb2xpY3kpOgorCiAyMDEwLTEwLTEyICBZYWVsIEFoYXJvbiAgPHlhZWwu YWhhcm9uQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbnRvbmlvIEdvbWVzLgpk aWZmIC0tZ2l0IGEvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50UXQu Y3BwIGIvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50UXQuY3BwCmlu ZGV4IDI4MTUxNzFlMDE2ZjJiYzYxMjg4ZWRhMmE0ZmEwN2Q3YmMwMWRlMGIuLjAxMGM2YWI1NTYw ZjM3MTVlMDMzNDE1YmRjMzU2ZWJmMTJkODRlMzcgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9XZWJD b3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudFF0LmNwcAorKysgYi9XZWJLaXQvcXQvV2ViQ29y ZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRRdC5jcHAKQEAgLTcwOSw4ICs3MDksMTUgQEAgdm9p ZCBGcmFtZUxvYWRlckNsaWVudFF0OjpmcmFtZUxvYWRlckRlc3Ryb3llZCgpCiAgICAgZGVsZXRl IHRoaXM7CiB9CiAKLWJvb2wgRnJhbWVMb2FkZXJDbGllbnRRdDo6Y2FuSGFuZGxlUmVxdWVzdChj b25zdCBXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3QmKSBjb25zdAorYm9vbCBGcmFtZUxvYWRlckNs aWVudFF0OjpjYW5IYW5kbGVSZXF1ZXN0KGNvbnN0IFdlYkNvcmU6OlJlc291cmNlUmVxdWVzdCYg cmVxdWVzdCkgY29uc3QKIHsKKyAgICBpZiAoUVdlYlBhZ2VQcml2YXRlOjpkcnRSdW4pIHsKKyAg ICAgICAgLy8gSnVzdCByZWplY3QgdGhlIHNjaGVtZSB1c2VkIGluCisgICAgICAgIC8vIExheW91 dFRlc3RzL2h0dHAvdGVzdHMvbWlzYy9yZWRpcmVjdC10by1leHRlcm5hbC11cmwuaHRtbAorICAg ICAgICBRVXJsIHVybCA9IFFVcmwocmVxdWVzdC51cmwoKSk7CisgICAgICAgIGlmICh1cmwuc2No ZW1lKCkgPT0gInNwYWNlYmFsbHMiKQorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIH0K ICAgICByZXR1cm4gdHJ1ZTsKIH0KIApAQCAtMTE5Myw5ICsxMjAwLDE2IEBAIHZvaWQgRnJhbWVM b2FkZXJDbGllbnRRdDo6ZGlzcGF0Y2hEZWNpZGVQb2xpY3lGb3JOYXZpZ2F0aW9uQWN0aW9uKEZy YW1lUG9saWN5RnVuCiAgICAgY2FsbFBvbGljeUZ1bmN0aW9uKGZ1bmN0aW9uLCBQb2xpY3lVc2Up OwogfQogCi12b2lkIEZyYW1lTG9hZGVyQ2xpZW50UXQ6OmRpc3BhdGNoVW5hYmxlVG9JbXBsZW1l bnRQb2xpY3koY29uc3QgV2ViQ29yZTo6UmVzb3VyY2VFcnJvciYpCit2b2lkIEZyYW1lTG9hZGVy Q2xpZW50UXQ6OmRpc3BhdGNoVW5hYmxlVG9JbXBsZW1lbnRQb2xpY3koY29uc3QgV2ViQ29yZTo6 UmVzb3VyY2VFcnJvciYgZXJyb3IpCiB7Ci0gICAgbm90SW1wbGVtZW50ZWQoKTsKKyAgICBpZiAo IW1fd2ViRnJhbWUpCisgICAgICAgIHJldHVybjsKKworICAgIGlmIChRV2ViUGFnZVByaXZhdGU6 OmRydFJ1bikgeworICAgICAgICBwcmludGYoIlBvbGljeSBkZWxlZ2F0ZTogdW5hYmxlIHRvIGlt cGxlbWVudCBwb2xpY3kgd2l0aCBlcnJvciBkb21haW4gJyVzJywgIgorICAgICAgICAgICAgICAi ZXJyb3IgY29kZSAlZCwgaW4gZnJhbWUgJyVzJ1xuIiwKKyAgICAgICAgICAgICAgZXJyb3IuZG9t YWluKCkudXRmOCgpLmRhdGEoKSwgZXJyb3IuZXJyb3JDb2RlKCksIG1fd2ViRnJhbWUtPmZyYW1l TmFtZSgpLnRvVXRmOCgpLmRhdGEoKSk7CisgICAgfQogfQogCiB2b2lkIEZyYW1lTG9hZGVyQ2xp ZW50UXQ6OnN0YXJ0RG93bmxvYWQoY29uc3QgV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0JiByZXF1 ZXN0KQo=