47597 2010-10-13 09:49:16 -0700 Proposal: Require cross-organizational seconds for reviewer nominations 2011-01-21 12:35:49 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric eric ap darin hamaji kenneth kling mjs tonikitoo oldest_to_newest 293470 0 eric 2010-10-13 09:49:16 -0700 Proposal: Require cross-organizational seconds for reviewer nominations 293475 1 70619 eric 2010-10-13 09:55:38 -0700 Created attachment 70619 Patch 293478 2 70620 eric 2010-10-13 09:58:21 -0700 Created attachment 70620 Patch 326552 3 70620 kenneth 2010-12-24 02:44:19 -0800 Comment on attachment 70620 Patch I do not know who could review this, thought I support it. Did we agree on this on the mailing list? 326621 4 eric 2010-12-24 08:33:14 -0800 I'm not as passionate about this patch as a once was. But I still think it's a good idea. 326631 5 tonikitoo 2010-12-24 09:00:30 -0800 I do not think this patch should be up for review until there is a 100% agreement on the mailing list. ps: I agree with it. Well, sorta ... sometimes it is unneeded, you know... 326651 6 70620 darin 2010-12-24 09:50:43 -0800 Comment on attachment 70620 Patch This should be discussed on the reviewer mailing list. I don’t think the patch review process is sufficient for changing the rules about becoming a reviewer. 333416 7 70620 abarth 2011-01-12 16:39:06 -0800 Comment on attachment 70620 Patch There's been some discussion of this change on the webkit-reviewers list. I'm not sure this patch reflects the current consensus. In any case, we should probably sort out what policy we want first. 333814 8 78830 levin 2011-01-13 11:13:00 -0800 Created attachment 78830 Patch 333870 9 eric 2011-01-13 12:27:32 -0800 Thanks dave! 333976 10 78863 levin 2011-01-13 15:25:24 -0800 Created attachment 78863 Patch 338163 11 78863 darin 2011-01-21 11:00:19 -0800 Comment on attachment 78863 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=78863&action=review OK. Lets do this. My grammatical tweak suggestions are not binding, of course. For one thing they haven’t even been discussed with the rest of the reviewers. > Websites/webkit.org/coding/commit-review-policy.html:102 > +community as a whole, and not just within their own place of employment or This comma should be removed. > Websites/webkit.org/coding/commit-review-policy.html:105 > +with the nominee (other than WebKit itself).</p> This would be better with a comma rather than parentheses. I also think "the WebKit project itself" would be clearer than "WebKit itself". 338271 12 eric 2011-01-21 12:35:49 -0800 http://trac.webkit.org/changeset/76367 70619 2010-10-13 09:55:38 -0700 2010-10-13 09:58:17 -0700 Patch bug-47597-20101013095537.patch text/plain 2524 eric ZGlmZiAtLWdpdCBhL1dlYktpdFNpdGUvQ2hhbmdlTG9nIGIvV2ViS2l0U2l0ZS9DaGFuZ2VMb2cK aW5kZXggZjU1YTU4ZjhhYTRkMTYzZTZjMTcwMGM0ZWRhMWU0NmU5NTgxZTE2MS4uMDgwZDIxYjZl ZDQ3NzM5ODc2MTBiN2QwZTU0NzRmY2U3ODdiYjYxYyAxMDA2NDQKLS0tIGEvV2ViS2l0U2l0ZS9D aGFuZ2VMb2cKKysrIGIvV2ViS2l0U2l0ZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAx MC0xMC0xMyAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUHJvcG9zYWw6IFJlcXVpcmUgY3Jvc3Mt b3JnYW5pemF0aW9uYWwgc2Vjb25kcyBmb3IgcmV2aWV3ZXIgbm9taW5hdGlvbnMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3NTk3CisKKyAgICAgICAg KiBjb2RpbmcvY29tbWl0LXJldmlldy1wb2xpY3kuaHRtbDoKKwogMjAxMC0xMC0wMSAgQWxleCBN YXRoZXdzICA8cG9zc2Vzc2VkcGVuZ3VpbmJvYkBnbWFpbC5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgU2ltb24gRnJhc2VyLgpkaWZmIC0tZ2l0IGEvV2ViS2l0U2l0ZS9jb2RpbmcvY29tbWl0 LXJldmlldy1wb2xpY3kuaHRtbCBiL1dlYktpdFNpdGUvY29kaW5nL2NvbW1pdC1yZXZpZXctcG9s aWN5Lmh0bWwKaW5kZXggYzc4YjdkYWMyZjkwZGYwZDRhOTEyNTdiMjE2MDA3NDMzZTk0MjVjNi4u ODM2MTgyNTI3NDg2NDYyZjQzNjk2YzZmZmEyM2RjZTY1ZTM3MjA4OSAxMDA2NDQKLS0tIGEvV2Vi S2l0U2l0ZS9jb2RpbmcvY29tbWl0LXJldmlldy1wb2xpY3kuaHRtbAorKysgYi9XZWJLaXRTaXRl L2NvZGluZy9jb21taXQtcmV2aWV3LXBvbGljeS5odG1sCkBAIC0yNCw5ICsyNCw5IEBAIFJldmll d2VycyB3aWxsIGJlIG1haW50YWluZWQgYXQgd2Via2l0Lm9yZy48L3A+CiAKIDxwPkEgY2FuZGlk YXRlIGZvciBXZWJLaXQgQ29tbWl0dGVyIG9yIFdlYktpdCBSZXZpZXdlciBzaG91bGQKIGluaXRp YWxseSBiZSBub21pbmF0ZWQgYnkgYSByZXZpZXdlciBvbiB0aGUgcmV2aWV3ZXJzIG1haWxpbmcg bGlzdCwgaW4KLWFjY29yZGFuY2Ugd2l0aCB0aGUgY3JpdGVyaWEgYmVsb3cuIElmIGF0IGxlYXN0 IHR3byBtb3JlIHJldmlld2VycworYWNjb3JkYW5jZSB3aXRoIHRoZSBjcml0ZXJpYSBiZWxvdy4g SWYgdGhlIHJlcXVpcmVkIHJldmlld2VycyAoc2VlIGJlbG93KQogc2Vjb25kIHRoZSBub21pbmF0 aW9uLCB0aGVuIGl0IGNhcnJpZXMgd2l0aGluIDUgYnVzaW5lc3MgZGF5cyB1bmxlc3MKLXNvbWVv bmUgb2JqZWN0cy4gSWYgYW4gb2JqZWN0aW9uIGlzIHJhaXNlZCwgdGhlIHJldmlld2VycyBzaG91 bGQKK3NvbWVvbmUgb2JqZWN0cy4gIElmIGFuIG9iamVjdGlvbiBpcyByYWlzZWQsIHRoZSByZXZp ZXdlcnMgc2hvdWxkCiBkaXNjdXNzIHRoZSBtYXR0ZXIgYW5kIHRyeSB0byBjb21lIHRvIGNvbnNl bnN1czsgZmFpbGluZyB0aGlzLCB0aGUKIG1hdHRlciB3aWxsIGJlIGRlY2lkZWQgYnkgbWFqb3Jp dHkgdm90ZSBvZiB0aGUgcmV2aWV3ZXJzLjwvcD4KIApAQCAtNzAsNiArNzAsOSBAQCBtYW5hZ2Vy L2VtcGxveWVlIHJlbGF0aW9uc2hpcCwganVzdCB0aGF0IHlvdSB3b3JrIHdpdGggdGhlIHBvdGVu dGlhbAogY29tbWl0dGVyIGNsb3NlbHkgZW5vdWdoIHRvIG1ha2Ugc3VyZSB0aGV5IGZvbGxvdyBw b2xpY3kgYW5kIHdvcmsgd2VsbAogd2l0aCBvdGhlcnMuPC9wPgogCis8cD5BbGwgY29tbWl0dGVy IG5vbWluYXRpb25zIHJlcXVpcmUgdGhlIHN1cHBvcnQgb2YgdGhyZWUgcmV2aWV3ZXJzLgorT25l IHJldmlld2VyIG5vbWluYXRlcywgdHdvIG90aGVycyBzZWNvbmQgdGhlIG5vbWluYXRpb24uPC9w PgorCiA8aDM+Q3JpdGVyaWEgZm9yIFJldmlld2VyczwvaDM+CiAKIDxwPkEgV2ViS2l0IFJldmll d2VyIHNob3VsZCBiZSBhIHBlcnNvbiB3aG8gaGFzIHNob3duIHBhcnRpY3VsYXJseQpAQCAtOTQs NiArOTcsMTEgQEAgdW5vZmZpY2lhbCByZXZpZXdzLjwvcD4KIAogPHA+Rm9yIFJldmlld2VyIHN0 YXR1cywgdGhlcmUgaXMgbm8gc3VwZXJ2aXNpb24gZXhjZXB0aW9uLjwvcD4KIAorPHA+QWxsIHJl dmlld2VyIG5vbWluYXRpb25zIHJlcXVpcmUgdGhlIHN1cHBvcnQgb2YgZm91ciByZXZpZXdlcnMu CitBdCBsZWFzdCBvbmUgb2YgdGhlc2UgcmV2aWV3ZXJzIG11c3Qgbm90IHdvcmsgYXQgdGhlIHNh bWUgY29tcGFueSBvcgorb24gdGhlIHNhbWUgV2ViS2l0IHBvcnQgYXMgdGhlIG5vbWluZWUuICBU aGlzIHJlcXVpcmVtZW50IGVuc3VyZXMKK2RlbW9uc3RyYXRpb24gb2YgY3Jvc3Mtb3JnYW5pemF0 aW9uIGNvbGxhYm9yYXRpb24gc2tpbGxzIG1lbnRpb25lZCBhYm92ZS48L3A+CisKIDxoMz5TdXNw ZW5zaW9uIGFuZCBSZXZvY2F0aW9uIG9mIENvbW1pdHRlciBvciBSZXZpZXdlciBTdGF0dXM8L2gz PgogCiA8cD5XZWJLaXQgQ29tbWl0dGVyIG9yIFdlYktpdCBSZXZpZXdlciBzdGF0dXMgY2FuIGJl IHJldm9rZWQgYnkgMi8zCg== 70620 2010-10-13 09:58:21 -0700 2011-01-13 11:12:56 -0800 Patch bug-47597-20101013095819.patch text/plain 2892 eric ZGlmZiAtLWdpdCBhL1dlYktpdFNpdGUvQ2hhbmdlTG9nIGIvV2ViS2l0U2l0ZS9DaGFuZ2VMb2cK aW5kZXggZjU1YTU4ZjhhYTRkMTYzZTZjMTcwMGM0ZWRhMWU0NmU5NTgxZTE2MS4uMWZmODY0NTBm ODI5NjBkODY0ZDdjNDA0MDMyYTdmOGFmNmU4MzY5NiAxMDA2NDQKLS0tIGEvV2ViS2l0U2l0ZS9D aGFuZ2VMb2cKKysrIGIvV2ViS2l0U2l0ZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAx MC0xMC0xMyAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUHJvcG9zYWw6IFJlcXVpcmUgY3Jvc3Mt b3JnYW5pemF0aW9uYWwgc2Vjb25kcyBmb3IgcmV2aWV3ZXIgbm9taW5hdGlvbnMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3NTk3CisKKyAgICAgICAg VGhpcyBjaGFuZ2VzIHRoZSBjb21taXR0ZXIvcmV2aWV3ZXIgcG9saWN5IHRvIHJlcXVpcmUgYW4g YWRkaXRpb25hbAorICAgICAgICByZXZpZXdlciBzdXBwb3J0aW5nIGEgcmV2aWV3ZXIgbm9taW5h dGlvbiB0byB3b3JrIGZvciBhIGRpZmZlcmVudAorICAgICAgICBjb21wYW55IGFuZCBkaWZmZXJl bnQgV2ViS2l0IHBvcnQgZnJvbSB0aGUgbm9taW5lZS4KKworICAgICAgICBUaGlzIG1lYW5zIHJl dmlld2VyIG5vbWluYXRpb25zIHdvdWxkIHJlcXVpcmUgZm91ciBzdXBwb3J0aW5nIHJldmlld2Vy cywKKyAgICAgICAgb25lIG9mIHdoaWNoIGtub3dzIHRoZSByZXZpZXdlciB0aHJvdWdoIHRoZSBj b21tdW5pdHkgKGlyYywgZW1haWwsIGJ1Z3MpCisgICAgICAgIGVuc3VyaW5nIHRoYXQgdGhlIG5v bWluZWUgaGFzIHRoZSBvcGVuLXNvdXJjZSBjb2xsYWJvcmF0aW9uIHNraWxscworICAgICAgICB3 ZSBzbyBoaWdobHkgdmFsdWUgaGVyZSBpbiBXZWJLaXQuCisKKyAgICAgICAgKiBjb2RpbmcvY29t bWl0LXJldmlldy1wb2xpY3kuaHRtbDoKKwogMjAxMC0xMC0wMSAgQWxleCBNYXRoZXdzICA8cG9z c2Vzc2VkcGVuZ3VpbmJvYkBnbWFpbC5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24g RnJhc2VyLgpkaWZmIC0tZ2l0IGEvV2ViS2l0U2l0ZS9jb2RpbmcvY29tbWl0LXJldmlldy1wb2xp Y3kuaHRtbCBiL1dlYktpdFNpdGUvY29kaW5nL2NvbW1pdC1yZXZpZXctcG9saWN5Lmh0bWwKaW5k ZXggYzc4YjdkYWMyZjkwZGYwZDRhOTEyNTdiMjE2MDA3NDMzZTk0MjVjNi4uNDUwMWI2OGJmZTY0 OGY2ZWI1MDc4NDMxODQ0MDY4YTJhNTE4OWQwNCAxMDA2NDQKLS0tIGEvV2ViS2l0U2l0ZS9jb2Rp bmcvY29tbWl0LXJldmlldy1wb2xpY3kuaHRtbAorKysgYi9XZWJLaXRTaXRlL2NvZGluZy9jb21t aXQtcmV2aWV3LXBvbGljeS5odG1sCkBAIC0yNCw3ICsyNCw3IEBAIFJldmlld2VycyB3aWxsIGJl IG1haW50YWluZWQgYXQgd2Via2l0Lm9yZy48L3A+CiAKIDxwPkEgY2FuZGlkYXRlIGZvciBXZWJL aXQgQ29tbWl0dGVyIG9yIFdlYktpdCBSZXZpZXdlciBzaG91bGQKIGluaXRpYWxseSBiZSBub21p bmF0ZWQgYnkgYSByZXZpZXdlciBvbiB0aGUgcmV2aWV3ZXJzIG1haWxpbmcgbGlzdCwgaW4KLWFj Y29yZGFuY2Ugd2l0aCB0aGUgY3JpdGVyaWEgYmVsb3cuIElmIGF0IGxlYXN0IHR3byBtb3JlIHJl dmlld2VycworYWNjb3JkYW5jZSB3aXRoIHRoZSBjcml0ZXJpYSBiZWxvdy4gSWYgdGhlIHJlcXVp cmVkIHJldmlld2VycyAoc2VlIGJlbG93KQogc2Vjb25kIHRoZSBub21pbmF0aW9uLCB0aGVuIGl0 IGNhcnJpZXMgd2l0aGluIDUgYnVzaW5lc3MgZGF5cyB1bmxlc3MKIHNvbWVvbmUgb2JqZWN0cy4g SWYgYW4gb2JqZWN0aW9uIGlzIHJhaXNlZCwgdGhlIHJldmlld2VycyBzaG91bGQKIGRpc2N1c3Mg dGhlIG1hdHRlciBhbmQgdHJ5IHRvIGNvbWUgdG8gY29uc2Vuc3VzOyBmYWlsaW5nIHRoaXMsIHRo ZQpAQCAtNzAsNiArNzAsOSBAQCBtYW5hZ2VyL2VtcGxveWVlIHJlbGF0aW9uc2hpcCwganVzdCB0 aGF0IHlvdSB3b3JrIHdpdGggdGhlIHBvdGVudGlhbAogY29tbWl0dGVyIGNsb3NlbHkgZW5vdWdo IHRvIG1ha2Ugc3VyZSB0aGV5IGZvbGxvdyBwb2xpY3kgYW5kIHdvcmsgd2VsbAogd2l0aCBvdGhl cnMuPC9wPgogCis8cD5BbGwgY29tbWl0dGVyIG5vbWluYXRpb25zIHJlcXVpcmUgdGhlIHN1cHBv cnQgb2YgdGhyZWUgcmV2aWV3ZXJzLgorT25lIHJldmlld2VyIG5vbWluYXRlcywgdHdvIG90aGVy cyBzZWNvbmQgdGhlIG5vbWluYXRpb24uPC9wPgorCiA8aDM+Q3JpdGVyaWEgZm9yIFJldmlld2Vy czwvaDM+CiAKIDxwPkEgV2ViS2l0IFJldmlld2VyIHNob3VsZCBiZSBhIHBlcnNvbiB3aG8gaGFz IHNob3duIHBhcnRpY3VsYXJseQpAQCAtOTQsNiArOTcsMTEgQEAgdW5vZmZpY2lhbCByZXZpZXdz LjwvcD4KIAogPHA+Rm9yIFJldmlld2VyIHN0YXR1cywgdGhlcmUgaXMgbm8gc3VwZXJ2aXNpb24g ZXhjZXB0aW9uLjwvcD4KIAorPHA+QWxsIHJldmlld2VyIG5vbWluYXRpb25zIHJlcXVpcmUgdGhl IHN1cHBvcnQgb2YgZm91ciByZXZpZXdlcnMuCitBdCBsZWFzdCBvbmUgb2YgdGhlc2UgcmV2aWV3 ZXJzIG11c3Qgbm90IHdvcmsgYXQgdGhlIHNhbWUgY29tcGFueSBvcgorb24gdGhlIHNhbWUgV2Vi S2l0IHBvcnQgYXMgdGhlIG5vbWluZWUuIFRoaXMgcmVxdWlyZW1lbnQgZW5zdXJlcworZGVtb25z dHJhdGlvbiBvZiBjcm9zcy1vcmdhbml6YXRpb24gY29sbGFib3JhdGlvbiBza2lsbHMgbWVudGlv bmVkIGFib3ZlLjwvcD4KKwogPGgzPlN1c3BlbnNpb24gYW5kIFJldm9jYXRpb24gb2YgQ29tbWl0 dGVyIG9yIFJldmlld2VyIFN0YXR1czwvaDM+CiAKIDxwPldlYktpdCBDb21taXR0ZXIgb3IgV2Vi S2l0IFJldmlld2VyIHN0YXR1cyBjYW4gYmUgcmV2b2tlZCBieSAyLzMK 78830 2011-01-13 11:13:00 -0800 2011-01-13 15:25:15 -0800 Patch bug-47597-20110113111259.patch text/plain 3099 levin ZGlmZiAtLWdpdCBhL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvd2Vi a2l0Lm9yZy9DaGFuZ2VMb2cKaW5kZXggMTRmNWExYzFhYmU2NmI1YjM2ZDkzOTc0ZWUzNjU5NDk4 MTlhNmMyZS4uZDY0YjY4NGJkMDNjZTg0MTZhNjU3NGY5MGM5NTEwMTNjYmY3ZjAyMCAxMDA2NDQK LS0tIGEvV2Vic2l0ZXMvd2Via2l0Lm9yZy9DaGFuZ2VMb2cKKysrIGIvV2Vic2l0ZXMvd2Via2l0 Lm9yZy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMS0wMS0xMyAgRGF2aWQgTGV2aW4g IDxsZXZpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgUHJvcG9zYWw6IFJlcXVpcmUgY3Jvc3Mtb3JnYW5pemF0aW9uYWwgc2Vj b25kcyBmb3IgcmV2aWV3ZXIgbm9taW5hdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3NTk3CisKKyAgICAgICAgVGhpcyBjaGFuZ2VzIHRoZSBj b21taXR0ZXIvcmV2aWV3ZXIgcG9saWN5IHRvIHJlcXVpcmUgYW4gYWRkaXRpb25hbAorICAgICAg ICByZXZpZXdlciBzdXBwb3J0aW5nIGEgcmV2aWV3ZXIgbm9taW5hdGlvbiB0byB3b3JrIGZvciBh IGRpZmZlcmVudAorICAgICAgICBjb21wYW55IGFuZCBkaWZmZXJlbnQgcHJvamVjdCBhZmZpbGlh dGlvbiBmcm9tIHRoZSBub21pbmVlLgorCisgICAgICAgIFRoaXMgbWVhbnMgcmV2aWV3ZXIgbm9t aW5hdGlvbnMgd291bGQgcmVxdWlyZSBmb3VyIHN1cHBvcnRpbmcgcmV2aWV3ZXJzLAorICAgICAg ICBvbmUgb2Ygd2hpY2gga25vd3MgdGhlIHJldmlld2VyIHRocm91Z2ggdGhlIGNvbW11bml0eSAo aXJjLCBlbWFpbCwgYnVncykKKyAgICAgICAgZW5zdXJpbmcgdGhhdCB0aGUgbm9taW5lZSBoYXMg dGhlIG9wZW4tc291cmNlIGNvbGxhYm9yYXRpb24gc2tpbGxzCisgICAgICAgIHdlIHNvIGhpZ2hs eSB2YWx1ZSBoZXJlIGluIFdlYktpdC4KKworICAgICAgICAqIGNvZGluZy9jb21taXQtcmV2aWV3 LXBvbGljeS5odG1sOgorCiAyMDExLTAxLTAxICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1naXQgYS9XZWJz aXRlcy93ZWJraXQub3JnL2NvZGluZy9jb21taXQtcmV2aWV3LXBvbGljeS5odG1sIGIvV2Vic2l0 ZXMvd2Via2l0Lm9yZy9jb2RpbmcvY29tbWl0LXJldmlldy1wb2xpY3kuaHRtbAppbmRleCBjNzhi N2RhYzJmOTBkZjBkNGE5MTI1N2IyMTYwMDc0MzNlOTQyNWM2Li5jN2I3NGJmZDU0NDU5MWU5ODUx MTgwY2U2NzY2YzYxMWI5NmM4NTQyIDEwMDY0NAotLS0gYS9XZWJzaXRlcy93ZWJraXQub3JnL2Nv ZGluZy9jb21taXQtcmV2aWV3LXBvbGljeS5odG1sCisrKyBiL1dlYnNpdGVzL3dlYmtpdC5vcmcv Y29kaW5nL2NvbW1pdC1yZXZpZXctcG9saWN5Lmh0bWwKQEAgLTI0LDcgKzI0LDcgQEAgUmV2aWV3 ZXJzIHdpbGwgYmUgbWFpbnRhaW5lZCBhdCB3ZWJraXQub3JnLjwvcD4KIAogPHA+QSBjYW5kaWRh dGUgZm9yIFdlYktpdCBDb21taXR0ZXIgb3IgV2ViS2l0IFJldmlld2VyIHNob3VsZAogaW5pdGlh bGx5IGJlIG5vbWluYXRlZCBieSBhIHJldmlld2VyIG9uIHRoZSByZXZpZXdlcnMgbWFpbGluZyBs aXN0LCBpbgotYWNjb3JkYW5jZSB3aXRoIHRoZSBjcml0ZXJpYSBiZWxvdy4gSWYgYXQgbGVhc3Qg dHdvIG1vcmUgcmV2aWV3ZXJzCithY2NvcmRhbmNlIHdpdGggdGhlIGNyaXRlcmlhIGJlbG93LiBJ ZiB0aGUgcmVxdWlyZWQgcmV2aWV3ZXJzIChzZWUgYmVsb3cpCiBzZWNvbmQgdGhlIG5vbWluYXRp b24sIHRoZW4gaXQgY2FycmllcyB3aXRoaW4gNSBidXNpbmVzcyBkYXlzIHVubGVzcwogc29tZW9u ZSBvYmplY3RzLiBJZiBhbiBvYmplY3Rpb24gaXMgcmFpc2VkLCB0aGUgcmV2aWV3ZXJzIHNob3Vs ZAogZGlzY3VzcyB0aGUgbWF0dGVyIGFuZCB0cnkgdG8gY29tZSB0byBjb25zZW5zdXM7IGZhaWxp bmcgdGhpcywgdGhlCkBAIC03MCw2ICs3MCw5IEBAIG1hbmFnZXIvZW1wbG95ZWUgcmVsYXRpb25z aGlwLCBqdXN0IHRoYXQgeW91IHdvcmsgd2l0aCB0aGUgcG90ZW50aWFsCiBjb21taXR0ZXIgY2xv c2VseSBlbm91Z2ggdG8gbWFrZSBzdXJlIHRoZXkgZm9sbG93IHBvbGljeSBhbmQgd29yayB3ZWxs CiB3aXRoIG90aGVycy48L3A+CiAKKzxwPkFsbCBjb21taXR0ZXIgbm9taW5hdGlvbnMgcmVxdWly ZSB0aGUgc3VwcG9ydCBvZiB0aHJlZSByZXZpZXdlcnMuCitPbmUgcmV2aWV3ZXIgbm9taW5hdGVz LCB0d28gb3RoZXJzIHNlY29uZCB0aGUgbm9taW5hdGlvbi48L3A+CisKIDxoMz5Dcml0ZXJpYSBm b3IgUmV2aWV3ZXJzPC9oMz4KIAogPHA+QSBXZWJLaXQgUmV2aWV3ZXIgc2hvdWxkIGJlIGEgcGVy c29uIHdobyBoYXMgc2hvd24gcGFydGljdWxhcmx5CkBAIC05NCw2ICs5NywxMyBAQCB1bm9mZmlj aWFsIHJldmlld3MuPC9wPgogCiA8cD5Gb3IgUmV2aWV3ZXIgc3RhdHVzLCB0aGVyZSBpcyBubyBz dXBlcnZpc2lvbiBleGNlcHRpb24uPC9wPgogCis8cD5BbGwgcmV2aWV3ZXIgbm9taW5hdGlvbnMg cmVxdWlyZSB0aGUgc3VwcG9ydCBvZiBmb3VyIHJldmlld2Vycy4gT25lIHJldmlld2VyCitub21p bmF0ZXMsIHRocmVlIHJldmlld2VycyBzZWNvbmQuIFJldmlld2VycyBzaG91bGQgYmUga25vd24g aW4gdGhlIFdlYktpdAorY29tbXVuaXR5IGFzIGEgd2hvbGUsIGFuZCBub3QganVzdCB3aXRoaW4g dGhlaXIgb3duIHBsYWNlIG9mIGVtcGxveW1lbnQgb3IKK2p1c3Qgd2l0aGluIGEgc3BlY2lmaWMg b3JnYW5pemVkIHByb2plY3QgKG90aGVyIHRoYW4gV2ViS2l0IGl0c2VsZikuCitUaGVyZWZvcmUs IGF0IGxlYXN0IG9uZSBzdXBwb3J0aW5nIHJldmlld2VyIG11c3Qgbm90IHNoYXJlIGFueSBjb21w YW55IG9yCitwcm9qZWN0IGFmZmlsaWF0aW9ucyB3aXRoIHRoZSBub21pbmVlLjwvcD4KKwogPGgz PlN1c3BlbnNpb24gYW5kIFJldm9jYXRpb24gb2YgQ29tbWl0dGVyIG9yIFJldmlld2VyIFN0YXR1 czwvaDM+CiAKIDxwPldlYktpdCBDb21taXR0ZXIgb3IgV2ViS2l0IFJldmlld2VyIHN0YXR1cyBj YW4gYmUgcmV2b2tlZCBieSAyLzMK 78863 2011-01-13 15:25:24 -0800 2011-01-21 11:00:19 -0800 Patch bug-47597-20110113152522.patch text/plain 3112 levin ZGlmZiAtLWdpdCBhL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvd2Vi a2l0Lm9yZy9DaGFuZ2VMb2cKaW5kZXggMTRmNWExYzFhYmU2NmI1YjM2ZDkzOTc0ZWUzNjU5NDk4 MTlhNmMyZS4uZDY0YjY4NGJkMDNjZTg0MTZhNjU3NGY5MGM5NTEwMTNjYmY3ZjAyMCAxMDA2NDQK LS0tIGEvV2Vic2l0ZXMvd2Via2l0Lm9yZy9DaGFuZ2VMb2cKKysrIGIvV2Vic2l0ZXMvd2Via2l0 Lm9yZy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMS0wMS0xMyAgRGF2aWQgTGV2aW4g IDxsZXZpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgUHJvcG9zYWw6IFJlcXVpcmUgY3Jvc3Mtb3JnYW5pemF0aW9uYWwgc2Vj b25kcyBmb3IgcmV2aWV3ZXIgbm9taW5hdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3NTk3CisKKyAgICAgICAgVGhpcyBjaGFuZ2VzIHRoZSBj b21taXR0ZXIvcmV2aWV3ZXIgcG9saWN5IHRvIHJlcXVpcmUgYW4gYWRkaXRpb25hbAorICAgICAg ICByZXZpZXdlciBzdXBwb3J0aW5nIGEgcmV2aWV3ZXIgbm9taW5hdGlvbiB0byB3b3JrIGZvciBh IGRpZmZlcmVudAorICAgICAgICBjb21wYW55IGFuZCBkaWZmZXJlbnQgcHJvamVjdCBhZmZpbGlh dGlvbiBmcm9tIHRoZSBub21pbmVlLgorCisgICAgICAgIFRoaXMgbWVhbnMgcmV2aWV3ZXIgbm9t aW5hdGlvbnMgd291bGQgcmVxdWlyZSBmb3VyIHN1cHBvcnRpbmcgcmV2aWV3ZXJzLAorICAgICAg ICBvbmUgb2Ygd2hpY2gga25vd3MgdGhlIHJldmlld2VyIHRocm91Z2ggdGhlIGNvbW11bml0eSAo aXJjLCBlbWFpbCwgYnVncykKKyAgICAgICAgZW5zdXJpbmcgdGhhdCB0aGUgbm9taW5lZSBoYXMg dGhlIG9wZW4tc291cmNlIGNvbGxhYm9yYXRpb24gc2tpbGxzCisgICAgICAgIHdlIHNvIGhpZ2hs eSB2YWx1ZSBoZXJlIGluIFdlYktpdC4KKworICAgICAgICAqIGNvZGluZy9jb21taXQtcmV2aWV3 LXBvbGljeS5odG1sOgorCiAyMDExLTAxLTAxICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1naXQgYS9XZWJz aXRlcy93ZWJraXQub3JnL2NvZGluZy9jb21taXQtcmV2aWV3LXBvbGljeS5odG1sIGIvV2Vic2l0 ZXMvd2Via2l0Lm9yZy9jb2RpbmcvY29tbWl0LXJldmlldy1wb2xpY3kuaHRtbAppbmRleCBjNzhi N2RhYzJmOTBkZjBkNGE5MTI1N2IyMTYwMDc0MzNlOTQyNWM2Li5lOGFkYzRmMGFlYTNhYjY2MTQx Mjc1MDAwMzUzZjQ2NmRiMWFmNTU3IDEwMDY0NAotLS0gYS9XZWJzaXRlcy93ZWJraXQub3JnL2Nv ZGluZy9jb21taXQtcmV2aWV3LXBvbGljeS5odG1sCisrKyBiL1dlYnNpdGVzL3dlYmtpdC5vcmcv Y29kaW5nL2NvbW1pdC1yZXZpZXctcG9saWN5Lmh0bWwKQEAgLTI0LDcgKzI0LDcgQEAgUmV2aWV3 ZXJzIHdpbGwgYmUgbWFpbnRhaW5lZCBhdCB3ZWJraXQub3JnLjwvcD4KIAogPHA+QSBjYW5kaWRh dGUgZm9yIFdlYktpdCBDb21taXR0ZXIgb3IgV2ViS2l0IFJldmlld2VyIHNob3VsZAogaW5pdGlh bGx5IGJlIG5vbWluYXRlZCBieSBhIHJldmlld2VyIG9uIHRoZSByZXZpZXdlcnMgbWFpbGluZyBs aXN0LCBpbgotYWNjb3JkYW5jZSB3aXRoIHRoZSBjcml0ZXJpYSBiZWxvdy4gSWYgYXQgbGVhc3Qg dHdvIG1vcmUgcmV2aWV3ZXJzCithY2NvcmRhbmNlIHdpdGggdGhlIGNyaXRlcmlhIGJlbG93LiBJ ZiB0aGUgcmVxdWlyZWQgcmV2aWV3ZXJzIChzZWUgYmVsb3cpCiBzZWNvbmQgdGhlIG5vbWluYXRp b24sIHRoZW4gaXQgY2FycmllcyB3aXRoaW4gNSBidXNpbmVzcyBkYXlzIHVubGVzcwogc29tZW9u ZSBvYmplY3RzLiBJZiBhbiBvYmplY3Rpb24gaXMgcmFpc2VkLCB0aGUgcmV2aWV3ZXJzIHNob3Vs ZAogZGlzY3VzcyB0aGUgbWF0dGVyIGFuZCB0cnkgdG8gY29tZSB0byBjb25zZW5zdXM7IGZhaWxp bmcgdGhpcywgdGhlCkBAIC03MCw2ICs3MCw5IEBAIG1hbmFnZXIvZW1wbG95ZWUgcmVsYXRpb25z aGlwLCBqdXN0IHRoYXQgeW91IHdvcmsgd2l0aCB0aGUgcG90ZW50aWFsCiBjb21taXR0ZXIgY2xv c2VseSBlbm91Z2ggdG8gbWFrZSBzdXJlIHRoZXkgZm9sbG93IHBvbGljeSBhbmQgd29yayB3ZWxs CiB3aXRoIG90aGVycy48L3A+CiAKKzxwPkFsbCBjb21taXR0ZXIgbm9taW5hdGlvbnMgcmVxdWly ZSB0aGUgc3VwcG9ydCBvZiB0aHJlZSByZXZpZXdlcnMuCitPbmUgcmV2aWV3ZXIgbm9taW5hdGVz LCB0d28gb3RoZXJzIHNlY29uZCB0aGUgbm9taW5hdGlvbi48L3A+CisKIDxoMz5Dcml0ZXJpYSBm b3IgUmV2aWV3ZXJzPC9oMz4KIAogPHA+QSBXZWJLaXQgUmV2aWV3ZXIgc2hvdWxkIGJlIGEgcGVy c29uIHdobyBoYXMgc2hvd24gcGFydGljdWxhcmx5CkBAIC05NCw2ICs5NywxMyBAQCB1bm9mZmlj aWFsIHJldmlld3MuPC9wPgogCiA8cD5Gb3IgUmV2aWV3ZXIgc3RhdHVzLCB0aGVyZSBpcyBubyBz dXBlcnZpc2lvbiBleGNlcHRpb24uPC9wPgogCis8cD5BbGwgcmV2aWV3ZXIgbm9taW5hdGlvbnMg cmVxdWlyZSB0aGUgc3VwcG9ydCBvZiBmb3VyIHJldmlld2Vycy4gT25lIHJldmlld2VyCitub21p bmF0ZXMsIHRocmVlIHJldmlld2VycyBzZWNvbmQuIFJldmlld2VycyBzaG91bGQgYmUga25vd24g aW4gdGhlIFdlYktpdAorY29tbXVuaXR5IGFzIGEgd2hvbGUsIGFuZCBub3QganVzdCB3aXRoaW4g dGhlaXIgb3duIHBsYWNlIG9mIGVtcGxveW1lbnQgb3IKK2p1c3Qgd2l0aGluIGEgc3BlY2lmaWMg b3JnYW5pemVkIHByb2plY3QuIFRoZXJlZm9yZSwgYXQgbGVhc3Qgb25lIG9mIHRoZQorZm91ciBz dXBwb3J0aW5nIHJldmlld2VycyBtdXN0IG5vdCBzaGFyZSBhbnkgY29tcGFueSBvciBwcm9qZWN0 IGFmZmlsaWF0aW9ucword2l0aCB0aGUgbm9taW5lZSAob3RoZXIgdGhhbiBXZWJLaXQgaXRzZWxm KS48L3A+CisKIDxoMz5TdXNwZW5zaW9uIGFuZCBSZXZvY2F0aW9uIG9mIENvbW1pdHRlciBvciBS ZXZpZXdlciBTdGF0dXM8L2gzPgogCiA8cD5XZWJLaXQgQ29tbWl0dGVyIG9yIFdlYktpdCBSZXZp ZXdlciBzdGF0dXMgY2FuIGJlIHJldm9rZWQgYnkgMi8zCg==