4759 2005-08-30 11:59:19 -0700 'ex' length unit calculation (Some layout tests fail if the system primary language is Russian) 2006-01-09 02:11:58 -0800 1 1 1 Unclassified WebKit Layout and Rendering 420+ Mac OS X 10.4 RESOLVED FIXED HasReduction P3 Normal --- 1 ap ap mitz oldest_to_newest 17941 0 ap 2005-08-30 11:59:19 -0700 Steps to reproduce: 1. Set the system primary lnguage to Russian (in International control panel); re-login 2. Run layout tests Results: five of them fail: css1/font_properties/font_size css1/text_properties/line_height css1/text_properties/text_indent css1/units/length_units fast/lists/008 Discussion: all these tests use lengths specified in ex units. Apparently, these are calculated incorrectly in some cases. I have traced this up to CSSPrimitiveValueImpl::computeLengthFloat(), which gives different results for different primary languages. For example, length_units.html uses ex values for two font sizes, with factor values of 7.66406 and 19.1602 (primary English). However, with primary Russian these become 7 and 18. 17947 1 ap 2005-08-30 13:10:48 -0700 Apparently, it's [font glyphWithName:@"x"] that fails (in [WebTextRenderer xHeight]) for primary Russian. Many thanks to Mitz Pettel for guiding to this result! 17994 2 ap 2005-08-30 22:23:29 -0700 Interestingly, the following reduced test fails for English primary language, too (also, see the thread at <http://www.cocoabuilder.com/archive/message/cocoa/2005/6/1/137649>). There's something in WebKit that makes fontWithName work, at least for some languages... int main (int argc, const char * argv[]) { NSAutoreleasePool * pool = [[NSAutoreleasePool alloc] init]; NSFont *font = [NSFont fontWithName:@"Times-Roman" size:12]; NSLog(@"Font: %@", [font description]); NSGlyph xGlyph = [font glyphWithName:@"x"]; NSLog(@"x glyph: %d", xGlyph); [pool release]; return 0; } 26950 3 eric 2005-12-28 01:17:49 -0800 I would encourage alexey or mitz to take a stab at a patch here, as most of us don't live on a non-english system day-to-day. Wonderful reduction, btw. It would be even better if we could create a layout test to show this (that would not require any specific system language setting). 27003 4 ap 2005-12-28 04:19:35 -0800 I approached this several times, but couldn't find a solution. Other ways of measuring width or advancement give different results, and I don't see any other way to find a glyph (other than the failing glyphWithName). I'm not a Cocoa expert, though. Judging from comments and cvs log, this is a pretty sensitive area, so the results for Roman systems should probably be preserved exactly. 27986 5 5544 ap 2006-01-08 07:38:26 -0800 Created attachment 5544 proposed patch Fallback to glyphForCharacter() if -[NSFont glyphWithName] has failed. (Sorry for a not quite canonical form of the patch, the repository is inaccessible at the moment) 28036 6 5544 mjs 2006-01-09 01:57:58 -0800 Comment on attachment 5544 proposed patch you could coneider using only the new way to get the x glyph, if it works for all languages. 28037 7 ap 2006-01-09 02:11:58 -0800 Landed with glyphForCharacter() being used always, not just as a fallback (discussed with Maciej on IRC). 5544 2006-01-08 07:38:26 -0800 2006-01-09 01:57:58 -0800 proposed patch 4759.txt text/plain 1216 ap LS0tIFdlYlRleHRSZW5kZXJlci5tCTIwMDYtMDEtMDggMTg6Mjg6MTIuMDAwMDAwMDAwICswMzAw CisrKyBXZWJUZXh0UmVuZGVyZXItbmV3Lm0JMjAwNi0wMS0wOCAxODozMTozOC4wMDAwMDAwMDAg KzAzMDAKQEAgLTEyOCw2ICsxMjgsNyBAQAogCiBzdGF0aWMgdm9pZCBmcmVlV2lkdGhNYXAoV2lk dGhNYXAgKik7CiBzdGF0aWMgdm9pZCBmcmVlR2x5cGhNYXAoR2x5cGhNYXAgKik7CitzdGF0aWMg aW5saW5lIEFUU0dseXBoUmVmIGdseXBoRm9yQ2hhcmFjdGVyKFdlYlRleHRSZW5kZXJlciAqKiwg VUNoYXIzMik7CiAKIC8vIE1lYXN1cmluZyBydW5zLgogc3RhdGljIGZsb2F0IENHX2Zsb2F0V2lk dGhGb3JSdW4oV2ViVGV4dFJlbmRlcmVyICosIGNvbnN0IFdlYkNvcmVUZXh0UnVuICosIGNvbnN0 IFdlYkNvcmVUZXh0U3R5bGUgKiwKQEAgLTQ4OCw2ICs0ODksMTMgQEAKICAgICAvLyBNZWFzdXJl IHRoZSBhY3R1YWwgY2hhcmFjdGVyICJ4IiwgYmVjYXVzZSBBcHBLaXQgc3ludGhlc2l6ZXMgWCBo ZWlnaHQgcmF0aGVyIHRoYW4gZ2V0dGluZyBpdCBmcm9tIHRoZSBmb250LgogICAgIC8vIFVuZm9y dHVuYXRlbHksIE5TRm9udCB3aWxsIHJvdW5kIHRoaXMgZm9yIHVzIHNvIHdlIGRvbid0IHF1aXRl IGdldCB0aGUgcmlnaHQgdmFsdWUuCiAgICAgTlNHbHlwaCB4R2x5cGggPSBbZm9udC5mb250IGds eXBoV2l0aE5hbWU6QCJ4Il07CisgICAgaWYgKCF4R2x5cGgpIHsKKyAgICAgICAgLy8gVGVtcG9y YXJ5IHdvcmthcm91bmQgZm9yIGh0dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NDc1OQorICAgICAgICAvLyAoZ2x5cGhXaXRoTmFtZSBmYWlscyBmb3IgUnVzc2lh biBwcmltYXJ5IHN5c3RlbSBsYW5ndWFnZSkuCisgICAgICAgIFdlYlRleHRSZW5kZXJlciAqcmVu ZGVyZXIgPSBbW1dlYlRleHRSZW5kZXJlckZhY3Rvcnkgc2hhcmVkRmFjdG9yeV0gcmVuZGVyZXJX aXRoRm9udDpmb250XTsKKyAgICAgICAgeEdseXBoID0gZ2x5cGhGb3JDaGFyYWN0ZXIoJnJlbmRl cmVyLCAneCcpOworICAgIH0KKyAgICAKICAgICBpZiAoeEdseXBoKSB7CiAgICAgICAgIE5TUmVj dCB4Qm94ID0gW2ZvbnQuZm9udCBib3VuZGluZ1JlY3RGb3JHbHlwaDp4R2x5cGhdOwogICAgICAg ICAvLyBVc2UgdGhlIG1heGltdW0gb2YgZWl0aGVyIHdpZHRoIG9yIGhlaWdodCBiZWNhdXNlICJ4 IiBpcyBuZWFybHkgc3F1YXJlCg==