47571 2010-10-12 22:01:35 -0700 [Qt] AC rendering bugs 2010-10-21 13:34:37 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC Linux RESOLVED FIXED Qt, QtTriaged P2 Normal --- 35524 1 girish webkit-unassigned abarth ademar christian.webkit commit-queue eric hausmann noam webkit.review.bot oldest_to_newest 293270 0 girish 2010-10-12 22:01:35 -0700 Bugs in Qt's AC implementation 1. When Scrolling the view, the items don't move correctly. This is reproducible using http://webkit.org/blog-files/pulse.html. Just make the view small enough and scroll vertically. The div gets clipped. 2. For AC/plugins (see 35524), the plugin layer moves incorrectly when scrolling. 3. When clicking on the plugin, the plugin moves/increases in size. 295483 1 71030 noam 2010-10-18 07:00:51 -0700 Created attachment 71030 Patch for the scroll issue 295485 2 71031 noam 2010-10-18 07:09:03 -0700 Created attachment 71031 Patch: second rendering bug (clicking a plugin) 295494 3 71030 kling 2010-10-18 07:51:28 -0700 Comment on attachment 71030 Patch for the scroll issue LGTM. 295503 4 71031 kling 2010-10-18 08:15:17 -0700 Comment on attachment 71031 Patch: second rendering bug (clicking a plugin) View in context: https://bugs.webkit.org/attachment.cgi?id=71031&action=review LGTM. > WebCore/platform/graphics/qt/GraphicsLayerQt.cpp:864 > + return; Nit: "break;" would fit better in this context. 295513 5 girish 2010-10-18 08:20:12 -0700 The scroll patch breaks youtube for me (scrolls fine but nothing renders). Patches rebased over r69947 295519 6 girish 2010-10-18 08:28:54 -0700 Scrolling works after applying both patches. Can we commit them as a single patch (or split them correctly?) 295536 7 girish 2010-10-18 09:10:59 -0700 Err, sorry for the confusion. I had some patches before noam's patches. All good, commit in any order. 295567 8 71030 commit-queue 2010-10-18 09:48:50 -0700 Comment on attachment 71030 Patch for the scroll issue Clearing flags on attachment: 71030 Committed r69966: <http://trac.webkit.org/changeset/69966> 295598 9 71031 commit-queue 2010-10-18 10:28:08 -0700 Comment on attachment 71031 Patch: second rendering bug (clicking a plugin) Clearing flags on attachment: 71031 Committed r69971: <http://trac.webkit.org/changeset/69971> 295599 10 commit-queue 2010-10-18 10:28:15 -0700 All reviewed patches have been landed. Closing bug. 295624 11 webkit.review.bot 2010-10-18 11:06:35 -0700 http://trac.webkit.org/changeset/69971 might have broken Qt Windows 32-bit Release 297608 12 ademar 2010-10-21 13:34:37 -0700 Removing bug 39121 (qtwebkit-2.1 release critical meta bug) from the list of blockers because this change won't be integrated into qtwebkit-2.1 without the other changes related to bug 35524, which already blocks bug 39121 71030 2010-10-18 07:00:51 -0700 2010-10-18 09:48:50 -0700 Patch for the scroll issue patch-47571-1.diff text/plain 3283 noam ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmlu ZGV4IGM0N2UyMmEuLmRhYTZhNjAgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysr IGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEwLTEwLTE4ICBObydh bSBSb3NlbnRoYWwgIDxub2FtLnJvc2VudGhhbEBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBBQyByZW5kZXJpbmcgYnVncwor CisgICAgICAgIFRoaXMgZml4ZXMgYSByZWdyZXNzaW9uIHRoYXQgd2FzIGludHJvZHVjZWQgYnkg bWFraW5nIHNjcm9sbGluZyBpbiBhY2NlbGVyYXRlZCBjb21wb3NpdGluZyBhdXRvbWF0aWMsCisg ICAgICAgIHdoaWNoIG1hZGUgb3VyIGV4cGxpY2l0IGZ1bmN0aW9uIHRvIHNjcm9sbCB0aGUgY29t cG9zaXRpbmcgbGF5ZXJzIHN1cGVyZmx1b3VzLCBtYWtpbmcgdGhlIHNjcm9sbGluZyBiZWhhdmlv cgorICAgICAgICB3aGVuIGdyYXBoaWNzIGxheWVycyBhcmUgcHJlc2VudCBpbmNvcnJlY3QuIFRo ZSBmaXggc2ltcGx5IHJlbW92ZXMgdGhvc2UgcmVkdW5kYW50IGZ1bmN0aW9ucy4KKworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDc1NzEKKworICAgICAg ICAqIFdlYkNvcmVTdXBwb3J0L1BhZ2VDbGllbnRRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQ YWdlQ2xpZW50UUdyYXBoaWNzV2lkZ2V0OjpzY3JvbGwpOgorICAgICAgICAoV2ViQ29yZTo6UGFn ZUNsaWVudFFHcmFwaGljc1dpZGdldDo6dXBkYXRlKToKKyAgICAgICAgKFdlYkNvcmU6OlBhZ2VD bGllbnRRR3JhcGhpY3NXaWRnZXQ6OnNldFJvb3RHcmFwaGljc0xheWVyKToKKyAgICAgICAgKiBX ZWJDb3JlU3VwcG9ydC9QYWdlQ2xpZW50UXQuaDoKKwogMjAxMC0xMC0xNSAgUWkgWmhhbmcgIDxx aS4yLnpoYW5nQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbmRyZWFzIEtsaW5n LgpkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L1BhZ2VDbGllbnRRdC5jcHAg Yi9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvUGFnZUNsaWVudFF0LmNwcAppbmRleCA5ZjExNDk2 Li45YWEwMWEyIDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvUGFnZUNsaWVu dFF0LmNwcAorKysgYi9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvUGFnZUNsaWVudFF0LmNwcApA QCAtMTE4LDEwICsxMTgsNiBAQCBQYWdlQ2xpZW50UUdyYXBoaWNzV2lkZ2V0Ojp+UGFnZUNsaWVu dFFHcmFwaGljc1dpZGdldCgpCiB2b2lkIFBhZ2VDbGllbnRRR3JhcGhpY3NXaWRnZXQ6OnNjcm9s bChpbnQgZHgsIGludCBkeSwgY29uc3QgUVJlY3QmIHJlY3RUb1Njcm9sbCkKIHsKICAgICB2aWV3 LT5zY3JvbGwocXJlYWwoZHgpLCBxcmVhbChkeSksIHJlY3RUb1Njcm9sbCk7Ci0KLSNpZiBVU0Uo QUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCi0gICAgdXBkYXRlQ29tcG9zaXRpbmdTY3JvbGxQb3Np dGlvbigpOwotI2VuZGlmCiB9CiAKIHZvaWQgUGFnZUNsaWVudFFHcmFwaGljc1dpZGdldDo6dXBk YXRlKGNvbnN0IFFSZWN0JiBkaXJ0eVJlY3QpCkBAIC0xMzMsOCArMTI5LDYgQEAgdm9pZCBQYWdl Q2xpZW50UUdyYXBoaWNzV2lkZ2V0Ojp1cGRhdGUoY29uc3QgUVJlY3QmIGRpcnR5UmVjdCkKICAg ICAgICAgb3ZlcmxheS0+dXBkYXRlKFFSZWN0RihkaXJ0eVJlY3QpKTsKICNpZiBVU0UoQUNDRUxF UkFURURfQ09NUE9TSVRJTkcpCiAgICAgc3luY0xheWVycygpOwotICAgIC8vIFRoaXMgbWlnaHQg YmUgYSBzbG93LXNjcm9sbC4gV2UgZW5zdXJlIHRoYXQgdGhlIGNvbXBvc2l0aW5nIGxheWVycyBh cmUgaW4gdGhlIHJpZ2h0IHBvc2l0aW9uLgotICAgIHVwZGF0ZUNvbXBvc2l0aW5nU2Nyb2xsUG9z aXRpb24oKTsKICNlbmRpZgogfQogCkBAIC0xODUsNyArMTc5LDYgQEAgdm9pZCBQYWdlQ2xpZW50 UUdyYXBoaWNzV2lkZ2V0OjpzZXRSb290R3JhcGhpY3NMYXllcihRR3JhcGhpY3NJdGVtKiBsYXll cikKICAgICAgICAgbGF5ZXItPnNldEZsYWcoUUdyYXBoaWNzSXRlbTo6SXRlbUNsaXBzQ2hpbGRy ZW5Ub1NoYXBlLCB0cnVlKTsKICAgICAgICAgbGF5ZXItPnNldFBhcmVudEl0ZW0odmlldyk7CiAg ICAgICAgIGxheWVyLT5zZXRaVmFsdWUoUm9vdEdyYXBoaWNzTGF5ZXJaVmFsdWUpOwotICAgICAg ICB1cGRhdGVDb21wb3NpdGluZ1Njcm9sbFBvc2l0aW9uKCk7CiAgICAgfQogICAgIGNyZWF0ZU9y RGVsZXRlT3ZlcmxheSgpOwogfQpAQCAtMTk3LDEzICsxOTAsNiBAQCB2b2lkIFBhZ2VDbGllbnRR R3JhcGhpY3NXaWRnZXQ6Om1hcmtGb3JTeW5jKGJvb2wgc2NoZWR1bGVTeW5jKQogICAgICAgICBz eW5jTWV0YU1ldGhvZC5pbnZva2UodmlldywgUXQ6OlF1ZXVlZENvbm5lY3Rpb24pOwogfQogCi12 b2lkIFBhZ2VDbGllbnRRR3JhcGhpY3NXaWRnZXQ6OnVwZGF0ZUNvbXBvc2l0aW5nU2Nyb2xsUG9z aXRpb24oKQotewotICAgIGlmIChyb290R3JhcGhpY3NMYXllciAmJiBwYWdlICYmIHBhZ2UtPm1h aW5GcmFtZSgpKSB7Ci0gICAgICAgIGNvbnN0IFFQb2ludCBzY3JvbGxQb3NpdGlvbiA9IHBhZ2Ut Pm1haW5GcmFtZSgpLT5zY3JvbGxQb3NpdGlvbigpOwotICAgICAgICByb290R3JhcGhpY3NMYXll ci5kYXRhKCktPnNldFBvcygtc2Nyb2xsUG9zaXRpb24pOwotICAgIH0KLX0KICNlbmRpZgogCiAj aWYgRU5BQkxFKFRJTEVEX0JBQ0tJTkdfU1RPUkUpCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvV2Vi Q29yZVN1cHBvcnQvUGFnZUNsaWVudFF0LmggYi9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvUGFn ZUNsaWVudFF0LmgKaW5kZXggM2MzMmVjMS4uNzAxNGZkMiAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0 L1dlYkNvcmVTdXBwb3J0L1BhZ2VDbGllbnRRdC5oCisrKyBiL1dlYktpdC9xdC9XZWJDb3JlU3Vw cG9ydC9QYWdlQ2xpZW50UXQuaApAQCAtMTcwLDcgKzE3MCw2IEBAIHB1YmxpYzoKICNpZiBVU0Uo QUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCiAgICAgdmlydHVhbCB2b2lkIHNldFJvb3RHcmFwaGlj c0xheWVyKFFHcmFwaGljc0l0ZW0qIGxheWVyKTsKICAgICB2aXJ0dWFsIHZvaWQgbWFya0ZvclN5 bmMoYm9vbCBzY2hlZHVsZVN5bmMpOwotICAgIHZvaWQgdXBkYXRlQ29tcG9zaXRpbmdTY3JvbGxQ b3NpdGlvbigpOwogICAgIHZvaWQgc3luY0xheWVycygpOwogCiAgICAgLy8gUUdyYXBoaWNzV2Vi VmlldyBjYW4gcmVuZGVyIGNvbXBvc2l0ZWQgbGF5ZXJzCg== 71031 2010-10-18 07:09:03 -0700 2010-10-18 10:28:08 -0700 Patch: second rendering bug (clicking a plugin) patch-47571-2.diff text/plain 4830 noam ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MzRiZDM4NS4uY2UxM2UwNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0xMC0xOCAgTm8nYW0gUm9zZW50 aGFsICA8bm9hbS5yb3NlbnRoYWxAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gQUMgcmVuZGVyaW5nIGJ1Z3MKKyAgICAgICAg VGhlcmUgd2VyZSBhIGZldyBtaXNzaW5nIGNvbm5lY3Rpb25zIGluIFF0IEFDIGJldHdlZW4gR3Jh cGhpY3NMYXllciBhbmQgcGx1Z2lucywgbGlrZSBjaGFuZ2luZyB0aGUgcGx1Z2luJ3MgZ2VvbWV0 cnkgdG8gdGhlIGxheWVyJ3MKKyAgICAgICAgY29udGVudHNSZWN0LCBhbmQgbWFraW5nIHN1cmUg bWVkaWEgbGF5ZXJzIGhhbmRsZSBQYXJlbnRDaGFuZ2UgZXZlbnRzIGFuZCBzZXRDb250ZW50c05l ZWRzRGlzcGxheS4gTm93IG1lZGlhIGxheWVycyBiZWhhdmUgY29ycmVjdGx5LgorCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NzU3MQorCisgICAgICAg IE5vIG5ldyB0ZXN0cy4gVGhpcyBpcyBpbiBwcmVwYXJhdGlvbiBmb3IgZml4aW5nIEFDK3BsdWdp bnMsIHdoaWNoIGFscmVhZHkgaGFzIHRlc3RzIHRoYXQgZG9uJ3Qgd29yayB5ZXQgd2l0aCBRdC4K KworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzTGF5ZXJRdC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0xheWVyUXRJbXBsOjpmbHVzaENoYW5nZXMpOgorICAg ICAgICAoV2ViQ29yZTo6R3JhcGhpY3NMYXllclF0OjpzZXRDb250ZW50c05lZWRzRGlzcGxheSk6 CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NMYXllclF0Lmg6CisKIDIw MTAtMTAtMTggIElseWEgVGlraG9ub3Zza3kgIDxsb2lzbG9AY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IFl1cnkgU2VtaWtoYXRza3kuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzTGF5ZXJRdC5jcHAgYi9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL3F0L0dyYXBoaWNzTGF5ZXJRdC5jcHAKaW5kZXggOGZjNjUxOS4uZTA5NDFmNSAx MDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0xheWVyUXQu Y3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NMYXllclF0LmNw cApAQCAtMzcsNiArMzcsNyBAQAogI2luY2x1ZGUgPFF0R3VpL3FncmFwaGljc2VmZmVjdC5oPgog I2luY2x1ZGUgPFF0R3VpL3FncmFwaGljc2l0ZW0uaD4KICNpbmNsdWRlIDxRdEd1aS9xZ3JhcGhp Y3NzY2VuZS5oPgorI2luY2x1ZGUgPFF0R3VpL3FncmFwaGljc3dpZGdldC5oPgogI2luY2x1ZGUg PFF0R3VpL3FwYWludGVyLmg+CiAjaW5jbHVkZSA8UXRHdWkvcXBpeG1hcC5oPgogI2luY2x1ZGUg PFF0R3VpL3FwaXhtYXBjYWNoZS5oPgpAQCAtNjEwLDEzICs2MTEsMTMgQEAgdm9pZCBHcmFwaGlj c0xheWVyUXRJbXBsOjpmbHVzaENoYW5nZXMoYm9vbCByZWN1cnNpdmUsIGJvb2wgZm9yY2VVcGRh dGVUcmFuc2Zvcm0KICAgICBpZiAoIW1fbGF5ZXIgfHwgbV9jaGFuZ2VNYXNrID09IE5vQ2hhbmdl cykKICAgICAgICAgZ290byBhZnRlckxheWVyQ2hhbmdlczsKIAotICAgIGlmIChtX2N1cnJlbnRD b250ZW50LmNvbnRlbnRUeXBlID09IEhUTUxDb250ZW50VHlwZSAmJiAobV9jaGFuZ2VNYXNrICYg UGFyZW50Q2hhbmdlKSkgeworICAgIGlmIChtX2NoYW5nZU1hc2sgJiBQYXJlbnRDaGFuZ2UpIHsK ICAgICAgICAgLy8gVGhlIFdlYkNvcmUgY29tcG9zaXRvciBtYW5hZ2VzIGl0ZW0gb3duZXJzaGlw LiBXZSBoYXZlIHRvIG1ha2Ugc3VyZSBncmFwaGljc3ZpZXcgZG9lc24ndAogICAgICAgICAvLyB0 cnkgdG8gc25hdGNoIHRoYXQgb3duZXJzaGlwLgogICAgICAgICBpZiAoIW1fbGF5ZXItPnBhcmVu dCgpICYmICFwYXJlbnRJdGVtKCkpCiAgICAgICAgICAgICBzZXRQYXJlbnRJdGVtKDApOwogICAg ICAgICBlbHNlIGlmIChtX2xheWVyICYmIG1fbGF5ZXItPnBhcmVudCgpICYmIG1fbGF5ZXItPnBh cmVudCgpLT5uYXRpdmVMYXllcigpICE9IHBhcmVudEl0ZW0oKSkKLSAgICAgICAgICAgIHNldFBh cmVudEl0ZW0obV9sYXllci0+cGFyZW50KCktPm5hdGl2ZUxheWVyKCkpOworICAgICAgICAgICAg c2V0UGFyZW50SXRlbShtX2xheWVyLT5wYXJlbnQoKS0+cGxhdGZvcm1MYXllcigpKTsKICAgICB9 CiAKICAgICBpZiAobV9jaGFuZ2VNYXNrICYgQ2hpbGRyZW5DaGFuZ2UpIHsKQEAgLTY4MCw3ICs2 ODEsNyBAQCB2b2lkIEdyYXBoaWNzTGF5ZXJRdEltcGw6OmZsdXNoQ2hhbmdlcyhib29sIHJlY3Vy c2l2ZSwgYm9vbCBmb3JjZVVwZGF0ZVRyYW5zZm9ybQogICAgICAgICBpZiAoc2NlbmUoKSkKICAg ICAgICAgICAgIHNjZW5lKCktPnVwZGF0ZSgpOwogCi0gICAgaWYgKG1fY2hhbmdlTWFzayAmIChD aGlsZHJlblRyYW5zZm9ybUNoYW5nZSB8IFByZXNlcnZlczNEQ2hhbmdlIHwgVHJhbnNmb3JtQ2hh bmdlIHwgQW5jaG9yUG9pbnRDaGFuZ2UgfCBTaXplQ2hhbmdlIHwgQmFja2ZhY2VWaXNpYmlsaXR5 Q2hhbmdlIHwgUG9zaXRpb25DaGFuZ2UpKSB7CisgICAgaWYgKG1fY2hhbmdlTWFzayAmIChDaGls ZHJlblRyYW5zZm9ybUNoYW5nZSB8IFByZXNlcnZlczNEQ2hhbmdlIHwgVHJhbnNmb3JtQ2hhbmdl IHwgQW5jaG9yUG9pbnRDaGFuZ2UgfCBTaXplQ2hhbmdlIHwgQmFja2ZhY2VWaXNpYmlsaXR5Q2hh bmdlIHwgUG9zaXRpb25DaGFuZ2UgfCBQYXJlbnRDaGFuZ2UpKSB7CiAgICAgICAgIC8vIER1ZSB0 byB0aGUgZGlmZmVyZW5jZXMgYmV0d2VlbiB0aGUgd2F5IFdlYkNvcmUgaGFuZGxlcyB0cmFuc2Zv cm1zIGFuZCB0aGUgd2F5IFF0IGhhbmRsZXMgdHJhbnNmb3JtcywKICAgICAgICAgLy8gYWxsIHRo ZXNlIGVsZW1lbnRzIGFmZmVjdCB0aGUgdHJhbnNmb3JtcyBvZiBhbGwgdGhlIGRlc2NlbmRhbnRz LgogICAgICAgICBmb3JjZVVwZGF0ZVRyYW5zZm9ybSA9IHRydWU7CkBAIC03MzcsNiArNzM4LDEx IEBAIHZvaWQgR3JhcGhpY3NMYXllclF0SW1wbDo6Zmx1c2hDaGFuZ2VzKGJvb2wgcmVjdXJzaXZl LCBib29sIGZvcmNlVXBkYXRlVHJhbnNmb3JtCiAgICAgICAgIGNvbnN0IFFSZWN0IHJlY3QobV9s YXllci0+Y29udGVudHNSZWN0KCkpOwogICAgICAgICBpZiAobV9zdGF0ZS5jb250ZW50c1JlY3Qg IT0gcmVjdCkgewogICAgICAgICAgICAgbV9zdGF0ZS5jb250ZW50c1JlY3QgPSByZWN0OworICAg ICAgICAgICAgaWYgKG1fcGVuZGluZ0NvbnRlbnQubWVkaWFMYXllcikgeworICAgICAgICAgICAg ICAgIFFHcmFwaGljc1dpZGdldCogd2lkZ2V0ID0gcW9iamVjdF9jYXN0PFFHcmFwaGljc1dpZGdl dCo+KG1fcGVuZGluZ0NvbnRlbnQubWVkaWFMYXllci5kYXRhKCkpOworICAgICAgICAgICAgICAg IGlmICh3aWRnZXQpCisgICAgICAgICAgICAgICAgICAgIHdpZGdldC0+c2V0R2VvbWV0cnkocmVj dCk7CisgICAgICAgICAgICB9CiAgICAgICAgICAgICB1cGRhdGUoKTsKICAgICAgICAgfQogICAg IH0KQEAgLTg1MCw2ICs4NTYsMjAgQEAgdm9pZCBHcmFwaGljc0xheWVyUXQ6OnNldE5lZWRzRGlz cGxheUluUmVjdChjb25zdCBGbG9hdFJlY3QmIHJlY3QpCiAgICAgbV9pbXBsLT5ub3RpZnlDaGFu Z2UoR3JhcGhpY3NMYXllclF0SW1wbDo6RGlzcGxheUNoYW5nZSk7CiB9CiAKK3ZvaWQgR3JhcGhp Y3NMYXllclF0OjpzZXRDb250ZW50c05lZWRzRGlzcGxheSgpCit7CisgICAgc3dpdGNoIChtX2lt cGwtPm1fcGVuZGluZ0NvbnRlbnQuY29udGVudFR5cGUpIHsKKyAgICBjYXNlIEdyYXBoaWNzTGF5 ZXJRdEltcGw6Ok1lZGlhQ29udGVudFR5cGU6CisgICAgICAgIGlmICghbV9pbXBsLT5tX3BlbmRp bmdDb250ZW50Lm1lZGlhTGF5ZXIpCisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIG1faW1w bC0+bV9wZW5kaW5nQ29udGVudC5tZWRpYUxheWVyLmRhdGEoKS0+dXBkYXRlKCk7CisgICAgICAg IGJyZWFrOworICAgIGRlZmF1bHQ6CisgICAgICAgIHNldE5lZWRzRGlzcGxheSgpOworICAgICAg ICBicmVhazsKKyAgICB9Cit9CisKIC8qIFxyZWltcCAoR3JhcGhpY3NMYXllci5oKQogKi8KIHZv aWQgR3JhcGhpY3NMYXllclF0OjpzZXROYW1lKGNvbnN0IFN0cmluZyYgbmFtZSkKZGlmZiAtLWdp dCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NMYXllclF0LmggYi9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzTGF5ZXJRdC5oCmluZGV4IDc1Y2E0OTgu LmVkNTM1ZWIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhp Y3NMYXllclF0LmgKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0xh eWVyUXQuaApAQCAtNzUsNiArNzUsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIHJlc3Vt ZUFuaW1hdGlvbnMoKTsKICNlbmRpZiAvLyBRVF9OT19BTklNQVRJT04KICAgICB2aXJ0dWFsIHZv aWQgc2V0Q29udGVudHNUb0ltYWdlKEltYWdlKik7CisgICAgdmlydHVhbCB2b2lkIHNldENvbnRl bnRzTmVlZHNEaXNwbGF5KCk7CiAgICAgdmlydHVhbCB2b2lkIHNldENvbnRlbnRzVG9NZWRpYShQ bGF0Zm9ybUxheWVyKik7CiAgICAgdmlydHVhbCB2b2lkIHNldENvbnRlbnRzQmFja2dyb3VuZENv bG9yKGNvbnN0IENvbG9yJik7CiAjaWYgRU5BQkxFKDNEX0NBTlZBUykK