47568 2010-10-12 18:47:30 -0700 Update getUniform for bvec[234] to return boolean[] rather than Uint8Array 2010-11-02 14:02:09 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 kbr zmo cmarrin enne zmo oldest_to_newest 293244 0 kbr 2010-10-12 18:47:30 -0700 In a recent WebGL working group face-to-face it was decided to change getUniform for bvec[234] to return boolean[] rather than Uint8Array. The WebGL implementation and any associated tests need to be updated. 301481 1 72266 zmo 2010-10-28 17:15:21 -0700 Created attachment 72266 patch Test has been updated on the khronos already. 303515 2 72266 kbr 2010-11-02 11:37:25 -0700 Comment on attachment 72266 patch Looks good. 303641 3 zmo 2010-11-02 14:02:09 -0700 Committed r71164: <http://trac.webkit.org/changeset/71164> 72266 2010-10-28 17:15:21 -0700 2010-11-02 11:37:25 -0700 patch getUniform.patch text/plain 4956 zmo SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MDgyNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMTAtMjggIFpoZW55YW8gTW8gIDx6bW9AZ29vZ2xlLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGUg Z2V0VW5pZm9ybSBmb3IgYnZlY1syMzRdIHRvIHJldHVybiBib29sZWFuW10gcmF0aGVyIHRoYW4g VWludDhBcnJheQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NDc1NjgKKworICAgICAgICAqIGh0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpXZWJHTFJlbmRlcmluZ0NvbnRleHQ6OmdldFVuaWZvcm0p OgorCiAyMDEwLTEwLTI4ICBKaWEgUHUgIDxqcHVAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IERhbiBCZXJuc3RlaW4uCkluZGV4OiBXZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVu ZGVyaW5nQ29udGV4dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJH TFJlbmRlcmluZ0NvbnRleHQuY3BwCShyZXZpc2lvbiA3MDc4NykKKysrIFdlYkNvcmUvaHRtbC9j YW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTc0OSwy MCArMTc0OSwyMCBAQCBXZWJHTEdldEluZm8gV2ViR0xSZW5kZXJpbmdDb250ZXh0OjpnZXRVCiAg ICAgICAgICAgICAgICAgICAgIHJldHVybiBXZWJHTEdldEluZm8oRmxvYXQzMkFycmF5OjpjcmVh dGUodmFsdWUsIGxlbmd0aCkpOwogICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICBj YXNlIEdyYXBoaWNzQ29udGV4dDNEOjpJTlQ6IHsKLSAgICAgICAgICAgICAgICAgICAgaW50IHZh bHVlWzE2XSA9IHswfTsKKyAgICAgICAgICAgICAgICAgICAgaW50IHZhbHVlWzRdID0gezB9Owog ICAgICAgICAgICAgICAgICAgICBtX2NvbnRleHQtPmdldFVuaWZvcm1pdihvYmplY3RPclplcm8o cHJvZ3JhbSksIGxvY2F0aW9uLCB2YWx1ZSk7CiAgICAgICAgICAgICAgICAgICAgIGlmIChsZW5n dGggPT0gMSkKICAgICAgICAgICAgICAgICAgICAgICAgIHJldHVybiBXZWJHTEdldEluZm8oc3Rh dGljX2Nhc3Q8bG9uZz4odmFsdWVbMF0pKTsKICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIFdl YkdMR2V0SW5mbyhJbnQzMkFycmF5OjpjcmVhdGUodmFsdWUsIGxlbmd0aCkpOwogICAgICAgICAg ICAgICAgIH0KICAgICAgICAgICAgICAgICBjYXNlIEdyYXBoaWNzQ29udGV4dDNEOjpCT09MOiB7 Ci0gICAgICAgICAgICAgICAgICAgIGludCB2YWx1ZVsxNl0gPSB7MH07CisgICAgICAgICAgICAg ICAgICAgIGludCB2YWx1ZVs0XSA9IHswfTsKICAgICAgICAgICAgICAgICAgICAgbV9jb250ZXh0 LT5nZXRVbmlmb3JtaXYob2JqZWN0T3JaZXJvKHByb2dyYW0pLCBsb2NhdGlvbiwgdmFsdWUpOwog ICAgICAgICAgICAgICAgICAgICBpZiAobGVuZ3RoID4gMSkgewotICAgICAgICAgICAgICAgICAg ICAgICAgdW5zaWduZWQgY2hhciBib29sVmFsdWVbMTZdID0gezB9OworICAgICAgICAgICAgICAg ICAgICAgICAgYm9vbCBib29sVmFsdWVbMTZdID0gezB9OwogICAgICAgICAgICAgICAgICAgICAg ICAgZm9yICh1bnNpZ25lZCBqID0gMDsgaiA8IGxlbmd0aDsgaisrKQogICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGJvb2xWYWx1ZVtqXSA9IHN0YXRpY19jYXN0PGJvb2w+KHZhbHVlW2pdKTsK LSAgICAgICAgICAgICAgICAgICAgICAgIHJldHVybiBXZWJHTEdldEluZm8oVWludDhBcnJheTo6 Y3JlYXRlKGJvb2xWYWx1ZSwgbGVuZ3RoKSk7CisgICAgICAgICAgICAgICAgICAgICAgICByZXR1 cm4gV2ViR0xHZXRJbmZvKGJvb2xWYWx1ZSwgbGVuZ3RoKTsKICAgICAgICAgICAgICAgICAgICAg fQogICAgICAgICAgICAgICAgICAgICByZXR1cm4gV2ViR0xHZXRJbmZvKHN0YXRpY19jYXN0PGJv b2w+KHZhbHVlWzBdKSk7CiAgICAgICAgICAgICAgICAgfQpJbmRleDogTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNzA4 MjYpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwx MyBAQAorMjAxMC0xMC0yOCAgWmhlbnlhbyBNbyAgPHptb0Bnb29nbGUuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0ZSBnZXRVbmlmb3Jt IGZvciBidmVjWzIzNF0gdG8gcmV0dXJuIGJvb2xlYW5bXSByYXRoZXIgdGhhbiBVaW50OEFycmF5 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NzU2OAor CisgICAgICAgICogZmFzdC9jYW52YXMvd2ViZ2wvZ2wtb2JqZWN0LWdldC1jYWxscy1leHBlY3Rl ZC50eHQ6CisgICAgICAgICogZmFzdC9jYW52YXMvd2ViZ2wvZ2wtb2JqZWN0LWdldC1jYWxscy5o dG1sOgorCiAyMDEwLTEwLTI4ICBKaWEgUHUgIDxqcHVAYXBwbGUuY29tPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IERhbiBCZXJuc3RlaW4uCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93 ZWJnbC9nbC1vYmplY3QtZ2V0LWNhbGxzLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9nbC1vYmplY3QtZ2V0LWNhbGxzLWV4cGVjdGVkLnR4 dAkocmV2aXNpb24gNzA3ODcpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9nbC1v YmplY3QtZ2V0LWNhbGxzLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtNTIsOSArNTIs OSBAQCBQQVNTIGdsLmdldFRleFBhcmFtZXRlcihnbC5URVhUVVJFXzJELCBnCiBQQVNTIGdsLmdl dFByb2dyYW1QYXJhbWV0ZXIoYm9vbFByb2dyYW0sIGdsLkxJTktfU1RBVFVTKSBpcyB0cnVlCiBQ QVNTIGdldEVycm9yIHdhcyBleHBlY3RlZCB2YWx1ZTogTk9fRVJST1IgOiAKIFBBU1MgZ2wuZ2V0 VW5pZm9ybShib29sUHJvZ3JhbSwgYnZhbExvYykgaXMgdHJ1ZQotUEFTUyBnbC5nZXRVbmlmb3Jt KGJvb2xQcm9ncmFtLCBidmFsMkxvYykgaXMgWzEsIDBdCi1QQVNTIGdsLmdldFVuaWZvcm0oYm9v bFByb2dyYW0sIGJ2YWwzTG9jKSBpcyBbMSwgMCwgMV0KLVBBU1MgZ2wuZ2V0VW5pZm9ybShib29s UHJvZ3JhbSwgYnZhbDRMb2MpIGlzIFsxLCAwLCAxLCAwXQorUEFTUyBnbC5nZXRVbmlmb3JtKGJv b2xQcm9ncmFtLCBidmFsMkxvYykgaXMgW3RydWUsIGZhbHNlXQorUEFTUyBnbC5nZXRVbmlmb3Jt KGJvb2xQcm9ncmFtLCBidmFsM0xvYykgaXMgW3RydWUsIGZhbHNlLCB0cnVlXQorUEFTUyBnbC5n ZXRVbmlmb3JtKGJvb2xQcm9ncmFtLCBidmFsNExvYykgaXMgW3RydWUsIGZhbHNlLCB0cnVlLCBm YWxzZV0KIFBBU1MgZ2wuZ2V0UHJvZ3JhbVBhcmFtZXRlcihpbnRQcm9ncmFtLCBnbC5MSU5LX1NU QVRVUykgaXMgdHJ1ZQogUEFTUyBnZXRFcnJvciB3YXMgZXhwZWN0ZWQgdmFsdWU6IE5PX0VSUk9S IDogCiBQQVNTIGdsLmdldFVuaWZvcm0oaW50UHJvZ3JhbSwgaXZhbExvYykgaXMgMQpJbmRleDog TGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvZ2wtb2JqZWN0LWdldC1jYWxscy5odG1sCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL2dsLW9iamVjdC1nZXQt Y2FsbHMuaHRtbAkocmV2aXNpb24gNzA3ODcpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93 ZWJnbC9nbC1vYmplY3QtZ2V0LWNhbGxzLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTE1MCw5ICsx NTAsOSBAQCBnbC51bmlmb3JtM2koYnZhbDNMb2MsIDEsIDAsIDEpOwogZ2wudW5pZm9ybTRpKGJ2 YWw0TG9jLCAxLCAwLCAxLCAwKTsKIGdsRXJyb3JTaG91bGRCZShnbCwgZ2wuTk9fRVJST1IpOwog c2hvdWxkQmUoJ2dsLmdldFVuaWZvcm0oYm9vbFByb2dyYW0sIGJ2YWxMb2MpJywgJ3RydWUnKTsK LXNob3VsZEJlKCdnbC5nZXRVbmlmb3JtKGJvb2xQcm9ncmFtLCBidmFsMkxvYyknLCAnWzEsIDBd Jyk7Ci1zaG91bGRCZSgnZ2wuZ2V0VW5pZm9ybShib29sUHJvZ3JhbSwgYnZhbDNMb2MpJywgJ1sx LCAwLCAxXScpOwotc2hvdWxkQmUoJ2dsLmdldFVuaWZvcm0oYm9vbFByb2dyYW0sIGJ2YWw0TG9j KScsICdbMSwgMCwgMSwgMF0nKTsKK3Nob3VsZEJlKCdnbC5nZXRVbmlmb3JtKGJvb2xQcm9ncmFt LCBidmFsMkxvYyknLCAnW3RydWUsIGZhbHNlXScpOworc2hvdWxkQmUoJ2dsLmdldFVuaWZvcm0o Ym9vbFByb2dyYW0sIGJ2YWwzTG9jKScsICdbdHJ1ZSwgZmFsc2UsIHRydWVdJyk7CitzaG91bGRC ZSgnZ2wuZ2V0VW5pZm9ybShib29sUHJvZ3JhbSwgYnZhbDRMb2MpJywgJ1t0cnVlLCBmYWxzZSwg dHJ1ZSwgZmFsc2VdJyk7CiAvLyBJbnRlZ2VyIHVuaWZvcm0gdmFyaWFibGVzCiB2YXIgaW50UHJv Z3JhbSA9IGxvYWRQcm9ncmFtKGdsLCAicmVzb3VyY2VzL2ludFVuaWZvcm1TaGFkZXIudmVydCIs ICJyZXNvdXJjZXMvbm9vcFVuaWZvcm1TaGFkZXIuZnJhZyIpOwogc2hvdWxkQmUoJ2dsLmdldFBy b2dyYW1QYXJhbWV0ZXIoaW50UHJvZ3JhbSwgZ2wuTElOS19TVEFUVVMpJywgJ3RydWUnKTsK