47567 2010-10-12 18:44:14 -0700 Wrong ASSERT when select element has size 0 2010-10-13 05:28:10 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 yael webkit-unassigned commit-queue oldest_to_newest 293243 0 yael 2010-10-12 18:44:14 -0700 When clicking on a select element and then hitting up or down arrow key, an ASSERT is hit in SelectElement::listBoxDefaultEventHandler(). The ASSERT has wrong assumption and should be fixed. ASSERT_UNUSED(listItems, endIndex >= 0 && (unsigned) endIndex < listItems.size()); 293251 1 70579 yael 2010-10-12 19:55:19 -0700 Created attachment 70579 Patch Change the ASSERT so that it can handle size 0. 293359 2 70579 kling 2010-10-13 05:12:19 -0700 Comment on attachment 70579 Patch Nice catch, r=me 293364 3 70579 commit-queue 2010-10-13 05:28:05 -0700 Comment on attachment 70579 Patch Clearing flags on attachment: 70579 Committed r69651: <http://trac.webkit.org/changeset/69651> 293365 4 commit-queue 2010-10-13 05:28:10 -0700 All reviewed patches have been landed. Closing bug. 70579 2010-10-12 19:55:19 -0700 2010-10-13 05:28:05 -0700 Patch 47567.patch text/plain 4407 yael SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2OTYzNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMTAtMTIgIFlhZWwgQWhhcm9uICA8eWFlbC5haGFyb25Abm9r aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFdyb25nIEFTU0VSVCB3aGVuIHNlbGVjdCBlbGVtZW50IGhhcyBzaXplIDAKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3NTY3CisKKyAgICAgICAgS2Vl cCB0aGUgQVNTRVJUIG9ubHkgaWYgdGhlIHNpemUgb2YgdGhlIGVsZW1lbnQgbGlzdCBpcyBtb3Jl IHRoYW4gMAorICAgICAgICBUZXN0OiBmYXN0L2RvbS9IVE1MU2VsZWN0RWxlbWVudC9jbGljay1z aXplLXplcm8tbm8tY3Jhc2guaHRtbAorCisgICAgICAgICogZG9tL1NlbGVjdEVsZW1lbnQuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6U2VsZWN0RWxlbWVudDo6dXBkYXRlTGlzdEJveFNlbGVjdGlv bik6CisgICAgICAgIChXZWJDb3JlOjpTZWxlY3RFbGVtZW50OjpsaXN0Qm94RGVmYXVsdEV2ZW50 SGFuZGxlcik6CisKIDIwMTAtMTAtMTIgIEtpbnVrbyBZYXN1ZGEgIDxraW51a29AY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEppYW4gTGkuCkluZGV4OiBXZWJDb3JlL2RvbS9T ZWxlY3RFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2RvbS9TZWxlY3RFbGVtZW50 LmNwcAkocmV2aXNpb24gNjk1ODMpCisrKyBXZWJDb3JlL2RvbS9TZWxlY3RFbGVtZW50LmNwcAko d29ya2luZyBjb3B5KQpAQCAtMTUyLDcgKzE1Miw3IEBAIHZvaWQgU2VsZWN0RWxlbWVudDo6c2V0 QWN0aXZlU2VsZWN0aW9uRW4KIHZvaWQgU2VsZWN0RWxlbWVudDo6dXBkYXRlTGlzdEJveFNlbGVj dGlvbihTZWxlY3RFbGVtZW50RGF0YSYgZGF0YSwgRWxlbWVudCogZWxlbWVudCwgYm9vbCBkZXNl bGVjdE90aGVyT3B0aW9ucykKIHsKICAgICBBU1NFUlQoZWxlbWVudC0+cmVuZGVyZXIoKSAmJiAo ZWxlbWVudC0+cmVuZGVyZXIoKS0+aXNMaXN0Qm94KCkgfHwgZGF0YS5tdWx0aXBsZSgpKSk7Ci0g ICAgQVNTRVJUKGRhdGEuYWN0aXZlU2VsZWN0aW9uQW5jaG9ySW5kZXgoKSA+PSAwKTsKKyAgICBB U1NFUlQoIWRhdGEubGlzdEl0ZW1zKGVsZW1lbnQpLnNpemUoKSB8fCBkYXRhLmFjdGl2ZVNlbGVj dGlvbkFuY2hvckluZGV4KCkgPj0gMCk7CiAKICAgICB1bnNpZ25lZCBzdGFydCA9IG1pbihkYXRh LmFjdGl2ZVNlbGVjdGlvbkFuY2hvckluZGV4KCksIGRhdGEuYWN0aXZlU2VsZWN0aW9uRW5kSW5k ZXgoKSk7CiAgICAgdW5zaWduZWQgZW5kID0gbWF4KGRhdGEuYWN0aXZlU2VsZWN0aW9uQW5jaG9y SW5kZXgoKSwgZGF0YS5hY3RpdmVTZWxlY3Rpb25FbmRJbmRleCgpKTsKQEAgLTc1Miw3ICs3NTIs NyBAQCB2b2lkIFNlbGVjdEVsZW1lbnQ6Omxpc3RCb3hEZWZhdWx0RXZlbnRICiAgICAgICAgICAg ICAvLyBTYXZlIHRoZSBzZWxlY3Rpb24gc28gaXQgY2FuIGJlIGNvbXBhcmVkIHRvIHRoZSBuZXcg c2VsZWN0aW9uIHdoZW4gZGlzcGF0Y2hpbmcgY2hhbmdlIGV2ZW50cyBpbW1lZGlhdGVseSBhZnRl ciBtYWtpbmcgdGhlIG5ldyBzZWxlY3Rpb24uCiAgICAgICAgICAgICBzYXZlTGFzdFNlbGVjdGlv bihkYXRhLCBlbGVtZW50KTsKIAotICAgICAgICAgICAgQVNTRVJUX1VOVVNFRChsaXN0SXRlbXMs IGVuZEluZGV4ID49IDAgJiYgKHVuc2lnbmVkKSBlbmRJbmRleCA8IGxpc3RJdGVtcy5zaXplKCkp OworICAgICAgICAgICAgQVNTRVJUX1VOVVNFRChsaXN0SXRlbXMsICFsaXN0SXRlbXMuc2l6ZSgp IHx8IChlbmRJbmRleCA+PSAwICYmICh1bnNpZ25lZCkgZW5kSW5kZXggPCBsaXN0SXRlbXMuc2l6 ZSgpKSk7CiAgICAgICAgICAgICBzZXRBY3RpdmVTZWxlY3Rpb25FbmRJbmRleChkYXRhLCBlbmRJ bmRleCk7CiAgICAgICAgICAgICAKICAgICAgICAgICAgIC8vIElmIHRoZSBhbmNob3IgaXMgdW5p dGlhbGl6ZWQsIG9yIGlmIHdlJ3JlIGdvaW5nIHRvIGRlc2VsZWN0IGFsbCBvdGhlciBvcHRpb25z LCB0aGVuIHNldCB0aGUgYW5jaG9yIGluZGV4IGVxdWFsIHRvIHRoZSBlbmQgaW5kZXguCkluZGV4 OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCShyZXZpc2lvbiA2OTYzNCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBj b3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEwLTEwLTEyICBZYWVsIEFoYXJvbiAgPHlhZWwuYWhh cm9uQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBXcm9uZyBBU1NFUlQgd2hlbiBzZWxlY3QgZWxlbWVudCBoYXMgc2l6ZSAwCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NzU2NworCisgICAg ICAgICogZmFzdC9kb20vSFRNTFNlbGVjdEVsZW1lbnQvY2xpY2stc2l6ZS16ZXJvLW5vLWNyYXNo LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9kb20vSFRNTFNlbGVjdEVsZW1l bnQvY2xpY2stc2l6ZS16ZXJvLW5vLWNyYXNoLmh0bWw6IEFkZGVkLgorCiAyMDEwLTA5LTMwICBE dW1pdHJ1IERhbmlsaXVjICA8ZHVtaUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgRGF2aWQgTGV2aW4uCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MU2VsZWN0RWxl bWVudC9jbGljay1zaXplLXplcm8tbm8tY3Jhc2gtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxTZWxlY3RFbGVtZW50L2NsaWNrLXNpemUtemVyby1u by1jcmFzaC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Rv bS9IVE1MU2VsZWN0RWxlbWVudC9jbGljay1zaXplLXplcm8tbm8tY3Jhc2gtZXhwZWN0ZWQudHh0 CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxIEBACisgVGhpcyBzaG91bGQgbm90IGNyYXNoCkluZGV4 OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MU2VsZWN0RWxlbWVudC9jbGljay1zaXplLXplcm8t bm8tY3Jhc2guaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MU2Vs ZWN0RWxlbWVudC9jbGljay1zaXplLXplcm8tbm8tY3Jhc2guaHRtbAkocmV2aXNpb24gMCkKKysr IExheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxTZWxlY3RFbGVtZW50L2NsaWNrLXNpemUtemVyby1u by1jcmFzaC5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDMzIEBACis8aHRtbD4KKzxzY3Jp cHQgc3JjPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPHNjcmlw dD4KK2Z1bmN0aW9uIGdldENlbnRlckZvcihlbGVtZW50KQoreworICB2YXIgcmVjdCA9IGVsZW1l bnQuZ2V0Qm91bmRpbmdDbGllbnRSZWN0KCk7CisgIHJldHVybiB7IHggOiBwYXJzZUludCgocmVj dC5sZWZ0ICsgcmVjdC5yaWdodCkgLyAyKSAsIHkgOiBwYXJzZUludCgocmVjdC50b3AgKyByZWN0 LmJvdHRvbSkgLyAyKX07Cit9CisKK2Z1bmN0aW9uIHJ1blRlc3QoKQoreworICBpZiAoIXdpbmRv dy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICByZXR1cm47CisgIGlmICghd2luZG93LmV2ZW50 U2VuZGVyKQorICAgIHJldHVybjsKKworICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0 KCk7CisgIGNlbnRlciA9IGdldENlbnRlckZvcihkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiZW1w dHlzZWxlY3QiKSk7CisgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKGNlbnRlci54LCBjZW50ZXIu eSk7CisgIGV2ZW50U2VuZGVyLm1vdXNlRG93bigpOworICBldmVudFNlbmRlci5tb3VzZVVwKCk7 CisgIGV2ZW50U2VuZGVyLmtleURvd24oImRvd25BcnJvdyIpOworfQorCis8L3NjcmlwdD4KKzxz dHlsZT4KKzwvc3R5bGU+Cis8Ym9keSBvbmxvYWQ9InJ1blRlc3QoKTsiPgorPHNlbGVjdCBtdWx0 aXBsZSBpZD0iZW1wdHlzZWxlY3QiPjwvc2VsZWN0PgorVGhpcyBzaG91bGQgbm90IGNyYXNoCis8 L2JvZHk+Cis8L2h0bWw+CisK